Commit Graph

105 Commits

Author SHA1 Message Date
Carlos Florêncio cc934adb85 fix: make executors_running the single source of truth for agent_execution_id (#799) 2026-05-03 22:17:23 +01:00
João Salavisa dccff23cc0 feat(backend): per-launch authentication for agentctl (#666)
* feat(backend): per-launch authentication for agentctl

Add nonce-based handshake protocol to secure all agentctl HTTP/WS
endpoints. On launch, the parent (backend) passes a one-time bootstrap
nonce via AGENTCTL_BOOTSTRAP_NONCE env var. agentctl generates its own
auth token, enables Bearer auth immediately, and returns the token to
the parent via POST /auth/handshake (validated by nonce).

Standalone, Docker, and Sprites executors all use the same handshake
flow. Removes the old AGENTCTL_AUTH_TOKEN env var approach. For
Docker/Sprites, the retrieved token is persisted encrypted in
SecretStore (AES-256-GCM) for crash recovery.

Security properties:
- Auth enabled from boot (no unprotected window)
- Token never in env vars (only the burned nonce)
- Nonce is one-shot (replay impossible)
- Constant-time token comparison (timing-safe)

* fix: check fmt.Sscanf return value in integration test

* fix: address review feedback - constant-time nonce comparison, safe ID truncation

* fix(backend): exempt MCP routes from agentctl auth middleware

The agent subprocess connects to agentctl's MCP endpoints (/sse, /message,
/mcp) to use kandev tools (create_task, ask_user_question, etc.). These
endpoints run on the same HTTP server as the authenticated API, but the
agent process doesn't possess the auth token — it was only exchanged
between the backend and agentctl during the handshake.

Exempt /sse, /message, and /mcp from the Bearer auth middleware since the
agent process runs in the same trust boundary as agentctl.

* refactor(backend): remove query param token fallback and document SetAuthToken constraint

Remove the ?token= query parameter fallback from extractBearerToken —
tokens in URLs leak via access logs, referer headers, and browser history.
All WS callers already use Authorization headers via wsAuthHeaders().

Document SetAuthToken's concurrency constraint: it must not be called
concurrently with HTTP requests on the same client.

* fix(backend): enforce mutex in ControlClient/Launcher auth, fix Start() lock scope

- Add sync.Mutex to ControlClient; protect SetAuthToken and AuthToken() reads
- Guard Launcher.AuthToken() with l.mu (written under lock in Start, read unprotected)
- Extract buildAndStartProcess and performHandshake from Start() (was 106 lines, over 80-line limit)
- Release l.mu before blocking health/handshake calls so monitorExit() can close
  l.exited — previously the fast-fail path in waitForHealthy was unreachable
- Update stale executor_backend.go comment (standalone no longer uses env var auth)

Co-authored-by: João Salavisa <undefined@users.noreply.github.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
2026-04-21 14:00:49 +01:00
Carlos Florêncio 7e7865a82c fix(backend): silence spurious errors during Ctrl+C shutdown (#658) 2026-04-20 22:31:30 +01:00
Carlos Florêncio 5b04c9c675 perf: focus-gated git polling to reduce CPU on retained worktrees (#610) 2026-04-18 11:33:04 +01:00
Carlos Florêncio 0074cfbaa9 fix: recover workspace operations after backend restart (#475) 2026-03-26 18:50:28 +00:00
Carlos Florêncio 2c9b878c44 fix: recover stuck sessions after agent stream disconnect (#424) 2026-03-12 19:54:38 +00:00
João Salavisa 299d948af8 feat: auto-update base commit on branch switch (#399) 2026-03-09 23:19:03 +00:00
João Salavisa d84b8873ea feat: quick chat implementation (#393) 2026-03-08 22:37:37 +00:00
Carlos Florêncio c81fb77f72 ci: improve docker image and KANDEV_DATA_DIR env var (#370) 2026-03-05 20:31:17 +00:00
Carlos Florêncio c7978a4ef3 fix: resolve stale PR data on task switch and deduplicate lifecycle code (#361) 2026-03-03 23:40:44 +00:00
Carlos Florêncio 31dc3d148b fix: lazy Docker client initialization to avoid startup errors (#300) 2026-02-27 15:24:12 +00:00
Carlos Florêncio 40b4de3f1a feat: improve remote executor sprites.dev (#267) 2026-02-23 01:37:02 +00:00
Carlos Florêncio 66ba91ca3f feat: remove executor healthcheck (#263) 2026-02-22 12:22:36 +00:00
Carlos Florêncio a23ab5be3a feat: remote executors + secrets (#257) 2026-02-21 22:14:56 +00:00
Carlos Florêncio fd4ae1eb54 fix: resolve all backend golangci-lint violations (#245) 2026-02-18 18:24:24 +00:00
Carlos Florêncio 90bec9aaa0 feat: update readme & agent TUI reliability (#239) 2026-02-17 22:59:53 +00:00
Carlos Florêncio 2b05ed0735 feat: improved passthrough and workflow (#237) 2026-02-17 12:32:02 +00:00
Carlos Florêncio ee612a42c5 feat: agents.json refactor (#221) 2026-02-14 15:54:11 +00:00
Carlos Florêncio ea751d3ecc feat: improve task creation (#220) 2026-02-13 17:26:38 +00:00
Carlos Florêncio 4e1951aa41 feat: remove blocking http call when creating the agent (#214) 2026-02-09 21:58:15 +00:00
Carlos Florêncio ead9a210f9 feat: add agent boot message (#213) 2026-02-08 23:30:40 +00:00
Carlos Florêncio 3196a02220 feat: file icons (#207) 2026-02-07 15:40:59 +00:00
João Salavisa 9fd79f294a try to resume a failed task (#200) 2026-02-06 01:44:03 +00:00
Copilot c864b3533f fix: diff bg lines and codex last message (#186) 2026-02-05 22:38:54 +00:00
João Salavisa b0fe1a8a59 codex (#189) 2026-02-05 22:37:29 +00:00
João Salavisa 93e3759c5f feat: Implement image paste functionality for Claude Code (#188) 2026-02-05 22:34:30 +00:00
Carlos Florêncio 06f7fe9795 feat: improve session terminals (#185) 2026-02-05 04:09:04 +00:00
João Salavisa 68b398f800 fix: prevent duplicate agent messages in database (#181) 2026-02-04 23:52:26 +00:00
Carlos Florêncio 0f79342fe8 fix: agent profile creation (#170) 2026-02-03 22:07:34 +00:00
Carlos Florêncio 5b6be01156 feat: slash commands from agents (#136) 2026-02-01 01:20:13 +00:00
João Salavisa 9ddf131a05 fix: permission request ID mismatch, SSE duplicates, and subprocess cleanup (#137) 2026-02-01 01:16:54 +00:00
Carlos Florêncio 122deb3b13 feat: add GitHub Copilot CLI and Sourcegraph Amp agent support (#130) 2026-02-01 00:40:56 +00:00
Carlos Florêncio ff4e0779d2 feat: improve make dev shutdown (#133) 2026-01-31 18:06:22 +00:00
João Salavisa 6eb24006f9 feat: implement task plans feature (#131) 2026-01-31 00:51:17 +00:00
João Salavisa f229c72393 feat: migrate MCP server from backend to agentctl (#124) 2026-01-30 15:15:19 +00:00
João Salavisa 49f98b88ff fix: Multiple bug fixes for agent lifecycle and task creation (#122) 2026-01-29 23:40:02 +00:00
João Salavisa 1888f8465f feat(backend): add thinking/reasoning streaming support (#113) 2026-01-28 17:22:19 +00:00
Carlos Florêncio 7c82ccdf24 feat: improve logging (#105) 2026-01-27 00:18:42 +00:00
Carlos Florêncio 9463ddac9f feat: remove npm warns from terminal + fix terminal render on refresh (#104) 2026-01-26 23:52:28 +00:00
Carlos Florêncio 47a02fd18e feat: git pull before worktree creation (#100) 2026-01-26 19:09:55 +00:00
Carlos Florêncio 323e14c1a6 feat: opencode dynamic model loader (#99) 2026-01-25 22:23:03 +00:00
Carlos Florêncio 859eb70908 feat: improve task switch + cli passthrough resume (#98) 2026-01-25 20:14:40 +00:00
Carlos Florêncio ab404261dd feat: cli passthrough state transitions (#95) 2026-01-25 18:37:37 +00:00
Carlos Florêncio 66cda240e0 feat: cli passthrough setting (#93) 2026-01-25 17:49:53 +00:00
João Salavisa 187d002717 feat: per-task executor selection with multi-runtime support (#92) 2026-01-25 02:05:19 +00:00
João Salavisa d43037bf82 fix: filter upstream commits, fix ahead/behind, and remove duplicate types (#91) 2026-01-25 00:16:01 +00:00
Carlos Florêncio 3b9abea3ca feat: gemini and opencode 2026-01-24 19:03:31 +00:00
Carlos Florêncio eec22dc3bb feat: claude code support (#87) 2026-01-24 13:41:45 +00:00
João Salavisa 39b6e89244 feat: Git status tracking refactor with persistent snapshots and commit history (#86) 2026-01-24 00:41:43 +00:00
Carlos Florêncio 7a7927925e feat: improved codex and auggie default permissions 2026-01-24 00:19:20 +00:00