bc218dfbbe
* feat: add workspace sources from files panel * fix: preserve worktree identity during recovery * feat: unify workspace source actions * fix: validate recovered workspace repositories * fix: harden workspace source filesystem boundaries * test: split workspace repository chip coverage * fix: restrict repository rescan recovery paths * fix: stabilize workspace source CI checks * test: canonicalize workspace source paths * test: align workspace source container paths * fix: populate direct workspace repository names * test: preserve git fixture rewrites across restarts * test: isolate backend git fixture config * fix: resume remote workspace executions before creation * fix: preserve ssh agent identity during resume * fix: preserve SSH workspace across backend restart * fix: simplify workspace actions trigger * fix: refine add workspace repositories UX * docs: narrow workspace source UX updates * fix: avoid phantom turn on session resume * test(web): normalize workspace source request headers * feat(web): streamline workspace source picker * docs: remove trailing spaces from workspace source plan * fix: prevent resume status from creating phantom turns * fix(web): stabilize workspace source attachment * refactor(web): extract workspace source store contract * fix: avoid phantom turns on idle agent resume * fix: address backend static analysis findings * fix: preserve agentctl readiness status value * fix: preserve resume messages without active turns * fix: resume agents from promoted workspace root * chore: merge origin/main into feature/add-new-repo-folder-d97 * feat(web): explain workspace source consequences * test(websocket): count session activity subscription
66 lines
1.9 KiB
Markdown
66 lines
1.9 KiB
Markdown
---
|
|
id: "10-final-verification"
|
|
title: "Final verification"
|
|
status: completed
|
|
wave: 6
|
|
depends_on: ["08-end-to-end-coverage", "09-public-documentation"]
|
|
plan: "plan.md"
|
|
spec: "../../specs/tasks/attach-workspace-sources.md"
|
|
---
|
|
|
|
# Task 10: Final Verification
|
|
|
|
## Acceptance
|
|
|
|
- Repository-wide formatting runs before typecheck, tests, and lint, and every command result is
|
|
recorded without source/test fixes by the verification worker.
|
|
- Focused desktop/mobile rendered checks and executor coverage from Task 08 are linked in the report.
|
|
- The spec, ADR, plan, task statuses, scoped `AGENTS.md` files, and public docs match the final
|
|
behavior; any failure or deferred executor is reported explicitly.
|
|
|
|
## Verification
|
|
|
|
```bash
|
|
rtk make fmt
|
|
rtk make typecheck
|
|
rtk make test
|
|
rtk make lint
|
|
```
|
|
|
|
## Files likely touched
|
|
|
|
- `docs/plans/attach-workspace-sources/plan.md` (status only)
|
|
- `docs/plans/attach-workspace-sources/task-10-final-verification.md` (status/report only)
|
|
- scoped `AGENTS.md` only if implementation changed a documented architectural pattern
|
|
|
|
## Dependencies
|
|
|
|
Tasks 08 and 09; all earlier tasks must already be done.
|
|
|
|
## Inputs
|
|
|
|
- Completed implementation tasks and their verification reports.
|
|
- Root and scoped `AGENTS.md` verification order.
|
|
|
|
## Output contract
|
|
|
|
Exact commands/results, failures without fixes, coverage gaps, blockers, risks, divergence, final
|
|
task/plan status, and readiness recommendation.
|
|
|
|
## Result
|
|
|
|
Final verification used `TMPDIR=/tmp/kvt` to avoid the runner's Unix-socket path-length limit.
|
|
|
|
- `make fmt`: passed.
|
|
- `make typecheck`: passed.
|
|
- `make test`: passed.
|
|
- `make lint`: passed.
|
|
- Backend compile-only and focused race suites: passed.
|
|
- `git diff --check`: passed.
|
|
- Desktop Chromium: 2/2 passed.
|
|
- Mobile Chrome: 1/1 passed.
|
|
- Independent final security review: approved.
|
|
|
|
Live Docker/SSH attachment execution remains an environment coverage limitation, not a source
|
|
failure; see Task 08.
|