67 lines
3.5 KiB
Markdown
67 lines
3.5 KiB
Markdown
---
|
|
id: "01-service-authorization"
|
|
title: "Service-layer workspace authorization"
|
|
status: pending
|
|
wave: 1
|
|
depends_on: []
|
|
plan: "plan.md"
|
|
spec: "../../specs/tasks/requirements/workflow-sync-workspace-authz.md"
|
|
---
|
|
|
|
# Task 01: Service-layer workspace authorization
|
|
|
|
Add the `workspaceAuthorizer` boundary to `workflowsync.Service` and wire it at app boot, following
|
|
the exact pattern already used by `internal/github`, `internal/jira`, `internal/linear`,
|
|
`internal/slack`, `internal/azuredevops`, and `internal/automation`.
|
|
|
|
## Changes
|
|
|
|
1. `apps/backend/internal/workflowsync/service.go`:
|
|
- Add `workspaceAuthorizer func(context.Context, string) error` field to `Service`.
|
|
- Add `SetWorkspaceAuthorizer` (nil-safe on `s`) and `authorizeWorkspaceAccess` (nil-safe on `s`
|
|
and the field) methods — copy the shape from `internal/github/service.go:169-181`.
|
|
- Call `s.authorizeWorkspaceAccess(ctx, workspaceID)` first in `GetConfigForWorkspace`,
|
|
`SetConfigForWorkspace`, `DeleteConfigForWorkspace`, `SyncWorkspace`, returning the error
|
|
immediately (before touching `s.store` or `s.applier`).
|
|
2. `apps/backend/internal/backendapp/services.go`: in `initWorkflowSyncService`, after
|
|
`workflowsync.Provide` succeeds, call `svc.SetWorkspaceAuthorizer(taskSvc.AuthorizeWorkspaceAccess)`
|
|
before returning `svc`.
|
|
|
|
## Acceptance
|
|
|
|
- A caller whose identity does not own the target workspace gets `repoerrors.ErrWorkspaceNotFound`
|
|
from all four `Service` methods, and no store read/write or applier call happens for that call.
|
|
- A caller with no identity in context, or a synthetic identity, or a `Service` with no authorizer
|
|
wired, behaves exactly as before this change (fully unscoped, no denial).
|
|
- `go vet` / build clean; no new lint findings under the changed-file thresholds in
|
|
`apps/backend/.golangci.yml`.
|
|
|
|
## Verification
|
|
|
|
```bash
|
|
cd apps/backend && go test ./internal/workflowsync/... -run 'Authoriz|SyncWorkspace|ConfigForWorkspace' -v
|
|
cd apps/backend && go build ./...
|
|
cd apps/backend && golangci-lint run ./internal/workflowsync/... ./internal/backendapp/... --new-from-rev=main --timeout=5m
|
|
```
|
|
|
|
## Results
|
|
|
|
- Status: **done**.
|
|
- `go test ./internal/workflowsync/... -run 'Authoriz|DeniesForeign|SucceedWhenNoAuthorizer|SucceedWhenAuthorizerAllows' -v`: 6/6 pass (`TestGetConfigForWorkspace_DeniesForeignWorkspace`,
|
|
`TestSetConfigForWorkspace_DeniesForeignWorkspaceAndLeavesConfigUnchanged`,
|
|
`TestDeleteConfigForWorkspace_DeniesForeignWorkspaceAndLeavesConfigInPlace`,
|
|
`TestSyncWorkspace_DeniesForeignWorkspaceAndNeverApplies`,
|
|
`TestServiceMethods_SucceedWhenNoAuthorizerWired`, `TestServiceMethods_SucceedWhenAuthorizerAllows`).
|
|
- `go build ./...`: clean.
|
|
- `go test -race ./internal/workflowsync/... ./internal/backendapp/...`: both `ok`.
|
|
- `golangci-lint run ./internal/workflowsync/... ./internal/backendapp/... --new-from-rev=main --timeout=5m`: 0 issues.
|
|
- **Codex review finding (blocker, fixed):** the initial service-layer tests only ever installed a
|
|
hand-written fake authorizer, so a regression removing the real
|
|
`svc.SetWorkspaceAuthorizer(taskSvc.AuthorizeWorkspaceAccess)` wiring line in
|
|
`initWorkflowSyncService` would leave every test green. Added
|
|
`apps/backend/internal/backendapp/workflowsync_wiring_test.go`
|
|
(`TestInitWorkflowSyncService_WiresRealWorkspaceAuthorization`), which calls
|
|
`initWorkflowSyncService` itself with a real `taskservice.Service` backed by SQLite. Verified by
|
|
temporarily commenting out the wiring line: the new test failed for the expected reason; restoring
|
|
the line made it pass again (confirmed via `go build`/full suite afterward).
|