Files
kandev/docs/plans/steer-attachment-materialization/task-01-materialize-steer-attachments.md
T
Corey Fogg 17da0aafe3 fix(agent): materialize attachments sent into a generating turn (#3277)
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Carlos Florencio <carlosmflorencio@gmail.com>
2026-09-02 16:55:33 +00:00

63 lines
2.1 KiB
Markdown

---
id: "01-materialize-steer-attachments"
title: "Materialize steer attachments"
status: complete
wave: 1
depends_on: []
plan: "plan.md"
requirements:
- REQ-TASKS-PROMPT-ATTACHMENTS-001
acceptance_criteria:
- AC-TASKS-PROMPT-ATTACHMENTS-001.6
- AC-TASKS-PROMPT-ATTACHMENTS-001.7
system_design:
- ../../specs/tasks/system-design/prompt-attachments.md
---
# Task 01: Materialize Steer Attachments
## Summary
Resolve claimed attachment descriptors before a steer dispatches into a live
turn. Keep the resolution outside the prompt lifecycle lock and make a
resolution failure terminal for that message.
## In scope
- Materialize in `SendPromptSteerWithDispatchCallback` before `tryDispatchSteer`.
- Return a no-dispatch result when the active generation ends before steer
delivery, so the orchestrator owns the ordinary prompt fallback.
- Release the steer admission slot and retry queued draining after a
pre-dispatch materialization failure.
- Return the materialization error instead of dispatching or falling back.
- Record materialize uploads in `newMockAgentServer` for assertions.
- Add the three lifecycle regression tests named in the plan.
## Out of scope
- Claim admission, upload limits, retention, and delivery-mode selection.
- The Playwright scenario, which is Task 02.
## Acceptance
- A steer into a generating turn reaches agentctl with a resolved filename and
no bare attachment ID.
- The ordinary prompt route uploads attachment bytes exactly once.
- A materialization failure returns an error and dispatches no prompt frame.
- Existing steer generation and ordering behavior is unchanged.
## Verification
```bash
gofmt -l apps/backend/internal/agent/runtime/lifecycle
(cd apps/backend && go test ./internal/agent/runtime/lifecycle -run 'TestSendPromptSteer' -count=1 -race)
(cd apps/backend && go test ./internal/agent/runtime/lifecycle -count=1)
make -C apps/backend lint
```
## Files likely touched
- `apps/backend/internal/agent/runtime/lifecycle/session.go`
- `apps/backend/internal/agent/runtime/lifecycle/session_steer_test.go`
- `apps/backend/internal/agent/runtime/lifecycle/session_test.go`