João Salavisa
0df2bbac0a
* docs(plugins): draft Host data API proto (read + write DTOs) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(plugins): ADR + spec + plan for the Host data API Plugins access kandev data via capability-gated Host gRPC RPCs returning hand-mapped DTOs, never the DB directly. ADR 0042. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): add Host data API RPCs and DTOs to plugin proto Extends the existing service Host (per ADR 0042) with read RPCs (ListTasks/GetTask, ListWorkspaces, ListWorkflows, ListWorkflowSteps, ListAgentProfiles, ListRepositories, ListSessions, ListSessionCodeStats) and declares the deferred phase-2 write RPCs (CreateTask, UpdateTask, CreateComment) so the contract is stable for later tasks. Regenerates plugin.pb.go/plugin_grpc.pb.go via `make -C apps/backend proto`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * feat(plugins): Host data API SDK accessors + session LOC aggregation Wave 1-2 of ADR 0042: pkg/pluginsdk gains typed reader accessors (host.Tasks(), host.Sessions().CodeStats(), host.Workflows(), ...) over the extended Host gRPC service, with proto<->native DTO conversions and an UnimplementedHostData seam for the kandev-side impl. internal/analytics gains the per-session LOC aggregation those readers surface. Backend handlers + capability gating land in the next wave. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): capability-gated Host data read handlers (ADR 0042) Implement pluginHost Tasks/Sessions/Workspaces/Workflows/AgentProfiles/ Repositories readers: each gated on api_read:<resource> (PermissionDenied otherwise), backed by the service layer via narrow injected interfaces, and hand-mapped to the pluginsdk DTOs. Sessions().CodeStats routes through the analytics aggregation; acp_session_id preserves the metadata->resume_token fallback. Wired through plugins.Service.SetDataSources + backendapp. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): wire test for Host data reads + docs (ADR 0042 accepted) End-to-end test over the real go-plugin transport: session data round-trips, per-resource api_read gating returns PermissionDenied over the wire, cursor pagination. Document the Host data API + SDK accessors in GRPC-CONTRACT.md, reconcile the spec to shipped code, mark ADR 0042 accepted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): full session history + snapshot profile name in data API Sessions().List now fetches tasks with includeArchived=true — an archived task's sessions are still real sessions, and CodeStats already made the same call at the SQL layer, so the two session reads were inconsistent (26 of 359 sessions visible on a real instance). Tasks().List keeps archived tasks excluded. Session gains agent_profile_name (proto field 10) sourced from the profile snapshot, so sessions of since-uninstalled agents keep a human label — the AgentProfiles registry only lists live agents. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(plugins): renumber Host data API ADR 0042 -> 0043 main merged its own ADR 0042 (project shell output); renumber this one to the next free slot and update all references. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address Host data API review (perf, pagination, filters, proto) - paginate before DTO conversion so per-session ACP lookups run <=limit times - fetch all source pages (no silent 1000/workspace truncation); accurate HasMore - stable id tiebreaker on paginated sorts - AND SessionFilter.TaskIDs with WorkspaceIDs; exclude config-mode sessions from CodeStats (shared dialect.ExcludeConfigModePredicate) so List/CodeStats match - Get returns codes.NotFound consistently in-process and over the wire - wrap bare-DTO RPC responses (GetTaskResponse etc.) for Buf response uniqueness Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(plugins): mark Host data API plan tasks done --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
78 lines
3.7 KiB
Markdown
78 lines
3.7 KiB
Markdown
---
|
|
id: "04-host-data-impl"
|
|
title: "kandev-side Host data RPC implementation + capability gating + wiring"
|
|
status: done
|
|
wave: 3
|
|
depends_on: ["01-proto-contract", "02-session-loc-aggregation", "03-sdk-data-accessors"]
|
|
plan: "plan.md"
|
|
spec: "../../../specs/plugins/spec.md"
|
|
adr: "../../../decisions/0043-plugin-host-data-api.md"
|
|
---
|
|
|
|
# Task 04: kandev-side Host data RPC implementation
|
|
|
|
Implement the Go-native Host data interface (from task-03) inside
|
|
`internal/plugins`, backed by the service layer, with per-resource capability
|
|
gating, and wire the new service dependencies through `plugins.Service`.
|
|
|
|
## Scope
|
|
- Implement each read method on `pluginHost` (or a sibling type in
|
|
`internal/plugins/`) satisfying the extended `pluginsdk.Host` interface:
|
|
1. **Gate:** check `manifest.CanRead("<resource>")`; on miss return
|
|
`permissionDenied("api_read:<resource>")` (extend the existing helper —
|
|
`status.Errorf(codes.PermissionDenied, "capability '%s' not declared", ...)`).
|
|
2. **Service call:** tasks/workspaces/repositories/sessions → `taskSvc`
|
|
methods (e.g. `ListTaskSessions`, workspace + repository listers); workflows/
|
|
steps → workflow service (`ListStepsByWorkflow`, workflow lister); agent
|
|
profiles → agent settings store; code stats → the task-02 aggregation
|
|
service method. Never call a repository directly from the handler.
|
|
3. **Map:** explicit internal model → Go-native DTO mapping (RFC3339 strings,
|
|
optional/NULL handling). Session DTO must carry `acp_session_id` (from
|
|
session metadata / `executors_running` fallback, as the source plugin did).
|
|
- Apply the v1 scoping rule: global reads, filters narrow results, ephemeral
|
|
tasks excluded unless requested. Leave a single scoping hook per ADR 0043(a).
|
|
- Implement opaque-cursor pagination (server-defined cursor encoding + max cap).
|
|
- Write RPC handlers return `codes.Unimplemented`.
|
|
- **Wiring:** add the new service deps to `plugins.Service`, `plugins.NewService`,
|
|
and `Provide`; thread them into `hostForPlugin` so each spawned `pluginHost`
|
|
can serve data RPCs. Confirm the new RPCs are served over the existing Host
|
|
broker connection (`runtime/manager.go` spawn path, `registerHostServer`).
|
|
|
|
## Acceptance
|
|
- A plugin declaring `api_read:sessions` gets `ListSessions` +
|
|
`ListSessionCodeStats` results via the Host channel; one without it gets
|
|
`PermissionDenied` naming `api_read:sessions`.
|
|
- All read RPCs map internal models to DTOs with no proto/domain-struct leakage;
|
|
write RPCs return `Unimplemented`.
|
|
- `make -C apps/backend proto` not required here (done in task-01); package builds
|
|
and tests pass.
|
|
|
|
## Verification
|
|
- `cd apps/backend && go test ./internal/plugins/...`
|
|
- `cd apps/backend && go build ./...`
|
|
|
|
## Files likely touched
|
|
- `apps/backend/internal/plugins/host.go`
|
|
- `apps/backend/internal/plugins/service.go` (deps, `NewService`, `Provide`,
|
|
`hostForPlugin`)
|
|
- possibly a new `apps/backend/internal/plugins/host_data.go`
|
|
- `apps/backend/internal/plugins/host_test.go`
|
|
|
|
## Inputs
|
|
- Extended `Host` interface + Go-native DTOs from task-03.
|
|
- Aggregation service method from task-02.
|
|
- Existing gating pattern: `internal/plugins/host.go` (`permissionDenied`,
|
|
capability checks), `service.go` `hostForPlugin`, `manifest.CanRead`/`CanWrite`.
|
|
- Service methods: `internal/task/service/service_sessions.go`,
|
|
`internal/workflow/service/service.go`, `internal/agent/settings/store`.
|
|
- Spec: "Host data API"; ADR 0043 (service-layer reads, DTO discipline, scoping).
|
|
|
|
## Dependencies
|
|
Tasks 01, 02, 03.
|
|
|
|
## Output contract
|
|
Summary, per-resource service method used for each RPC, capability-gating result,
|
|
wiring changes, `acp_session_id` sourcing note, test result, and status update
|
|
here + in `plan.md`.
|
|
</content>
|