Files
kandev/apps/web/components/task/executor-settings-button.tsx
T
José Almeida f169d25b72 fix(executor-profile): live Configured badge + session/load resilience + live container status
Three independent fixes that all surface together while iterating on the
Docker executor flow:

- Remote Credentials card: the per-agent "Configured" / "Not Configured"
  badge was driven by useState that only seeded once on mount. Picking a
  secret in the dropdown updated the parent's `agentEnvVars` map but the
  local `choice` never moved to `"env"`, so the badge stayed grey until
  the page was reloaded. Derive `choice` straight from props every render
  so the badge tracks live state.

- ACP session/load: when the agent process restarted between turns
  (common with claude-agent-acp because its session map is in-memory),
  the host's session/load call failed with JSON-RPC -32002 "Resource not
  found" and the entire launch errored out. Treat that as the same kind
  of "session is gone" signal as -32601 / capability=false and fall back
  to session/new. Worst case the agent loses prior context; best case
  the user just keeps typing.

- Executor Settings popover: dropped Execution ID and Environment ID
  rows (debug-only noise users don't need), kept Container ID + the
  copyable `docker exec -it … bash` line, added a live status badge
  with tones for running / exited / paused / dead / error / missing,
  and a 3-second polling interval so the badge follows the real
  container state. New `GET /api/v1/tasks/:id/environment/live`
  endpoint plumbs Docker `inspect` data through the lifecycle manager
  → task service → handler. ContainerLiveStatus mirror type at the
  service layer keeps lifecycle types out of the public surface.
2026-05-04 21:08:51 +01:00

343 lines
10 KiB
TypeScript

"use client";
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { IconBox, IconCopy, IconLoader, IconTrash } from "@tabler/icons-react";
import { Popover, PopoverContent, PopoverTrigger } from "@kandev/ui/popover";
import { Button } from "@kandev/ui/button";
import { Badge } from "@kandev/ui/badge";
import { toast } from "sonner";
import {
fetchTaskEnvironmentLive,
resetTaskEnvironment,
type ContainerLiveStatus,
type TaskEnvironment,
} from "@/lib/api/domains/task-environment-api";
import { TaskResetEnvConfirmDialog } from "./task-reset-env-confirm-dialog";
type ExecutorSettingsButtonProps = {
taskId?: string | null;
disabled?: boolean;
};
const POLL_INTERVAL_MS = 3000;
export function ExecutorSettingsButton({ taskId, disabled }: ExecutorSettingsButtonProps) {
const [open, setOpen] = useState(false);
const [env, setEnv] = useState<TaskEnvironment | null>(null);
const [container, setContainer] = useState<ContainerLiveStatus | null>(null);
const [loading, setLoading] = useState(false);
const [resetDialogOpen, setResetDialogOpen] = useState(false);
const [isResetting, setIsResetting] = useState(false);
const inFlight = useRef(false);
const loadEnv = useCallback(async () => {
if (!taskId || inFlight.current) return;
inFlight.current = true;
setLoading((prev) => prev || env == null);
try {
const data = await fetchTaskEnvironmentLive(taskId);
setEnv(data.environment);
setContainer(data.container ?? null);
} catch {
setEnv(null);
setContainer(null);
} finally {
inFlight.current = false;
setLoading(false);
}
}, [taskId, env]);
useEffect(() => {
if (!open || !taskId) return;
void loadEnv();
const interval = window.setInterval(() => {
void loadEnv();
}, POLL_INTERVAL_MS);
return () => window.clearInterval(interval);
}, [open, taskId, loadEnv]);
const handleReset = useCallback(
async ({ pushBranch }: { pushBranch: boolean }) => {
if (!taskId) return;
setIsResetting(true);
try {
await resetTaskEnvironment(taskId, { push_branch: pushBranch });
toast.success("Environment reset");
setEnv(null);
setContainer(null);
setResetDialogOpen(false);
setOpen(false);
} catch (err) {
const msg = err instanceof Error ? err.message : "Unknown error";
toast.error(`Reset failed: ${msg}`);
} finally {
setIsResetting(false);
}
},
[taskId],
);
if (!taskId) return null;
return (
<>
<Popover open={open} onOpenChange={setOpen}>
<PopoverTrigger asChild>
<Button
variant="outline"
size="sm"
className="cursor-pointer px-2"
disabled={disabled}
data-testid="executor-settings-button"
aria-label="Executor settings"
>
<IconBox className="h-4 w-4" />
</Button>
</PopoverTrigger>
<PopoverContent
align="end"
className="w-[340px] p-0 text-sm"
data-testid="executor-settings-popover"
>
<EnvironmentInfo env={env} container={container} loading={loading} />
<div className="border-t border-border p-2 flex items-center justify-end">
<Button
variant="destructive"
size="sm"
className="cursor-pointer text-xs"
disabled={!env || isResetting}
data-testid="executor-settings-reset"
onClick={() => setResetDialogOpen(true)}
>
<IconTrash className="h-3.5 w-3.5 mr-1" /> Reset environment
</Button>
</div>
</PopoverContent>
</Popover>
<TaskResetEnvConfirmDialog
open={resetDialogOpen}
onOpenChange={setResetDialogOpen}
hasWorktreePath={Boolean(env?.worktree_path)}
isResetting={isResetting}
onConfirm={handleReset}
/>
</>
);
}
function EnvironmentInfo({
env,
container,
loading,
}: {
env: TaskEnvironment | null;
container: ContainerLiveStatus | null;
loading: boolean;
}) {
if (loading && !env) {
return (
<div className="flex items-center justify-center py-6 text-muted-foreground">
<IconLoader className="h-4 w-4 animate-spin" />
</div>
);
}
if (!env) {
return (
<div className="px-3 py-4 text-muted-foreground">
<p className="font-medium text-foreground">No environment yet</p>
<p className="text-xs mt-1">
An environment is created when you start a session on this task.
</p>
</div>
);
}
return (
<div className="p-3 space-y-3">
<div className="flex items-center justify-between gap-2">
<span className="font-medium text-foreground">{formatExecutorType(env.executor_type)}</span>
<StatusBadge env={env} container={container} />
</div>
<EnvironmentFields env={env} container={container} />
</div>
);
}
function StatusBadge({
env,
container,
}: {
env: TaskEnvironment;
container: ContainerLiveStatus | null;
}) {
// For container-backed envs the live state is the source of truth; for the
// others fall back to the recorded TaskEnvironment.status.
const { label, tone } = resolveStatus(env, container);
const className = TONE_CLASSES[tone];
return (
<Badge variant="outline" className={`text-[10px] uppercase ${className}`}>
{label}
</Badge>
);
}
type StatusTone = "running" | "stopped" | "warn" | "error" | "neutral";
const TONE_CLASSES: Record<StatusTone, string> = {
running: "border-green-500/30 bg-green-500/10 text-green-700 dark:text-green-300",
stopped: "border-zinc-500/30 bg-zinc-500/10 text-zinc-700 dark:text-zinc-300",
warn: "border-amber-500/30 bg-amber-500/10 text-amber-700 dark:text-amber-300",
error: "border-red-500/30 bg-red-500/10 text-red-700 dark:text-red-300",
neutral: "border-muted text-muted-foreground",
};
function resolveStatus(
env: TaskEnvironment,
container: ContainerLiveStatus | null,
): { label: string; tone: StatusTone } {
if (container) {
return resolveContainerStatus(container);
}
return resolveEnvStatus(env.status);
}
const CONTAINER_STATUS_TONES: Record<string, StatusTone> = {
paused: "warn",
restarting: "warn",
dead: "error",
};
function resolveContainerStatus(container: ContainerLiveStatus): {
label: string;
tone: StatusTone;
} {
if (container.missing) return { label: "missing", tone: "warn" };
if (container.state === "running") {
return { label: container.status || "running", tone: "running" };
}
if (container.state === "exited") {
return {
label: container.exit_code ? `exited (${container.exit_code})` : "exited",
tone: container.exit_code ? "error" : "stopped",
};
}
const tone = CONTAINER_STATUS_TONES[container.state] ?? "neutral";
return { label: container.state || "unknown", tone };
}
const ENV_STATUS_MAP: Record<string, { label: string; tone: StatusTone }> = {
ready: { label: "ready", tone: "running" },
creating: { label: "starting", tone: "warn" },
stopped: { label: "stopped", tone: "stopped" },
failed: { label: "failed", tone: "error" },
};
function resolveEnvStatus(status: string): { label: string; tone: StatusTone } {
return ENV_STATUS_MAP[status] ?? { label: status || "unknown", tone: "neutral" };
}
function EnvironmentFields({
env,
container,
}: {
env: TaskEnvironment;
container: ContainerLiveStatus | null;
}) {
const fields = useMemo(() => buildFields(env, container), [env, container]);
if (fields.length === 0) {
return <p className="text-xs text-muted-foreground">No resource details available.</p>;
}
return (
<dl className="space-y-1.5 text-xs">
{fields.map((f) => (
<Field key={f.label} label={f.label} value={f.value} copy={f.copy} />
))}
</dl>
);
}
function Field({ label, value, copy }: { label: string; value: string; copy?: boolean }) {
return (
<div className="flex items-start gap-2">
<dt className="text-muted-foreground min-w-[80px]">{label}</dt>
<dd className="flex-1 flex items-center gap-1 break-all font-mono">
<span className="flex-1">{value}</span>
{copy && (
<button
type="button"
className="cursor-pointer text-muted-foreground hover:text-foreground"
aria-label={`Copy ${label}`}
onClick={() => {
void navigator.clipboard.writeText(value).then(() => toast.success(`${label} copied`));
}}
>
<IconCopy className="h-3 w-3" />
</button>
)}
</dd>
</div>
);
}
type FieldRow = { label: string; value: string; copy?: boolean };
function buildFields(env: TaskEnvironment, container: ContainerLiveStatus | null): FieldRow[] {
const rows: FieldRow[] = [];
if (env.worktree_path) {
rows.push({ label: "Worktree", value: env.worktree_path, copy: true });
}
if (env.worktree_branch) {
rows.push({ label: "Branch", value: env.worktree_branch, copy: true });
}
if (env.container_id) {
const short = env.container_id.slice(0, 12);
rows.push({ label: "Container", value: short, copy: true });
rows.push({
label: "Shell",
value: `docker exec -it ${short} bash`,
copy: true,
});
if (container?.started_at && container.state === "running") {
rows.push({ label: "Uptime", value: formatUptime(container.started_at) });
}
}
if (env.sandbox_id) {
rows.push({ label: "Sprite", value: env.sandbox_id, copy: true });
}
return rows;
}
function formatUptime(startedAt: string): string {
const startedMs = Date.parse(startedAt);
if (Number.isNaN(startedMs)) return startedAt;
const elapsedSec = Math.max(0, Math.floor((Date.now() - startedMs) / 1000));
if (elapsedSec < 60) return `${elapsedSec}s`;
const min = Math.floor(elapsedSec / 60);
if (min < 60) return `${min}m`;
const hr = Math.floor(min / 60);
return `${hr}h ${min % 60}m`;
}
function formatExecutorType(type: string): string {
switch (type) {
case "local_pc":
case "worktree":
return "Local (worktree)";
case "local_docker":
return "Local Docker";
case "sprites":
return "Sprites sandbox";
case "remote_docker":
return "Remote Docker";
default:
return type || "Unknown executor";
}
}