e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
184 lines
7.9 KiB
Markdown
184 lines
7.9 KiB
Markdown
# kandev.plugin.v1 — gRPC plugin contract (FROZEN)
|
|
|
|
Supersedes the HTTP+HMAC transport. Every task builds against this file; do not
|
|
diverge without updating it. The frontend contract (PLUGIN-API.md) is unchanged
|
|
except where noted in §7.
|
|
|
|
## 1. Architecture
|
|
|
|
- Plugin **backends are Go binaries** distributed in a release tarball and
|
|
**spawned by kandev as subprocesses** via `hashicorp/go-plugin`.
|
|
- Transport: gRPC over a unix domain socket (macOS/Linux) or loopback TCP +
|
|
AutoMTLS (Windows) — negotiated by go-plugin, invisible to authors.
|
|
- Auth: the spawn relationship + go-plugin handshake + AutoMTLS. **No api_key,
|
|
no webhook_secret, no HMAC** — all credential machinery is removed for managed
|
|
plugins. The remote/self-hosted tier (`base_url` registration) is REMOVED
|
|
(future work if ever needed).
|
|
- The `LISTENING <addr>` stdout handshake is replaced by go-plugin's handshake.
|
|
|
|
## 2. go-plugin handshake
|
|
|
|
```go
|
|
var Handshake = plugin.HandshakeConfig{
|
|
ProtocolVersion: 1,
|
|
MagicCookieKey: "KANDEV_PLUGIN",
|
|
MagicCookieValue: "kandev-plugin-v1",
|
|
}
|
|
// plugin map key: "plugin"; AutoMTLS: enabled on the client (kandev) side.
|
|
```
|
|
|
|
Env kandev injects into the subprocess:
|
|
- `KANDEV_PLUGIN_DATA_DIR` — per-plugin writable dir (`~/.kandev/plugins/<id>/data`).
|
|
|
|
## 3. Proto (`apps/backend/proto/kandev/plugin/v1/plugin.proto`)
|
|
|
|
```proto
|
|
syntax = "proto3";
|
|
package kandev.plugin.v1;
|
|
import "google/protobuf/struct.proto";
|
|
|
|
// Implemented by the PLUGIN. kandev is the client.
|
|
service Plugin {
|
|
rpc DeliverEvent(Event) returns (EventAck);
|
|
rpc InvokeTool(ToolRequest) returns (ToolResponse);
|
|
rpc HandleWebhook(WebhookRequest) returns (WebhookResponse);
|
|
}
|
|
|
|
// Implemented by KANDEV (served back over the go-plugin broker).
|
|
// Every RPC is capability-gated server-side (§5).
|
|
service Host {
|
|
rpc GetState(GetStateRequest) returns (GetStateResponse);
|
|
rpc SetState(SetStateRequest) returns (SetStateResponse);
|
|
rpc DeleteState(DeleteStateRequest) returns (DeleteStateResponse);
|
|
rpc ListState(ListStateRequest) returns (ListStateResponse);
|
|
rpc RevealSecret(RevealSecretRequest) returns (RevealSecretResponse);
|
|
rpc EmitEvent(EmitEventRequest) returns (EmitEventResponse);
|
|
}
|
|
|
|
message Event {
|
|
string event_id = 1; // fresh uuid per delivery
|
|
string event_type = 2; // bus subject, e.g. "task.created"
|
|
string occurred_at = 3; // RFC3339 UTC
|
|
string workspace_id = 4; // empty if not derivable
|
|
google.protobuf.Struct payload = 5; // marshaled bus event.Data
|
|
}
|
|
message EventAck {}
|
|
|
|
message ToolRequest {
|
|
string tool_call_id = 1;
|
|
string tool_name = 2;
|
|
google.protobuf.Struct input = 3;
|
|
ToolContext context = 4;
|
|
}
|
|
message ToolContext { string task_id = 1; string agent_instance_id = 2; string session_id = 3; }
|
|
message ToolResponse { google.protobuf.Struct output = 1; string error = 2; }
|
|
|
|
message WebhookRequest {
|
|
string webhook_key = 1;
|
|
string method = 2;
|
|
string path = 3; // remainder after the key
|
|
string query = 4;
|
|
map<string, string> headers = 5; // single-valued; multi joined by ", "
|
|
bytes body = 6;
|
|
}
|
|
message WebhookResponse { int32 status = 1; map<string, string> headers = 2; bytes body = 3; }
|
|
|
|
message GetStateRequest { string scope = 1; string scope_id = 2; string key = 3; }
|
|
message GetStateResponse { bool found = 1; google.protobuf.Struct value = 2; }
|
|
message SetStateRequest { string scope = 1; string scope_id = 2; string key = 3; google.protobuf.Struct value = 4; }
|
|
message SetStateResponse {}
|
|
message DeleteStateRequest { string scope = 1; string scope_id = 2; string key = 3; }
|
|
message DeleteStateResponse {}
|
|
message ListStateRequest { string scope = 1; string scope_id = 2; }
|
|
message ListStateResponse { repeated StateEntry entries = 1; }
|
|
message StateEntry { string key = 1; google.protobuf.Struct value = 2; string updated_at = 3; }
|
|
|
|
message RevealSecretRequest { string ref = 1; }
|
|
message RevealSecretResponse { string value = 1; }
|
|
|
|
message EmitEventRequest { string event_name = 1; google.protobuf.Struct payload = 2; }
|
|
message EmitEventResponse {}
|
|
```
|
|
|
|
Notes: scope ∈ instance|workspace|task|agent (empty scope_id for instance —
|
|
matches the state store). The plugin never passes its own id; the Host service
|
|
instance is bound to the plugin's record at spawn time.
|
|
|
|
## 4. SDK (`apps/backend/pkg/pluginsdk`)
|
|
|
|
Public Go module surface (authors import only this):
|
|
|
|
```go
|
|
type Plugin interface {
|
|
OnEvent(ctx context.Context, e *Event) error // return err → kandev retries
|
|
InvokeTool(ctx context.Context, req *ToolRequest) (*ToolResponse, error)
|
|
HandleWebhook(ctx context.Context, req *WebhookRequest) (*WebhookResponse, error)
|
|
}
|
|
type Host interface { // injected before Serve returns
|
|
GetState/SetState/DeleteState/ListState(...)
|
|
RevealSecret(ctx, ref string) (string, error)
|
|
EmitEvent(ctx, name string, payload map[string]any) error
|
|
}
|
|
func Serve(p Plugin, opts ...Option) // blocks; wires go-plugin server + broker
|
|
// Optional embeddable no-op base: sdk.UnimplementedPlugin
|
|
```
|
|
|
|
SDK types mirror proto but use `map[string]any` for Struct fields. The SDK owns
|
|
all go-plugin/grpc plumbing (handshake, broker for Host, conversions).
|
|
|
|
## 5. Delivery / tools / webhooks semantics (unchanged from HTTP era)
|
|
|
|
- **DeliverEvent**: unary. Per-plugin sequential queue, 10s timeout, 3 retries
|
|
(5s/15s/45s, injectable), ring buffer 100/5min while plugin unhealthy, flush
|
|
in order on recovery. Non-nil error or timeout counts as failure.
|
|
- **InvokeTool**: 30s timeout.
|
|
- **HandleWebhook**: kandev's HTTP endpoint `POST /api/plugins/{id}/webhooks/{key}`
|
|
converts the HTTP request to WebhookRequest and relays the WebhookResponse.
|
|
- **Health**: go-plugin client `Ping()` every 30s (injectable), 3 consecutive
|
|
failures → status `error` (+ restart attempt with backoff), recovery → `active`
|
|
+ delivery flush. Crash (process exit) → immediate restart with backoff
|
|
(max 5 attempts, then `error`).
|
|
- **Capability gating**: a unary server interceptor on Host checks the plugin's
|
|
manifest capabilities (state, secrets; api_read/api_write reserved) and returns
|
|
PermissionDenied with `capability '<name>' not declared`.
|
|
|
|
## 6. Package format (`<id>-<version>.tar.gz`)
|
|
|
|
```
|
|
manifest.yaml # authoritative; read BEFORE any code runs
|
|
server/plugin-<goos>-<goarch>[.exe] # any subset; host platform key required at install
|
|
ui/bundle.js # optional (frontend half)
|
|
ui/*.css / assets/icon.svg # optional
|
|
checksums.txt # "sha256 path" for every other file
|
|
checksums.txt.sig # OPTIONAL ed25519 signature (unsigned → warn)
|
|
```
|
|
|
|
Manifest additions (replaces base_url; endpoints block is REMOVED):
|
|
|
|
```yaml
|
|
runtime:
|
|
type: binary
|
|
executables:
|
|
linux-amd64: server/plugin-linux-amd64
|
|
darwin-arm64: server/plugin-darwin-arm64
|
|
# ... any subset
|
|
min_kandev_version: "0.78.0" # optional
|
|
```
|
|
|
|
Install pipeline: `POST /api/plugins/install` with JSON `{"url": "..."}` OR
|
|
multipart field `package` → verify checksums.txt covers all files & hashes match
|
|
→ parse+validate manifest (host platform key present; id pattern; capabilities)
|
|
→ extract to `~/.kandev/plugins/<id>/<version>/` → write record → status
|
|
`registered` → spawn → handshake OK → `active`. Record keeps `version` and
|
|
`install_path`. Uninstall stops the process and removes record + versions + data
|
|
(24h grace not required for v1). `POST /api/plugins/register` is REMOVED.
|
|
|
|
## 7. Frontend deltas (PLUGIN-API.md otherwise unchanged)
|
|
|
|
- `GET /api/plugins/{id}/bundle` and `/api/plugins/{id}/ui/*` are served by
|
|
kandev **from the extracted package dir** (no reverse proxy, no upstream).
|
|
- Management page: "Register plugin" (manifest paste) is replaced by "Install
|
|
plugin" (URL input + file upload). No credentials are ever displayed.
|
|
- Boot payload `plugins: [{id,name,bundleUrl,styleUrls}]` unchanged.
|
|
```
|