Files
João Salavisa e145d48f22 feat: add plugin system with grpc runtime and native ui plugins (#1742)
* feat: add plugin system with grpc runtime and native ui plugins

- go plugin backends ship as release tarballs (per-platform binaries, checksums) that
  kandev installs from url/upload or filesystem sideload+sync, then spawns and
  supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls)
- strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook
  plus a capability-gated host service (state, secrets, emit); author sdk in
  pkg/pluginsdk; packaging cli in cmd/plugin-pack
- native frontend bundles: window.registerKandevPlugin + registry/host loader with
  dynamic routes, nav items, slots and ws handlers; plugins settings page with
  install dialog, sync button and enable/disable/uninstall
- gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and
  integration tests plus playwright e2e against a real packaged fixture plugin

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): hydrate base app context on plugin routes

Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped
only feature flags — no workspaces, workflows, or kanban context. Native plugin
UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same
base context as the Home route for unknown SPA routes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): expose TaskCreateDialog on host.ui

Lets a native plugin open kandev's real create-task modal (prefilled via
initialValues) instead of POSTing directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): harden filesystem/URL sinks against CodeQL findings

Add sink-level guards on the plugin trust boundary: securejoin containment on
archive extraction (zip-slip), plugin-id validation before every fs_store path,
http/https scheme validation on install-from-URL, and non-interpolated ws-handler
error logging.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address review findings (races, resource caps, lifecycle)

- serialize per-plugin startup to close a TOCTOU double-spawn race, and let a
  plugin restart after exhausting attempts
- bound plugin startup with an explicit 30s timeout
- reject backslash paths and cap decompressed bytes by actual size in pkgtar;
  only mark a package Signed when a verifier actually ran and passed
- delete plugin_state on uninstall; validate webhook keys against the manifest
  and cap webhook body size; restart an active plugin when a new version installs

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): sanitize plugin-id path sinks for CodeQL

Pin the plugin id to a single path segment with filepath.Base at recordPath/
configPath and pkgtar.Remove — a barrier the taint analysis recognizes.
Behaviour-identical for valid ids (already validated by safePluginID); clears
the go/path-injection alerts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): inline plugin-id validation at path sinks for CodeQL

filepath.Base does not strip '..', so it is not a path-injection barrier. Call
the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/
SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address code-review findings (backend)

- add capability-gating tests for the Host RPC service (was untested)
- close a stop-during-start orphan race so Disable/Uninstall can't leave a
  supervised subprocess behind
- on failed upgrade, remove only the new version dir (not all versions + data);
  restart the prior version
- validate manifest version and reject ids ending in .config (record-file alias)
- make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop
- clamp out-of-range webhook status, skip-and-warn corrupt records in List,
  write records atomically, semver-aware sideload version pick

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address code-review findings (frontend)

- wrap plugin routes + settings routes in a shared PluginErrorBoundary so a
  throwing plugin page shows a fallback instead of white-screening the SPA
- fix disable/re-enable in one session: keep the cached registration and
  re-run initialize instead of relying on a cached ES-module re-import
- prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri)
- surface partial-install warnings via toast.warning instead of a bare success
- dedupe/remove injected style links on unload; gate PluginNavItems on the flag

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): serialize per-plugin lifecycle + guard config writes

- add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/
  Uninstall/UpdateConfig for one id are serialized (no status-machine race)
- take s.mu in SetConfig/GetConfig and write config atomically
- bound each plugin initialize() with a timeout so one hung bundle can't stall
  the rest of the boot load

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(plugins): split service_test.go to satisfy file-length lint

Move the install/URL test group into service_install_test.go; no logic change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci: build and ship the e2e fixture plugin package to E2E shards

The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz.
Build it in the E2E build job, upload it as an artifact, and download it in both
the regular and container shard jobs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-17 12:00:26 +01:00

152 lines
4.4 KiB
Go

// Command plugin-pack tests. Exercises Pack() (the packaging core) against
// real temp-dir package layouts, verifying both the raw tar contents (for
// -platform-only filtering) and that pkgtar.Install accepts the produced
// archive end to end.
package main
import (
"archive/tar"
"bytes"
"compress/gzip"
"fmt"
"io"
"os"
"path/filepath"
"runtime"
"testing"
"github.com/kandev/kandev/internal/plugins/pkgtar"
"github.com/stretchr/testify/require"
)
// writeTestPackageDir builds a plugin package source directory (not yet
// packed) under t.TempDir(), with a manifest.yaml declaring runtime
// executables for the current host platform plus two extra platforms, a
// dummy binary for each, and a ui/bundle.js. Returns the dir.
func writeTestPackageDir(t *testing.T) string {
t.Helper()
dir := t.TempDir()
hostKey := runtime.GOOS + "-" + runtime.GOARCH
manifestYAML := fmt.Sprintf(`
id: "kandev-plugin-pack-test"
api_version: 1
version: "1.0.0"
display_name: "Pack Test Plugin"
description: "fixture for plugin-pack tests"
author: "kandev"
runtime:
type: binary
executables:
%s: "server/plugin-%s"
linux-arm64: "server/plugin-linux-arm64"
windows-amd64: "server/plugin-windows-amd64.exe"
capabilities:
state: true
`, hostKey, hostKey)
require.NoError(t, os.WriteFile(filepath.Join(dir, "manifest.yaml"), []byte(manifestYAML), 0o644))
require.NoError(t, os.MkdirAll(filepath.Join(dir, "server"), 0o755))
for _, name := range []string{
"plugin-" + hostKey,
"plugin-linux-arm64",
"plugin-windows-amd64.exe",
} {
require.NoError(t, os.WriteFile(filepath.Join(dir, "server", name), []byte("#!/bin/sh\necho fake-binary\n"), 0o755))
}
require.NoError(t, os.MkdirAll(filepath.Join(dir, "ui"), 0o755))
require.NoError(t, os.WriteFile(filepath.Join(dir, "ui", "bundle.js"), []byte("console.log('hi');"), 0o644))
return dir
}
// tarEntryNames decompresses and lists every regular-file entry name in a
// tar.gz archive.
func tarEntryNames(t *testing.T, data []byte) []string {
t.Helper()
gz, err := gzip.NewReader(bytes.NewReader(data))
require.NoError(t, err)
defer func() { _ = gz.Close() }()
tr := tar.NewReader(gz)
var names []string
for {
hdr, err := tr.Next()
if err == io.EOF {
break
}
require.NoError(t, err)
if hdr.Typeflag == tar.TypeReg {
names = append(names, hdr.Name)
}
}
return names
}
func TestPack_ProducesInstallableTarball(t *testing.T) {
dir := writeTestPackageDir(t)
var buf bytes.Buffer
require.NoError(t, Pack(dir, &buf, PackOptions{}))
names := tarEntryNames(t, buf.Bytes())
require.Contains(t, names, "manifest.yaml")
require.Contains(t, names, "server/plugin-"+runtime.GOOS+"-"+runtime.GOARCH)
require.Contains(t, names, "server/plugin-linux-arm64")
require.Contains(t, names, "server/plugin-windows-amd64.exe")
require.Contains(t, names, "ui/bundle.js")
require.Contains(t, names, "checksums.txt")
destRoot := t.TempDir()
result, err := pkgtar.Install(&buf, destRoot)
require.NoError(t, err)
require.Equal(t, "kandev-plugin-pack-test", result.Manifest.ID)
require.Equal(t, "1.0.0", result.Version)
}
func TestPack_PlatformOnly_IncludesOnlyHostBinary(t *testing.T) {
dir := writeTestPackageDir(t)
var buf bytes.Buffer
require.NoError(t, Pack(dir, &buf, PackOptions{PlatformOnly: true}))
names := tarEntryNames(t, buf.Bytes())
require.Contains(t, names, "server/plugin-"+runtime.GOOS+"-"+runtime.GOARCH)
require.NotContains(t, names, "server/plugin-linux-arm64")
require.NotContains(t, names, "server/plugin-windows-amd64.exe")
require.Contains(t, names, "manifest.yaml")
require.Contains(t, names, "ui/bundle.js")
// The filtered package must still install cleanly on the host platform.
destRoot := t.TempDir()
result, err := pkgtar.Install(&buf, destRoot)
require.NoError(t, err)
require.Equal(t, "kandev-plugin-pack-test", result.Manifest.ID)
}
func TestPack_MissingManifest_Errors(t *testing.T) {
dir := t.TempDir()
require.NoError(t, os.WriteFile(filepath.Join(dir, "ui.js"), []byte("x"), 0o644))
var buf bytes.Buffer
err := Pack(dir, &buf, PackOptions{})
require.Error(t, err)
require.Contains(t, err.Error(), "manifest.yaml")
}
func TestPackToFile_WritesTarballToDisk(t *testing.T) {
dir := writeTestPackageDir(t)
out := filepath.Join(t.TempDir(), "nested", "out.tar.gz")
require.NoError(t, packToFile(dir, out, false))
data, err := os.ReadFile(out)
require.NoError(t, err)
names := tarEntryNames(t, data)
require.Contains(t, names, "manifest.yaml")
}