* fix: gate gitlab/linear fetches on integration being configured
The GitLab and Linear pages fired merge-request/issue searches on mount
regardless of connection state, producing console errors when the
integration was unconfigured (two 500s on /gitlab, one 503 on /linear)
even though the UI already rendered the "not connected/configured" notice.
Gate the search fetch on the same connected/configured condition that
decides whether the results list renders:
- useGitLabSearch takes an `enabled` flag (converted to an options object
to stay within the 5-param lint limit, matching useGitHubSearch); the
page enables it only when status is loaded and GitLab is connected.
- Linear's inline issue-search hook is extracted to
useLinearIssueSearch with an `enabled` flag, enabled only when the
workspace is loaded, configured, and available.
Adds gating/wiring tests for both hooks.
* refactor: gate gitlab search at the effect level too
Mirror the Linear hook (which guards both its run callback and its debounce
effect) by adding the enabled guard to useGitLabSearch's fetch effect and
enabled to its dep array, so a disabled integration never schedules a fetch.
The callback keeps its own guard to also cover the exported refresh().
Addresses PR review feedback on the enabled-gate asymmetry.
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
* feat(linear): enrich issue watch filters with priority, labels, creator, estimate
Adds priority, labels (multi-select), creator (team member select), and
estimate range filters to Linear issue watchers — closing the gap with
Linear's GraphQL filter surface so users can scope auto-run watchers
nearly as tightly as they would in Linear itself.
- Backend: extend SearchFilter, map new fields to IssueFilter, add
ListLabels / ListUsers on the Client interface, expose them over HTTP
(GET /api/v1/linear/labels, /users) and via SearchIssues query params.
- Frontend: extend LinearSearchFilter, fetch labels + users per team,
render new filter controls in the watcher dialog, and split helpers
into linear-issue-watch-form.ts + linear-issue-watch-fields.tsx so
the dialog stays under file/function size limits.
* fix(linear): address reviewer feedback on enriched filter PR
- Reject invalid priority / malformed estimate query params with 400 instead
of silently dropping them; reject estimateMin > estimateMax. Mirror the
bounds check in the issue-watch validator so JSON-encoded watches go
through the same gate.
- A11y: render label/state toggle Badges inside <button aria-pressed> so
keyboard users can navigate and screen readers can announce state.
- Recover from per-team fetch failures so a transient network blip doesn't
permanently mark a team as "fetched-empty" — clear the in-flight marker
when any of states/labels/users fail, allowing remount to retry.
- Tighten priority typing: LinearSearchFilter.priority is 0|1|2|3|4, and
LinearPriority is the source of truth on the form-state side. Promote
FormState from a type alias to an interface per repo convention.
* fix(linear): align update error message and clear fetchedTeams on cancel
- UpdateIssueWatch's filter-empty error still listed only the original
four fields; bring it in line with the create path so the message
matches what filterIsEmpty actually accepts.
- linear-issue-watch-fields: clear the fetchedTeams marker on effect
cancellation as well as failure, so a remount after a fast teamKey
switch can retry instead of being stuck with whatever partial cache
the prior effect produced.
* fix(linear): address PR #974 reviewer findings
- linear-issue-watch-fields: delete the fetchedTeams marker on effect
cleanup so rapid team switches (A → B → A) refetch on return instead
of being stranded mid-load. Capture the Set in a local so the cleanup
closure references the exact instance the effect body added to.
- graphql_client: raise the labels/users page cap from 100 to Linear's
max of 250 via a shared linearMaxPageSize constant and a $first
variable. Documented that a workspace exceeding that would need
cursor-pagination here AND lazy-load in the UI.
- service_issue_watch.validateFilterBounds + handlers parseSearchNumeric
Filters: reject negative estimate values — Linear story points are
non-negative, so a -1 would silently match nothing.
* fix(linear): collapse duplicate hint text on States/Labels rows
When no team was selected the row showed two stacked muted lines —
the field description and the multi-select's "Pick a team…" prose —
saying overlapping things. Swap the row description based on team
selection and let the multi-select render nothing when disabled, so
exactly one line is shown in either state.
Also tightens the new fields' descriptions to match the brevity of
the existing ones (Labels, Estimate min/max).
* fix(linear): reject NaN/Inf estimates and preserve team cache after success
CodeRabbit + cubic flagged two real issues in the previous round:
- strconv.ParseFloat accepts "NaN" / "+Inf" / "-Inf" without erroring,
and "f < 0" passes through for NaN. Without an explicit math.IsNaN /
math.IsInf guard those values would propagate into the GraphQL
request and the eventual json.Marshal would 500 instead of 400.
Add the guard for both estimate_min and estimate_max, with a
regression test covering NaN, ±Inf, negative, and inverted range.
- useTeamsAndStates was deleting the per-team cache marker on every
cleanup, so a normal team switch evicted a healthy cache and the
next visit re-fetched all three datasets. Track a "loaded" flag and
only evict on cleanup when the fetch didn't complete successfully.
Also extracts the duplicated "team_key" / "team_key required" wire
strings into package-level constants per the repo's
"3+ occurrences → constant" convention.
* test(linear): add handler tests for /labels and /users endpoints
Mirrors the existing TestHTTPListStates_* pair — required team_key
returns 400, and a happy path that asserts the team_key reaches the
client and the response is 200. Closes the coverage gap CodeRabbit
flagged on the two new endpoints introduced in this PR.
* feat(linear): make priority filter multi-select
Status and label filters are already multi-select; priority being a
single Select broke the symmetry and forced single-value thinking.
Linear's own filter UI is multi-select per priority, and the GraphQL
filter takes priority: { in: [...] } natively, so the wire change is
clean.
Backend
- SearchFilter.Priority *int → Priorities []int
- buildIssueFilter emits priority: { in: priorities } when non-empty
- validateFilterBounds checks each element ∈ [0,4]
- normalizeFilter de-dupes (preserves caller order)
- HTTP query param priority → priorities, parsed as CSV
- Tests updated, including priority=0 still expressible as
Priorities=[0] (matches "No priority" issues only)
Frontend
- LinearSearchFilter.priority → priorities: LinearPriority[]
- FormState.priority → priorities
- PRIORITY_OPTIONS dropped the (any) sentinel; "No priority" sits at
the end of the chip row
- PriorityMultiSelect added next to State/Label multi-selects
- Priority moved to its own full-width row matching States/Labels;
Creator promoted to a stand-alone CreatorRow
Refactor
- searchLinearIssues query-param building extracted to a flat
table-driven helper to keep cyclomatic complexity ≤ 15
* refactor(linear): regroup watcher dialog fields and add section separators
UX pass on the watcher dialog:
- Pulled Team out into its own full-width row and paired Assignee +
Creator in a 2-col row so the people filters sit together — the old
Team+Assignee pairing forced a context switch between scope and
people filters mid-form.
- Added hairlines between the four conceptual blocks (Destination /
Filter / Automation / Prompt / Settings). Each block answers a
different question, so a consistent rhythm helps users scan the form
by section instead of reading one long stack.
No behaviour change; pure layout.
* refactor(linear): use shared Separator for watcher dialog section breaks
Initially extracted a local SectionDivider, but @kandev/ui/separator
(Radix-based, shadcn) already exists and is used in 14 places across
the codebase — including the sibling Jira settings page. Use that
instead so the styling tracks the rest of the app.
* refactor(linear): split parseSearchNumericFilters to satisfy cyclop
Extract priority and estimate-bound parsing into helpers so the entry
point drops below the project's max cyclomatic complexity (15).
* fix(linear): reject non-finite/negative estimates and align fmt
- validateFilterBounds rejects NaN/+-Inf in addition to negatives, so a
watch config can't be persisted with values that would later crash
json.Marshal. Adds focused unit tests.
- parseEstimate on the frontend treats negatives as unset so the UI
cannot submit estimateMin/Max < 0.
- gofmt-only alignment tweak in handlers_test.go test table.
* refactor: move integrations to top-level settings with install-wide configs
Jira and Linear configurations are now install-wide singletons rather than
per-workspace duplicates, and the GitHub/Jira/Linear settings pages live
under /settings/integrations instead of being nested inside each workspace.
Issue and PR watchers stay per-workspace via a workspace switcher inside
each integration page. Backend ships one-shot migrations that promote the
most-recently-updated row and copy its secret onto the new global key.
* fix: address review feedback on integrations refactor
Fix migration crash on installs whose jira_configs predate the auth-health
columns by selecting only guaranteed-present legacy columns and falling back
to defaults for the rest. Cover the empty-legacy-table and pre-health-columns
upgrade paths with new store tests.
On the frontend, refactor useIntegrationEnabled to take string parameters
instead of an inline options object so getSnapshot stays referentially stable
across renders, and stop dispatching a misleading no-op sync event when
localStorage.setItem fails in private mode.
* fix: hydrate workspace list on integration settings pages
The integration pages wrapped their content in a fresh StateProvider, which
created a nested store scope with an empty initial state and shadowed the
settings layout's hydrated workspace list. WorkspaceScopedSection then saw
zero workspaces and rendered the "Create a workspace to configure this
integration" empty state even when the user had workspaces.
Drop the redundant StateProvider from the jira and linear pages so they share
the layout's store. The github page switches to StateHydrator so it can still
seed the GitHub OAuth status without resetting the rest of the store.
* refactor(integrations): flatten watcher tables, pick workspace in create dialog
Hiding watchers behind a workspace switcher made the list invisible at a
glance — a user with multiple workspaces had to flip between each one to
see what was configured. Replace the switcher with a flat table that lists
every watch across every workspace, with a Workspace column for context, and
move workspace selection into the create dialog so the user picks once when
the watcher is born.
Backend: jira list-issue-watches and github list-review-watches /
list-issue-watches accept the workspace_id query param as optional; when
omitted, the corresponding store ListAll* method returns rows across every
workspace. Per-row mutations still require workspace_id as the IDOR guard.
Frontend: useReviewWatches / useIssueWatches / useJiraIssueWatches gain a
three-state contract — string for one workspace, undefined for all
workspaces, null to skip fetching. Watch tables grow an optional
showWorkspace column. Watch dialogs accept an optional workspaceId prop;
when absent, the dialog renders a workspace dropdown for the create flow
(disabled when editing existing rows so refs aren't orphaned). Github
review-watch-dialog crossed the 600-line lint cap so the prompt editor
moved to review-watch-prompt-field.tsx.
* fix(integrations): make watcher step dropdown reactive across workspace switches
Switching to a workspace whose workflows had to be fetched left the workflow
step dropdown stuck — the user could pick a workflow but the step Select
either showed the previous workflow's steps or appeared inert. The cause was
the per-dialog useWorkflowSteps hook deferring its empty-state reset via
Promise.resolve().then(() => setSteps([])) to dodge a setState-in-effect
lint rule, which let stale steps survive into the next render and gave Radix
nothing to anchor the popover to during the in-flight fetch.
Hoist the hook into a shared useWorkflowSteps that resets via React's
official setState-during-render pattern, exposes a loading flag, and returns
a stepPlaceholder helper so the Select can render "Loading steps…" or "No
steps in this workflow" instead of an empty popover. The Step Select is now
also disabled while loading or when there are no steps, making the state of
the dropdown unambiguous.
* fix: address PR review feedback on integrations refactor
Backend:
- linear migration: add column-presence guard mirroring the Jira fix so
installs that upgraded from the original Linear schema (without org_slug
/ last_checked_at / last_ok / last_error) don't crash startup with
"no such column"; add TestStore_MigrateLegacyPerWorkspaceTable_PreHealthColumns
- jira/handlers.go: drop the now-unused errMsgWorkspaceIDRequired constant
that was failing golangci-lint
- jira/mock_controller_test.go (new): cover setAuthHealth happy-path and
invalid-JSON-rejection so the singleton-shaped payload is locked in
Frontend:
- useIntegrationAvailable: gate the auth-health probe on loaded && enabled
so disabled integrations don't poll /config every 90s
- use-workflow-steps: initialize loading to !!workflowId so edit-mode opens
show "Loading steps…" instead of "No steps in this workflow" before the
first fetch lands
- use-workflow-steps.test.ts (new): cover the empty/non-empty workflowId,
workflow switch, fetch error, and stepPlaceholder branches
- use-linear-enabled.test: tighten the legacy-key migration assertion to
pin the migrated value rather than just verifying key cleanup
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
* test: add e2e coverage and mock backends for jira and linear integrations
Adds in-memory MockClient + MockController for both integrations gated by
KANDEV_MOCK_{JIRA,LINEAR}=true, plus apiClient mock helpers and Playwright
specs covering settings and import flows.
Also fixes ValidatedPopover's TriggerButton silently dropping radix Slot's
onClick handler — the popover wouldn't open under any synthetic-click path
(including Playwright). Spreads `...rest` onto the inner Button.
Reworks the integration cleanup hook in test-base as an auto fixture so it
runs for every test using the imported `test` object, not just tests in the
fixture file itself.
* fix: address PR review feedback on jira/linear mocks and e2e specs
- Fix SetAuthResult docstrings: nil simulates an unconfigured state, not the default success.
- Drop unused JSON tags from doneTransitionCall and setStateCall (Go-only test fixtures).
- Track Linear issue insertion order so SearchIssues returns deterministic results instead of map-iteration shuffle.
- Document filterByJQL precedence at the SearchTickets call site so the all-hits-on-no-match fallback is visible.
- Wait for the post-save auth-health probe before forcing a failure in the seeded-failure tests, eliminating a goroutine race.
- Reorder authMethod precedence in setJiraConfig/setLinearConfig to put the spread first so 'caller wins' reads naturally.
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
* refactor: extract shared shapes between jira and linear integrations
Factors out the duplicated logic between internal/jira + internal/linear
(backend) and components/jira + components/linear (frontend) into reusable
shared shapes. Follow-up to PR #736.
Backend:
- New internal/integrations/secretadapter wraps secrets.SecretStore with
the upsert API both jira.SecretStore and linear.SecretStore expect;
drops both adapter copies from cmd/kandev/services.go.
- New internal/integrations/healthpoll owns the 90s auth-health loop via
a Prober interface; linear/poller.go is a thin wrapper, jira/poller.go
keeps only its (jira-specific) issue-watch loop.
- provideServices split into initGitHubService / initJiraService /
initLinearService — now 75 lines (was ~125, exceeded the 80-line limit).
Frontend:
- New hooks/domains/integrations/use-integration-availability.ts and
use-integration-enabled.ts; jira/linear hooks reduce to one-line
delegates and move from components/<x>/ to hooks/domains/<x>/ per the
project convention Greptile flagged on PR #736.
- New components/integrations/{auth-status-banner,auth-error-message,
validated-popover}.tsx; the four link/import-bar wrappers drop from
~110 lines to ~35 each, and JiraLinkButton picks up the
clear-error-on-close behaviour LinearLinkButton already had.
Docs:
- New 'Adding a new third-party integration' section in CLAUDE.md/AGENTS.md
documenting the shared shapes and intentional Jira/Linear divergence
(transition vs state, JQL vs filter object, eventBus only on jira).
* fix: address PR #759 review feedback
- validated-popover: outline-with-label trigger now sets type="button" and
honours triggerDisabled, matching ghost-icon (Greptile, Claude, CodeRabbit).
- jira-link-button / linear-link-button: move updateTask() into the awaited
fetch path so a failed title update surfaces as the popover's inline error
instead of an unhandled rejection (CodeRabbit).
- use-integration-availability: monotonic requestId race guard prevents a
slow earlier probe from overwriting a newer auth result (CodeRabbit).
- use-integration-enabled: drop unnecessary async on synchronous init
(Claude).
- jira/linear poller smoke tests: wrap in testing/synctest instead of
time.After(2s) per backend testing convention (CodeRabbit nitpick).
Skipped with reasoning on the threads:
- secretadapter Set TOCTOU — single-process SQLite + single-writer per
workspace; constraint violation on conflict surfaces as an error to the
caller, not silent corruption.
- healthpoll SetInterval validation — the function isn't called from
production code today; a panic on misuse would be a footgun and silent
ignore would just hide bugs differently.
* fix: address PR #759 round-2 review feedback
- jira-settings / linear-settings: drop the local STATUS_REFRESH_MS = 90_000
copies and import the shared INTEGRATION_STATUS_REFRESH_MS so changing the
cadence only touches one file (Claude).
- healthpoll: rename Poller.ProbeAll → probeAll. The only callers are the
loop and the in-package tests, so widening the public API wasn't buying
anything (Claude).
* fix: invalidate ValidatedPopover in-flight submits on close
If the user clicked Submit and dismissed the popover before the request
settled, the next time they re-opened it would inherit `loading=true` (the
disabled-while-loading submit button was stuck) and a late rejection from
the previous session could repopulate `error` in the new one.
Track the submit via a `useRef` token, bump it on close, and ignore any
result/rejection whose token no longer matches. Also reset `loading` and
`error` on close so the next open starts clean. Adds a regression test
covering both the late-resolution and late-rejection paths.
Addresses CodeRabbit review on PR #759.
* ci: trigger workflow re-run
GitHub Actions did not dispatch the pull_request workflows on the previous
two pushes (1d869f0e, 0ab6c034); only pull_request_target and CodeQL fired.
Empty commit to nudge synchronize event.
* fix: address PR #759 round-3 review feedback
- jira.Poller.Stop: add nil-receiver guard so callers using the
defer-Stop-after-NewPoller pattern don't panic when initJiraService
returned nil (Greptile + Claude). Matches linear.Poller's guard.
- healthpoll TestStart_RunsImmediateProbe + TestStart_IsIdempotent:
rewrap in testing/synctest with synctest.Wait() instead of
time.After(2s) wall-clock waits. Drops the now-unused probedAll signal
channel from fakeProber (Claude).
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
* feat: add Linear integration
Mirrors the existing Jira integration so a workspace can connect to Linear
with a personal API key, browse and search issues, and start a Kandev task
from any issue. Backend uses Linear's GraphQL API with a workspace-scoped
config + secret store and a 90s auth-health poller; the frontend adds a
settings page, an issue dialog with state transitions, link/import buttons
in the task UI, and a paginated /linear browse page with a Start task flow.
* fix(linear): address PR review feedback
- Route httpListStates through Service.ListStates instead of clientFor
- Extract repeated workspace_id required string into a constant
- Log GetConfig errors during credential resolution instead of dropping them
- Clear popover error state on close in import + link buttons
- Pick the first workflow with steps in the quick task launcher (don't hard-pin to workflows[0])
- Reset useLinearEnabled state on workspace change via tag-based pattern
- Add cursor-pointer to anchor + Link elements per project convention
- Add tests: handlers_test.go, linear-api.test.ts, use-linear-enabled.test.ts, linear-issue-common.test.tsx
- Document internal/jira and internal/linear in CLAUDE.md/AGENTS.md
* fix(linear): address second-round PR review feedback
- Round Linear's fractional state position instead of truncating it via
int(math.Round(s.Position)) so adjacent fractional positions don't collapse
- Force LinearSettings to remount on workspace change with key={id} so the
previous workspace's config / form / testResult / teams cannot bleed into
the next workspace before the new fetches settle
- Broaden the legacy-value useLinearEnabled test to cover "true", "1", "yes",
and "legacy" so a regression to strict value === "true" would fail
* fix(linear): address third-round PR review feedback
- Propagate context.Canceled / context.DeadlineExceeded from ListStates in
GetIssue instead of swallowing them — a caller cancellation must not return
a partial-success response
- Drop the one-off contains() test helper in handlers_test.go and use
strings.Contains directly so the assertion is self-documenting
- Add getLinearIssue URL-shape test that locks identifier-as-path-segment
vs workspaceId-as-query-param so accidentally swapping them would fail
* test(linear): extract repeated literals in linear-api.test.ts
Pulls "ws-1", the API base URL, and the auth-method literal into module-
level constants so the assertions read as the route shape they care about
and the duplicate-strings ESLint rule (currently warn, threshold 4)
stays quiet as the file grows.
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
Carlos Florêncio