dreampiler/kandev
1
0
Fork 0
Code Issues 43 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(web): reset attachments when switching chat sessions (#421)

Browse Source
This commit is contained in:
João Salavisa
2026-03-12 21:54:08 +00:00
committed by GitHub
parent 9a698b9f36
commit ae9037f63c
1 changed files with 30 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/components/task/chat/use-chat-input-state.ts
+30 -16
View File
@@ -1,4 +1,4 @@
import { useRef, useCallback, useState, useEffect, useMemo } from "react";
import { useRef, useCallback, useState, useEffect, useLayoutEffect, useMemo } from "react";
import {
getChatDraftText,
setChatDraftText,
@@ -68,11 +68,30 @@ function useAttachments(sessionId: string | null) {
);
const attachmentsRef = useRef(attachments);
const prevSessionIdRef = useRef(sessionId);
const prevPersistSessionIdRef = useRef(sessionId);
// Reset attachments from storage when session changes (runs before paint)
useLayoutEffect(() => {
if (sessionId === prevSessionIdRef.current) return;
prevSessionIdRef.current = sessionId;
const newAttachments = sessionId
? getChatDraftAttachments(sessionId).map(restoreAttachmentPreview)
: [];
/* eslint-disable react-hooks/set-state-in-effect -- syncing from localStorage on session switch */
setAttachments(newAttachments);
/* eslint-enable react-hooks/set-state-in-effect */
attachmentsRef.current = newAttachments;
}, [sessionId]);
// Persist attachments to storage when they change (for the same session)
useEffect(() => {
// Skip first invocation after session change to avoid overwriting freshly loaded attachments
if (sessionId !== prevPersistSessionIdRef.current) {
prevPersistSessionIdRef.current = sessionId;
return;
}
attachmentsRef.current = attachments;
if (sessionId && prevSessionIdRef.current === sessionId)
setChatDraftAttachments(sessionId, attachments);
if (sessionId) setChatDraftAttachments(sessionId, attachments);
}, [attachments, sessionId]);
const addFiles = useCallback(
@@ -102,7 +121,6 @@ function useAttachments(sessionId: string | null) {
return {
attachments,
attachmentsRef,
prevSessionIdRef,
setAttachments,
addFiles,
handleRemoveAttachment,
@@ -124,23 +142,19 @@ export function useChatInputState({
const inputRef = useRef<TipTapInputHandle>(null);
const valueRef = useRef(value);
const pendingCommentsRef = useRef(pendingCommentsByFile);
const prevTextSessionIdRef = useRef(sessionId);
const {
attachments,
attachmentsRef,
prevSessionIdRef,
setAttachments,
addFiles,
handleRemoveAttachment,
} = useAttachments(sessionId);
const { attachments, attachmentsRef, setAttachments, addFiles, handleRemoveAttachment } =
useAttachments(sessionId);
useEffect(() => {
if (sessionId === prevSessionIdRef.current) return;
prevSessionIdRef.current = sessionId;
// Reset text value from storage when session changes (runs before paint)
useLayoutEffect(() => {
if (sessionId === prevTextSessionIdRef.current) return;
prevTextSessionIdRef.current = sessionId;
/* eslint-disable react-hooks/set-state-in-effect -- syncing from localStorage on session switch */
setValue(sessionId ? getChatDraftText(sessionId) : "");
/* eslint-enable react-hooks/set-state-in-effect */
}, [sessionId, prevSessionIdRef]);
}, [sessionId]);
useEffect(() => {
valueRef.current = value;