fix(lifecycle): reject non-regular files for KANDEV_MOCK_AGENT_LINUX_BINARY

`os.Stat` succeeds on a directory, so the previous resolver happily
accepted a directory path and forwarded it to the Docker bind-mount +
exec path, where it surfaced as a confusing "permission denied" /
"exec format error" deep in container bootstrap.

Validate `info.Mode().IsRegular()` up front and return a clear error
naming the env var.
This commit is contained in:
José Almeida
2026-05-11 23:54:18 +01:00
parent 1dd3dbc427
commit 970956fb90
@@ -33,11 +33,19 @@ func NewMockAgentResolver(log *logger.Logger) *MockAgentResolver {
// env var path is invalid.
func (r *MockAgentResolver) ResolveLinuxBinary() (string, error) {
if envPath := os.Getenv("KANDEV_MOCK_AGENT_LINUX_BINARY"); envPath != "" {
if _, err := os.Stat(envPath); err == nil {
r.logger.Debug("using mock-agent from env var", zap.String("path", envPath))
return envPath, nil
info, err := os.Stat(envPath)
if err != nil {
return "", fmt.Errorf("KANDEV_MOCK_AGENT_LINUX_BINARY=%q does not exist", envPath)
}
return "", fmt.Errorf("KANDEV_MOCK_AGENT_LINUX_BINARY=%q does not exist", envPath)
// Reject directories (and anything that isn't a regular file) up
// front. Otherwise the path slips through to the bind-mount + exec
// step and surfaces as a less actionable "permission denied" or
// "exec format error" deep inside container startup.
if !info.Mode().IsRegular() {
return "", fmt.Errorf("KANDEV_MOCK_AGENT_LINUX_BINARY=%q is not a regular file", envPath)
}
r.logger.Debug("using mock-agent from env var", zap.String("path", envPath))
return envPath, nil
}
exePath, err := os.Executable()