fix(homebrew): add uses_from_macos sqlite, drop head stanza
Address Greptile review on PR #904: declare sqlite as a build-time dep for the cgo go-sqlite3 link, and drop the head stanza since homebrew-core typically asks new formulae to omit it.
This commit is contained in:
+2
-1
@@ -4,7 +4,6 @@ class Kandev < Formula
|
||||
url "https://github.com/kdlbs/kandev/archive/refs/tags/v0.41.0.tar.gz"
|
||||
sha256 "dbb689fc3dd0ca7fed00f33da8b10ecfec9f9cd2e49bd9908c4950026743073c"
|
||||
license "AGPL-3.0-only"
|
||||
head "https://github.com/kdlbs/kandev.git", branch: "main"
|
||||
|
||||
livecheck do
|
||||
url :stable
|
||||
@@ -15,6 +14,8 @@ class Kandev < Formula
|
||||
depends_on "pnpm" => :build
|
||||
depends_on "node"
|
||||
|
||||
uses_from_macos "sqlite"
|
||||
|
||||
def install
|
||||
ENV["KANDEV_VERSION"] = version.to_s
|
||||
ENV["CGO_ENABLED"] = "1"
|
||||
|
||||
@@ -77,15 +77,7 @@ brew untap kdlbs/kandev # avoid local tap shadowing
|
||||
brew install --build-from-source ./Formula/kandev.rb
|
||||
```
|
||||
|
||||
## 6. (Optional) HEAD install
|
||||
|
||||
```bash
|
||||
brew install --HEAD ./Formula/kandev.rb
|
||||
```
|
||||
|
||||
If `head do` block is present, this clones `main` and builds. Useful for catching breakage early but not required for submission.
|
||||
|
||||
## 7. Open the upstream PR
|
||||
## 6. Open the upstream PR
|
||||
|
||||
```bash
|
||||
# 1. Fork & clone homebrew-core
|
||||
@@ -125,13 +117,13 @@ EOF
|
||||
)"
|
||||
```
|
||||
|
||||
## 8. Respond to review
|
||||
## 7. Respond to review
|
||||
|
||||
- Bottle CI runs automatically; failures appear as PR check comments.
|
||||
- Maintainer may ask for: tighter test block, dropping `pnpm` for `npm` (lockfile compatibility), license format, or resource-vendoring of JS deps.
|
||||
- Iterate until merged.
|
||||
|
||||
## 9. After merge
|
||||
## 8. After merge
|
||||
|
||||
- Auto-bump worker (`BrewTestBot`) will open bump PRs on new tags via `livecheck`.
|
||||
- For manual bump: `brew bump-formula-pr --version=X.Y.Z kandev`.
|
||||
|
||||
Reference in New Issue
Block a user