dreampiler/kandev
1
0
Fork 0
Code Issues 46 Pull Requests Actions 79 Packages Projects Releases Wiki Activity

feat(i18n): localize Settings → Integrations → GitHub watches and defaults (#2158)

Browse Source 
Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
João Salavisa
2026-08-02 15:03:04 +02:00
committed by GitHub
parent 0e82887ef6
commit 5b12a37b0c
20 changed files with 871 additions and 391 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/components/github/my-github/action-presets.ts
+23 -9
View File
@@ -16,15 +16,22 @@ import type {
} from "@/lib/types/github";
import type { TaskPreset } from "./quick-task-launcher";
export const PRESET_ICON_CHOICES: { key: GitHubActionPresetIcon; icon: Icon; label: string }[] = [
{ key: "eye", icon: IconEye, label: "Eye" },
{ key: "message", icon: IconMessageDots, label: "Message" },
{ key: "tool", icon: IconTool, label: "Tool" },
{ key: "code", icon: IconCode, label: "Code" },
{ key: "search", icon: IconSearch, label: "Search" },
{ key: "bug", icon: IconBug, label: "Bug" },
{ key: "sparkle", icon: IconSparkles, label: "Sparkle" },
{ key: "check", icon: IconChecks, label: "Check" },
// `key` is the persisted GitHubActionPresetIcon enum; only the label is copy, so
// it travels as a catalog key resolved at render (module-scope `t()` would
// freeze at the boot locale — see docs/i18n.md).
export const PRESET_ICON_CHOICES: {
key: GitHubActionPresetIcon;
icon: Icon;
labelKey: string;
}[] = [
{ key: "eye", icon: IconEye, labelKey: "github:presetIconEye" },
{ key: "message", icon: IconMessageDots, labelKey: "github:presetIconMessage" },
{ key: "tool", icon: IconTool, labelKey: "github:presetIconTool" },
{ key: "code", icon: IconCode, labelKey: "github:presetIconCode" },
{ key: "search", icon: IconSearch, labelKey: "github:presetIconSearch" },
{ key: "bug", icon: IconBug, labelKey: "github:presetIconBug" },
{ key: "sparkle", icon: IconSparkles, labelKey: "github:presetIconSparkle" },
{ key: "check", icon: IconChecks, labelKey: "github:presetIconCheck" },
];
const ICON_BY_KEY: Record<string, Icon> = Object.fromEntries(
@@ -60,6 +67,13 @@ export function toTaskPreset(stored: GitHubActionPreset): TaskPreset {
};
}
// NOTE: `label`, `hint` and `prompt_template` below are NOT translated, and must
// not be. These records seed the editable draft in action-presets-section.tsx
// (`setPrDraft(DEFAULT_PR_PRESETS)`) and are persisted to workspace settings as
// `GitHubActionPreset`, so translating them would write locale-dependent values
// into a user's saved presets and leave them there after a locale switch.
// `prompt_template` is additionally sent to the agent verbatim. Localizing these
// needs a key/persisted-value split, the same open item as PR_PRESETS.
export const DEFAULT_PR_PRESETS: GitHubActionPreset[] = [
{
id: "review",
apps/web/components/github/my-github/search-bar.tsx
+8
View File
@@ -19,6 +19,14 @@ export type PresetOption = {
icon: Icon;
};
// NOTE: `label` here is NOT translated, and must not be. `toStored()` in
// use-default-query-presets.ts copies it verbatim into `StoredQueryPreset`,
// which is persisted to `github_default_query_presets` in user and workspace
// settings and is user-editable in Settings → Integrations → GitHub. Translating
// it in place would write locale-dependent values into saved settings and leave
// them there after a locale switch. Localizing these needs a key/persisted-value
// split in this module, the same open item as the built-in layout profile names.
// `value`, `filter` and `group` are wire values and a GitHub search query.
export const PR_PRESETS: PresetOption[] = [
{
value: "review_requested",