* feat(linear): enrich issue watch filters with priority, labels, creator, estimate
Adds priority, labels (multi-select), creator (team member select), and
estimate range filters to Linear issue watchers — closing the gap with
Linear's GraphQL filter surface so users can scope auto-run watchers
nearly as tightly as they would in Linear itself.
- Backend: extend SearchFilter, map new fields to IssueFilter, add
ListLabels / ListUsers on the Client interface, expose them over HTTP
(GET /api/v1/linear/labels, /users) and via SearchIssues query params.
- Frontend: extend LinearSearchFilter, fetch labels + users per team,
render new filter controls in the watcher dialog, and split helpers
into linear-issue-watch-form.ts + linear-issue-watch-fields.tsx so
the dialog stays under file/function size limits.
* fix(linear): address reviewer feedback on enriched filter PR
- Reject invalid priority / malformed estimate query params with 400 instead
of silently dropping them; reject estimateMin > estimateMax. Mirror the
bounds check in the issue-watch validator so JSON-encoded watches go
through the same gate.
- A11y: render label/state toggle Badges inside <button aria-pressed> so
keyboard users can navigate and screen readers can announce state.
- Recover from per-team fetch failures so a transient network blip doesn't
permanently mark a team as "fetched-empty" — clear the in-flight marker
when any of states/labels/users fail, allowing remount to retry.
- Tighten priority typing: LinearSearchFilter.priority is 0|1|2|3|4, and
LinearPriority is the source of truth on the form-state side. Promote
FormState from a type alias to an interface per repo convention.
* fix(linear): align update error message and clear fetchedTeams on cancel
- UpdateIssueWatch's filter-empty error still listed only the original
four fields; bring it in line with the create path so the message
matches what filterIsEmpty actually accepts.
- linear-issue-watch-fields: clear the fetchedTeams marker on effect
cancellation as well as failure, so a remount after a fast teamKey
switch can retry instead of being stuck with whatever partial cache
the prior effect produced.
* fix(linear): address PR #974 reviewer findings
- linear-issue-watch-fields: delete the fetchedTeams marker on effect
cleanup so rapid team switches (A → B → A) refetch on return instead
of being stranded mid-load. Capture the Set in a local so the cleanup
closure references the exact instance the effect body added to.
- graphql_client: raise the labels/users page cap from 100 to Linear's
max of 250 via a shared linearMaxPageSize constant and a $first
variable. Documented that a workspace exceeding that would need
cursor-pagination here AND lazy-load in the UI.
- service_issue_watch.validateFilterBounds + handlers parseSearchNumeric
Filters: reject negative estimate values — Linear story points are
non-negative, so a -1 would silently match nothing.
* fix(linear): collapse duplicate hint text on States/Labels rows
When no team was selected the row showed two stacked muted lines —
the field description and the multi-select's "Pick a team…" prose —
saying overlapping things. Swap the row description based on team
selection and let the multi-select render nothing when disabled, so
exactly one line is shown in either state.
Also tightens the new fields' descriptions to match the brevity of
the existing ones (Labels, Estimate min/max).
* fix(linear): reject NaN/Inf estimates and preserve team cache after success
CodeRabbit + cubic flagged two real issues in the previous round:
- strconv.ParseFloat accepts "NaN" / "+Inf" / "-Inf" without erroring,
and "f < 0" passes through for NaN. Without an explicit math.IsNaN /
math.IsInf guard those values would propagate into the GraphQL
request and the eventual json.Marshal would 500 instead of 400.
Add the guard for both estimate_min and estimate_max, with a
regression test covering NaN, ±Inf, negative, and inverted range.
- useTeamsAndStates was deleting the per-team cache marker on every
cleanup, so a normal team switch evicted a healthy cache and the
next visit re-fetched all three datasets. Track a "loaded" flag and
only evict on cleanup when the fetch didn't complete successfully.
Also extracts the duplicated "team_key" / "team_key required" wire
strings into package-level constants per the repo's
"3+ occurrences → constant" convention.
* test(linear): add handler tests for /labels and /users endpoints
Mirrors the existing TestHTTPListStates_* pair — required team_key
returns 400, and a happy path that asserts the team_key reaches the
client and the response is 200. Closes the coverage gap CodeRabbit
flagged on the two new endpoints introduced in this PR.
* feat(linear): make priority filter multi-select
Status and label filters are already multi-select; priority being a
single Select broke the symmetry and forced single-value thinking.
Linear's own filter UI is multi-select per priority, and the GraphQL
filter takes priority: { in: [...] } natively, so the wire change is
clean.
Backend
- SearchFilter.Priority *int → Priorities []int
- buildIssueFilter emits priority: { in: priorities } when non-empty
- validateFilterBounds checks each element ∈ [0,4]
- normalizeFilter de-dupes (preserves caller order)
- HTTP query param priority → priorities, parsed as CSV
- Tests updated, including priority=0 still expressible as
Priorities=[0] (matches "No priority" issues only)
Frontend
- LinearSearchFilter.priority → priorities: LinearPriority[]
- FormState.priority → priorities
- PRIORITY_OPTIONS dropped the (any) sentinel; "No priority" sits at
the end of the chip row
- PriorityMultiSelect added next to State/Label multi-selects
- Priority moved to its own full-width row matching States/Labels;
Creator promoted to a stand-alone CreatorRow
Refactor
- searchLinearIssues query-param building extracted to a flat
table-driven helper to keep cyclomatic complexity ≤ 15
* refactor(linear): regroup watcher dialog fields and add section separators
UX pass on the watcher dialog:
- Pulled Team out into its own full-width row and paired Assignee +
Creator in a 2-col row so the people filters sit together — the old
Team+Assignee pairing forced a context switch between scope and
people filters mid-form.
- Added hairlines between the four conceptual blocks (Destination /
Filter / Automation / Prompt / Settings). Each block answers a
different question, so a consistent rhythm helps users scan the form
by section instead of reading one long stack.
No behaviour change; pure layout.
* refactor(linear): use shared Separator for watcher dialog section breaks
Initially extracted a local SectionDivider, but @kandev/ui/separator
(Radix-based, shadcn) already exists and is used in 14 places across
the codebase — including the sibling Jira settings page. Use that
instead so the styling tracks the rest of the app.
* refactor(linear): split parseSearchNumericFilters to satisfy cyclop
Extract priority and estimate-bound parsing into helpers so the entry
point drops below the project's max cyclomatic complexity (15).
* fix(linear): reject non-finite/negative estimates and align fmt
- validateFilterBounds rejects NaN/+-Inf in addition to negatives, so a
watch config can't be persisted with values that would later crash
json.Marshal. Adds focused unit tests.
- parseEstimate on the frontend treats negatives as unset so the UI
cannot submit estimateMin/Max < 0.
- gofmt-only alignment tweak in handlers_test.go test table.
Nicolas Lenepveu
e740417885