85aa3ac0aa
* feat(github): add /github page for PRs and issues Dedicated page under /github lists pull requests and issues across the authenticated user's repos with preset filters, custom GitHub search queries, per-repo narrowing, saved queries, and one-click task launching for any PR or issue. Performance: - Cache user PR/issue search responses for 30s with singleflight to coalesce concurrent misses, so preset switching and pagination avoid upstream round trips. - Replace the per-row PR status fetch (N+1) with a batch endpoint POST /api/v1/github/prs/statuses that fans out concurrently on the backend with a semaphore and caches per-PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on PR cache + status batching - Harden searchCacheKey against separator collisions from user-controllable customQuery (length-prefix encoding). - Drop repositories.loaded hydration when inner workspace fetch fails so the client refetches instead of trusting a partial snapshot. - Guard useGitHubSearch with a monotonic request counter to drop stale responses when filter+page changes overlap. - Fix usePRStatuses teardown: depend only on composed key so a new array identity per render doesn't cancel the in-flight batch. - Correct godocs (duplicate, outdated state:open claim). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address additional review feedback - Restore state:open for issue watcher: buildIssueSearchQuery no longer injects it as a default, so existing watches were starting to surface closed issues. Inject state:open in buildIssueFilter so only the watcher path is affected; the /github page presets already set their own state qualifiers. - countCheckResults now excludes in-progress checks from the denominator so a `1/3` badge reflects pass rate on completed checks, not a mix of running and failed. The pending state is still carried via ChecksState. - usePRStatuses retries after a transient fetch error (only mark the key as completed once the fetch resolves). This also fixes missing badges under React Strict Mode's intentional double-mount, since the first effect's cleanup fires before the response lands and the guard stays unset for the second mount to retry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(github): add tests for my-github hooks Covers use-committed-query, buildParams from use-github-search, use-saved-presets readStorage validation, use-known-repos recordForKey accumulator semantics, and use-pr-statuses batch fetch lifecycle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on search cache and repo accumulator - Clamp perPage before composing the search cache key so identical pages (e.g. perPage=150 and =100) share a cache entry instead of creating duplicates keyed on the raw value. - Add resetKnownReposStore and call it on /github unmount so the module-level repo accumulator doesn't carry across navigations. - Rename use-pr-statuses test to match its assertion (it verifies stale statuses are cleared when the key changes and fetch fails). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(web): distinguish blocked from dirty in PR mergeable badge GitHub's blocked state (required reviews/checks/branch protection) is not a merge conflict, so don't label it "Conflicts". Surface it as "Blocked" with the pending tone; keep "Conflicts" for dirty. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: address remaining /github code review comments - Route PR status + batch through handleSearchError so ErrNoClient surfaces as 503 instead of 500 (matches the search endpoints). - Sort workflow steps by position in the quick-task-launcher default pick, matching the convention in issue-watch-dialog. - Make PresetItem keyboard-accessible: role=button, tabIndex, and Enter/Space handling on the wrapping div (it contains a nested delete button, so it can't itself be a button). - Extract useRepoOptions out of useGitHubPageState to bring the hook back under the 100-line complexity limit. - Honor ctx.Done() when acquiring the PR-status batch semaphore so a cancelled HTTP request releases queued goroutines instead of running each upstream fetch to completion. - Clarify parsePaginationQuery doc: the upper bound (100) is enforced by clampSearchPage in the client layer, not here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): address /github review follow-ups - Merge duplicate @/lib/utils imports in pr-list. - Use rel="noopener noreferrer" on external PR/issue links (codebase convention) and add cursor-pointer per the UI guidelines. - Rewrite onOpenSaveDialog as an explicit if-block so the callback returns void rather than boolean | void. - Use PaginationEllipsis in its own PaginationItem so the ellipsis and the adjacent page link are separate list items instead of visually fused into a single cell. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(web): derive QuickTaskLauncher dialog state from props Replaces the useEffect+setState anti-pattern with useMemo-derived state driven directly by the payload prop. Drops the eslint suppression that was needed for react-hooks/set-state-in-effect. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
108 lines
3.1 KiB
TypeScript
108 lines
3.1 KiB
TypeScript
"use client";
|
|
|
|
import {
|
|
IconCheck,
|
|
IconX,
|
|
IconClockHour4,
|
|
IconGitMerge,
|
|
IconAlertTriangle,
|
|
IconGitPullRequestDraft,
|
|
} from "@tabler/icons-react";
|
|
import type { Icon } from "@tabler/icons-react";
|
|
import type { GitHubPR, GitHubPRStatus } from "@/lib/types/github";
|
|
import { cn } from "@/lib/utils";
|
|
|
|
type StatusChipProps = {
|
|
Icon: Icon;
|
|
label: string;
|
|
tone: "success" | "failure" | "pending" | "neutral";
|
|
title?: string;
|
|
};
|
|
|
|
function StatusChip({ Icon, label, tone, title }: StatusChipProps) {
|
|
const toneClass = {
|
|
success: "text-emerald-600 dark:text-emerald-400",
|
|
failure: "text-red-600 dark:text-red-400",
|
|
pending: "text-amber-600 dark:text-amber-400",
|
|
neutral: "text-muted-foreground",
|
|
}[tone];
|
|
return (
|
|
<span
|
|
className={cn("inline-flex items-center gap-1 text-xs", toneClass)}
|
|
title={title ?? label}
|
|
>
|
|
<Icon className="h-3.5 w-3.5 shrink-0" />
|
|
<span className="whitespace-nowrap tabular-nums">{label}</span>
|
|
</span>
|
|
);
|
|
}
|
|
|
|
function ChecksChip({ status }: { status: GitHubPRStatus }) {
|
|
const { checks_state: state, checks_total: total, checks_passing: passing } = status;
|
|
if (!state) return null;
|
|
const label = total > 0 ? `${passing}/${total}` : "";
|
|
if (state === "success")
|
|
return <StatusChip Icon={IconCheck} label={label || "Checks passed"} tone="success" />;
|
|
if (state === "failure")
|
|
return <StatusChip Icon={IconX} label={label || "Checks failed"} tone="failure" />;
|
|
return <StatusChip Icon={IconClockHour4} label={label || "Checks running"} tone="pending" />;
|
|
}
|
|
|
|
function ReviewChip({
|
|
state,
|
|
pending,
|
|
}: {
|
|
state: GitHubPRStatus["review_state"];
|
|
pending: number;
|
|
}) {
|
|
if (state === "approved") return <StatusChip Icon={IconCheck} label="Approved" tone="success" />;
|
|
if (state === "changes_requested")
|
|
return <StatusChip Icon={IconAlertTriangle} label="Changes requested" tone="failure" />;
|
|
if (pending > 0)
|
|
return (
|
|
<StatusChip
|
|
Icon={IconClockHour4}
|
|
label={`${pending} pending`}
|
|
tone="pending"
|
|
title={`${pending} pending review(s)`}
|
|
/>
|
|
);
|
|
return null;
|
|
}
|
|
|
|
function MergeableChip({
|
|
state,
|
|
prState,
|
|
}: {
|
|
state: GitHubPRStatus["mergeable_state"];
|
|
prState: GitHubPR["state"];
|
|
}) {
|
|
if (prState === "merged") return <StatusChip Icon={IconGitMerge} label="Merged" tone="success" />;
|
|
if (state === "draft")
|
|
return <StatusChip Icon={IconGitPullRequestDraft} label="Draft" tone="neutral" />;
|
|
if (state === "dirty")
|
|
return <StatusChip Icon={IconAlertTriangle} label="Conflicts" tone="failure" />;
|
|
if (state === "blocked")
|
|
return <StatusChip Icon={IconAlertTriangle} label="Blocked" tone="pending" />;
|
|
if (state === "behind")
|
|
return <StatusChip Icon={IconAlertTriangle} label="Behind base" tone="pending" />;
|
|
return null;
|
|
}
|
|
|
|
export function PRStatusBadges({
|
|
pr,
|
|
status,
|
|
}: {
|
|
pr: GitHubPR;
|
|
status: GitHubPRStatus | null | undefined;
|
|
}) {
|
|
if (!status) return null;
|
|
return (
|
|
<>
|
|
<ChecksChip status={status} />
|
|
<ReviewChip state={status.review_state} pending={status.pending_review_count} />
|
|
<MergeableChip state={status.mergeable_state} prState={pr.state} />
|
|
</>
|
|
);
|
|
}
|