João Salavisa
99dfbbde58
* feat(plugins): add keybindings and modal window capabilities
Add two independent plugin UI capabilities.
Keybindings: plugins declare keybindings in the manifest under
ui.keybindings ({id, default, description}), validated backend-side
(combo grammar + unique ids, requires a UI bundle) and exposed to the
frontend. Plugin JS binds a handler via registry.registerKeybinding(id,
handler); a global dispatcher fires it. Combos are user-overridable in
Settings > Keyboard Shortcuts (namespaced plugin:{pluginId}:{id}) with
conflict detection against core and other plugins.
Modals: host.openModal({title?, content, size?, dismissible?}) returns a
{ close() } handle and renders in a single host-owned Dialog isolated by
PluginErrorBoundary, cleaned up on plugin unload.
Fixture plugin, PLUGIN-API.md / spec, and a Playwright e2e demonstrate a
keybinding handler opening a modal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(plugins): address review feedback on keybinding dispatch and validation
Core shortcuts now take precedence over plugin keybindings on a colliding
combo (defaultPrevented cooperation between the two capture-phase
dispatchers), a throwing plugin handler no longer aborts dispatch to other
plugins, and the keybinding combo grammar is tightened: the backend validator
and frontend parser both drop the undocumented control/super modifier
aliases and reject shift+digit/symbol combos that can never actually fire
(KeyboardEvent.key reports the shifted character, not the token).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(plugins): stop conflicting core shortcut from double-firing with plugin keybindings
The earlier defaultPrevented guard only covered the central useAppShortcuts
dispatcher. Per-component core shortcuts registered via useKeyboardShortcut
run in the bubble phase, after the capture-phase plugin keybinding dispatcher,
so a plugin-handled-and-prevented combo still triggered the core action too.
Guard useKeyboardShortcut (and use-editor-keybinds, another capture-phase core
listener) on event.defaultPrevented so exactly one action fires per combo.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(plugins): make core shortcuts always win over plugin keybindings
Panel-search, task-switcher, and other core listeners never checked
event.defaultPrevented, so a plugin bound to the same combo (e.g. Cmd/Ctrl+F)
could still fire alongside them. Instead of patching every core listener,
usePluginShortcuts now computes the set of effective core shortcut combos
(registry, resolved through user overrides, plus FIND_IN_PANEL/SAVE) and
skips invoking any plugin handler whose combo is in that set, so the
matching core listener always handles the event exactly once.
Also adds a hook-level regression test for useEditorKeybinds' existing
defaultPrevented guard, and fixes a leaked capture-phase window listener in
use-keyboard-shortcut.test.ts that could bleed into later tests.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(web): keep Cmd+K closing the command panel after shortcut-precedence guard
cmdk's built-in vim bindings intercept Ctrl/Cmd+K and +P as list-navigation
shortcuts and call preventDefault() before the event reaches our window-level
useKeyboardShortcut listeners. Once that hook started bailing on
event.defaultPrevented (added to fix core/plugin shortcut double-firing), the
palette's own Cmd+K close/reopen toggle got silently suppressed whenever focus
was inside the open panel. Disable cmdk's vim bindings on the command palette
so its Ctrl/Cmd+K and +P always reach the app-level toggle.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(plugins): document keybindings and modal window plugin APIs
Fill in the public author-facing docs that the internal plugin-keybindings
and modal-window contract (PLUGIN-API.md, spec.md) already covers: the
registry.registerKeybinding / host.openModal JS surface, the ui.keybindings
manifest field with its combo grammar, and a capability mention on the
Plugins overview page.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
54 lines
1.6 KiB
YAML
54 lines
1.6 KiB
YAML
# Manifest for the plugin-fixture SDK plugin (docs/plans/plugins/GRPC-CONTRACT.md
|
|
# §6). Used by Go integration tests and Playwright e2e tests — see
|
|
# apps/backend/cmd/plugin-fixture and the `e2e-plugin-package` Makefile
|
|
# target, which stages this directory, builds the plugin-fixture binary for
|
|
# the host platform into server/, and packs the whole tree with
|
|
# cmd/plugin-pack into apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz.
|
|
id: "kandev-plugin-e2e"
|
|
api_version: 1
|
|
version: "1.0.0"
|
|
display_name: "Kandev E2E Fixture Plugin"
|
|
description: "SDK-based plugin backend used by backend integration tests and Playwright e2e tests"
|
|
author: "kandev"
|
|
categories: ["tools"]
|
|
repo_url: "https://github.com/kdlbs/kandev-plugin-template"
|
|
|
|
runtime:
|
|
type: binary
|
|
executables:
|
|
linux-amd64: "server/plugin-linux-amd64"
|
|
linux-arm64: "server/plugin-linux-arm64"
|
|
darwin-amd64: "server/plugin-darwin-amd64"
|
|
darwin-arm64: "server/plugin-darwin-arm64"
|
|
windows-amd64: "server/plugin-windows-amd64.exe"
|
|
|
|
capabilities:
|
|
events: ["task.created"]
|
|
state: true
|
|
secrets: true
|
|
|
|
webhooks:
|
|
- key: "test-hook"
|
|
description: "Records inbound webhooks for e2e polling"
|
|
method: "POST"
|
|
|
|
ui:
|
|
bundle: "/ui/bundle.js"
|
|
keybindings:
|
|
- id: open-demo
|
|
default: mod+shift+j
|
|
description: Open the demo modal
|
|
|
|
config_schema:
|
|
type: object
|
|
required: ["api_token"]
|
|
properties:
|
|
api_token:
|
|
type: string
|
|
title: "API token"
|
|
description: "Secret token; masked on the operator API, delivered to the plugin via the Host GetConfig RPC."
|
|
secret: true
|
|
greeting:
|
|
type: string
|
|
title: "Greeting"
|