f7d8d5d603
* fix(web): require confirmation before archiving from PR merged/closed banners The Archive link in the PR merged/closed status-bar banners archived the task immediately, unlike every other archive surface. Route it through the shared TaskArchiveConfirmDialog (cleanup summary + subtask cascade), and move the banners into pr-archive-banners.tsx since chat-input-area.tsx was over the file-size lint limit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(web): cover cascade passthrough in banner archive confirmation Review follow-up: the subtask cascade checkbox is an acceptance criterion for the banner archive flow, but tests only asserted cascade: false. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(e2e): verify cancel path of PR banner archive confirmation QA follow-up: exercise the dialog cancel path in a real browser — cancel must close the dialog, keep the banner, and archive nothing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): expose pending state on banner archive confirmation Thread isPending from useBannerArchiveConfirm into TaskArchiveConfirmDialog as isArchiving, matching the other archive surfaces. Guards double-submit when the dialog is reopened while an archive is still in flight on a slow connection. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(e2e): scope archive-cancel click to the alertdialog Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
121 lines
3.2 KiB
TypeScript
121 lines
3.2 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { act, cleanup, renderHook } from "@testing-library/react";
|
|
|
|
const toastMock = vi.fn();
|
|
const handleSendMessageMock = vi.fn();
|
|
|
|
const mockState = {};
|
|
|
|
vi.mock("@/components/state-provider", () => ({
|
|
useAppStore: (selector: (state: typeof mockState) => unknown) => selector(mockState),
|
|
useAppStoreApi: () => ({ getState: () => mockState }),
|
|
}));
|
|
|
|
vi.mock("@/components/toast-provider", () => ({
|
|
useToast: () => ({ toast: toastMock }),
|
|
}));
|
|
|
|
vi.mock("@/components/github/pr-status-chip", () => ({
|
|
PRStatusChip: () => null,
|
|
}));
|
|
|
|
vi.mock("@/components/task/share/share-button", () => ({
|
|
ShareButton: () => null,
|
|
shareableSessionStateClient: () => false,
|
|
}));
|
|
|
|
vi.mock("@/components/task/chat/chat-input-container", () => ({
|
|
ChatInputContainer: () => null,
|
|
}));
|
|
|
|
vi.mock("@/components/task/chat/todo-indicator", () => ({
|
|
TodoIndicator: () => null,
|
|
}));
|
|
|
|
vi.mock("./pr-archive-banners", () => ({
|
|
PRMergedBanner: () => null,
|
|
PRClosedBanner: () => null,
|
|
}));
|
|
|
|
vi.mock("@/hooks/use-keyboard-shortcut", () => ({
|
|
useKeyboardShortcut: () => undefined,
|
|
}));
|
|
|
|
vi.mock("@/hooks/use-message-handler", () => ({
|
|
buildTaskMentionsContext: vi.fn(),
|
|
useMessageHandler: () => ({ handleSendMessage: handleSendMessageMock }),
|
|
}));
|
|
|
|
vi.mock("@/hooks/domains/kanban/use-plan-actions", () => ({
|
|
usePlanActions: () => ({
|
|
implementPlanHandler: vi.fn(),
|
|
proceedStepName: null,
|
|
proceed: vi.fn(),
|
|
isMoving: false,
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/hooks/domains/session/use-executor-environment-availability", () => ({
|
|
useExecutorEnvironmentAvailability: () => ({
|
|
unavailable: false,
|
|
status: null,
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/lib/ws/connection", () => ({
|
|
getWebSocketClient: () => ({ send: vi.fn() }),
|
|
}));
|
|
|
|
import { useSubmitHandler } from "./chat-input-area";
|
|
|
|
beforeEach(() => {
|
|
handleSendMessageMock.mockResolvedValue(undefined);
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.restoreAllMocks();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
describe("useSubmitHandler", () => {
|
|
function panelState(overrides = {}) {
|
|
return {
|
|
resolvedSessionId: "session-1",
|
|
taskId: "task-1",
|
|
sessionModel: null,
|
|
activeModel: null,
|
|
isAgentBusy: false,
|
|
activeDocument: null,
|
|
planComments: [],
|
|
pendingPRFeedback: [],
|
|
contextFiles: [],
|
|
prompts: [],
|
|
markCommentsSent: vi.fn(),
|
|
clearSessionPlanComments: vi.fn(),
|
|
handleClearPRFeedback: vi.fn(),
|
|
clearEphemeral: vi.fn(),
|
|
addContextFile: vi.fn(),
|
|
planModeEnabled: false,
|
|
...overrides,
|
|
} as never;
|
|
}
|
|
|
|
it("shows a toast when sending fails", async () => {
|
|
vi.spyOn(console, "error").mockImplementation(() => undefined);
|
|
handleSendMessageMock.mockRejectedValueOnce(new Error("WebSocket request timed out"));
|
|
const { result } = renderHook(() => useSubmitHandler(panelState()));
|
|
|
|
await act(async () => {
|
|
await result.current.handleSubmit("hello");
|
|
});
|
|
|
|
expect(toastMock).toHaveBeenCalledWith({
|
|
title: "Message send status unknown",
|
|
description:
|
|
"The connection dropped or timed out. Refresh the task to confirm whether it went through.",
|
|
variant: "error",
|
|
});
|
|
});
|
|
});
|