de92557f46
* chore(backend): add go.uber.org/goleak test dependency Promotes the previously-indirect goleak v1.3.0 to a direct require so per-package TestMain calls can use it for goroutine leak detection. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(backend/lifecycle): drain workspace-stream backoff on Manager.Stop StreamManager.connectWorkspaceStream slept the full retry backoff in time.Sleep between failed attempts. SessionTraceContext is deliberately uncancellable (it carries a long-lived span), so if the Manager began shutting down mid-backoff the goroutine outlived Stop() and stranded until the timer fired. Thread Manager.stopCh through the StreamManager constructor and add a sleepOrStop helper that selects between the timer and the shutdown signal. ReconnectAll's startup sleep gets the same treatment. TestConnectWorkspaceStream_BackoffDrainsOnStop closes stopCh while a failing-port retry is in flight and asserts the goroutine exits within 500ms — fails without the fix, passes with it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(backend/github): close sqlite DB in newTestStore to drain connectionOpener newTestStore opened *sqlx.DB via db.OpenSQLite but never registered a Close on cleanup, leaving database/sql.(*DB).connectionOpener goroutines parked across test boundaries. Add t.Cleanup(sqlxDB.Close); goleak's per-package TestMain (added in a follow-up commit) is the regression check. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(backend): wire goleak.VerifyTestMain across leak-prone packages Per-package TestMain in: - internal/integrations/healthpoll (auth-health ticker loop) - internal/jira, internal/linear (auth + issue-watch loops) - internal/github (PR / review / issue poller loops) - internal/gateway/websocket (per-conn pumps + terminal bridge) - internal/orchestrator (detached event-handler goroutines) - internal/agent/runtime/lifecycle (remote-status loop, StreamManager helpers; ignores OTel batch-span processor and OTLP retry helper — initialised early in the process and only exit on shutdown) - internal/agentctl/server/process (extends the existing fixture-binary TestMain so subprocess + PTY pump leaks surface there) Catches regressions where a Start/Stop forgets to drain on WaitGroup, or a detached goroutine forgets to honour ctx/stopCh cancellation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(backend): document goroutine ownership and leak-testing convention New "Goroutine ownership and leak testing" subsection under Conventions in apps/backend/AGENTS.md (CLAUDE.md symlinks to it). Covers: - Lifecycle: Start/Stop + WaitGroup, both idempotent. - Cancellation: every long wait selects on ctx.Done() or stopCh; never time.Sleep in retry loops (reference lifecycle.StreamManager.sleepOrStop). - Detached helpers: must respect the owning type's shutdown signal. - Leak testing: new packages spawning goroutines add goleak.VerifyTestMain; IgnoreTopFunction is reserved for genuine third-party background goroutines and must carry a comment explaining the suppression. Lists the packages currently instrumented so future contributors can mirror the pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore(backend/lifecycle): drop dead OTel IgnoreTopFunction from goleak setup Review follow-up. agentctl/tracing.initTracing only spawns the OTel SDK provider when OTEL_EXPORTER_OTLP_ENDPOINT is set; in tests it isn't, so the noop provider is used and no batchSpanProcessor / OTLP retry goroutines ever exist. The IgnoreTopFunction calls were dead suppressions and the comment ("called by NewManager via the agent execution trace path") misdescribed when the SDK init runs. Drop the ignores and correct AGENTS.md to stop citing OTel as the canonical suppression example. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(backend/lifecycle): drop unneeded 50ms sleep from backoff-drain test QA follow-up. The 50ms time.Sleep before close(stopCh) in TestConnectWorkspaceStream_BackoffDrainsOnStop was meant to ensure the goroutine had entered the backoff sleep before shutdown — but that ordering doesn't affect the test outcome: - With the fix: sleepOrStop sees stopCh already closed and returns false on the first call, so the goroutine drains within one attempt regardless of when stopCh closes. - Without the fix: time.Sleep ignores stopCh, the goroutine burns its full 5-retry backoff (~31s), and the 500ms timeout fires. Removing the sleep makes the test ~12x faster (15ms vs 200ms total) and removes the only time.Sleep-based wait from the new tests, aligning with the codebase's "channel-based sync, no sleep waits" convention. Verified by 50x -race and 5x revert-and-fail. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(backend/github): drain HTTP idle conns before goleak inspects CI surfaced a leaked goroutine on the Linux runner that local runs missed: a single net/http.(*http2ClientConn).readLoop parked on a TLS read, created by net/http.(*http2Transport).newClientConn. The package's anonymousHTTPClient and PATClient's rewriteTransport both route through http.DefaultTransport's connection pool, so an idle HTTP/2 connection in that pool keeps the reader goroutine alive past m.Run() — invisible on sandboxed local runs where outbound network is blocked. Replace github/goleak_test.go's plain VerifyTestMain with an expanded TestMain that drains http.DefaultTransport's idle connections before goleak.Find runs. This is the stdlib's documented teardown for the connection pool, keeps the assertion strict (no IgnoreTopFunction), and doesn't leak into production code. Other in-scope packages don't need this — they don't use http.DefaultTransport for HTTPS calls. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(backend): drain ws.Done on stopCh; always run goleak in github tests - lifecycle/streams.go: replace bare <-ws.Done() with a select that also watches sm.stopCh so a connected goroutine drains when Manager.Stop() fires before the remote WS closes. A nil stopCh (isolated tests) blocks the nil channel case forever, degrading to plain <-ws.Done() semantics. - github/goleak_test.go: remove the exitCode==0 guard around goleak.Find so leaks are always surfaced even when a test has already failed; original exit code is preserved (leaks only promote it to 1). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(backend/lifecycle): close ws on stopCh so agentctl WS loops drain cubic flagged that the previous shutdown path observed stopCh but never called ws.Close(), so the underlying WebSocket and its agentctl-side read/write goroutines (workspace_stream.go:67-68) kept running past Manager.Stop(). ClearWorkspaceStream only removes the WS from the execution's tracking — it doesn't close the connection. Call ws.Close() on the stopCh path. ws.Close is idempotent via closeOnce, so it's safe even if the remote end already closed. TestConnectWorkspaceStream_ClosesWSOnStop connects to a mock workspace server that stays open until the client closes its side; after stopCh fires, the test asserts ws.Done() closes within 500ms — which is only true if connectWorkspaceStream invoked ws.Close(). Verified to fail without the fix and pass with it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(backend/lifecycle): use channel sync instead of sleep polling in ws-close test cubic flagged that TestConnectWorkspaceStream_ClosesWSOnStop polled execution.GetWorkspaceStream() in a 500ms sleep loop, which is brittle under CI load. connectWorkspaceStream already accepts a ready channel that closes after SetWorkspaceStream — pass it in and wait on the channel instead. synctest isn't viable here (real network I/O), so channel-based sync is the testing convention per AGENTS.md. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
142 lines
5.1 KiB
Go
142 lines
5.1 KiB
Go
package process
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"os/exec"
|
|
"runtime"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.uber.org/goleak"
|
|
)
|
|
|
|
// kandevTestFixtureEnv activates fixture-binary mode in this test binary.
|
|
// Tests use fixtureExec / fixtureShellExec (below) to spawn known commands
|
|
// (sleep / echo / cat) without depending on Unix-only shell tooling — the
|
|
// test binary re-invokes itself with this env var set, and TestMain dispatches
|
|
// to runFixture before the normal test runner starts. This replaces the
|
|
// previous fixtures that hardcoded `sleep`, `cat`, `echo`, `printf` which
|
|
// don't exist as standalone executables on Windows.
|
|
const kandevTestFixtureEnv = "KANDEV_TEST_FIXTURE"
|
|
|
|
// TestMain branches into fixture-binary mode when the activation env var
|
|
// is set; otherwise it runs the test suite normally — wrapped in goleak so
|
|
// the per-process subprocess managers (workspace tracker, PTY pumps, poll
|
|
// loops) surface goroutine leaks here.
|
|
func TestMain(m *testing.M) {
|
|
if spec := os.Getenv(kandevTestFixtureEnv); spec != "" {
|
|
runFixture(spec)
|
|
return
|
|
}
|
|
goleak.VerifyTestMain(m)
|
|
}
|
|
|
|
// runFixture executes a whitespace-separated command spec and exits.
|
|
// Supported commands:
|
|
//
|
|
// sleep <secs> — sleep for <secs> seconds
|
|
// echo <args...> — print args joined by spaces, plus newline
|
|
// cat — copy stdin to stdout until EOF
|
|
// echo-then-sleep <msg> <secs> — print msg, then sleep <secs>
|
|
//
|
|
// New commands can be added here as tests need them; the goal is to keep the
|
|
// surface tiny so the helper stays inspectable.
|
|
func runFixture(spec string) {
|
|
parts := strings.Fields(spec)
|
|
if len(parts) == 0 {
|
|
fmt.Fprintln(os.Stderr, "fixture: empty spec")
|
|
os.Exit(2)
|
|
}
|
|
switch parts[0] {
|
|
case "sleep":
|
|
if len(parts) != 2 {
|
|
fmt.Fprintln(os.Stderr, "fixture: sleep takes 1 arg")
|
|
os.Exit(2)
|
|
}
|
|
secs, err := strconv.Atoi(parts[1])
|
|
if err != nil {
|
|
fmt.Fprintf(os.Stderr, "fixture: sleep: bad seconds %q\n", parts[1])
|
|
os.Exit(2)
|
|
}
|
|
time.Sleep(time.Duration(secs) * time.Second)
|
|
case "echo":
|
|
fmt.Println(strings.Join(parts[1:], " "))
|
|
case "cat":
|
|
_, _ = io.Copy(os.Stdout, os.Stdin)
|
|
case "echo-then-sleep":
|
|
if len(parts) != 3 {
|
|
fmt.Fprintln(os.Stderr, "fixture: echo-then-sleep takes 2 args")
|
|
os.Exit(2)
|
|
}
|
|
fmt.Println(parts[1])
|
|
// Force the kernel to flush this write to the parent's pipe before
|
|
// we sleep. On Windows in particular, an anonymous pipe's first
|
|
// small write can sit in the per-process buffer until the writer
|
|
// makes a second write or exits — that would defeat the point of a
|
|
// "print, then wait" fixture used by output-capture tests.
|
|
_ = os.Stdout.Sync()
|
|
secs, err := strconv.Atoi(parts[2])
|
|
if err != nil {
|
|
fmt.Fprintf(os.Stderr, "fixture: echo-then-sleep: bad seconds %q\n", parts[2])
|
|
os.Exit(2)
|
|
}
|
|
time.Sleep(time.Duration(secs) * time.Second)
|
|
default:
|
|
fmt.Fprintf(os.Stderr, "fixture: unknown command %q\n", parts[0])
|
|
os.Exit(2)
|
|
}
|
|
os.Exit(0)
|
|
}
|
|
|
|
// fixtureExec returns the (Command argv, Env) pair tests pass to runners that
|
|
// take a Command []string and an Env map (e.g. InteractiveStartRequest). The
|
|
// runner spawns this test binary with the env var set, TestMain dispatches
|
|
// to runFixture, and the spec is executed in-process.
|
|
func fixtureExec(spec string) (command []string, env map[string]string) {
|
|
return []string{os.Args[0]}, map[string]string{kandevTestFixtureEnv: spec}
|
|
}
|
|
|
|
// fixtureShellExec returns the (Command string, Env) pair tests pass to
|
|
// runners that take a single shell-string Command (e.g. StartProcessRequest,
|
|
// which runs via `sh -lc` on Unix and `cmd /c` on Windows). The spec travels
|
|
// in the env var so we don't have to worry about per-shell argument quoting.
|
|
//
|
|
// Quoting is platform-specific because cmd.exe's `/c` parser strips at most
|
|
// one outer pair of quotes — pre-quoting the path on Windows turns into
|
|
// `cmd /c "\"C:\path\""` after Go's exec escaping, and cmd then fails to
|
|
// resolve the executable. We leave Windows paths bare (Go's syscall.EscapeArg
|
|
// adds quotes only if needed) and double-quote on Unix where sh splits on
|
|
// whitespace.
|
|
func fixtureShellExec(spec string) (command string, env map[string]string) {
|
|
if runtime.GOOS == "windows" {
|
|
return os.Args[0], map[string]string{kandevTestFixtureEnv: spec}
|
|
}
|
|
return `"` + os.Args[0] + `"`, map[string]string{kandevTestFixtureEnv: spec}
|
|
}
|
|
|
|
// fixtureCmd builds an *exec.Cmd ready to run a fixture spec via this test
|
|
// binary. Used by tests that bypass the runner abstractions and call
|
|
// exec.Command directly.
|
|
func fixtureCmd(spec string) *exec.Cmd {
|
|
cmd := exec.Command(os.Args[0])
|
|
cmd.Env = fixtureEnvSlice(spec)
|
|
return cmd
|
|
}
|
|
|
|
// fixtureEnvSlice returns os.Environ() plus the fixture activation variable,
|
|
// formatted as a []string suitable for exec.Cmd.Env / InstanceConfig.AgentEnv.
|
|
func fixtureEnvSlice(spec string) []string {
|
|
return append(os.Environ(), kandevTestFixtureEnv+"="+spec)
|
|
}
|
|
|
|
// fixtureArgs returns the argv to spawn this test binary in fixture mode.
|
|
// Used together with fixtureEnvSlice when populating fields like
|
|
// InstanceConfig.AgentArgs.
|
|
func fixtureArgs() []string {
|
|
return []string{os.Args[0]}
|
|
}
|