Files
kandev/apps/web/components/github
João Salavisa c913522626 fix(web): make PR CI status reachable on mobile via tap-activated drawer (#1060)
* fix(web): make PR CI status reachable on mobile via tap-activated drawer

PRStatusChip's HoverCard was hover-only, so touch users in the chat
status bar had no way to open the CI status surface. Branch on
useIsMobile(): keep the existing HoverCard on desktop, and on mobile
render a vaul Drawer hosting the same PRCIPopover body so tapping the
chip opens a bottom-sheet "modal" with passes / failures / reviews.

The desktop topbar PR button isn't mounted in SessionMobileTopBar (and
its click path is Dockview-only), so the chip is the only surface that
needs the fix today. New mobile-chrome e2e spec covers tap-to-open,
failed-bucket content, and close.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(e2e): rephrase PR CI accessors section comment

The block now spans desktop hover popover + chip + mobile drawer
locators, not just the hover popover.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(web): cover PRStatusChip desktop/mobile branching in jsdom

Adds focused unit tests around the new mobile drawer path:
- desktop branch renders a chip and click does NOT mount the drawer
- mobile branch starts with no drawer, click mounts drawer + popover
  inner + close button (regression guard for the e2e's toHaveCount(0)
  precondition)
- chip data-* attrs preserved across both branches
- failed PR maps to data-status='failed'
- no-checks PR shows the popover's empty state inside the drawer

Close-on-dismiss can only be verified in a real browser (happy-dom
doesn't fire vaul's CSS transition events) — covered by the
mobile-pr-ci-chip.spec.ts e2e.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(web): a11y polish on mobile PR/CI chip drawer trigger

Addresses bot review feedback on #1060:
- Add aria-haspopup="dialog" + aria-expanded={open} on the mobile chip
  button (mirrors the established mobile-pill-button.tsx pattern).
- Add a visually hidden DrawerDescription to satisfy Radix's accessible
  Dialog contract and suppress the console warning observed during
  unit tests.
- Annotate the e2e failed-bucket count assertion with the arithmetic
  (3 total - 2 passing = 1 failed) so future seed-value edits stay
  in sync.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-24 14:39:02 +01:00
..