3.0 KiB
3.0 KiB
id, title, status, wave, depends_on, plan, spec
| id | title | status | wave | depends_on | plan | spec | |
|---|---|---|---|---|---|---|---|
| 02-align-shared-launch-and-docs | Align shared launch and docs | done | 2 |
|
plan.md | ../../specs/platform/setup-launch-timeout.md |
Task 02: Align Shared Launch and Docs
Acceptance
- Environment resolution does not consume the runtime launch-phase budget.
- Each runtime launch phase remains bounded by
AgentLaunchTimeout, while a preparation script receives the full independentSetupScriptTimeout. - Manager shutdown and per-caller cancellation keep their existing coalescing behavior, and a deadline releases the activity lease.
- Public configuration and executor docs describe the one environment variable and the derived default launch limit.
Verification
cd apps/backend && go test ./internal/agent/runtime/lifecycle ./internal/orchestrator ./internal/task/handlers ./internal/mcp/handlers && cd ../.. && git diff --check
Files likely touched
apps/backend/internal/agent/runtime/lifecycle/manager_execution.goapps/backend/internal/agent/runtime/lifecycle/manager_execution_test.goapps/backend/internal/backendapp/adapters_plugin_starter_test.goapps/backend/internal/orchestrator/task_operations_wait_test.godocs/public/configuration.mddocs/public/executors.md
Dependencies
Task 01.
Parallelism
sequential. This task verifies and documents Task 01's common timeout policy.
Inputs
- Setup and Launch Timeout spec.
- Task 01's resolved
SetupScriptTimeoutandAgentLaunchTimeoutvalues. - Existing coalescing tests in
manager_execution_test.go. - GitHub issue #2574 and its 90-second setup reproduction.
Output contract
Report the RED 90-second virtual-time regression, launch-phase change, public
documentation updates, exact verification results, residual risks, and update
this task plus plan.md status.
Results
- Replaced the fixed shared execution-creation deadline with a deadline-free coalescing context plus fresh runtime launch-phase contexts derived from the setup timeout. Preparation contexts keep the full setup budget after pre-setup work, while caller cancellation and manager-stop behavior remain intact.
- RED verification first demonstrated that a setup operation extending past the old 60-second deadline was cancelled; the regression now passes with the new launch budget.
- Documented the environment variable, duration parsing, executor coverage, launch allowance, restart requirement, and unchanged setup failure semantics in the public executor/configuration docs.
- Verification:
cd apps/backend && go test -count=1 ./internal/agent/runtime/lifecycle ./internal/orchestrator ./internal/task/handlers ./internal/mcp/handlerspassed with 4,587 tests across 4 packages. - Focused lifecycle regressions passed under
go test -race;git diff --checkpassed. - Host-mode Docker launch E2E passed 12 tests with one pre-existing
fixmeskipped, and the Alpine BusyBox preparation test passed three consecutive repetitions without retries.