Files
kandev/docs/plans/multi-pr-review-selector/task-01-selection-foundation.md
T
José Almeida d5da5d0022 fix(web): select pull request on review surface (#1857)
* fix(web): select pull request on review surface

* fix(web): address review feedback

* test(web): stabilize tablet review target assertion

* fix(web): address late review feedback

* test(web): cover PR review boundary branches
2026-07-22 17:52:58 +01:00

1.5 KiB

id, title, status, wave, depends_on, plan
id title status wave depends_on plan
multi-pr-review-01 Add task-scoped Review PR selection done 1
./plan.md

Acceptance

  • Resolver defaults to primary PR, honors a stable override, isolates tasks, and falls back when selected PR disappears.
  • Zustand UI state stores only task-keyed in-session overrides.
  • PR key utility lives outside React panel code.

Files

  • apps/web/components/github/pr-utils.ts
  • Existing prTaskKey importers
  • apps/web/hooks/domains/github/use-review-pr-selection.ts
  • apps/web/hooks/domains/github/use-review-pr-selection.test.ts
  • apps/web/hooks/domains/github/use-pr-review-repository-identity.ts
  • apps/web/hooks/domains/github/use-pr-review-repository-identity.test.tsx
  • apps/web/lib/state/slices/ui/types.ts
  • apps/web/lib/state/slices/ui/ui-slice.ts
  • apps/web/lib/state/default-state.ts
  • apps/web/lib/state/store.ts
  • apps/web/lib/state/store-overrides.ts

Inputs

  • Spec Frontend section
  • useTaskPR() / getPrimaryTaskPR() in use-task-pr.ts
  • Derived fallback pattern in multi-pr-ci-popover.tsx

Method

Use strict RED → GREEN → REFACTOR. First run must fail on behavior, not missing import.

Verification

cd apps/web && pnpm test -- hooks/domains/github/use-review-pr-selection.test.ts hooks/domains/github/use-pr-review-repository-identity.test.tsx lib/state/store.test.ts

Output contract

Report summary, files, RED and GREEN results, blockers, and remaining risks; mark status done only after focused verification passes.