d5da5d0022
* fix(web): select pull request on review surface * fix(web): address review feedback * test(web): stabilize tablet review target assertion * fix(web): address late review feedback * test(web): cover PR review boundary branches
1.5 KiB
1.5 KiB
id, title, status, wave, depends_on, plan
| id | title | status | wave | depends_on | plan |
|---|---|---|---|---|---|
| multi-pr-review-01 | Add task-scoped Review PR selection | done | 1 | ./plan.md |
Acceptance
- Resolver defaults to primary PR, honors a stable override, isolates tasks, and falls back when selected PR disappears.
- Zustand UI state stores only task-keyed in-session overrides.
- PR key utility lives outside React panel code.
Files
apps/web/components/github/pr-utils.ts- Existing
prTaskKeyimporters apps/web/hooks/domains/github/use-review-pr-selection.tsapps/web/hooks/domains/github/use-review-pr-selection.test.tsapps/web/hooks/domains/github/use-pr-review-repository-identity.tsapps/web/hooks/domains/github/use-pr-review-repository-identity.test.tsxapps/web/lib/state/slices/ui/types.tsapps/web/lib/state/slices/ui/ui-slice.tsapps/web/lib/state/default-state.tsapps/web/lib/state/store.tsapps/web/lib/state/store-overrides.ts
Inputs
- Spec Frontend section
useTaskPR()/getPrimaryTaskPR()inuse-task-pr.ts- Derived fallback pattern in
multi-pr-ci-popover.tsx
Method
Use strict RED → GREEN → REFACTOR. First run must fail on behavior, not missing import.
Verification
cd apps/web && pnpm test -- hooks/domains/github/use-review-pr-selection.test.ts hooks/domains/github/use-pr-review-repository-identity.test.tsx lib/state/store.test.ts
Output contract
Report summary, files, RED and GREEN results, blockers, and remaining risks; mark status done only after focused verification passes.