Files

T

Carlos Florêncio bc218dfbbe feat: add workspace sources from files panel (#1900 )

* feat: add workspace sources from files panel

* fix: preserve worktree identity during recovery

* feat: unify workspace source actions

* fix: validate recovered workspace repositories

* fix: harden workspace source filesystem boundaries

* test: split workspace repository chip coverage

* fix: restrict repository rescan recovery paths

* fix: stabilize workspace source CI checks

* test: canonicalize workspace source paths

* test: align workspace source container paths

* fix: populate direct workspace repository names

* test: preserve git fixture rewrites across restarts

* test: isolate backend git fixture config

* fix: resume remote workspace executions before creation

* fix: preserve ssh agent identity during resume

* fix: preserve SSH workspace across backend restart

* fix: simplify workspace actions trigger

* fix: refine add workspace repositories UX

* docs: narrow workspace source UX updates

* fix: avoid phantom turn on session resume

* test(web): normalize workspace source request headers

* feat(web): streamline workspace source picker

* docs: remove trailing spaces from workspace source plan

* fix: prevent resume status from creating phantom turns

* fix(web): stabilize workspace source attachment

* refactor(web): extract workspace source store contract

* fix: avoid phantom turns on idle agent resume

* fix: address backend static analysis findings

* fix: preserve agentctl readiness status value

* fix: preserve resume messages without active turns

* fix: resume agents from promoted workspace root

* chore: merge origin/main into feature/add-new-repo-folder-d97

* feat(web): explain workspace source consequences

* test(websocket): count session activity subscription

2026-07-25 21:29:53 +01:00

3.2 KiB

Raw Blame History

id, title, status, wave, depends_on, plan, spec

title

status

wave

depends_on

plan

spec

06-shared-source-picker

Shared source picker

done

02-attachment-service

plan.md

../../specs/tasks/attach-workspace-sources.md

Task 06: Shared Source Picker

Acceptance

Reusable workspace-repository, remote-repository, branch, and folder selection leaves live under components/workspace-source-picker/ with task-create behavior unchanged.
Mixed source form state supports independent stable rows, validation, retry, and exact HTTP payload construction for repository, remote repository, and folder kinds.
Executor capability hides the folder row kind for Docker, SSH, Sprites, and remote Docker while leaving local and remote repository choices available.
Frontend API/types/store contracts model workspace folders and attachment responses, and the old Worktree-only multi-repository guard is removed only after runtime capability is present.

Verification

cd apps/web
rtk pnpm test -- components/workspace-source-picker components/task-create-dialog lib/api/domains/kanban-api
rtk pnpm run typecheck

Files likely touched

apps/web/components/workspace-source-picker/** (new)
apps/web/components/task-create-dialog-workspace-repo-chips.tsx
apps/web/components/task-create-dialog-remote-repo-chip.tsx
apps/web/components/task-create-dialog-remote-repo-chips.tsx
apps/web/components/folder-picker.tsx
apps/web/components/task-create-dialog-computed.ts
apps/web/components/task-create-dialog-multi-repo-guard.ts
apps/web/lib/api/domains/kanban-api.ts
apps/web/lib/types/http.ts
apps/web/lib/state/slices/kanban/types.ts

Dependencies

Task 02 for the final request contract. This task may begin extraction in parallel with Tasks 03/04 but must not delete the executor guard until Task 05 is integrated.

Inputs

Existing task-create picker files named above.
Spec: mixed batch inputs and executor parity.

Output contract

Summary, files changed, tests run, blockers, risks, divergence, and task/plan status updates.

Completion notes

Added the shared typed source-row state, validation, deterministic request builder, and executor capability helper under apps/web/components/workspace-source-picker/.
Re-exported the existing task-create repository, remote repository, branch, and folder picker leaves from the shared namespace without changing their behavior. Task 07 owns the Add sources desktop/dialog/drawer compositions.
Mobile parity handoff: Task 07 must consume this same state/capability layer in a phone-native, viewport-contained MobilePickerSheet or Drawer with a single internal scroll owner and 44px touch controls; this task introduces no rendered outer surface, so no mobile E2E is appropriate yet.
Kept the existing Worktree-only multi-repository guard in task-create-dialog-computed.ts and task-create-dialog-multi-repo-guard.ts. Deferred handoff to Task 05: remove or relax that create-task guard only after Task 05 wires the remote runtime multi-repository capability and its executor profile contract; this attachment-picker capability does not make create-task provisioning safe by itself.

3.2 KiB Raw Blame History