a34ea719df
* refactor(web): extract measureCaretRect into shared util Move the textarea caret-position measurement helper out of rich-text-input.tsx into apps/web/lib/utils/caret-position.ts so the task-create dialog's autocomplete wiring can reuse it without depending on the chat-only RichTextInput component. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web): allow custom prompts in task creation input Add an @-mention autocomplete to the task-create dialog's prompt textarea so users can quickly insert one of their saved custom prompts (built-in + user-created) by typing @<name>. - Extend useInlineMention with a promptInsertMode option. The default "context" mode preserves chat behavior (attach the prompt to the context store). The new "inline" mode replaces the @query text with the prompt's full content, requiring no backend changes -- the resolved text just becomes part of the task description on submit. - Wire the hook into TaskFormInputs via a small useTaskCreatePromptMention helper that adapts the existing textarea ref to the RichTextInputHandle surface the hook expects (focus / selection / caret-rect / value). - Reuse the existing MentionMenu popup component for parity with chat. - Cover the new branches with unit tests for makePromptItem / detectMentionTrigger / filterItems, and an E2E spec exercising the menu open / inline-insertion / Enter-doesn't-submit / trigger-inside-word paths. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): make mention popup clickable inside Radix Dialog Radix Dialog sets pointer-events: none on document.body to enforce modal isolation. The mention/slash menu portals to document.body and inherits the disabled pointer events when opened from inside a Dialog (the task-create flow). The popup was visible but unclickable: keyboard select worked, mouse clicks were swallowed by the Dialog body. Restore pointerEvents: auto on the popup container so it stays clickable when invoked from within a modal. Bump z-index to 60 so the popup also wins the visual stacking race against the Dialog (overlay + content are both z-50). Chat continues to work unchanged since z-60 and pointer-events: auto are no-ops outside a modal. Add an adversarial QA spec covering mouse-click select, ArrowDown + Enter on the 2nd item, Escape close, multi-line content auto-grow, backspace-over-@ close, space-after-@ close, no-arrow-cursor-shift, and end-to-end submit. The mouse-click case is the one this fix unblocks; the rest pin behavior for future regressions. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): address PR review feedback - caret-position.ts: wrap DOM measurement in try/finally so the mirror element is always removed even if getBoundingClientRect throws - useTextareaHandlers: destructure stable fn refs from mention before useCallback so deps are specific properties, not the whole object — avoids defeating memoization on every keystroke - QA spec: consolidate inline cleanupPrompts calls into a shared test.afterEach so cleanup always runs even when a test throws; update submit test comment to accurately reflect what is asserted Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(web): tighten ArrowDown selection assertion in QA E2E spec Equal filter scores sort by insertion order (stable), so qa-arr-1 lands at index 0 and qa-arr-2 at index 1. After one ArrowDown from the default the selected item is "SECOND" — assert that directly instead of accepting either value, matching the test title "selects the second prompt". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
92 lines
3.2 KiB
TypeScript
92 lines
3.2 KiB
TypeScript
import { test, expect } from "../../fixtures/test-base";
|
|
import { KanbanPage } from "../../pages/kanban-page";
|
|
|
|
const PROMPT_NAME = "e2e-bug-template";
|
|
const PROMPT_CONTENT = "Reproduce, isolate, fix with a regression test.";
|
|
const MENU_TITLE = /Mention tasks, files, prompts/i;
|
|
|
|
test.describe("Task creation: custom prompt autocomplete", () => {
|
|
test.afterEach(async ({ apiClient }) => {
|
|
const { prompts } = await apiClient.listPrompts();
|
|
for (const p of prompts) {
|
|
if (!p.builtin && p.name === PROMPT_NAME) {
|
|
await apiClient.deletePrompt(p.id).catch(() => undefined);
|
|
}
|
|
}
|
|
});
|
|
|
|
test("typing @<name> opens the menu and selecting inlines the prompt content", async ({
|
|
testPage,
|
|
apiClient,
|
|
}) => {
|
|
test.setTimeout(60_000);
|
|
|
|
await apiClient.createPrompt(PROMPT_NAME, PROMPT_CONTENT);
|
|
|
|
const kanban = new KanbanPage(testPage);
|
|
await kanban.goto();
|
|
await kanban.createTaskButton.first().click();
|
|
|
|
const dialog = testPage.getByTestId("create-task-dialog");
|
|
await expect(dialog).toBeVisible();
|
|
|
|
const textarea = testPage.getByTestId("task-description-input");
|
|
await textarea.click();
|
|
await textarea.pressSequentially("@e2e-bu");
|
|
|
|
const menu = testPage.getByText(MENU_TITLE);
|
|
await expect(menu).toBeVisible({ timeout: 5_000 });
|
|
await expect(testPage.getByRole("button", { name: new RegExp(PROMPT_NAME) })).toBeVisible();
|
|
|
|
await textarea.press("Enter");
|
|
|
|
await expect(textarea).toHaveValue(PROMPT_CONTENT);
|
|
await expect(menu).not.toBeVisible();
|
|
});
|
|
|
|
test("typing @ inside a word does NOT open the menu", async ({ testPage, apiClient }) => {
|
|
test.setTimeout(60_000);
|
|
|
|
await apiClient.createPrompt(PROMPT_NAME, PROMPT_CONTENT);
|
|
|
|
const kanban = new KanbanPage(testPage);
|
|
await kanban.goto();
|
|
await kanban.createTaskButton.first().click();
|
|
await expect(testPage.getByTestId("create-task-dialog")).toBeVisible();
|
|
|
|
const textarea = testPage.getByTestId("task-description-input");
|
|
await textarea.click();
|
|
// No preceding whitespace before @ — the trigger is invalid.
|
|
await textarea.pressSequentially("foo@bar");
|
|
|
|
await expect(textarea).toHaveValue("foo@bar");
|
|
await expect(testPage.getByText(MENU_TITLE)).toHaveCount(0);
|
|
});
|
|
|
|
test("Enter inside the menu does NOT submit the form", async ({ testPage, apiClient }) => {
|
|
test.setTimeout(60_000);
|
|
|
|
await apiClient.createPrompt(PROMPT_NAME, PROMPT_CONTENT);
|
|
|
|
const kanban = new KanbanPage(testPage);
|
|
await kanban.goto();
|
|
await kanban.createTaskButton.first().click();
|
|
|
|
const dialog = testPage.getByTestId("create-task-dialog");
|
|
await expect(dialog).toBeVisible();
|
|
|
|
// Fill title so the form would be otherwise submittable.
|
|
await testPage.getByTestId("task-title-input").fill("autocomplete-enter-test");
|
|
const textarea = testPage.getByTestId("task-description-input");
|
|
await textarea.click();
|
|
await textarea.pressSequentially("@e2e-bu");
|
|
|
|
await expect(testPage.getByText(MENU_TITLE)).toBeVisible();
|
|
await textarea.press("Enter");
|
|
|
|
// Dialog must still be open — Enter selected the menu item, not the form submit.
|
|
await expect(dialog).toBeVisible();
|
|
await expect(textarea).toHaveValue(PROMPT_CONTENT);
|
|
});
|
|
});
|