João Salavisa
706 lines
26 KiB
TypeScript
706 lines
26 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { cleanup, fireEvent, render, screen, waitFor, within } from "@testing-library/react";
|
|
import type { ReactNode } from "react";
|
|
import { TooltipProvider } from "@kandev/ui/tooltip";
|
|
import { StateProvider } from "@/components/state-provider";
|
|
import { ToastProvider } from "@/components/toast-provider";
|
|
import { pluginRegistry } from "@/lib/plugins/registry";
|
|
import type { PluginTaskMenuContext } from "@/lib/plugins/types";
|
|
import { TaskItemWithContextMenu } from "./task-switcher-context-menu";
|
|
import type { TaskSwitcherItem } from "./task-switcher-types";
|
|
|
|
const PLUGIN_ID = "example-task-actions";
|
|
const PLUGIN_ACTION_LABEL = "Inspect task";
|
|
const WORKFLOW_1_ID = "workflow-1";
|
|
const WORKFLOW_1_NAME = "Workflow 1";
|
|
const WORKFLOW_ID = WORKFLOW_1_ID;
|
|
const STEP_ID = "step-1";
|
|
const SEPARATOR_SLOT = "context-menu-separator";
|
|
const MOVE_TO_TEST_ID = "task-context-move-to";
|
|
const STEP_2_TEST_ID = "task-context-step-step-2";
|
|
const INSTRUCTIONS_TEST_ID = "workflow-move-instructions";
|
|
const workflowMoveMock = vi.hoisted(() => ({
|
|
move: vi.fn(),
|
|
isMoving: false,
|
|
}));
|
|
const touchDrawerMock = vi.hoisted(() => ({ enabled: false }));
|
|
|
|
vi.mock("@/hooks/domains/kanban/use-workflow-move", () => ({
|
|
useWorkflowMove: () => workflowMoveMock,
|
|
}));
|
|
vi.mock("@/hooks/use-compact-task-chrome", () => ({
|
|
useTouchDrawer: () => touchDrawerMock.enabled,
|
|
}));
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
Object.defineProperty(window, "innerWidth", { configurable: true, value: 1024 });
|
|
pluginRegistry.unregisterPlugin(PLUGIN_ID);
|
|
});
|
|
|
|
beforeEach(() => {
|
|
workflowMoveMock.move.mockReset();
|
|
workflowMoveMock.move.mockResolvedValue({ disposition: "committed", response: {} });
|
|
touchDrawerMock.enabled = false;
|
|
});
|
|
|
|
function task(overrides: Partial<TaskSwitcherItem> = {}): TaskSwitcherItem {
|
|
return { id: "task-1", title: "Task 1", state: "IN_PROGRESS", ...overrides };
|
|
}
|
|
|
|
function ArchiveAwareRow({ archiveConfirmation }: { archiveConfirmation?: ReactNode }) {
|
|
return (
|
|
<div data-testid="task-row" data-inline-confirmation={Boolean(archiveConfirmation)}>
|
|
Task 1{archiveConfirmation}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
it("keeps phone rows intact while archive hands off from the menu to a sheet", async () => {
|
|
Object.defineProperty(window, "innerWidth", { configurable: true, value: 390 });
|
|
const { onArchiveTask } = renderWithDragHandle();
|
|
await openContextMenu();
|
|
fireEvent.click(screen.getByRole("menuitem", { name: /archive/i }));
|
|
await screen.findByRole("dialog", { name: /Archive task/ });
|
|
expect(screen.queryByRole("menu")).toBeNull();
|
|
expect(screen.getByTestId("task-row").getAttribute("data-inline-confirmation")).toBe("false");
|
|
expect(onArchiveTask).not.toHaveBeenCalled();
|
|
});
|
|
|
|
/**
|
|
* Stands in for the dnd-kit drag handle that wraps the row. In the real tree
|
|
* the handle's sensor listeners (`onMouseDown`, `onTouchStart`, `onPointerDown`)
|
|
* are fiber ancestors of the context-menu portal, so a pointer-start event on a
|
|
* menu item fiber-bubbles into them and starts a row drag — unless the menu
|
|
* stops it. `onClick` stands in for the row's `onSelectTask` click handler.
|
|
*/
|
|
function renderWithDragHandle(overrides: Partial<TaskSwitcherItem> = {}) {
|
|
const onMouseDown = vi.fn();
|
|
const onPointerDown = vi.fn();
|
|
const onTouchStart = vi.fn();
|
|
const onClick = vi.fn();
|
|
const onArchiveTask = vi.fn();
|
|
render(
|
|
<StateProvider>
|
|
<ToastProvider>
|
|
<div
|
|
data-testid="drag-handle"
|
|
onMouseDown={onMouseDown}
|
|
onPointerDown={onPointerDown}
|
|
onTouchStart={onTouchStart}
|
|
onClick={onClick}
|
|
>
|
|
<TaskItemWithContextMenu task={task(overrides)} onArchiveTask={onArchiveTask}>
|
|
<ArchiveAwareRow />
|
|
</TaskItemWithContextMenu>
|
|
</div>
|
|
</ToastProvider>
|
|
</StateProvider>,
|
|
);
|
|
return { onMouseDown, onPointerDown, onTouchStart, onClick, onArchiveTask };
|
|
}
|
|
|
|
async function openContextMenu() {
|
|
fireEvent.contextMenu(screen.getByTestId("task-row"));
|
|
await screen.findByRole("menuitem", { name: /color/i });
|
|
}
|
|
|
|
function renderPluginMenu(run: (context: PluginTaskMenuContext) => void = vi.fn()) {
|
|
pluginRegistry.forPlugin(PLUGIN_ID).registerTaskMenuAction({
|
|
id: "inspect-task",
|
|
label: PLUGIN_ACTION_LABEL,
|
|
group: "primary",
|
|
run,
|
|
});
|
|
render(
|
|
<StateProvider initialState={{ workspaces: { items: [], activeId: "workspace-1" } }}>
|
|
<ToastProvider>
|
|
<TaskItemWithContextMenu task={task({ workflowStepId: STEP_ID })}>
|
|
<div data-testid="plugin-task-row">Task 1</div>
|
|
</TaskItemWithContextMenu>
|
|
</ToastProvider>
|
|
</StateProvider>,
|
|
);
|
|
fireEvent.contextMenu(screen.getByTestId("plugin-task-row"));
|
|
}
|
|
|
|
describe("TaskItemWithContextMenu — plugin primary actions", () => {
|
|
it("runs a generic primary action with the sidebar task context", async () => {
|
|
const run = vi.fn();
|
|
renderPluginMenu(run);
|
|
|
|
fireEvent.click(screen.getByRole("menuitem", { name: PLUGIN_ACTION_LABEL }));
|
|
await Promise.resolve();
|
|
|
|
expect(run).toHaveBeenCalledWith({
|
|
workspaceId: "workspace-1",
|
|
taskId: "task-1",
|
|
taskTitle: "Task 1",
|
|
workflowStepId: STEP_ID,
|
|
presentation: "desktop",
|
|
});
|
|
});
|
|
|
|
it("removes an action from an already-open menu when its plugin unregisters", async () => {
|
|
renderPluginMenu();
|
|
expect(screen.getByRole("menuitem", { name: PLUGIN_ACTION_LABEL })).not.toBeNull();
|
|
|
|
pluginRegistry.unregisterPlugin(PLUGIN_ID);
|
|
|
|
await waitFor(() => {
|
|
expect(screen.queryByRole("menuitem", { name: PLUGIN_ACTION_LABEL })).toBeNull();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("TaskItemWithContextMenu — grouped single-task actions", () => {
|
|
it("renders actions in group order with one divider between nonempty groups", async () => {
|
|
pluginRegistry.forPlugin(PLUGIN_ID).registerTaskMenuAction({
|
|
id: "inspect-task",
|
|
label: PLUGIN_ACTION_LABEL,
|
|
group: "primary",
|
|
run: vi.fn(),
|
|
});
|
|
|
|
render(
|
|
<StateProvider initialState={{ workspaces: { items: [], activeId: "workspace-1" } }}>
|
|
<ToastProvider>
|
|
<TaskItemWithContextMenu
|
|
task={task({
|
|
workflowId: WORKFLOW_ID,
|
|
workflowStepId: STEP_ID,
|
|
parentTaskId: "parent-1",
|
|
})}
|
|
workflows={[
|
|
{ id: WORKFLOW_ID, name: WORKFLOW_1_NAME },
|
|
{ id: "workflow-2", name: "Workflow 2" },
|
|
]}
|
|
stepsByWorkflowId={{
|
|
[WORKFLOW_ID]: [
|
|
{ id: STEP_ID, title: "Step 1" },
|
|
{ id: "step-2", title: "Step 2" },
|
|
],
|
|
}}
|
|
onTogglePin={vi.fn()}
|
|
onEditTask={vi.fn()}
|
|
onRenameTask={vi.fn()}
|
|
onArchiveTask={vi.fn()}
|
|
onCreateSubtask={vi.fn()}
|
|
onDeleteTask={vi.fn()}
|
|
onDetachTask={vi.fn()}
|
|
onMoveToStep={vi.fn()}
|
|
onLinkPullRequest={vi.fn()}
|
|
>
|
|
<ArchiveAwareRow />
|
|
</TaskItemWithContextMenu>
|
|
</ToastProvider>
|
|
</StateProvider>,
|
|
);
|
|
|
|
fireEvent.contextMenu(screen.getByTestId("task-row"));
|
|
const menu = await screen.findByRole("menu");
|
|
const labels = within(menu)
|
|
.getAllByRole("menuitem")
|
|
.map((item) => item.textContent?.replace(/\s+/g, " ").trim());
|
|
|
|
expect(labels).toEqual([
|
|
"Pin",
|
|
"Color",
|
|
"Priority",
|
|
"Edit",
|
|
"Rename",
|
|
"Duplicate",
|
|
"Create Subtask",
|
|
"Nest under",
|
|
"Link",
|
|
"Detach from parent",
|
|
"Move to",
|
|
"Send to workflow",
|
|
PLUGIN_ACTION_LABEL,
|
|
"Archive",
|
|
"Delete",
|
|
]);
|
|
|
|
const directChildren = Array.from(menu.children);
|
|
const separators = directChildren.filter(
|
|
(child) => child.getAttribute("data-slot") === SEPARATOR_SLOT,
|
|
);
|
|
expect(separators).toHaveLength(5);
|
|
expect(directChildren[0]?.getAttribute("data-slot")).not.toBe(SEPARATOR_SLOT);
|
|
expect(directChildren.at(-1)?.getAttribute("data-slot")).not.toBe(SEPARATOR_SLOT);
|
|
expect(
|
|
directChildren.some(
|
|
(child, index) =>
|
|
child.getAttribute("data-slot") === SEPARATOR_SLOT &&
|
|
directChildren[index - 1]?.getAttribute("data-slot") === SEPARATOR_SLOT,
|
|
),
|
|
).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("TaskItemWithContextMenu — grouped bulk actions", () => {
|
|
it("keeps bulk actions in mark, movement, and removal groups", async () => {
|
|
render(
|
|
<StateProvider>
|
|
<ToastProvider>
|
|
<TaskItemWithContextMenu
|
|
task={task({ workflowId: WORKFLOW_ID, workflowStepId: STEP_ID })}
|
|
selectedTaskIds={new Set(["task-1", "task-2"])}
|
|
workflows={[
|
|
{ id: WORKFLOW_ID, name: WORKFLOW_1_NAME },
|
|
{ id: "workflow-2", name: "Workflow 2" },
|
|
]}
|
|
stepsByWorkflowId={{
|
|
[WORKFLOW_ID]: [
|
|
{ id: STEP_ID, title: "Step 1" },
|
|
{ id: "step-2", title: "Step 2" },
|
|
],
|
|
}}
|
|
onBulkPin={vi.fn()}
|
|
onBulkArchive={vi.fn()}
|
|
onBulkDelete={vi.fn()}
|
|
onBulkMove={vi.fn()}
|
|
>
|
|
<ArchiveAwareRow />
|
|
</TaskItemWithContextMenu>
|
|
</ToastProvider>
|
|
</StateProvider>,
|
|
);
|
|
|
|
fireEvent.contextMenu(screen.getByTestId("task-row"));
|
|
const menu = await screen.findByRole("menu");
|
|
const labels = within(menu)
|
|
.getAllByRole("menuitem")
|
|
.map((item) => item.textContent?.replace(/\s+/g, " ").trim());
|
|
|
|
expect(labels).toEqual([
|
|
"Pin 2 tasks",
|
|
"Move to",
|
|
"Send to workflow",
|
|
"Archive 2 tasks",
|
|
"Delete 2 tasks",
|
|
]);
|
|
|
|
const directChildren = Array.from(menu.children);
|
|
const separators = directChildren.filter(
|
|
(child) => child.getAttribute("data-slot") === SEPARATOR_SLOT,
|
|
);
|
|
expect(separators).toHaveLength(2);
|
|
expect(directChildren[0]?.getAttribute("data-slot")).not.toBe(SEPARATOR_SLOT);
|
|
expect(directChildren.at(-1)?.getAttribute("data-slot")).not.toBe(SEPARATOR_SLOT);
|
|
});
|
|
});
|
|
|
|
function renderWorkflowMoveMenu({
|
|
selectedTaskIds,
|
|
onMoveToStep,
|
|
onBulkMove,
|
|
}: {
|
|
selectedTaskIds?: Set<string>;
|
|
onMoveToStep?: (taskId: string, workflowId: string, targetStepId: string) => void;
|
|
onBulkMove?: (taskIds: string[], targetWorkflowId: string, targetStepId: string) => void;
|
|
} = {}) {
|
|
const bulkMove = onBulkMove ?? vi.fn();
|
|
render(
|
|
<StateProvider>
|
|
<ToastProvider>
|
|
<TooltipProvider>
|
|
<TaskItemWithContextMenu
|
|
task={task({
|
|
workflowId: WORKFLOW_1_ID,
|
|
workflowStepId: "step-1",
|
|
})}
|
|
workflows={[{ id: WORKFLOW_1_ID, name: WORKFLOW_1_NAME }]}
|
|
stepsByWorkflowId={{
|
|
[WORKFLOW_1_ID]: [
|
|
{ id: "step-1", title: "Todo" },
|
|
{ id: "step-2", title: "Review" },
|
|
],
|
|
}}
|
|
selectedTaskIds={selectedTaskIds}
|
|
onMoveToStep={onMoveToStep}
|
|
onBulkMove={bulkMove}
|
|
>
|
|
<div data-testid="task-row">Task 1</div>
|
|
</TaskItemWithContextMenu>
|
|
</TooltipProvider>
|
|
</ToastProvider>
|
|
</StateProvider>,
|
|
);
|
|
return { bulkMove };
|
|
}
|
|
|
|
async function openMoveSubmenu() {
|
|
fireEvent.contextMenu(screen.getByTestId("task-row"));
|
|
await screen.findByTestId(MOVE_TO_TEST_ID);
|
|
fireEvent.pointerMove(screen.getByTestId(MOVE_TO_TEST_ID), {
|
|
pointerType: "mouse",
|
|
});
|
|
const targetStep = await screen.findByTestId(STEP_2_TEST_ID);
|
|
fireEvent.pointerMove(targetStep, {
|
|
pointerType: "mouse",
|
|
});
|
|
}
|
|
|
|
// happy-dom's TouchEvent drops the touches/changedTouches init, so the touch
|
|
// events in the cancellation tests stub it faithfully.
|
|
function stubTouchEvent() {
|
|
vi.stubGlobal(
|
|
"TouchEvent",
|
|
class StubTouchEvent extends Event {
|
|
touches: unknown[];
|
|
changedTouches: unknown[];
|
|
constructor(
|
|
type: string,
|
|
init?: EventInit & { touches?: unknown[]; changedTouches?: unknown[] },
|
|
) {
|
|
// Forward bubbles/cancelable so the stub faithfully models the
|
|
// production `new TouchEvent("touchcancel", { bubbles: true,
|
|
// cancelable: true })` dispatch.
|
|
super(type, init);
|
|
this.touches = init?.touches ?? [];
|
|
this.changedTouches = init?.changedTouches ?? [];
|
|
}
|
|
},
|
|
);
|
|
}
|
|
|
|
describe("TaskItemWithContextMenu — pointer containment", () => {
|
|
it("shows a flag-labelled priority submenu with the current value", async () => {
|
|
renderWithDragHandle({ priority: "high" } as Partial<TaskSwitcherItem>);
|
|
await openContextMenu();
|
|
|
|
const priority = screen.getByTestId("task-context-priority");
|
|
expect(priority.querySelector("svg")).not.toBeNull();
|
|
fireEvent.pointerMove(priority, { pointerType: "mouse" });
|
|
|
|
expect(await screen.findByTestId("task-context-priority-current-high")).not.toBeNull();
|
|
expect(screen.getByTestId("task-context-priority-critical")).not.toBeNull();
|
|
expect(screen.getByTestId("task-context-priority-medium")).not.toBeNull();
|
|
expect(screen.getByTestId("task-context-priority-low")).not.toBeNull();
|
|
});
|
|
|
|
// Regression: the menu renders in a portal whose fiber ancestors include the
|
|
// drag handle. Without a guard, mousedown/pointerdown on any menu item
|
|
// bubbles through the React fiber tree to the handle's dnd-kit sensor
|
|
// listeners and starts a row drag (MouseSensor ignores only right-click).
|
|
it("mousedown and pointerdown on the Color submenu trigger do not reach the drag handle", async () => {
|
|
const { onMouseDown, onPointerDown } = renderWithDragHandle();
|
|
await openContextMenu();
|
|
|
|
fireEvent.mouseDown(screen.getByRole("menuitem", { name: /color/i }));
|
|
fireEvent.pointerDown(screen.getByRole("menuitem", { name: /color/i }));
|
|
|
|
expect(onMouseDown).not.toHaveBeenCalled();
|
|
expect(onPointerDown).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("touchstart on the Color submenu trigger and swatch does not reach the drag handle", async () => {
|
|
const { onTouchStart } = renderWithDragHandle();
|
|
await openContextMenu();
|
|
|
|
fireEvent.touchStart(screen.getByRole("menuitem", { name: /color/i }));
|
|
expect(onTouchStart).not.toHaveBeenCalled();
|
|
|
|
fireEvent.pointerMove(screen.getByRole("menuitem", { name: /color/i }), {
|
|
pointerType: "mouse",
|
|
});
|
|
const redSwatch = await screen.findByRole("menuitem", { name: /red/i });
|
|
fireEvent.touchStart(redSwatch);
|
|
expect(onTouchStart).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("mousedown and pointerdown on a color swatch do not reach the drag handle", async () => {
|
|
const { onMouseDown, onPointerDown } = renderWithDragHandle();
|
|
await openContextMenu();
|
|
|
|
fireEvent.pointerMove(screen.getByRole("menuitem", { name: /color/i }), {
|
|
pointerType: "mouse",
|
|
});
|
|
const redSwatch = await screen.findByRole("menuitem", { name: /red/i });
|
|
fireEvent.mouseDown(redSwatch);
|
|
fireEvent.pointerDown(redSwatch);
|
|
|
|
expect(onMouseDown).not.toHaveBeenCalled();
|
|
expect(onPointerDown).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("clicking a menu item runs its action without activating the row", async () => {
|
|
const { onClick, onArchiveTask } = renderWithDragHandle();
|
|
await openContextMenu();
|
|
|
|
fireEvent.click(screen.getByRole("menuitem", { name: /archive/i }));
|
|
|
|
expect(onArchiveTask).not.toHaveBeenCalled();
|
|
const dialog = await screen.findByRole("alertdialog");
|
|
fireEvent.click(within(dialog).getByRole("button", { name: /^Archive$/ }));
|
|
await waitFor(() => {
|
|
expect(onArchiveTask).toHaveBeenCalledTimes(1);
|
|
expect(onArchiveTask).toHaveBeenCalledWith("task-1", { cascade: false });
|
|
});
|
|
expect(onClick).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe("TaskItemWithContextMenu — single-task move options", () => {
|
|
it("keeps the existing direct move as a one-selection action", async () => {
|
|
const onMoveToStep = vi.fn();
|
|
renderWorkflowMoveMenu({ onMoveToStep });
|
|
|
|
fireEvent.contextMenu(screen.getByTestId("task-row"));
|
|
fireEvent.pointerMove(screen.getByTestId(MOVE_TO_TEST_ID), {
|
|
pointerType: "mouse",
|
|
});
|
|
fireEvent.click(await screen.findByTestId(STEP_2_TEST_ID));
|
|
|
|
expect(onMoveToStep).toHaveBeenCalledOnce();
|
|
expect(onMoveToStep).toHaveBeenCalledWith("task-1", WORKFLOW_1_ID, "step-2");
|
|
expect(workflowMoveMock.move).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("submits one-shot options through the single-task move payload", async () => {
|
|
renderWorkflowMoveMenu();
|
|
await openMoveSubmenu();
|
|
|
|
const instructions = await screen.findByTestId(INSTRUCTIONS_TEST_ID);
|
|
fireEvent.change(instructions, { target: { value: " start review with tests " } });
|
|
fireEvent.click(screen.getByTestId("workflow-move-submit"));
|
|
|
|
await waitFor(() =>
|
|
expect(workflowMoveMock.move).toHaveBeenCalledWith("task-1", {
|
|
workflow_id: WORKFLOW_1_ID,
|
|
workflow_step_id: "step-2",
|
|
position: 0,
|
|
entry_options: { instructions: "start review with tests" },
|
|
}),
|
|
);
|
|
});
|
|
|
|
it("keeps desktop one-shot options when the move is rejected", async () => {
|
|
workflowMoveMock.move.mockResolvedValueOnce({
|
|
disposition: "failed",
|
|
error: new Error("move rejected"),
|
|
response: {},
|
|
});
|
|
renderWorkflowMoveMenu();
|
|
await openMoveSubmenu();
|
|
|
|
const instructions = await screen.findByTestId(INSTRUCTIONS_TEST_ID);
|
|
fireEvent.change(instructions, { target: { value: " retry review later " } });
|
|
fireEvent.click(screen.getByTestId("workflow-move-submit"));
|
|
|
|
await waitFor(() => expect(workflowMoveMock.move).toHaveBeenCalledOnce());
|
|
expect((screen.getByTestId(INSTRUCTIONS_TEST_ID) as HTMLTextAreaElement).value).toBe(
|
|
" retry review later ",
|
|
);
|
|
});
|
|
|
|
it("exposes inline move options under a one-task selection step", async () => {
|
|
renderWorkflowMoveMenu({ selectedTaskIds: new Set(["task-1"]) });
|
|
|
|
fireEvent.contextMenu(screen.getByTestId("task-row"));
|
|
await screen.findByTestId(MOVE_TO_TEST_ID);
|
|
|
|
expect(screen.queryByTestId("task-context-move-with-options")).toBeNull();
|
|
fireEvent.pointerMove(screen.getByTestId(MOVE_TO_TEST_ID), {
|
|
pointerType: "mouse",
|
|
});
|
|
fireEvent.pointerMove(await screen.findByTestId(STEP_2_TEST_ID), {
|
|
pointerType: "mouse",
|
|
});
|
|
expect(await screen.findByTestId("workflow-move-skip-step-prompt")).toBeTruthy();
|
|
expect(screen.getByTestId(INSTRUCTIONS_TEST_ID)).toBeTruthy();
|
|
expect(screen.getByTestId("workflow-move-submit")).toBeTruthy();
|
|
expect(screen.queryByTestId("task-context-step-options-step-2")).toBeNull();
|
|
});
|
|
|
|
it("does not expose an options submenu for bulk selection moves", async () => {
|
|
const { bulkMove } = renderWorkflowMoveMenu({
|
|
selectedTaskIds: new Set(["task-1", "task-2"]),
|
|
});
|
|
fireEvent.contextMenu(screen.getByTestId("task-row"));
|
|
await screen.findByTestId(MOVE_TO_TEST_ID);
|
|
|
|
expect(screen.queryByTestId("task-context-move-with-options")).toBeNull();
|
|
expect(screen.getByTestId(MOVE_TO_TEST_ID)).toBeTruthy();
|
|
expect(workflowMoveMock.move).not.toHaveBeenCalled();
|
|
|
|
fireEvent.pointerMove(screen.getByTestId(MOVE_TO_TEST_ID), {
|
|
pointerType: "mouse",
|
|
});
|
|
fireEvent.click(await screen.findByTestId(STEP_2_TEST_ID));
|
|
expect(bulkMove).toHaveBeenCalledWith(["task-1", "task-2"], WORKFLOW_1_ID, "step-2");
|
|
});
|
|
|
|
it("uses the touch Drawer presentation for the shared form", async () => {
|
|
touchDrawerMock.enabled = true;
|
|
renderWorkflowMoveMenu();
|
|
await openMoveSubmenu();
|
|
|
|
// Coarse/touch pointers keep the "Move with options" item that opens the
|
|
// shared form in a Drawer instead of rendering it inline.
|
|
fireEvent.click(await screen.findByTestId("task-context-step-options-step-2"));
|
|
expect(await screen.findByTestId("workflow-move-options")).toBeTruthy();
|
|
});
|
|
});
|
|
|
|
describe("TaskItemWithContextMenu — touch drag cancellation", () => {
|
|
it("opening the menu cancels an in-flight touch drag at the touchstart target", async () => {
|
|
// A touch long-press arms the row's TouchSensor (250ms) before the menu
|
|
// opens (~700ms); dnd-kit cancels the drag when a touchcancel reaches the
|
|
// element the touch began on, so opening the menu must emit one there.
|
|
stubTouchEvent();
|
|
const touchCancelListener = vi.fn();
|
|
|
|
try {
|
|
renderWithDragHandle();
|
|
const row = screen.getByTestId("task-row");
|
|
row.addEventListener("touchcancel", touchCancelListener);
|
|
|
|
fireEvent.touchStart(row, { touches: [{ identifier: 1 }] });
|
|
fireEvent.contextMenu(row);
|
|
await screen.findByRole("menuitem", { name: /color/i });
|
|
|
|
expect(touchCancelListener).toHaveBeenCalledTimes(1);
|
|
expect(touchCancelListener.mock.calls[0]?.[0].type).toBe("touchcancel");
|
|
expect(touchCancelListener.mock.calls[0]?.[0].target).toBe(row);
|
|
row.removeEventListener("touchcancel", touchCancelListener);
|
|
} finally {
|
|
vi.unstubAllGlobals();
|
|
}
|
|
});
|
|
|
|
it("a second concurrent touch does not overwrite the captured drag target", async () => {
|
|
// dnd-kit's TouchSensor ignores a second finger (touches.length > 1), so
|
|
// the first touch's target must stay the cancel target. The listener sits
|
|
// on the row and `secondFinger` nests inside it, so a buggy overwrite
|
|
// would still bubble here — assert the event target itself.
|
|
stubTouchEvent();
|
|
|
|
try {
|
|
renderWithDragHandle();
|
|
const row = screen.getByTestId("task-row");
|
|
const secondFinger = document.createElement("div");
|
|
row.appendChild(secondFinger);
|
|
const touchCancelListener = vi.fn();
|
|
row.addEventListener("touchcancel", touchCancelListener);
|
|
|
|
fireEvent.touchStart(row, { touches: [{ identifier: 1 }] });
|
|
fireEvent.touchStart(secondFinger, {
|
|
touches: [{ identifier: 1 }, { identifier: 2 }],
|
|
});
|
|
fireEvent.contextMenu(row);
|
|
await screen.findByRole("menuitem", { name: /color/i });
|
|
|
|
// The cancel went to the first touch's target (the row), not the second.
|
|
expect(touchCancelListener).toHaveBeenCalledTimes(1);
|
|
expect(touchCancelListener.mock.calls[0]?.[0].target).toBe(row);
|
|
row.removeEventListener("touchcancel", touchCancelListener);
|
|
} finally {
|
|
vi.unstubAllGlobals();
|
|
}
|
|
});
|
|
|
|
it("a completed touch leaves no stale cancel target for a later menu open", async () => {
|
|
// Stub TouchEvent so the touchstart genuinely stores a target (happy-dom
|
|
// drops the touches init); without it this assertion would pass vacuously.
|
|
stubTouchEvent();
|
|
|
|
try {
|
|
renderWithDragHandle();
|
|
const row = screen.getByTestId("task-row");
|
|
const touchCancelListener = vi.fn();
|
|
row.addEventListener("touchcancel", touchCancelListener);
|
|
|
|
fireEvent.touchStart(row, { touches: [{ identifier: 1 }] });
|
|
fireEvent.touchEnd(row, { changedTouches: [{ identifier: 1 }] });
|
|
fireEvent.contextMenu(row);
|
|
await screen.findByRole("menuitem", { name: /color/i });
|
|
|
|
// No gesture is active when the menu opens, so nothing is dispatched.
|
|
expect(touchCancelListener).not.toHaveBeenCalled();
|
|
row.removeEventListener("touchcancel", touchCancelListener);
|
|
} finally {
|
|
vi.unstubAllGlobals();
|
|
}
|
|
});
|
|
|
|
it("a non-primary finger lifting does not clear the tracked drag target", async () => {
|
|
// Finger 1 holds the row (long-press in progress); finger 2 lifts first.
|
|
// Only finger 1's touchend may clear the target, so the menu-open cancel
|
|
// still reaches the first touch's element.
|
|
stubTouchEvent();
|
|
|
|
try {
|
|
renderWithDragHandle();
|
|
const row = screen.getByTestId("task-row");
|
|
const touchCancelListener = vi.fn();
|
|
row.addEventListener("touchcancel", touchCancelListener);
|
|
|
|
fireEvent.touchStart(row, { touches: [{ identifier: 1 }] });
|
|
fireEvent.touchEnd(row, { changedTouches: [{ identifier: 2 }] });
|
|
fireEvent.contextMenu(row);
|
|
await screen.findByRole("menuitem", { name: /color/i });
|
|
|
|
expect(touchCancelListener).toHaveBeenCalledTimes(1);
|
|
expect(touchCancelListener.mock.calls[0]?.[0].type).toBe("touchcancel");
|
|
expect(touchCancelListener.mock.calls[0]?.[0].target).toBe(row);
|
|
row.removeEventListener("touchcancel", touchCancelListener);
|
|
} finally {
|
|
vi.unstubAllGlobals();
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("TaskItemWithContextMenu — touch drag cancellation identifier lifecycle", () => {
|
|
it("a non-primary touchcancel leaves the tracked drag target live", async () => {
|
|
// Same rule on the touchcancel path: finger 2's cancel must not clear
|
|
// finger 1's tracked target.
|
|
stubTouchEvent();
|
|
|
|
try {
|
|
renderWithDragHandle();
|
|
const row = screen.getByTestId("task-row");
|
|
const touchCancelListener = vi.fn();
|
|
row.addEventListener("touchcancel", touchCancelListener);
|
|
|
|
fireEvent.touchStart(row, { touches: [{ identifier: 1 }] });
|
|
fireEvent.touchCancel(row, { changedTouches: [{ identifier: 2 }] });
|
|
// The fired touchcancel above is caught by the row listener; count only
|
|
// what the menu-open path dispatches.
|
|
touchCancelListener.mockClear();
|
|
fireEvent.contextMenu(row);
|
|
await screen.findByRole("menuitem", { name: /color/i });
|
|
|
|
expect(touchCancelListener).toHaveBeenCalledTimes(1);
|
|
expect(touchCancelListener.mock.calls[0]?.[0].target).toBe(row);
|
|
row.removeEventListener("touchcancel", touchCancelListener);
|
|
} finally {
|
|
vi.unstubAllGlobals();
|
|
}
|
|
});
|
|
|
|
it("the tracked touch's touchcancel clears the cancel target", async () => {
|
|
// When finger 1 itself is cancelled, no synthetic cancel may fire later.
|
|
stubTouchEvent();
|
|
|
|
try {
|
|
renderWithDragHandle();
|
|
const row = screen.getByTestId("task-row");
|
|
const touchCancelListener = vi.fn();
|
|
row.addEventListener("touchcancel", touchCancelListener);
|
|
|
|
fireEvent.touchStart(row, { touches: [{ identifier: 1 }] });
|
|
fireEvent.touchCancel(row, { changedTouches: [{ identifier: 1 }] });
|
|
touchCancelListener.mockClear();
|
|
fireEvent.contextMenu(row);
|
|
await screen.findByRole("menuitem", { name: /color/i });
|
|
|
|
expect(touchCancelListener).not.toHaveBeenCalled();
|
|
row.removeEventListener("touchcancel", touchCancelListener);
|
|
} finally {
|
|
vi.unstubAllGlobals();
|
|
}
|
|
});
|
|
});
|