21202ef437
* fix(web): show skeleton in mobile task switcher sheet while snapshot loads
When the user opens the mobile task switcher inside a task page before the
workflow snapshot has hydrated kanban, the sheet rendered "No tasks yet."
instead of a loading state — and stayed that way if the fetch silently
failed.
useWorkflowSnapshot now drives kanban.isLoading, useTasks exposes it as
{ tasks, isLoading }, and the sheet wires that into TaskSwitcher's existing
skeleton. Fetch errors are surfaced via console.warn so an indefinite empty
list isn't silent anymore.
* fix(web): guard snapshot finally on cancel and drop redundant subscription
Skip the workflow-snapshot fetch's finally block when the effect was superseded by a newer workflowId — otherwise the old fetch's settle would clear the loading flag the new effect just set, briefly flashing the empty-state UI mid-switch.
Also drop the redundant kanbanIsLoading subscription in useSheetData (useTasks already encapsulates it) and make the setState mock in use-tasks.test.ts actually mutate state so useWorkflowSnapshot's side effects are exercised by the test.
* fix(web): scope snapshot finally clear to the effect that raised the flag
If kanban already matched the requested workflowId, the effect skipped raising isLoading=true — but its finally still cleared it on settle, collapsing a skeleton a concurrent caller (e.g. workspace switch) had set independently. Track whether this effect raised the flag and only clear in that case.
Also collapse the multi-line useTasks comment per CLAUDE.md style.
* fix(web): suppress superseded snapshot fetch warnings
Skip the catch-handler console.warn when the effect has been cancelled — a stale fetch shouldn't surface noise after a newer workflow has taken over.
* test(web): flush microtasks explicitly in race test
waitFor on a never-true assertion resolves immediately, hiding the intent. Use explicit Promise.resolve() flushes to land the superseded fetch's .then/.finally chain before asserting.
* style(web): collapse multi-line comments per CLAUDE.md
140 lines
5.1 KiB
TypeScript
140 lines
5.1 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
import { renderHook, waitFor } from "@testing-library/react";
|
|
|
|
const mockHydrate = vi.fn();
|
|
const mockFetchWorkflowSnapshot = vi.fn();
|
|
const mockSetState = vi.fn();
|
|
|
|
type MockKanban = {
|
|
workflowId: string | null;
|
|
tasks: unknown[];
|
|
steps: unknown[];
|
|
isLoading?: boolean;
|
|
};
|
|
type MockState = {
|
|
connection: { status: string };
|
|
kanban: MockKanban;
|
|
hydrate: typeof mockHydrate;
|
|
};
|
|
|
|
let mockState: MockState = {
|
|
connection: { status: "connected" },
|
|
kanban: { workflowId: null, tasks: [], steps: [], isLoading: false },
|
|
hydrate: mockHydrate,
|
|
};
|
|
|
|
vi.mock("@/components/state-provider", () => ({
|
|
useAppStore: (selector: (s: MockState) => unknown) => selector(mockState),
|
|
useAppStoreApi: () => ({
|
|
getState: () => mockState,
|
|
setState: (updater: (s: MockState) => MockState) => {
|
|
const next = updater(mockState);
|
|
mockSetState(next);
|
|
mockState = next;
|
|
},
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/lib/api", () => ({
|
|
fetchWorkflowSnapshot: (...args: unknown[]) => mockFetchWorkflowSnapshot(...args),
|
|
}));
|
|
|
|
vi.mock("@/lib/ssr/mapper", () => ({
|
|
snapshotToState: (snapshot: unknown) => ({ snapshot }),
|
|
}));
|
|
|
|
import { useWorkflowSnapshot } from "./use-workflow-snapshot";
|
|
|
|
function resetState(kanban: Partial<MockKanban> = {}) {
|
|
vi.clearAllMocks();
|
|
mockState = {
|
|
connection: { status: "connected" },
|
|
kanban: {
|
|
workflowId: null,
|
|
tasks: [],
|
|
steps: [],
|
|
isLoading: false,
|
|
...kanban,
|
|
},
|
|
hydrate: mockHydrate,
|
|
};
|
|
}
|
|
|
|
describe("useWorkflowSnapshot — kanban.isLoading", () => {
|
|
beforeEach(() => resetState());
|
|
|
|
it("flips isLoading true while a fetch for an un-hydrated workflow is in flight", () => {
|
|
mockFetchWorkflowSnapshot.mockReturnValue(new Promise(() => {}));
|
|
renderHook(() => useWorkflowSnapshot("wf-1"));
|
|
expect(mockState.kanban.isLoading).toBe(true);
|
|
});
|
|
|
|
it("flips isLoading back to false after the fetch resolves", async () => {
|
|
mockFetchWorkflowSnapshot.mockResolvedValue({ steps: [], tasks: [] });
|
|
renderHook(() => useWorkflowSnapshot("wf-1"));
|
|
await waitFor(() => expect(mockHydrate).toHaveBeenCalled());
|
|
await waitFor(() => expect(mockState.kanban.isLoading).toBe(false));
|
|
});
|
|
|
|
it("flips isLoading back to false after the fetch rejects", async () => {
|
|
mockFetchWorkflowSnapshot.mockRejectedValue(new Error("nope"));
|
|
renderHook(() => useWorkflowSnapshot("wf-1"));
|
|
await waitFor(() => expect(mockState.kanban.isLoading).toBe(false));
|
|
expect(mockHydrate).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not flip isLoading true if the requested workflow is already hydrated", () => {
|
|
resetState({ workflowId: "wf-1", isLoading: false });
|
|
mockFetchWorkflowSnapshot.mockReturnValue(new Promise(() => {}));
|
|
renderHook(() => useWorkflowSnapshot("wf-1"));
|
|
expect(mockState.kanban.isLoading).toBe(false);
|
|
});
|
|
|
|
it("does not clear isLoading on settle when it didn't raise the flag (already-hydrated re-fetch)", async () => {
|
|
// Mimic a workspace switch having set isLoading=true after the snapshot
|
|
// hydrated for this workflowId. A silent re-fetch (e.g. WS reconnect)
|
|
// must not collapse that skeleton.
|
|
resetState({ workflowId: "wf-1", isLoading: true });
|
|
mockFetchWorkflowSnapshot.mockResolvedValue({ steps: [], tasks: [] });
|
|
renderHook(() => useWorkflowSnapshot("wf-1"));
|
|
await waitFor(() => expect(mockHydrate).toHaveBeenCalled());
|
|
expect(mockState.kanban.isLoading).toBe(true);
|
|
});
|
|
|
|
it("does nothing when workflowId is null", () => {
|
|
renderHook(() => useWorkflowSnapshot(null));
|
|
expect(mockFetchWorkflowSnapshot).not.toHaveBeenCalled();
|
|
expect(mockState.kanban.isLoading).toBe(false);
|
|
});
|
|
|
|
it("does not clear isLoading when an old fetch settles after workflowId changes", async () => {
|
|
// First fetch never settles synchronously — we resolve it manually
|
|
// *after* re-rendering with a new workflowId, simulating the race where
|
|
// the user switches workflows mid-fetch.
|
|
let resolveFirst!: (snapshot: { steps: unknown[]; tasks: unknown[] }) => void;
|
|
const firstFetch = new Promise<{ steps: unknown[]; tasks: unknown[] }>((r) => {
|
|
resolveFirst = r;
|
|
});
|
|
const secondFetch = new Promise<{ steps: unknown[]; tasks: unknown[] }>(() => {});
|
|
mockFetchWorkflowSnapshot.mockReturnValueOnce(firstFetch).mockReturnValueOnce(secondFetch);
|
|
|
|
const { rerender } = renderHook(({ id }: { id: string | null }) => useWorkflowSnapshot(id), {
|
|
initialProps: { id: "wf-1" as string | null },
|
|
});
|
|
expect(mockState.kanban.isLoading).toBe(true);
|
|
|
|
// User switches to wf-2 before wf-1 finishes loading
|
|
rerender({ id: "wf-2" });
|
|
expect(mockState.kanban.isLoading).toBe(true);
|
|
|
|
// Old fetch lands now; flush its .then/.finally microtask chain so we
|
|
// can assert the negatives without relying on waitFor (which would
|
|
// resolve immediately for never-true assertions).
|
|
resolveFirst({ steps: [], tasks: [] });
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
expect(mockHydrate).not.toHaveBeenCalled();
|
|
expect(mockState.kanban.isLoading).toBe(true);
|
|
});
|
|
});
|