83e01477df
* refactor: extract shared shapes between jira and linear integrations Factors out the duplicated logic between internal/jira + internal/linear (backend) and components/jira + components/linear (frontend) into reusable shared shapes. Follow-up to PR #736. Backend: - New internal/integrations/secretadapter wraps secrets.SecretStore with the upsert API both jira.SecretStore and linear.SecretStore expect; drops both adapter copies from cmd/kandev/services.go. - New internal/integrations/healthpoll owns the 90s auth-health loop via a Prober interface; linear/poller.go is a thin wrapper, jira/poller.go keeps only its (jira-specific) issue-watch loop. - provideServices split into initGitHubService / initJiraService / initLinearService — now 75 lines (was ~125, exceeded the 80-line limit). Frontend: - New hooks/domains/integrations/use-integration-availability.ts and use-integration-enabled.ts; jira/linear hooks reduce to one-line delegates and move from components/<x>/ to hooks/domains/<x>/ per the project convention Greptile flagged on PR #736. - New components/integrations/{auth-status-banner,auth-error-message, validated-popover}.tsx; the four link/import-bar wrappers drop from ~110 lines to ~35 each, and JiraLinkButton picks up the clear-error-on-close behaviour LinearLinkButton already had. Docs: - New 'Adding a new third-party integration' section in CLAUDE.md/AGENTS.md documenting the shared shapes and intentional Jira/Linear divergence (transition vs state, JQL vs filter object, eventBus only on jira). * fix: address PR #759 review feedback - validated-popover: outline-with-label trigger now sets type="button" and honours triggerDisabled, matching ghost-icon (Greptile, Claude, CodeRabbit). - jira-link-button / linear-link-button: move updateTask() into the awaited fetch path so a failed title update surfaces as the popover's inline error instead of an unhandled rejection (CodeRabbit). - use-integration-availability: monotonic requestId race guard prevents a slow earlier probe from overwriting a newer auth result (CodeRabbit). - use-integration-enabled: drop unnecessary async on synchronous init (Claude). - jira/linear poller smoke tests: wrap in testing/synctest instead of time.After(2s) per backend testing convention (CodeRabbit nitpick). Skipped with reasoning on the threads: - secretadapter Set TOCTOU — single-process SQLite + single-writer per workspace; constraint violation on conflict surfaces as an error to the caller, not silent corruption. - healthpoll SetInterval validation — the function isn't called from production code today; a panic on misuse would be a footgun and silent ignore would just hide bugs differently. * fix: address PR #759 round-2 review feedback - jira-settings / linear-settings: drop the local STATUS_REFRESH_MS = 90_000 copies and import the shared INTEGRATION_STATUS_REFRESH_MS so changing the cadence only touches one file (Claude). - healthpoll: rename Poller.ProbeAll → probeAll. The only callers are the loop and the in-package tests, so widening the public API wasn't buying anything (Claude). * fix: invalidate ValidatedPopover in-flight submits on close If the user clicked Submit and dismissed the popover before the request settled, the next time they re-opened it would inherit `loading=true` (the disabled-while-loading submit button was stuck) and a late rejection from the previous session could repopulate `error` in the new one. Track the submit via a `useRef` token, bump it on close, and ignore any result/rejection whose token no longer matches. Also reset `loading` and `error` on close so the next open starts clean. Adds a regression test covering both the late-resolution and late-rejection paths. Addresses CodeRabbit review on PR #759. * ci: trigger workflow re-run GitHub Actions did not dispatch the pull_request workflows on the previous two pushes (1d869f0e,0ab6c034); only pull_request_target and CodeQL fired. Empty commit to nudge synchronize event. * fix: address PR #759 round-3 review feedback - jira.Poller.Stop: add nil-receiver guard so callers using the defer-Stop-after-NewPoller pattern don't panic when initJiraService returned nil (Greptile + Claude). Matches linear.Poller's guard. - healthpoll TestStart_RunsImmediateProbe + TestStart_IsIdempotent: rewrap in testing/synctest with synctest.Wait() instead of time.After(2s) wall-clock waits. Drops the now-unused probedAll signal channel from fakeProber (Claude). --------- Co-authored-by: Kandev Agent <agent@kandev.dev>
73 lines
2.4 KiB
Go
73 lines
2.4 KiB
Go
// Package secretadapter wraps a global secrets.SecretStore so per-integration
|
|
// services (jira, linear, future) can use a small, upsert-style API without
|
|
// each one re-implementing the Create-or-Update fallback or the
|
|
// "secret not found:" string-prefix check.
|
|
//
|
|
// A single Adapter satisfies any integration's local SecretStore interface
|
|
// shaped as { Reveal, Set, Delete, Exists } — Go's structural typing means
|
|
// callers don't need to import this package to consume the adapter.
|
|
package secretadapter
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
|
|
"github.com/kandev/kandev/internal/secrets"
|
|
)
|
|
|
|
// Adapter exposes upsert-style access on top of secrets.SecretStore.
|
|
type Adapter struct {
|
|
store secrets.SecretStore
|
|
}
|
|
|
|
// New returns an adapter backed by the given store.
|
|
func New(store secrets.SecretStore) *Adapter {
|
|
return &Adapter{store: store}
|
|
}
|
|
|
|
// Reveal returns the decrypted value for id.
|
|
func (a *Adapter) Reveal(ctx context.Context, id string) (string, error) {
|
|
return a.store.Reveal(ctx, id)
|
|
}
|
|
|
|
// Set upserts the secret value: tries Update first, falls back to Create
|
|
// when the secret does not yet exist.
|
|
func (a *Adapter) Set(ctx context.Context, id, name, value string) error {
|
|
// Detect existence via Exists (which inspects the "secret not found:"
|
|
// prefix) instead of treating any Get error as "not found": a transient
|
|
// DB error on an existing row would otherwise turn into a constraint-
|
|
// violation Create that masks the real cause.
|
|
exists, err := a.Exists(ctx, id)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if exists {
|
|
return a.store.Update(ctx, id, &secrets.UpdateSecretRequest{Value: &value})
|
|
}
|
|
return a.store.Create(ctx, &secrets.SecretWithValue{
|
|
Secret: secrets.Secret{ID: id, Name: name},
|
|
Value: value,
|
|
})
|
|
}
|
|
|
|
// Delete removes the secret with the given id.
|
|
func (a *Adapter) Delete(ctx context.Context, id string) error {
|
|
return a.store.Delete(ctx, id)
|
|
}
|
|
|
|
// Exists reports whether a secret with id exists. Returns (false, nil) when
|
|
// the row is absent, and (false, err) on any other error so callers can
|
|
// distinguish "not configured" from a backend outage.
|
|
func (a *Adapter) Exists(ctx context.Context, id string) (bool, error) {
|
|
_, err := a.store.Get(ctx, id)
|
|
if err != nil {
|
|
// secrets layer reports "not found" via fmt.Errorf with the
|
|
// "secret not found:" prefix; treat that as the absence case.
|
|
if strings.HasPrefix(err.Error(), "secret not found:") {
|
|
return false, nil
|
|
}
|
|
return false, err
|
|
}
|
|
return true, nil
|
|
}
|