Files
kandev/apps/backend/internal/plugins/runtime/main_test.go
T
João Salavisa 1ba81a7cd0 refactor(plugins): remove the unused tools feature (#1776)
Plugin `tools[]` overlapped with MCP, kandev's established mechanism for
exposing tools to agents (`internal/mcp/`), and the `InvokeTool` path was
never wired into agent tool sets — the `listTools` handler was
listing-only. Rather than maintain a half-built parallel surface, remove
it. If plugins ever contribute agent tools, they should feed through MCP,
not a separate `InvokeTool` RPC.

Removes:
- proto `InvokeTool` RPC + `ToolRequest`/`ToolResponse`/`ToolContext`
  messages (regenerated `*.pb.go` / `*_grpc.pb.go`)
- pkg/pluginsdk `InvokeTool` from the `Plugin` interface and
  `UnimplementedPlugin`, the Tool* Go-native types, and the
  `RemotePlugin`/`GRPCServer` dispatch
- internal/plugins `Service.InvokeTool`, the `listTools` handler +
  `GET /api/plugins/tools` route, `PluginToolDTO`, and the manifest
  `Tools` field + tool-name uniqueness validation
- frontend `PluginTool`/`PluginToolDTO` types, `listPluginTools`, and the
  manifest-card tools list
- fixture/e2e `InvokeTool` echo impl and the `tools:` manifest block

Test doubles that used the "crash" tool to exercise crash-restart now use
a "crash" webhook key instead. Internal specs (GRPC-CONTRACT, spec) drop
the tool RPC/feature; docs/public was already updated in #1774.

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-18 17:03:13 +01:00

69 lines
2.0 KiB
Go

package runtime
import (
"flag"
"fmt"
"os"
"os/exec"
"path/filepath"
goruntime "runtime"
"testing"
"go.uber.org/goleak"
)
// fixtureBinPath is the path to the real SDK-based plugin binary built by
// TestMain, used by the end-to-end tests in manager_test.go that exercise a
// real subprocess spawn/handshake/DeliverEvent/crash-restart
// cycle. Empty when tests run with -short (no real subprocess tests run in
// that mode).
var fixtureBinPath string
// TestMain builds testdata/fixtureplugin (a real pkg/pluginsdk-based plugin
// backend) once for the whole package's test run, then asserts no
// goroutines from this package (the supervision loops process.go spawns)
// outlive the test process. Building is skipped under -short, per
// apps/backend/AGENTS.md's guidance to reserve real subprocess execution
// for integration tests.
func TestMain(m *testing.M) {
flag.Parse()
if !testing.Short() {
binPath, err := buildFixturePlugin()
if err != nil {
fmt.Fprintln(os.Stderr, "runtime: building fixtureplugin:", err)
os.Exit(1)
}
fixtureBinPath = binPath
}
goleak.VerifyTestMain(m)
}
// buildFixturePlugin compiles testdata/fixtureplugin into a temp binary and
// returns its path. The temp dir is intentionally not cleaned up here:
// goleak.VerifyTestMain calls os.Exit internally, which would skip a
// deferred cleanup anyway; the OS/CI temp-dir lifecycle handles it.
func buildFixturePlugin() (string, error) {
dir, err := os.MkdirTemp("", "plugin-runtime-fixture-")
if err != nil {
return "", fmt.Errorf("create temp dir: %w", err)
}
binName := "fixtureplugin"
if goruntime.GOOS == "windows" {
binName += ".exe"
}
binPath := filepath.Join(dir, binName)
pkgDir, err := os.Getwd()
if err != nil {
return "", fmt.Errorf("getwd: %w", err)
}
cmd := exec.Command("go", "build", "-o", binPath, "./testdata/fixtureplugin")
cmd.Dir = pkgDir
if out, err := cmd.CombinedOutput(); err != nil {
return "", fmt.Errorf("go build fixtureplugin: %w: %s", err, out)
}
return binPath, nil
}