85aa3ac0aa
* feat(github): add /github page for PRs and issues Dedicated page under /github lists pull requests and issues across the authenticated user's repos with preset filters, custom GitHub search queries, per-repo narrowing, saved queries, and one-click task launching for any PR or issue. Performance: - Cache user PR/issue search responses for 30s with singleflight to coalesce concurrent misses, so preset switching and pagination avoid upstream round trips. - Replace the per-row PR status fetch (N+1) with a batch endpoint POST /api/v1/github/prs/statuses that fans out concurrently on the backend with a semaphore and caches per-PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on PR cache + status batching - Harden searchCacheKey against separator collisions from user-controllable customQuery (length-prefix encoding). - Drop repositories.loaded hydration when inner workspace fetch fails so the client refetches instead of trusting a partial snapshot. - Guard useGitHubSearch with a monotonic request counter to drop stale responses when filter+page changes overlap. - Fix usePRStatuses teardown: depend only on composed key so a new array identity per render doesn't cancel the in-flight batch. - Correct godocs (duplicate, outdated state:open claim). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address additional review feedback - Restore state:open for issue watcher: buildIssueSearchQuery no longer injects it as a default, so existing watches were starting to surface closed issues. Inject state:open in buildIssueFilter so only the watcher path is affected; the /github page presets already set their own state qualifiers. - countCheckResults now excludes in-progress checks from the denominator so a `1/3` badge reflects pass rate on completed checks, not a mix of running and failed. The pending state is still carried via ChecksState. - usePRStatuses retries after a transient fetch error (only mark the key as completed once the fetch resolves). This also fixes missing badges under React Strict Mode's intentional double-mount, since the first effect's cleanup fires before the response lands and the guard stays unset for the second mount to retry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(github): add tests for my-github hooks Covers use-committed-query, buildParams from use-github-search, use-saved-presets readStorage validation, use-known-repos recordForKey accumulator semantics, and use-pr-statuses batch fetch lifecycle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on search cache and repo accumulator - Clamp perPage before composing the search cache key so identical pages (e.g. perPage=150 and =100) share a cache entry instead of creating duplicates keyed on the raw value. - Add resetKnownReposStore and call it on /github unmount so the module-level repo accumulator doesn't carry across navigations. - Rename use-pr-statuses test to match its assertion (it verifies stale statuses are cleared when the key changes and fetch fails). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(web): distinguish blocked from dirty in PR mergeable badge GitHub's blocked state (required reviews/checks/branch protection) is not a merge conflict, so don't label it "Conflicts". Surface it as "Blocked" with the pending tone; keep "Conflicts" for dirty. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: address remaining /github code review comments - Route PR status + batch through handleSearchError so ErrNoClient surfaces as 503 instead of 500 (matches the search endpoints). - Sort workflow steps by position in the quick-task-launcher default pick, matching the convention in issue-watch-dialog. - Make PresetItem keyboard-accessible: role=button, tabIndex, and Enter/Space handling on the wrapping div (it contains a nested delete button, so it can't itself be a button). - Extract useRepoOptions out of useGitHubPageState to bring the hook back under the 100-line complexity limit. - Honor ctx.Done() when acquiring the PR-status batch semaphore so a cancelled HTTP request releases queued goroutines instead of running each upstream fetch to completion. - Clarify parsePaginationQuery doc: the upper bound (100) is enforced by clampSearchPage in the client layer, not here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): address /github review follow-ups - Merge duplicate @/lib/utils imports in pr-list. - Use rel="noopener noreferrer" on external PR/issue links (codebase convention) and add cursor-pointer per the UI guidelines. - Rewrite onOpenSaveDialog as an explicit if-block so the callback returns void rather than boolean | void. - Use PaginationEllipsis in its own PaginationItem so the ellipsis and the adjacent page link are separate list items instead of visually fused into a single cell. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(web): derive QuickTaskLauncher dialog state from props Replaces the useEffect+setState anti-pattern with useMemo-derived state driven directly by the payload prop. Drops the eslint suppression that was needed for react-hooks/set-state-in-effect. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
131 lines
4.1 KiB
TypeScript
131 lines
4.1 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
import { act, renderHook, waitFor } from "@testing-library/react";
|
|
import type { GitHubPR, GitHubPRStatus } from "@/lib/types/github";
|
|
|
|
const getPRStatusesBatch = vi.fn();
|
|
|
|
vi.mock("@/lib/api/domains/github-api", () => ({
|
|
getPRStatusesBatch: (refs: { owner: string; repo: string; number: number }[]) =>
|
|
getPRStatusesBatch(refs) as Promise<{ statuses: Record<string, GitHubPRStatus> }>,
|
|
}));
|
|
|
|
import { prStatusKey, usePRStatuses } from "./use-pr-statuses";
|
|
|
|
function makePR(owner: string, repo: string, number: number): GitHubPR {
|
|
return {
|
|
number,
|
|
title: `PR #${number}`,
|
|
url: "",
|
|
html_url: "",
|
|
state: "open",
|
|
head_branch: "feat",
|
|
base_branch: "main",
|
|
author_login: "u",
|
|
repo_owner: owner,
|
|
repo_name: repo,
|
|
draft: false,
|
|
mergeable: true,
|
|
additions: 0,
|
|
deletions: 0,
|
|
requested_reviewers: [],
|
|
created_at: "",
|
|
updated_at: "",
|
|
merged_at: null,
|
|
closed_at: null,
|
|
};
|
|
}
|
|
|
|
function makeStatus(pr: GitHubPR): GitHubPRStatus {
|
|
return {
|
|
pr,
|
|
review_state: "",
|
|
checks_state: "",
|
|
mergeable_state: "unknown",
|
|
review_count: 0,
|
|
pending_review_count: 0,
|
|
checks_total: 0,
|
|
checks_passing: 0,
|
|
} as GitHubPRStatus;
|
|
}
|
|
|
|
describe("prStatusKey", () => {
|
|
it("encodes owner/repo#number", () => {
|
|
expect(prStatusKey("acme", "widget", 7)).toBe("acme/widget#7");
|
|
});
|
|
});
|
|
|
|
describe("usePRStatuses", () => {
|
|
beforeEach(() => {
|
|
getPRStatusesBatch.mockReset();
|
|
});
|
|
|
|
it("skips fetch when prs list is empty", () => {
|
|
renderHook(() => usePRStatuses([]));
|
|
expect(getPRStatusesBatch).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("fetches and populates map keyed by prStatusKey", async () => {
|
|
const pr = makePR("acme", "widget", 7);
|
|
getPRStatusesBatch.mockResolvedValueOnce({
|
|
statuses: { "acme/widget#7": makeStatus(pr) },
|
|
});
|
|
const { result } = renderHook(() => usePRStatuses([pr]));
|
|
await waitFor(() => {
|
|
expect(result.current.size).toBe(1);
|
|
});
|
|
expect(result.current.get("acme/widget#7")?.pr.number).toBe(7);
|
|
});
|
|
|
|
it("does not refetch when list identity changes but key stays the same", async () => {
|
|
const pr = makePR("acme", "widget", 7);
|
|
getPRStatusesBatch.mockResolvedValue({
|
|
statuses: { "acme/widget#7": makeStatus(pr) },
|
|
});
|
|
const { rerender, result } = renderHook(({ prs }) => usePRStatuses(prs), {
|
|
initialProps: { prs: [pr] },
|
|
});
|
|
await waitFor(() => expect(result.current.size).toBe(1));
|
|
expect(getPRStatusesBatch).toHaveBeenCalledTimes(1);
|
|
|
|
// New array reference, same content.
|
|
rerender({ prs: [makePR("acme", "widget", 7)] });
|
|
// Give effects a tick.
|
|
await act(async () => {
|
|
await Promise.resolve();
|
|
});
|
|
expect(getPRStatusesBatch).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("refetches when the list key changes", async () => {
|
|
const pr1 = makePR("acme", "widget", 7);
|
|
const pr2 = makePR("acme", "widget", 8);
|
|
getPRStatusesBatch.mockResolvedValue({
|
|
statuses: { "acme/widget#7": makeStatus(pr1), "acme/widget#8": makeStatus(pr2) },
|
|
});
|
|
const { rerender } = renderHook(({ prs }) => usePRStatuses(prs), {
|
|
initialProps: { prs: [pr1] },
|
|
});
|
|
await waitFor(() => expect(getPRStatusesBatch).toHaveBeenCalledTimes(1));
|
|
rerender({ prs: [pr1, pr2] });
|
|
await waitFor(() => expect(getPRStatusesBatch).toHaveBeenCalledTimes(2));
|
|
});
|
|
|
|
it("clears stale statuses when key changes and fetch fails", async () => {
|
|
const pr = makePR("acme", "widget", 7);
|
|
getPRStatusesBatch.mockResolvedValueOnce({
|
|
statuses: { "acme/widget#7": makeStatus(pr) },
|
|
});
|
|
const { result, rerender } = renderHook(({ prs }) => usePRStatuses(prs), {
|
|
initialProps: { prs: [pr] },
|
|
});
|
|
await waitFor(() => expect(result.current.size).toBe(1));
|
|
|
|
// New key, then fetch rejects: the stale badges from pr #7 belong to the
|
|
// old key and would be misleading, so the catch handler clears them.
|
|
const pr2 = makePR("acme", "widget", 8);
|
|
getPRStatusesBatch.mockRejectedValueOnce(new Error("boom"));
|
|
rerender({ prs: [pr2] });
|
|
await waitFor(() => expect(result.current.size).toBe(0));
|
|
});
|
|
});
|