Files
kandev/apps/web/components/task/chat/pr-archive-banners.test.tsx
T
João Salavisa f7d8d5d603 fix(web): confirm before archiving from PR merged/closed banners (#1619)
* fix(web): require confirmation before archiving from PR merged/closed banners

The Archive link in the PR merged/closed status-bar banners archived the
task immediately, unlike every other archive surface. Route it through the
shared TaskArchiveConfirmDialog (cleanup summary + subtask cascade), and
move the banners into pr-archive-banners.tsx since chat-input-area.tsx was
over the file-size lint limit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(web): cover cascade passthrough in banner archive confirmation

Review follow-up: the subtask cascade checkbox is an acceptance criterion
for the banner archive flow, but tests only asserted cascade: false.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(e2e): verify cancel path of PR banner archive confirmation

QA follow-up: exercise the dialog cancel path in a real browser — cancel
must close the dialog, keep the banner, and archive nothing.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(web): expose pending state on banner archive confirmation

Thread isPending from useBannerArchiveConfirm into
TaskArchiveConfirmDialog as isArchiving, matching the other archive
surfaces. Guards double-submit when the dialog is reopened while an
archive is still in flight on a slow connection.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(e2e): scope archive-cancel click to the alertdialog

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-08 12:14:01 +01:00

184 lines
6.3 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
const archiveAndSwitchMock = vi.fn();
const toastMock = vi.fn();
const mockGetSubtaskCount = vi.fn();
const taskPRsByTaskId = vi.hoisted(() => ({
value: {
"task-1": [{ pr_number: 42, state: "merged" }],
} as Record<string, Array<{ pr_number: number; state: string }>>,
}));
const mockState = {
taskPRs: {
get byTaskId() {
return taskPRsByTaskId.value;
},
},
kanban: {
tasks: [{ id: "task-1", title: "Task One", primaryExecutorType: "worktree" }],
},
kanbanMulti: { snapshots: {} },
};
vi.mock("@/components/state-provider", () => ({
useAppStore: (selector: (state: typeof mockState) => unknown) => selector(mockState),
useAppStoreApi: () => ({ getState: () => mockState }),
}));
vi.mock("@/hooks/use-task-actions", () => ({
useArchiveAndSwitchTask: () => archiveAndSwitchMock,
}));
vi.mock("@/components/toast-provider", () => ({
useToast: () => ({ toast: toastMock }),
}));
vi.mock("@/lib/api", () => ({
getSubtaskCount: (...args: unknown[]) => mockGetSubtaskCount(...args),
}));
vi.mock("@/lib/local-storage", async (importOriginal) => ({
...(await importOriginal<typeof import("@/lib/local-storage")>()),
markPRClosedBannerDismissed: vi.fn(),
markPRMergedBannerDismissed: vi.fn(),
wasPRClosedBannerDismissed: () => false,
wasPRMergedBannerDismissed: () => false,
}));
import { PRClosedBanner, PRMergedBanner } from "./pr-archive-banners";
const MERGED_ARCHIVE_BUTTON = "pr-merged-archive-button";
const MERGED_ARCHIVE_CONFIRM = "pr-merged-archive-confirm";
beforeEach(() => {
archiveAndSwitchMock.mockResolvedValue(undefined);
mockGetSubtaskCount.mockResolvedValue({ count: 0 });
taskPRsByTaskId.value = {
"task-1": [{ pr_number: 42, state: "merged" }],
};
});
afterEach(() => {
cleanup();
vi.restoreAllMocks();
vi.clearAllMocks();
});
describe("PRMergedBanner", () => {
it("opens the confirmation dialog instead of archiving directly", async () => {
render(<PRMergedBanner taskId="task-1" />);
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
expect(await screen.findByTestId(MERGED_ARCHIVE_CONFIRM)).toBeTruthy();
expect(screen.getByText(/Are you sure you want to archive "Task One"\?/)).toBeTruthy();
expect(archiveAndSwitchMock).not.toHaveBeenCalled();
});
it("archives after confirming, without a success toast", async () => {
render(<PRMergedBanner taskId="task-1" />);
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
fireEvent.click(await screen.findByTestId(MERGED_ARCHIVE_CONFIRM));
await waitFor(() =>
expect(archiveAndSwitchMock).toHaveBeenCalledWith("task-1", { cascade: false }),
);
expect(toastMock).not.toHaveBeenCalled();
});
it("does not archive when the dialog is cancelled", async () => {
render(<PRMergedBanner taskId="task-1" />);
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
fireEvent.click(await screen.findByText("Cancel"));
await waitFor(() => expect(screen.queryByTestId(MERGED_ARCHIVE_CONFIRM)).toBeNull());
expect(archiveAndSwitchMock).not.toHaveBeenCalled();
expect(screen.getByTestId("pr-merged-banner")).toBeTruthy();
});
it("keeps the failure toast when archive fails", async () => {
archiveAndSwitchMock.mockRejectedValueOnce(new Error("archive failed"));
render(<PRMergedBanner taskId="task-1" />);
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
fireEvent.click(await screen.findByTestId(MERGED_ARCHIVE_CONFIRM));
await waitFor(() =>
expect(toastMock).toHaveBeenCalledWith({
description: "Failed to archive task",
variant: "error",
}),
);
});
it("passes cascade=true through when the subtask checkbox is ticked", async () => {
mockGetSubtaskCount.mockResolvedValue({ count: 2 });
render(<PRMergedBanner taskId="task-1" />);
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
fireEvent.click(await screen.findByTestId("archive-cascade-checkbox"));
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_CONFIRM));
await waitFor(() =>
expect(archiveAndSwitchMock).toHaveBeenCalledWith("task-1", { cascade: true }),
);
});
it("disables the confirm button while an archive is in flight", async () => {
let resolveArchive: () => void = () => {};
archiveAndSwitchMock.mockImplementation(
() => new Promise<void>((resolve) => (resolveArchive = resolve)),
);
render(<PRMergedBanner taskId="task-1" />);
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
fireEvent.click(await screen.findByTestId(MERGED_ARCHIVE_CONFIRM));
await waitFor(() => expect(archiveAndSwitchMock).toHaveBeenCalledTimes(1));
// Reopen while the async archive is still pending: confirm must be disabled.
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
const confirm = await screen.findByTestId<HTMLButtonElement>(MERGED_ARCHIVE_CONFIRM);
expect(confirm.disabled).toBe(true);
fireEvent.click(confirm);
expect(archiveAndSwitchMock).toHaveBeenCalledTimes(1);
resolveArchive();
await waitFor(() =>
expect(screen.getByTestId<HTMLButtonElement>(MERGED_ARCHIVE_CONFIRM).disabled).toBe(false),
);
});
it("falls back to a generic title when the task is not in the store", async () => {
taskPRsByTaskId.value = {
"task-2": [{ pr_number: 7, state: "merged" }],
};
render(<PRMergedBanner taskId="task-2" />);
fireEvent.click(screen.getByTestId(MERGED_ARCHIVE_BUTTON));
expect(await screen.findByTestId(MERGED_ARCHIVE_CONFIRM)).toBeTruthy();
expect(screen.getByText(/Are you sure you want to archive "this task"\?/)).toBeTruthy();
});
});
describe("PRClosedBanner", () => {
it("archives through the confirmation dialog", async () => {
taskPRsByTaskId.value = {
"task-1": [{ pr_number: 42, state: "closed" }],
};
render(<PRClosedBanner taskId="task-1" />);
fireEvent.click(screen.getByTestId("pr-closed-archive-button"));
expect(archiveAndSwitchMock).not.toHaveBeenCalled();
fireEvent.click(await screen.findByTestId("pr-closed-archive-confirm"));
await waitFor(() =>
expect(archiveAndSwitchMock).toHaveBeenCalledWith("task-1", { cascade: false }),
);
});
});