f5dc6e2322
* fix: persist task create last-used selections Record final task-create selections server-side. Make dialog restore wait for backend settings before localStorage fallback. Update pinned-action verification tests and split dockview rendering for lint. * fix: address task create PR feedback * fix: resolve task create review follow-ups * test: cover task create service recording * fix: address task create review regressions * fix: avoid recording generated fresh branches * fix: skip repo-only last-used task records * fix: make task create settings updates atomic * fix: clear stale task create cache * fix: clear synced task create overlay * fix: address task create review feedback * fix: queue cached repository autopick * fix: preserve partial task create settings * fix: replace task create queued overlay * fix: clear branch when recording repository * test: cover task create queued payload * test: remove unused user service helper --------- Co-authored-by: root <root@kandev.ts.net>
326 lines
11 KiB
TypeScript
326 lines
11 KiB
TypeScript
"use client";
|
|
|
|
import { useCallback } from "react";
|
|
import type { Repository } from "@/lib/types/http";
|
|
import type { DialogFormState, TaskRepoRow } from "@/components/task-create-dialog-types";
|
|
import { removeLocalStorage, setLocalStorage } from "@/lib/local-storage";
|
|
import { STORAGE_KEYS } from "@/lib/settings/constants";
|
|
import { createDebugLogger } from "@/lib/debug/log";
|
|
import type { TaskCreateLastUsedState } from "@/lib/state/slices/settings/types";
|
|
|
|
type TaskCreateLastUsedPatch = {
|
|
repository_id?: string | null;
|
|
branch?: string | null;
|
|
agent_profile_id?: string | null;
|
|
executor_profile_id?: string | null;
|
|
};
|
|
|
|
type TaskCreateLastUsedPayload = {
|
|
repositories?: Array<{
|
|
repository_id?: string;
|
|
base_branch?: string;
|
|
checkout_branch?: string;
|
|
fresh_branch?: boolean;
|
|
}>;
|
|
agent_profile_id?: string;
|
|
executor_profile_id?: string;
|
|
};
|
|
|
|
let lastQueuedLastUsed: Partial<TaskCreateLastUsedState> = {};
|
|
const LOCAL_STORAGE_WRITE_EVENT = "localStorage-write";
|
|
const lastUsedDebug = createDebugLogger("task-create:last-used");
|
|
|
|
/**
|
|
* Clears task-create last-used overlay state.
|
|
* Pass `clearQueued` when test setup or teardown should also wipe the queued
|
|
* overlay that protects settings fetches from stale server values.
|
|
*/
|
|
export function resetTaskCreateLastUsedSync(
|
|
options: {
|
|
clearQueued?: boolean;
|
|
syncedSettings?: TaskCreateLastUsedState | null | undefined;
|
|
} = {},
|
|
) {
|
|
if (options.clearQueued) {
|
|
lastQueuedLastUsed = {};
|
|
} else if (taskCreateLastUsedSettingsMatchQueue(options.syncedSettings)) {
|
|
lastQueuedLastUsed = {};
|
|
}
|
|
lastUsedDebug("overlay-reset");
|
|
}
|
|
|
|
export function readQueuedTaskCreateLastUsedState(): Partial<TaskCreateLastUsedState> {
|
|
return lastQueuedLastUsed;
|
|
}
|
|
|
|
export function clearQueuedTaskCreateLastUsedIfSynced(
|
|
settings: TaskCreateLastUsedState | null | undefined,
|
|
) {
|
|
if (!hasQueuedTaskCreateLastUsed()) return;
|
|
if (!taskCreateLastUsedSettingsMatchQueue(settings)) return;
|
|
lastQueuedLastUsed = {};
|
|
lastUsedDebug("overlay-cleared-after-settings-sync");
|
|
}
|
|
|
|
function hasQueuedTaskCreateLastUsed() {
|
|
return Object.values(lastQueuedLastUsed).some((value) => value !== undefined);
|
|
}
|
|
|
|
function taskCreateLastUsedSettingsMatchQueue(
|
|
settings: TaskCreateLastUsedState | null | undefined,
|
|
) {
|
|
return Object.entries(lastQueuedLastUsed).every(([key, value]) => {
|
|
if (value === undefined) return true;
|
|
return settings?.[key as keyof TaskCreateLastUsedState] === value;
|
|
});
|
|
}
|
|
|
|
function mapTaskCreateLastUsedPatch(
|
|
pending: TaskCreateLastUsedPatch,
|
|
): Partial<TaskCreateLastUsedState> {
|
|
return {
|
|
repositoryId: pending.repository_id,
|
|
branch: pending.branch,
|
|
agentProfileId: pending.agent_profile_id,
|
|
executorProfileId: pending.executor_profile_id,
|
|
};
|
|
}
|
|
|
|
function compactTaskCreateLastUsedState(state: Partial<TaskCreateLastUsedState>) {
|
|
return Object.fromEntries(
|
|
Object.entries(state).filter(([, value]) => value !== undefined),
|
|
) as Partial<TaskCreateLastUsedState>;
|
|
}
|
|
|
|
export function syncTaskCreateLastUsed(patch: TaskCreateLastUsedPatch) {
|
|
lastQueuedLastUsed = {
|
|
...lastQueuedLastUsed,
|
|
...compactTaskCreateLastUsedState(mapTaskCreateLastUsedPatch(patch)),
|
|
};
|
|
lastUsedDebug("overlay-updated", { patch, queued: lastQueuedLastUsed });
|
|
}
|
|
|
|
export function replaceQueuedTaskCreateLastUsed(patch: TaskCreateLastUsedPatch) {
|
|
lastQueuedLastUsed = compactTaskCreateLastUsedState(mapTaskCreateLastUsedPatch(patch));
|
|
lastUsedDebug("overlay-replaced", { patch, queued: lastQueuedLastUsed });
|
|
}
|
|
|
|
export function queueTaskCreateLastUsedFromPayload(
|
|
payload: TaskCreateLastUsedPayload | null | undefined,
|
|
) {
|
|
if (!payload) return;
|
|
const firstWorkspaceRepo = payload.repositories?.find((repo) => repo.repository_id);
|
|
replaceQueuedTaskCreateLastUsed({
|
|
repository_id: firstWorkspaceRepo?.repository_id,
|
|
branch: firstWorkspaceRepo ? taskCreateLastUsedPayloadBranch(firstWorkspaceRepo) : undefined,
|
|
agent_profile_id: payload.agent_profile_id,
|
|
executor_profile_id: payload.executor_profile_id,
|
|
});
|
|
}
|
|
|
|
function taskCreateLastUsedPayloadBranch(
|
|
repo: NonNullable<TaskCreateLastUsedPayload["repositories"]>[number],
|
|
) {
|
|
if (repo.fresh_branch) return firstNonEmpty(repo.base_branch, repo.checkout_branch);
|
|
return firstNonEmpty(repo.checkout_branch, repo.base_branch);
|
|
}
|
|
|
|
function firstNonEmpty(...values: Array<string | undefined>) {
|
|
return values.find((value) => value) ?? undefined;
|
|
}
|
|
|
|
/**
|
|
* Centralizes form-field change handlers for the task-create dialog.
|
|
*
|
|
* The dialog stores all repos in a single `fs.repositories` list (no
|
|
* "primary vs extras" split), so per-row handlers are uniform: changing
|
|
* a repo on row N is the same op whether N==0 or N==5.
|
|
*
|
|
* Fresh-branch (local-executor opt-in: discard local changes and start on
|
|
* a new branch) is a separate concern that lives alongside.
|
|
*/
|
|
function clearFreshBranch(fs: DialogFormState) {
|
|
fs.setFreshBranchEnabled(false);
|
|
fs.setCurrentLocalBranch("");
|
|
// Set loading=true synchronously alongside the clear so the chip's
|
|
// autoselect effect (which runs bottom-up before useCurrentLocalBranchEffect
|
|
// can re-fire and set loading itself) sees the gate and skips. Otherwise
|
|
// the autoselect lands a last-used / preferred-default branch in row.branch
|
|
// before currentLocalBranch resolves, then the prefix logic computes
|
|
// "will switch to: master" instead of "current: master".
|
|
fs.setCurrentLocalBranchLoading(true);
|
|
}
|
|
|
|
function useRepositoryHandlers(fs: DialogFormState, repositories: Repository[]) {
|
|
/**
|
|
* Resolves a picker value into the right shape for a row:
|
|
* - If it matches a workspace repo id → `{ repositoryId, localPath: undefined }`.
|
|
* - Otherwise treat as a discovered on-machine path → `{ localPath, repositoryId: undefined }`.
|
|
* The branch is reset because the previous branch may not exist on the new repo.
|
|
*/
|
|
const handleRowRepositoryChange = useCallback(
|
|
(key: string, value: string) => {
|
|
const isWorkspaceRepo = repositories.some((r: Repository) => r.id === value);
|
|
const patch: Partial<TaskRepoRow> = isWorkspaceRepo
|
|
? { repositoryId: value, localPath: undefined, branch: "" }
|
|
: { repositoryId: undefined, localPath: value, branch: "" };
|
|
fs.updateRepository(key, patch);
|
|
if (isWorkspaceRepo) {
|
|
setLocalStorage(STORAGE_KEYS.LAST_REPOSITORY_ID, value);
|
|
removeLocalStorage(STORAGE_KEYS.LAST_BRANCH);
|
|
syncTaskCreateLastUsed({ repository_id: value, branch: null });
|
|
lastUsedDebug(LOCAL_STORAGE_WRITE_EVENT, {
|
|
key: "lastRepositoryId",
|
|
value,
|
|
row_key: key,
|
|
});
|
|
} else {
|
|
removeLocalStorage(STORAGE_KEYS.LAST_REPOSITORY_ID);
|
|
removeLocalStorage(STORAGE_KEYS.LAST_BRANCH);
|
|
syncTaskCreateLastUsed({ repository_id: null, branch: null });
|
|
}
|
|
// Switching the repo invalidates whatever local-status the fresh-branch
|
|
// panel had cached.
|
|
clearFreshBranch(fs);
|
|
},
|
|
[repositories, fs],
|
|
);
|
|
|
|
const handleRowBranchChange = useCallback(
|
|
(key: string, value: string) => {
|
|
fs.updateRepository(key, { branch: value });
|
|
setLocalStorage(STORAGE_KEYS.LAST_BRANCH, value);
|
|
syncTaskCreateLastUsed({ branch: value });
|
|
lastUsedDebug(LOCAL_STORAGE_WRITE_EVENT, { key: "lastBranch", value, row_key: key });
|
|
},
|
|
[fs],
|
|
);
|
|
|
|
return { handleRowRepositoryChange, handleRowBranchChange };
|
|
}
|
|
|
|
function useProfileAndNameHandlers(fs: DialogFormState) {
|
|
const handleAgentProfileChange = useCallback(
|
|
(value: string) => {
|
|
fs.setAgentProfileId(value);
|
|
setLocalStorage(STORAGE_KEYS.LAST_AGENT_PROFILE_ID, value);
|
|
syncTaskCreateLastUsed({ agent_profile_id: value });
|
|
lastUsedDebug(LOCAL_STORAGE_WRITE_EVENT, { key: "lastAgentProfileId", value });
|
|
},
|
|
[fs],
|
|
);
|
|
const handleExecutorProfileChange = useCallback(
|
|
(value: string) => {
|
|
fs.setExecutorProfileId(value);
|
|
setLocalStorage(STORAGE_KEYS.LAST_EXECUTOR_PROFILE_ID, value);
|
|
syncTaskCreateLastUsed({ executor_profile_id: value });
|
|
lastUsedDebug(LOCAL_STORAGE_WRITE_EVENT, { key: "lastExecutorProfileId", value });
|
|
},
|
|
[fs],
|
|
);
|
|
const handleTaskNameChange = useCallback(
|
|
(value: string) => {
|
|
fs.setTaskName(value);
|
|
fs.setHasTitle(value.trim().length > 0);
|
|
},
|
|
[fs],
|
|
);
|
|
const handleWorkflowChange = useCallback(
|
|
(value: string) => fs.setSelectedWorkflowId(value),
|
|
[fs],
|
|
);
|
|
return {
|
|
handleAgentProfileChange,
|
|
handleExecutorProfileChange,
|
|
handleTaskNameChange,
|
|
handleWorkflowChange,
|
|
};
|
|
}
|
|
|
|
function useGitHubAndFreshBranchHandlers(fs: DialogFormState) {
|
|
/**
|
|
* Toggles between "repo chips" mode and "GitHub Remote (URL)" mode. URL mode
|
|
* replaces the chip row with a URL input; flipping back leaves
|
|
* `remoteRepos` alone (toggle-back is non-destructive — Task 4 spec). The
|
|
* seed effect in state.ts inserts a single empty row on the first toggle
|
|
* into Remote mode.
|
|
*/
|
|
const handleToggleRemote = useCallback(() => {
|
|
const next = !fs.useRemote;
|
|
fs.setUseRemote(next);
|
|
fs.setGitHubUrlError(null);
|
|
// Remote and no-repository are mutually exclusive source modes. Without
|
|
// this, the user could land on both true at once (toggle no-repo on, then
|
|
// toggle Remote on) and the submit gate's mode-aware checks would produce
|
|
// confusing results. Mirror the no-repo handler which already clears
|
|
// useRemote when flipping the other way.
|
|
if (next) {
|
|
fs.setNoRepository(false);
|
|
removeLocalStorage(STORAGE_KEYS.LAST_REPOSITORY_ID);
|
|
removeLocalStorage(STORAGE_KEYS.LAST_BRANCH);
|
|
syncTaskCreateLastUsed({ repository_id: null, branch: null });
|
|
}
|
|
clearFreshBranch(fs);
|
|
}, [fs]);
|
|
|
|
const handleToggleFreshBranch = useCallback(
|
|
(enabled: boolean) => {
|
|
fs.setFreshBranchEnabled(enabled);
|
|
// Clearing fs.repositories[].branch on toggle would force a re-pick from
|
|
// the per-row branch list; for simplicity leave whatever the user picked.
|
|
// The submit path re-validates anyway.
|
|
},
|
|
[fs],
|
|
);
|
|
|
|
/**
|
|
* Toggles "no repository" mode. Replaces the chip row with a folder picker.
|
|
* Clears the URL-mode flag and the workspace_path so flipping back returns
|
|
* the user to a clean slate (the remoteRepos array itself is preserved).
|
|
*/
|
|
const handleToggleNoRepository = useCallback(() => {
|
|
const next = !fs.noRepository;
|
|
fs.setNoRepository(next);
|
|
if (next) {
|
|
fs.setUseRemote(false);
|
|
// Clear the executor selection so the auto-fill effect re-picks a
|
|
// non-worktree default (worktree is unworkable in no-repo mode).
|
|
fs.setExecutorId("");
|
|
fs.setExecutorProfileId("");
|
|
removeLocalStorage(STORAGE_KEYS.LAST_EXECUTOR_PROFILE_ID);
|
|
syncTaskCreateLastUsed({
|
|
repository_id: null,
|
|
branch: null,
|
|
executor_profile_id: null,
|
|
});
|
|
} else {
|
|
fs.setWorkspacePath("");
|
|
}
|
|
}, [fs]);
|
|
|
|
const handleWorkspacePathChange = useCallback(
|
|
(value: string) => {
|
|
fs.setWorkspacePath(value);
|
|
},
|
|
[fs],
|
|
);
|
|
|
|
return {
|
|
handleToggleRemote,
|
|
handleToggleFreshBranch,
|
|
handleToggleNoRepository,
|
|
handleWorkspacePathChange,
|
|
};
|
|
}
|
|
|
|
export function useDialogHandlers(fs: DialogFormState, repositories: Repository[]) {
|
|
const repo = useRepositoryHandlers(fs, repositories);
|
|
const profile = useProfileAndNameHandlers(fs);
|
|
const gh = useGitHubAndFreshBranchHandlers(fs);
|
|
return {
|
|
...repo,
|
|
...profile,
|
|
...gh,
|
|
};
|
|
}
|