6.2 KiB
6.2 KiB
id, title, status, wave, depends_on, plan, requirements, acceptance_criteria, system_design
| id | title | status | wave | depends_on | plan | requirements | acceptance_criteria | system_design | |||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 01-bound-dependency-tree-status-enumeration | Bound dependency-tree status enumeration | complete | 1 | plan.md |
|
|
|
Task 01: Bound Dependency-Tree Status Enumeration
Summary
Exclude untracked node_modules trees in Git before agentctl receives individual dependency paths. Preserve tracked changes and ordinary untracked files, and use the same policy for full snapshots and monitor fingerprints.
In scope
- Add the browser and process regressions before production changes.
- Add one shared NUL-separated untracked Git query with the
node_modules/exclusion. - Split full status into tracked porcelain collection and eligible untracked collection.
- Apply the shared untracked query to monitor fingerprinting.
- Preserve all existing status, diff, cancellation, admission, and payload contracts outside this exclusion.
Out of scope
- Other generated directory names.
- Frontend filtering or presentation changes.
- Git ignore-file creation or modification.
- Status schema, route, or WebSocket changes.
Acceptance
- Untracked top-level and nested
node_modulesfiles do not enter a status snapshot, synthetic diff work, or the monitor fingerprint when no ignore rule exists. - Tracked changes below
node_modulesand ordinary untracked files remain visible with their established metadata and diffs. - The Chromium Changes regression shows the ordinary untracked file and no dependency-tree path from the same completed snapshot.
Verification
If apps/node_modules is absent, run the workspace install once before the E2E or frontend lint command.
cd apps
rtk pnpm install --frozen-lockfile
cd backend
rtk go test ./internal/agentctl/server/process -run 'Test(GetGitStatus_ExcludesUntrackedNodeModules|GetGitStatus_PreservesTrackedNodeModules|GetUntrackedFilesID_ExcludesNodeModules|GetGitStatus_UsesConsistentIndexSnapshotAcrossTransitions|ParseGitUntrackedOutput|SnapshotGitIndex.*)$'
rtk go test ./internal/agentctl/server/process -run 'Test(GetGitStatus_UntrackedFileWithSpaces|EnrichUntrackedFileDiffs|DiffBudget)'
rtk go test -race ./internal/agentctl/server/process
cd ../web
rtk pnpm e2e:run tests/git/git-changes-panel.spec.ts -- --grep "omits untracked node_modules before repository ignore exists"
cd ../..
rtk make -C apps/backend fmt
rtk make -C apps/backend test
rtk make -C apps/backend lint
rtk pnpm --dir apps --filter @kandev/web lint
rtk git diff --check
During RED, run the focused Go command and the focused Chromium command after adding their tests. Confirm both fail against the current implementation before changing production code. The final report must contain the later GREEN results.
Files likely touched
apps/backend/internal/agentctl/server/process/workspace_git_untracked.goapps/backend/internal/agentctl/server/process/workspace_git_index.goapps/backend/internal/agentctl/server/process/workspace_git_status.goapps/backend/internal/agentctl/server/process/workspace_git_status_test.goapps/backend/internal/agentctl/server/process/workspace_monitor.goapps/backend/internal/agentctl/server/process/workspace_monitor_test.goapps/web/e2e/tests/git/git-changes-panel.spec.ts
Dependencies
None.
Risks
- Passing the exclusion to tracked status collection can hide valid tracked changes.
- Reusing line parsing for untracked output can mishandle filenames with embedded newlines.
- Different argument lists in the observer and monitor can reintroduce repeated dependency scans.
- The extra full-status Git command must not lose the current observation class or cancellation behavior.
Parallelism
sequential
Inputs
REQ-PLATFORM-WORKSPACE-GIT-STATUS-001, especially acceptance criteria .6, .8, and .13 through .15.docs/specs/platform/system-design/workspace-git-status.md, sectionGenerated untracked dependency trees.docs/decisions/2026-08-30-bound-untracked-dependency-enumeration.md.- Existing path, cancellation, diff-budget, and interactive-admission tests in the process package.
- Existing untracked-file Changes coverage in
apps/web/e2e/tests/git/git-changes-panel.spec.ts.
Results
- RED process run:
TestGetGitStatus_ExcludesUntrackedNodeModulesandTestGetUntrackedFilesID_ExcludesNodeModulesfailed against the prior implementation because dependency paths entered status and changed the monitor fingerprint.TestGetGitStatus_PreservesTrackedNodeModulespassed, protecting the tracked-path contract. - RED Chromium run:
omits untracked node_modules before repository ignore existsfailed at the intended assertion because one dependency row was visible. - GREEN focused process run: all three new tests passed.
- GREEN tracking-transition process run:
TestGetGitStatus_UsesConsistentIndexSnapshotAcrossTransitionspassed for both untracked-to-staged and tracked-to-untracked interleavings. - GREEN parser and index-lifecycle process run:
TestParseGitUntrackedOutputcovered NUL-separated paths with embedded newlines and cancellation;TestSnapshotGitIndex*covered cleanup, cancellation/error cleanup, and linked-worktree Git directories. - GREEN existing regressions: the untracked-space, enrichment, and diff-budget tests passed (9 tests).
- GREEN race run:
go test -race ./internal/agentctl/server/processpassed, covering 737 tests. - GREEN Chromium run:
omits untracked node_modules before repository ignore existspassed (1 test). make -C apps/backend fmt, backend lint (0 issues), web lint, andgit diff --checkpassed.- The first ambient backend suite run selected
/root/.kandev/config.yamlthrough inheritedKANDEV_INTERNAL_CONFIG_FILEandKANDEV_INTERNAL_CONFIG_HOME_FILEvalues. The isolated rerun with both variables unset passed the complete backend suite. - PR fixup remediation: full status now runs both queries against a temporary stable Git-index snapshot, and E2E cleanup derives dependency directories from
dependencyPaths.