5.7 KiB
5.7 KiB
id, title, status, wave, depends_on, plan, requirements, acceptance_criteria, system_design
| id | title | status | wave | depends_on | plan | requirements | acceptance_criteria | system_design | |||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 05-add-responsive-text-hierarchy-e2e | Add responsive text hierarchy E2E | completed | 3 |
|
plan.md |
|
|
|
Task 05: Add Responsive Text Hierarchy E2E
Summary
Prove the integrated text hierarchy in rendered browsers using real entry points, long dynamic content, and a longer bundled locale.
In scope
- Add focused phone and desktop E2E specs for representative AlertDialog, Dialog, Drawer, and inline Alert text behavior without adding a production-only test route.
- Exercise task deletion through the real phone task-action flow with a long task title and Portuguese or pseudo-localized copy at 320px and 393px.
- Inspect computed title/body wrapping, structured left alignment, viewport and document containment, body scroll ownership, persistent action geometry, semantic Delete treatment, Cancel, and task survival.
- Add one desktop representative check and run existing long-dialog/delete regressions.
Out of scope
- Production component changes except a stable selector when existing roles and labels cannot identify the required geometry boundary.
- Screenshot baselines or a new fixture application.
Implementation acceptance
- Phone checks prove balanced titles, non-balanced pretty descriptions, structured left alignment, and zero horizontal overflow at both target widths with long localized content.
- Task cleanup content remains reachable with visible 44px actions; Delete is destructive, and Cancel closes without deleting the task.
- Desktop preserves compact action density, surface placement, and existing delete behavior.
TDD sequence
- Write rendered assertions against the integrated pre-fix baseline where practical and record the expected computed-style/geometry failure.
- If a stable selector is genuinely missing, add only the smallest semantic test seam in the owning component and cover it in that component's test.
- Run mobile and desktop scenarios GREEN, then the E2E sleep ratchet and focused lint.
Verification
cd apps/web
pnpm e2e:run --project mobile-chrome tests/task/mobile-confirmation-text-hierarchy.spec.ts
pnpm e2e:run --project chromium tests/task/confirmation-text-hierarchy.spec.ts
pnpm e2e:run --project chromium tests/task/dialog-long-text-overflow.spec.ts tests/task/sidebar-delete-confirm.spec.ts
pnpm run e2e:sleep-ratchet
pnpm exec eslint e2e/tests/task/mobile-confirmation-text-hierarchy.spec.ts e2e/tests/task/confirmation-text-hierarchy.spec.ts
Files likely touched
apps/web/e2e/tests/task/mobile-confirmation-text-hierarchy.spec.ts(new)apps/web/e2e/tests/task/confirmation-text-hierarchy.spec.ts(new)- Existing E2E helpers only if reusable setup cannot expose the real flow.
- A production selector only if roles, names, and existing test IDs are insufficient.
Dependencies
- Tasks 02, 03, and 04 must be integrated after Task 01.
Parallelism
sequential-integration
Inputs
docs/specs/ui/requirements/surface-text-hierarchy.mddocs/specs/ui/system-design/surface-text-hierarchy.mddocs/specs/ui/requirements/confirmation-warning-hierarchy.mddocs/specs/ui/system-design/confirmation-warning-hierarchy.mddocs/plans/surface-text-hierarchy/plan.mdapps/web/AGENTS.mdapps/web/e2e/README.md.agents/skills/e2e/SKILL.md.agents/skills/mobile-parity/SKILL.md
Results
- RED baseline on the pre-fix base: the mobile suite had 3 of 4 tests fail on missing balanced Drawer and Alert titles, and the desktop suite had 2 of 2 tests fail on missing pretty archive prose and balanced Dialog titles.
- Integrated Task 04 RED: the mobile suite passed 4 tests, while the desktop
suite had 1 failure because the archive PopoverDescription computed
text-wrap: wrapinstead ofpretty. Task 04 added the narrowwidepopover contract fix before final verification. - Added six rendered tests across phone and desktop flows. They cover real task deletion, archive, Alert, board Drawer, Dialog, and Delete surfaces with long content, pseudo-localized copy, computed wrapping, structured alignment, viewport and document containment, scroll ownership, action geometry, semantic Delete styling, Cancel, and task survival.
- GREEN:
pnpm e2e:run --project mobile-chrome tests/task/mobile-confirmation-text-hierarchy.spec.ts(4 tests). - GREEN:
pnpm e2e:run --project chromium tests/task/confirmation-text-hierarchy.spec.ts(2 tests). - GREEN:
pnpm e2e:run --project chromium tests/task/dialog-long-text-overflow.spec.ts tests/task/sidebar-delete-confirm.spec.ts(2 tests). - GREEN:
pnpm run e2e:sleep-ratchetand focused ESLint for both new specs. - Review remediation synchronized the completed parent plan and removed redundant direct computed-style reads in favor of Playwright's retrying CSS assertions. Final reruns remained green: mobile 4/4, desktop 2/2, and existing long-dialog/delete regressions 2/2; focused lint, Prettier, the sleep ratchet, diff checks, and specification lint also passed.