2.5 KiB
2.5 KiB
id, title, status, wave, depends_on, plan, spec
| id | title | status | wave | depends_on | plan | spec | |
|---|---|---|---|---|---|---|---|
| 11-mobile-parity | Mobile parity for the review findings surface | pending | 8 |
|
plan.md | ../../specs/agents/requirements/native-code-review.md |
Task 11: Mobile parity for the review findings surface
Review is a primary mobile surface. Every desktop capability must be reachable with native mobile presentation.
Inputs
- Load the
mobile-parityskill first and follow its surface decision guide, design contract, and verification requirements. - Spec's phone scenario.
apps/web/AGENTS.md→ Responsive and touch surfaces: usehooks/use-responsive-breakpoint.ts(640px phone boundary), not the UI package'suseIsMobile; useuseTouchDrawerfor coarse-pointer disclosure; reuse the existing inset safe-area bottom-sheet treatment.components/task/mobile/mobile-changes-panel.tsxandsession-mobile-layout.test.tsx.
Work
components/task/mobile/mobile-review-findings-sheet.tsx— aDrawerbottom sheet listing findings grouped by repository then file, severity-sorted, with Resolve / Dismiss / Undo / Send-to-agent per finding and a tap target that navigates to the anchored line in the mobile diff.components/task/mobile/mobile-changes-panel.tsx— a findings entry point showing the open count, plus the Review changes run control (reusingreview-run-button.tsx) in the mobile changes toolbar with the same run states and the samereview_agent_unavailableinline message.- Ensure the inline finding cards inside the mobile diff remain usable at phone width: the card actions collapse into an overflow menu below 640px rather than wrapping.
- Confirm no capability is desktop-only: run the mobile-parity checklist against the finding actions, the run control, cancel, and clear.
Acceptance
- Every desktop finding action is reachable on a 390×844 viewport.
- The sheet respects safe-area insets and closes on backdrop tap and Escape.
- Tapping a finding opens the right file and scrolls to the anchored line.
Verification
cd apps/web && pnpm vitest run components/task/mobile
cd apps/web && pnpm e2e --project=mobile-chrome e2e/mobile/code-review-findings.spec.ts
Files likely touched
components/task/mobile/{mobile-review-findings-sheet.tsx,mobile-changes-panel.tsx}, components/diff/review-finding-card.tsx, plus tests.
Output contract
Summary, files changed, tests run with results, the mobile-parity checklist outcome, blockers, risks, status: done, plan checkbox.