3.1 KiB
3.1 KiB
id, title, status, wave, depends_on, plan, spec
| id | title | status | wave | depends_on | plan | spec |
|---|---|---|---|---|---|---|
| 01-agent-settings-layout | Agent settings layout | done | 1 | plan.md | ../../specs/agents/requirements/settings-profile-layout.md |
Task 01: Agent settings layout
Acceptance
- Configured agent cards show the existing
New profilelink in their header; the profile body has no count or separate creation/empty-state row. - Unconfigured agent cards show only the existing
Setup profileheader action, while saved profile rows and their duplicate/delete behavior remain intact. - The installed-agent toolbar places refresh/rescan immediately before the rightmost Add TUI Agent action, keeps terminal available, and preserves touch-safe targets on mobile.
Verification
cd apps && pnpm install --frozen-lockfile
cd apps/web && pnpm test -- components/settings/agents/agent-profiles-section.test.tsx components/settings/installed-agent-card.test.tsx
cd apps/web && pnpm run typecheck
cd apps/web && pnpm exec eslint app/settings/agents/page.tsx components/settings/agents/agent-profiles-section.tsx components/settings/installed-agent-card.tsx
cd apps/web && pnpm run i18n:check
The focused card test covers both unconfigured setup-link branches, while the existing profile-section test keeps the profile-row regression coverage.
Files likely touched
apps/web/app/settings/agents/page.tsxapps/web/components/settings/agents/agent-profiles-section.tsxapps/web/components/settings/agents/agent-profiles-section.test.tsxapps/web/components/settings/installed-agent-card.tsxapps/web/components/settings/installed-agent-card.test.tsx
Dependencies
None.
Parallelism
Sequential. The component markup, selector IDs, and unit assertions are one small vertical slice.
Inputs
- Spec:
docs/specs/agents/requirements/settings-profile-layout.md, especially What and the first four scenarios. - Plan:
plan.md, Frontend and Mobile design contract sections. - Existing patterns:
InstalledAgentCard,AgentProfilesSubList, and the currentagent-profiles-section.test.tsxstore read-after-write tests.
Output contract
Report the final changed files, exact unit/typecheck/lint/i18n commands and results, any selector or responsive decisions, blockers, risks, and synchronized task/plan status in the same conversation.
Results
cd apps && pnpm install --frozen-lockfilepassed.cd apps/web && pnpm test -- components/settings/agents/agent-profiles-section.test.tsx components/settings/installed-agent-card.test.tsxpassed (2 files, 8 tests), including both setup-link routes and both empty-body guards.cd apps/web && pnpm run typecheckpassed.cd apps/web && pnpm exec eslint app/settings/agents/page.tsx components/settings/agents/agent-profiles-section.tsx components/settings/installed-agent-card.tsxpassed.cd apps/web && pnpm run i18n:checkpassed. It reported the repository's existing advisory catalog parity/unreferenced-key warnings; this change adds no locale keys.- Review follow-up added setup-link coverage, the saved-empty profile-body guard, and removed a redundant toolbar-count assertion in the desktop E2E test.