João Salavisa
5257dfbaab
Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
64 lines
2.3 KiB
TypeScript
64 lines
2.3 KiB
TypeScript
import type { TaskReviewFinding } from "@/lib/types/review";
|
|
|
|
/**
|
|
* Severity wording for the markdown block sent to an agent.
|
|
*
|
|
* Held stable in English so a reviewer's UI locale cannot change what the
|
|
* agent is told. The on-screen chip resolves `SEVERITY_LABEL_KEYS` instead.
|
|
*/
|
|
// i18n-exempt: agent-facing prompt content, deliberately not localized.
|
|
export const SEVERITY_LABELS: Record<string, string> = {
|
|
blocker: "Blocker",
|
|
major: "Major",
|
|
minor: "Minor",
|
|
nit: "Nit",
|
|
};
|
|
|
|
export function severityLabel(severity: string): string {
|
|
return SEVERITY_LABELS[severity] ?? severity;
|
|
}
|
|
|
|
/** Catalog keys for the same severities, for anything rendered on screen. */
|
|
export const SEVERITY_LABEL_KEYS: Record<string, string> = {
|
|
blocker: "review:severityBlocker",
|
|
major: "review:severityMajor",
|
|
minor: "review:severityMinor",
|
|
nit: "review:severityNit",
|
|
};
|
|
|
|
/** `repo/path:12-14` or `path:12`, the form used in headings and agent context. */
|
|
export function findingLocation(finding: TaskReviewFinding): string {
|
|
const path = finding.repository_name
|
|
? `${finding.repository_name}/${finding.file_path}`
|
|
: finding.file_path;
|
|
if (finding.end_line > finding.start_line) {
|
|
return `${path}:${finding.start_line}-${finding.end_line}`;
|
|
}
|
|
return `${path}:${finding.start_line}`;
|
|
}
|
|
|
|
/**
|
|
* Renders a finding as the markdown block sent to an agent as follow-up context.
|
|
*
|
|
* Mirrors the shape of `formatReviewCommentsAsMarkdown` so a finding reads to the
|
|
* agent like any other anchored review feedback, and states plainly that the
|
|
* suggestion was not applied — the agent must not assume the fix is already in
|
|
* the working tree.
|
|
*/
|
|
export function formatFindingAsMarkdown(finding: TaskReviewFinding): string {
|
|
const lines: string[] = ["### Code Review Finding", ""];
|
|
lines.push(`**${findingLocation(finding)}** - ${severityLabel(finding.severity)}`);
|
|
if (finding.category) lines.push(`Category: ${finding.category}`);
|
|
lines.push("", `**${finding.title}**`, "", finding.body);
|
|
if (finding.suggestion) {
|
|
lines.push("", "Suggested change (not applied):", "```", finding.suggestion, "```");
|
|
}
|
|
lines.push("", "---", "");
|
|
return lines.join("\n");
|
|
}
|
|
|
|
/** Renders several findings as one markdown block. */
|
|
export function formatFindingsAsMarkdown(findings: TaskReviewFinding[]): string {
|
|
return findings.map(formatFindingAsMarkdown).join("\n");
|
|
}
|