Files
kandev/apps/web/lib/api/domains/marketplace-api.test.ts
T
João Salavisa bc2f310e73 feat(plugins): add plugin marketplace with curated registry and updates (#1798)
* feat(plugins): add plugin marketplace with curated registry and updates

Discover and install plugins from inside kandev instead of only by URL/upload.

- Backend marketplace subpackage: SQLite-backed sources, catalog fetch/merge
  (dedup, install_state, degraded-source handling), and the /api/plugins/
  marketplace[/sources] API. Install reuses the existing install-by-URL pipeline.
- Frontend: Settings > Plugins gains a Browse tab (search/category/star sort),
  source management, one-click install, and an Update button on the Installed
  tab when the catalog has a newer version. Plugins may ship an icon (manifest
  `icon` -> catalog icon_url) with a letter-tile fallback.
- Registry infra: plugin-registry/ (curated plugins.yaml + schema.json) and two
  GitHub Actions (zero-dependency Node build-index.mjs -> index.json on Pages,
  daily star refresh). Ships empty at launch; the empty catalog is valid.
- Spec: docs/specs/plugins/marketplace.md. No download telemetry; stars only.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(plugins): address marketplace PR review feedback

- CodeQL: stub fetch routers keyed off a path segment, not a hostname substring.
- Nullable stars end to end: a failed star lookup stays unknown (not 0) and
  sorts last, instead of decoding null -> 0 and corrupting ranking.
- Fetch marketplace sources concurrently and dedupe identical in-flight
  downloads (singleflight), so a slow source can't serialize the Browse tab.
- Register /marketplace routes before the /:id wildcard (gin tree ordering).
- Duplicate source URL returns 409 ErrDuplicateSource, not a raw SQL error.
- Browse: filter category client-side so the category dropdown never collapses.
- marketplaceInstall swallows after toasting (no unhandled promise rejection).
- Source badge keys off source_id, not a name substring.
- build-index: read block-sequence manifest categories, not just inline.
- Registry index workflow validates on pull_request; Pages deploy gated to
  push/schedule/dispatch. Spec: align package_sha256 (advisory in v1) + sort enum.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(plugins): guard catalog repo_url against javascript: href injection

repo_url comes from an untrusted index.json, so a malicious/compromised source
could set a javascript: URL that runs in the operator's session when the Repo
link is clicked (rel/target don't block it). Only render the anchor for http(s)
schemes. Adds regression tests for the scheme guard and null-star rendering.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(plugins): require https for remote sources; test oversized download

- Reject remote plain-http marketplace sources (MITM catalog-poisoning risk);
  loopback http stays allowed for local dev/e2e fixtures.
- Add the missing oversized-response assertion to TestDownloadRejectsNon200AndOversized
  so the maxIndexBytes memory bound has coverage.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(plugins): detach source download from singleflight leader's context

Two concurrent Browse opens after a cache Refresh share one singleflight
download; if the leader's request context is canceled (it navigates away), the
waiters must not inherit that cancellation. Use context.WithoutCancel so values
are preserved but the leader can't cancel everyone; the client's 20s timeout
still bounds the download.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-19 17:10:53 +01:00

168 lines
5.3 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
vi.mock("@/lib/config", () => ({
getBackendConfig: () => ({ apiBaseUrl: "http://api.test" }),
}));
import {
addMarketplaceSource,
deleteMarketplaceSource,
getMarketplaceCatalog,
listMarketplaceSources,
refreshMarketplace,
updateMarketplaceSource,
} from "./marketplace-api";
import { ApiError } from "../client";
type FetchInput = Parameters<typeof fetch>[0];
type FetchInit = Parameters<typeof fetch>[1];
const fetchSpy = vi.fn<(...args: [FetchInput, FetchInit?]) => Promise<Response>>();
beforeEach(() => {
fetchSpy.mockReset();
vi.stubGlobal("fetch", fetchSpy);
});
afterEach(() => {
vi.unstubAllGlobals();
});
function jsonResponse(body: unknown, status = 200) {
return new Response(JSON.stringify(body), {
status,
headers: { "Content-Type": "application/json" },
});
}
function entry(overrides: Record<string, unknown> = {}) {
return {
id: "agent-stats",
name: "Agent Stats",
description: "",
author: "kandev",
categories: ["analytics"],
repo_url: "https://github.com/kdlbs/kandev-plugin-agent-stats",
version: "1.0.0",
min_kandev_version: "",
package_url: "https://ex/agent-stats-1.0.0.tar.gz",
package_sha256: "",
stars: 42,
updated_at: "2026-07-17T00:00:00Z",
install_state: "available",
source_id: "official",
source_name: "Kandev Official",
...overrides,
};
}
describe("getMarketplaceCatalog", () => {
it("GETs the catalog and encodes the query params", async () => {
fetchSpy.mockResolvedValueOnce(jsonResponse({ plugins: [entry()], sources: [] }));
const result = await getMarketplaceCatalog({ q: "stats", category: "analytics", sort: "name" });
const [url] = fetchSpy.mock.calls.at(-1) ?? [];
expect(String(url)).toBe(
"http://api.test/api/plugins/marketplace?q=stats&category=analytics&sort=name",
);
expect(result.plugins).toHaveLength(1);
expect(result.plugins[0].id).toBe("agent-stats");
});
it("omits empty query params and defaults missing arrays", async () => {
fetchSpy.mockResolvedValueOnce(jsonResponse({}));
const result = await getMarketplaceCatalog();
const [url] = fetchSpy.mock.calls.at(-1) ?? [];
expect(String(url)).toBe("http://api.test/api/plugins/marketplace");
expect(result).toEqual({ plugins: [], sources: [] });
});
});
describe("marketplace sources", () => {
it("lists sources, unwrapping the sources array", async () => {
fetchSpy.mockResolvedValueOnce(
jsonResponse({
sources: [
{ id: "official", name: "Kandev Official", url: "u", enabled: true, builtin: true },
],
}),
);
const result = await listMarketplaceSources();
const [url] = fetchSpy.mock.calls.at(-1) ?? [];
expect(String(url)).toBe("http://api.test/api/plugins/marketplace/sources");
expect(result[0].builtin).toBe(true);
});
it("POSTs a new source with name+url as JSON", async () => {
fetchSpy.mockResolvedValueOnce(
jsonResponse(
{ id: "s1", name: "Acme", url: "https://acme/index.json", enabled: true, builtin: false },
201,
),
);
const result = await addMarketplaceSource("Acme", "https://acme/index.json");
const [url, init] = fetchSpy.mock.calls.at(-1) ?? [];
expect(String(url)).toBe("http://api.test/api/plugins/marketplace/sources");
expect(init?.method).toBe("POST");
expect(JSON.parse(String(init?.body))).toEqual({
name: "Acme",
url: "https://acme/index.json",
});
expect(result.id).toBe("s1");
});
it("propagates a 400 (bad/duplicate url) as an ApiError", async () => {
fetchSpy.mockResolvedValueOnce(
jsonResponse({ error: "source url must be an http(s) URL" }, 400),
);
await expect(addMarketplaceSource("x", "ftp://nope")).rejects.toBeInstanceOf(ApiError);
});
it("PATCHes a source with the partial patch body", async () => {
fetchSpy.mockResolvedValueOnce(
jsonResponse({ id: "s1", name: "Acme", url: "u", enabled: false, builtin: false }),
);
await updateMarketplaceSource("s1", { enabled: false });
const [url, init] = fetchSpy.mock.calls.at(-1) ?? [];
expect(String(url)).toBe("http://api.test/api/plugins/marketplace/sources/s1");
expect(init?.method).toBe("PATCH");
expect(JSON.parse(String(init?.body))).toEqual({ enabled: false });
});
it("DELETEs a source and propagates a 409 for the built-in source", async () => {
fetchSpy.mockResolvedValueOnce(jsonResponse({ deleted: true }));
await deleteMarketplaceSource("s1");
const [url, init] = fetchSpy.mock.calls.at(-1) ?? [];
expect(String(url)).toBe("http://api.test/api/plugins/marketplace/sources/s1");
expect(init?.method).toBe("DELETE");
fetchSpy.mockResolvedValueOnce(
jsonResponse({ error: "the built-in source cannot be deleted" }, 409),
);
await expect(deleteMarketplaceSource("official")).rejects.toBeInstanceOf(ApiError);
});
});
describe("refreshMarketplace", () => {
it("POSTs to the refresh endpoint", async () => {
fetchSpy.mockResolvedValueOnce(jsonResponse({ refreshed: true }));
const result = await refreshMarketplace();
const [url, init] = fetchSpy.mock.calls.at(-1) ?? [];
expect(String(url)).toBe("http://api.test/api/plugins/marketplace/refresh");
expect(init?.method).toBe("POST");
expect(result.refreshed).toBe(true);
});
});