5ee5161166
Co-authored-by: Kandev Agent <agent@kandev.dev>
272 lines
8.9 KiB
TypeScript
272 lines
8.9 KiB
TypeScript
import { cleanup, fireEvent, render, screen, waitFor, within } from "@testing-library/react";
|
|
import { IconInbox } from "@tabler/icons-react";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import {
|
|
IntegrationScopeBar,
|
|
type IntegrationScopeBarProps,
|
|
type ScopePreset,
|
|
} from "./presets-scope-bar-base";
|
|
|
|
let lastMenuItemSelectEvent: Event | null = null;
|
|
|
|
vi.mock("@kandev/ui/dropdown-menu", () => ({
|
|
DropdownMenu: ({ children }: { children: React.ReactNode }) => <>{children}</>,
|
|
DropdownMenuTrigger: ({ children }: { children: React.ReactNode }) => <>{children}</>,
|
|
DropdownMenuContent: ({ children }: { children: React.ReactNode }) => (
|
|
<div role="menu">{children}</div>
|
|
),
|
|
DropdownMenuItem: ({
|
|
children,
|
|
disabled,
|
|
onSelect,
|
|
...props
|
|
}: React.HTMLAttributes<HTMLDivElement> & {
|
|
disabled?: boolean;
|
|
onSelect?: (event: Event) => void;
|
|
}) => {
|
|
const select = () => {
|
|
if (disabled) return;
|
|
const event = new Event("select", { cancelable: true });
|
|
lastMenuItemSelectEvent = event;
|
|
onSelect?.(event);
|
|
};
|
|
return (
|
|
<div
|
|
{...props}
|
|
role="menuitem"
|
|
aria-disabled={disabled}
|
|
onClick={select}
|
|
onPointerUp={select}
|
|
>
|
|
{children}
|
|
</div>
|
|
);
|
|
},
|
|
DropdownMenuCheckboxItem: ({
|
|
children,
|
|
checked,
|
|
disabled,
|
|
onCheckedChange,
|
|
onSelect,
|
|
...props
|
|
}: React.HTMLAttributes<HTMLDivElement> & {
|
|
checked?: boolean;
|
|
disabled?: boolean;
|
|
onCheckedChange?: (checked: boolean) => void;
|
|
onSelect?: (event: Event) => void;
|
|
}) => (
|
|
<div
|
|
{...props}
|
|
role="menuitemcheckbox"
|
|
aria-checked={checked}
|
|
aria-disabled={disabled}
|
|
onClick={() => {
|
|
if (disabled) return;
|
|
onSelect?.(new Event("select", { cancelable: true }));
|
|
onCheckedChange?.(!checked);
|
|
}}
|
|
>
|
|
{children}
|
|
</div>
|
|
),
|
|
DropdownMenuSeparator: () => <hr />,
|
|
}));
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
lastMenuItemSelectEvent = null;
|
|
});
|
|
|
|
type Kind = "pr" | "issue";
|
|
type Props = IntegrationScopeBarProps<Kind>;
|
|
type DefaultActions<T> = T extends {
|
|
onToggleSavedDefault?: ((id: string) => void) | undefined;
|
|
defaultMutationPendingId?: string | null | undefined;
|
|
}
|
|
? Pick<T, "onToggleSavedDefault" | "defaultMutationPendingId">
|
|
: never;
|
|
const ARIA_DISABLED_ATTRIBUTE = "aria-disabled";
|
|
const FUTURE_DELETE_LABEL = "Delete Future default saved query";
|
|
|
|
function acceptDefaultActions(actions: DefaultActions<Props>) {
|
|
return actions;
|
|
}
|
|
|
|
function renderBar(overrides: Partial<Props> = {}) {
|
|
const onSelect = vi.fn();
|
|
const onToggleSavedDefault = vi.fn();
|
|
const onDeleteSaved = vi.fn();
|
|
const props: Props = {
|
|
testId: "scope-bar",
|
|
savedMenuTestId: "saved-menu",
|
|
kinds: [
|
|
{ value: "pr", label: "Pull requests" },
|
|
{ value: "issue", label: "Issues" },
|
|
],
|
|
selected: { kind: "pr", source: "preset", id: "review" },
|
|
onSelect,
|
|
presetsByKind: () => [
|
|
{
|
|
value: "review",
|
|
label: "Review requested",
|
|
icon: IconInbox,
|
|
group: "inbox",
|
|
},
|
|
],
|
|
savedPresets: [
|
|
{ id: "saved-a", kind: "pr", label: "Current default", isDefault: true },
|
|
{ id: "saved-b", kind: "pr", label: "Future default", isDefault: false },
|
|
],
|
|
onDeleteSaved,
|
|
canSaveCurrent: false,
|
|
onSaveCurrent: vi.fn(),
|
|
onToggleSavedDefault,
|
|
defaultMutationPendingId: null,
|
|
...overrides,
|
|
};
|
|
return {
|
|
...render(<IntegrationScopeBar {...props} />),
|
|
onSelect,
|
|
onToggleSavedDefault,
|
|
onDeleteSaved,
|
|
};
|
|
}
|
|
|
|
function expectActiveKindReselectionNoop() {
|
|
const { onSelect } = renderBar();
|
|
|
|
fireEvent.click(screen.getByRole("button", { name: "Pull requests" }));
|
|
|
|
expect(onSelect).not.toHaveBeenCalled();
|
|
}
|
|
|
|
describe("IntegrationScopeBar saved defaults", () => {
|
|
it("requires pending default state to include its callback", () => {
|
|
// @ts-expect-error A pending id without its mutation callback is an invalid contract.
|
|
expect(acceptDefaultActions({ defaultMutationPendingId: "saved-b" })).toBeDefined();
|
|
});
|
|
|
|
it("ignores reselecting the active kind", expectActiveKindReselectionNoop);
|
|
|
|
it("delegates kind changes to the explicit callback when provided", () => {
|
|
const onKindChange = vi.fn();
|
|
const { onSelect } = renderBar({ onKindChange });
|
|
|
|
fireEvent.click(screen.getByRole("button", { name: "Issues" }));
|
|
|
|
expect(onKindChange).toHaveBeenCalledWith("issue");
|
|
expect(onSelect).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("renders set and clear markers without selecting the saved query", () => {
|
|
const { onSelect, onToggleSavedDefault } = renderBar();
|
|
const clear = screen.getByRole("menuitemcheckbox", {
|
|
name: "Clear Current default as default view",
|
|
});
|
|
const set = screen.getByRole("menuitemcheckbox", {
|
|
name: "Set Future default as default view",
|
|
});
|
|
|
|
expect(clear.getAttribute("aria-checked")).toBe("true");
|
|
expect(set.getAttribute("aria-checked")).toBe("false");
|
|
expect(set.parentElement?.getAttribute("role")).toBe("none");
|
|
fireEvent.click(set);
|
|
|
|
expect(onToggleSavedDefault).toHaveBeenCalledWith("saved-b");
|
|
expect(onSelect).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("disables every default action while a mutation is pending", () => {
|
|
renderBar({ defaultMutationPendingId: "saved-b" });
|
|
const currentDefault = screen.getByRole("menuitemcheckbox", {
|
|
name: "Updating default view… Clear Current default as default view",
|
|
});
|
|
const currentDelete = screen.getByRole("menuitem", {
|
|
name: "Updating default view… Delete Current default saved query",
|
|
});
|
|
|
|
expect(currentDefault.getAttribute(ARIA_DISABLED_ATTRIBUTE)).toBe("true");
|
|
expect(currentDefault.getAttribute("aria-busy")).toBeNull();
|
|
expect(currentDefault.querySelector("svg")?.getAttribute("class")).not.toContain(
|
|
"animate-pulse",
|
|
);
|
|
const futureDefault = screen.getByRole("menuitemcheckbox", {
|
|
name: "Updating default view… Set Future default as default view",
|
|
});
|
|
expect(futureDefault.getAttribute(ARIA_DISABLED_ATTRIBUTE)).toBe("true");
|
|
expect(futureDefault.querySelector("svg")?.getAttribute("class")).toContain("fill-amber-500");
|
|
expect(futureDefault.querySelector("svg")?.getAttribute("class")).toContain("opacity-60");
|
|
expect(futureDefault.querySelector("svg")?.getAttribute("class")).toContain("animate-pulse");
|
|
expect(currentDelete.getAttribute(ARIA_DISABLED_ATTRIBUTE)).toBe("true");
|
|
expect(currentDelete.className).toContain("group-hover/saved:data-[disabled]:opacity-50");
|
|
expect(
|
|
screen
|
|
.getByRole("menuitem", {
|
|
name: `Updating default view… ${FUTURE_DELETE_LABEL}`,
|
|
})
|
|
.getAttribute(ARIA_DISABLED_ATTRIBUTE),
|
|
).toBe("true");
|
|
});
|
|
});
|
|
|
|
describe("IntegrationScopeBar saved-query actions", () => {
|
|
it("renders no default actions when an integration omits the optional contract", () => {
|
|
renderBar({ onToggleSavedDefault: undefined });
|
|
|
|
expect(screen.queryByRole("menuitemcheckbox", { name: /as default view/ })).toBeNull();
|
|
});
|
|
|
|
it("names each delete action for its saved query", () => {
|
|
renderBar();
|
|
|
|
expect(
|
|
screen
|
|
.getByRole("menuitem", { name: "Delete Current default saved query" })
|
|
.getAttribute("title"),
|
|
).toBe("Delete Current default saved query");
|
|
expect(screen.getByRole("menuitem", { name: FUTURE_DELETE_LABEL }).getAttribute("title")).toBe(
|
|
FUTURE_DELETE_LABEL,
|
|
);
|
|
});
|
|
|
|
it("keeps the menu open and waits for named confirmation before deletion", async () => {
|
|
const { onDeleteSaved } = renderBar();
|
|
|
|
fireEvent.click(screen.getByRole("menuitem", { name: FUTURE_DELETE_LABEL }));
|
|
|
|
expect(onDeleteSaved).not.toHaveBeenCalled();
|
|
expect(lastMenuItemSelectEvent?.defaultPrevented).toBe(true);
|
|
const confirmation = await screen.findByRole("dialog", { name: "Delete Future default?" });
|
|
fireEvent.click(within(confirmation).getByRole("button", { name: "Cancel" }));
|
|
expect(onDeleteSaved).not.toHaveBeenCalled();
|
|
|
|
fireEvent.click(screen.getByRole("menuitem", { name: FUTURE_DELETE_LABEL }));
|
|
fireEvent.click(screen.getByRole("button", { name: "Delete Future default" }));
|
|
|
|
await waitFor(() => expect(onDeleteSaved).toHaveBeenCalledWith("saved-b"));
|
|
expect(onDeleteSaved).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("uses a host icon when a plugin preset does not provide one", () => {
|
|
const presets = [{ value: "open", label: "Open", group: "inbox" }] as unknown as ScopePreset[];
|
|
|
|
expect(() =>
|
|
render(
|
|
<IntegrationScopeBar
|
|
testId="scope"
|
|
savedMenuTestId="saved"
|
|
kinds={[{ value: "pr", label: "Pull requests" }]}
|
|
selected={{ kind: "pr", source: "preset", id: "open" }}
|
|
onSelect={vi.fn()}
|
|
presetsByKind={() => presets}
|
|
savedPresets={[]}
|
|
onDeleteSaved={vi.fn()}
|
|
canSaveCurrent={false}
|
|
onSaveCurrent={vi.fn()}
|
|
/>,
|
|
),
|
|
).not.toThrow();
|
|
expect(screen.getByRole("button", { name: "Open" })).toBeTruthy();
|
|
});
|
|
});
|