Files
kandev/apps/backend/internal/repoclone/origin_test.go
T
2026-08-21 10:34:19 +01:00

142 lines
5.2 KiB
Go

package repoclone
import "testing"
func TestCanonicalHTTPSCloneURL(t *testing.T) {
t.Parallel()
tests := []struct {
name string
raw string
want string
}{
{name: "scp style", raw: "git@github.com:acme/widgets.git", want: "https://github.com/acme/widgets.git"},
{name: "scp style uppercase host", raw: "git@GitHub.com:acme/widgets.git", want: "https://github.com/acme/widgets.git"},
{name: "scp style leading slash", raw: "git@github.com:/acme/widgets.git", want: "https://github.com/acme/widgets.git"},
{name: "scp style nested namespace", raw: "git@gitlab.example:group/sub/widgets.git", want: "https://gitlab.example/group/sub/widgets.git"},
{name: "ssh scheme", raw: "ssh://git@github.com/acme/widgets.git", want: "https://github.com/acme/widgets.git"},
{name: "ssh scheme with port", raw: "ssh://git@gitlab.example:2222/group/widgets.git", want: "https://gitlab.example/group/widgets.git"},
{name: "ssh scheme drops password", raw: "ssh://git:secret@github.com/acme/widgets.git", want: "https://github.com/acme/widgets.git"},
{name: "scp style rejects Unicode authority", raw: "git@gİthub.com:acme/widgets.git"},
{name: "ssh scheme rejects Unicode authority", raw: "ssh://git@gİthub.com/acme/widgets.git"},
{name: "scp style rejects encoded authority", raw: "git@g%C4%B0thub.com:acme/widgets.git"},
{name: "ssh scheme rejects encoded authority", raw: "ssh://git@g%C4%B0thub.com/acme/widgets.git"},
{name: "scp style rejects double encoded authority", raw: "git@g%25C4%25B0thub.com:acme/widgets.git"},
{name: "ssh scheme rejects double encoded authority", raw: "ssh://git@g%25C4%25B0thub.com/acme/widgets.git"},
{name: "scp style preserves Unicode path", raw: "git@github.com:acme/wídgets.git", want: "https://github.com/acme/wídgets.git"},
{name: "ssh scheme preserves Unicode path", raw: "ssh://git@github.com/acme/wídgets.git", want: "https://github.com/acme/wídgets.git"},
{name: "https passes through untouched", raw: "https://github.com/acme/widgets.git"},
{name: "file remote", raw: "file:///tmp/widgets.git"},
{name: "local path", raw: "/home/user/widgets"},
{name: "windows path", raw: `C:\repos\widgets`},
{name: "empty", raw: ""},
{name: "ssh scheme without path", raw: "ssh://git@github.com/"},
{name: "scp style without path", raw: "git@github.com:"},
{name: "scp style without host", raw: "git@:acme/widgets.git"},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
t.Parallel()
if got := CanonicalHTTPSCloneURL(test.raw); got != test.want {
t.Fatalf("CanonicalHTTPSCloneURL(%q) = %q, want %q", test.raw, got, test.want)
}
})
}
}
func TestHTTPSProviderOriginRejectsUnsafeAuthority(t *testing.T) {
t.Parallel()
for _, providerHost := range []string{
"gİthub.com",
"g%C4%B0thub.com",
"g%25C4%25B0thub.com",
"https://gİthub.com",
"https://g%C4%B0thub.com",
"https://g%25C4%25B0thub.com",
} {
t.Run(providerHost, func(t *testing.T) {
t.Parallel()
if _, err := HTTPSProviderOrigin(providerHost); err == nil {
t.Fatalf("HTTPSProviderOrigin(%q) error = nil, want rejection", providerHost)
}
})
}
}
func TestValidateHTTPSCloneOrigin(t *testing.T) {
t.Parallel()
tests := []struct {
name string
cloneURL string
providerHost string
wantErr bool
}{
{
name: "same origin with provider context path",
cloneURL: "https://bitbucket.example.test/context/scm/TEAM/repo.git",
providerHost: "https://BITBUCKET.example.test/context",
},
{
name: "bare provider hostname",
cloneURL: "https://bitbucket.org/team/repo.git",
providerHost: "bitbucket.org",
},
{
name: "different host",
cloneURL: "https://attacker.example/repo.git",
providerHost: "https://bitbucket.example.test",
wantErr: true,
},
{
name: "different port",
cloneURL: "https://bitbucket.example.test:8443/repo.git",
providerHost: "https://bitbucket.example.test",
wantErr: true,
},
{
name: "userinfo",
cloneURL: "https://token@bitbucket.example.test/repo.git",
providerHost: "https://bitbucket.example.test",
wantErr: true,
},
{
name: "non HTTPS",
cloneURL: "http://bitbucket.example.test/repo.git",
providerHost: "https://bitbucket.example.test",
wantErr: true,
},
{
name: "Unicode clone authority",
cloneURL: "https://gİthub.com/acme/widgets.git",
providerHost: "https://github.com",
wantErr: true,
},
{
name: "encoded clone authority",
cloneURL: "https://g%C4%B0thub.com/acme/widgets.git",
providerHost: "https://github.com",
wantErr: true,
},
{
name: "unsafe provider authority",
cloneURL: "https://github.com/acme/widgets.git",
providerHost: "https://gİthub.com",
wantErr: true,
},
{
name: "bare Unicode provider authority",
cloneURL: "https://github.com/acme/widgets.git",
providerHost: "gİthub.com",
wantErr: true,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
t.Parallel()
err := ValidateHTTPSCloneOrigin(test.cloneURL, test.providerHost)
if (err != nil) != test.wantErr {
t.Fatalf("ValidateHTTPSCloneOrigin() error = %v, wantErr %v", err, test.wantErr)
}
})
}
}