7d9f81be84
Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
93 lines
3.0 KiB
Go
93 lines
3.0 KiB
Go
package backendapp
|
|
|
|
import (
|
|
"fmt"
|
|
"go/ast"
|
|
"go/parser"
|
|
"go/token"
|
|
"testing"
|
|
)
|
|
|
|
// TestWorkflowAccessCheckersAreWired guards the three lines that make the
|
|
// workflow-step surface's per-user scoping real in the shipped binary.
|
|
//
|
|
// The workflow package cannot resolve a workflow's owner on its own, so its
|
|
// guards call out through checkers that default to open when nothing is wired
|
|
// (the same shape SetSessionAccessChecker has always had, so a Service built
|
|
// without the task domain still works). Every test in internal/workflow wires
|
|
// its own fake, so deleting one of these lines here leaves that whole suite
|
|
// green while the real backend hands one user another user's workflow steps
|
|
// again — the defect the guards exist to close, reintroduced with no failing
|
|
// test. A rebase resolving a conflict in this DI function by dropping a line
|
|
// is exactly how that would happen.
|
|
func TestWorkflowAccessCheckersAreWired(t *testing.T) {
|
|
want := map[string]string{
|
|
"SetWorkflowAccessChecker": "AuthorizeWorkflowAccess",
|
|
"SetWorkspaceAccessChecker": "AuthorizeWorkspaceAccess",
|
|
"SetTaskAccessChecker": "AuthorizeTaskAccess",
|
|
"SetSessionAccessChecker": "AuthorizeSessionAccess",
|
|
}
|
|
|
|
provideFn := findFuncDecl(t, "services.go", "provideServices")
|
|
got := map[string]string{}
|
|
ast.Inspect(provideFn, func(n ast.Node) bool {
|
|
call, ok := n.(*ast.CallExpr)
|
|
if !ok {
|
|
return true
|
|
}
|
|
sel, ok := call.Fun.(*ast.SelectorExpr)
|
|
if !ok || len(call.Args) != 1 {
|
|
return true
|
|
}
|
|
if _, tracked := want[sel.Sel.Name]; !tracked {
|
|
return true
|
|
}
|
|
// Only the workflow service's wiring counts; the orchestrator's
|
|
// identically-named setters are guarded by their own test.
|
|
if receiver, ok := sel.X.(*ast.Ident); !ok || receiver.Name != "workflowSvc" {
|
|
return true
|
|
}
|
|
got[sel.Sel.Name] = argumentSelector(call.Args[0])
|
|
return true
|
|
})
|
|
|
|
for setter, checker := range want {
|
|
switch arg, called := got[setter]; {
|
|
case !called:
|
|
t.Errorf("provideServices never calls workflowSvc.%s; without it the workflow-step "+
|
|
"surface falls open to any authenticated user", setter)
|
|
case arg != "taskSvc."+checker:
|
|
t.Errorf("workflowSvc.%s(%s), want taskSvc.%s", setter, arg, checker)
|
|
}
|
|
}
|
|
}
|
|
|
|
// findFuncDecl parses filename and returns the named top-level function.
|
|
func findFuncDecl(t *testing.T, filename, name string) *ast.FuncDecl {
|
|
t.Helper()
|
|
file, err := parser.ParseFile(token.NewFileSet(), filename, nil, 0)
|
|
if err != nil {
|
|
t.Fatalf("parse %s: %v", filename, err)
|
|
}
|
|
for _, decl := range file.Decls {
|
|
if fn, ok := decl.(*ast.FuncDecl); ok && fn.Name.Name == name {
|
|
return fn
|
|
}
|
|
}
|
|
t.Fatalf("%s not found in %s; re-point this guard at the DI function", name, filename)
|
|
return nil
|
|
}
|
|
|
|
// argumentSelector renders a `receiver.Method` argument for comparison.
|
|
func argumentSelector(arg ast.Expr) string {
|
|
sel, ok := arg.(*ast.SelectorExpr)
|
|
if !ok {
|
|
return fmt.Sprintf("%T", arg)
|
|
}
|
|
ident, ok := sel.X.(*ast.Ident)
|
|
if !ok {
|
|
return fmt.Sprintf("%T.%s", sel.X, sel.Sel.Name)
|
|
}
|
|
return ident.Name + "." + sel.Sel.Name
|
|
}
|