kandev/apps/web/e2e/tests/settings/agent-profile-delete.spec.ts

import { test, expect } from "../../fixtures/test-base";

test.describe("Agent profile deletion", () => {
  test("deleting profile with no active sessions shows confirm dialog then succeeds", async ({
    testPage,
    apiClient,
  }) => {
    test.setTimeout(60_000);

    // Create a test profile to delete
    const { agents } = await apiClient.listAgents();
    const agent = agents[0];
    const profile = await apiClient.createAgentProfile(agent.id, "Delete Me", {
      model: agent.profiles[0].model,
    });

    // Navigate to profile settings page
    await testPage.goto(`/settings/agents/${agent.name}/profiles/${profile.id}`);

    // Wait for the delete card to load (the card title is "Delete profile")
    await expect(testPage.getByText("Delete profile", { exact: true })).toBeVisible({
      timeout: 15_000,
    });

    // Click the delete button inside the delete card
    await testPage.getByRole("button", { name: "Delete", exact: true }).click();

    // Confirmation dialog should appear
    const dialog = testPage.getByRole("alertdialog");
    await expect(dialog).toBeVisible({ timeout: 10_000 });
    await expect(dialog.getByText("This action cannot be undone")).toBeVisible();

    // Confirm the deletion
    await dialog.getByRole("button", { name: "Delete", exact: true }).click();

    // Should redirect to agents settings page
    await expect(testPage).toHaveURL(/\/settings\/agents$/, { timeout: 15_000 });
  });

  test("deleting profile with active task shows confirm then conflict dialog and allows cancel", async ({
    testPage,
    apiClient,
    seedData,
  }) => {
    test.setTimeout(90_000);

    // Create a test profile
    const { agents } = await apiClient.listAgents();
    const agent = agents[0];
    const profile = await apiClient.createAgentProfile(agent.id, "Busy Profile", {
      model: agent.profiles[0].model,
    });

    // Create a task using this profile (this creates an active session)
    await apiClient.createTaskWithAgent(
      seedData.workspaceId,
      "Active Task For Profile",
      profile.id,
      {
        description: 'e2e:message("profile test")',
        workflow_id: seedData.workflowId,
        workflow_step_id: seedData.startStepId,
        repository_ids: [seedData.repositoryId],
      },
    );

    // Navigate to profile settings page
    await testPage.goto(`/settings/agents/${agent.name}/profiles/${profile.id}`);

    // Wait for the delete card to load (the card title is "Delete profile")
    await expect(testPage.getByText("Delete profile", { exact: true })).toBeVisible({
      timeout: 15_000,
    });

    // Click the delete button
    await testPage.getByRole("button", { name: "Delete", exact: true }).click();

    // Initial confirmation dialog should appear
    const confirmDialog = testPage.getByRole("alertdialog");
    await expect(confirmDialog).toBeVisible({ timeout: 10_000 });

    // Confirm the initial deletion
    await confirmDialog.getByRole("button", { name: "Delete", exact: true }).click();

    // The conflict dialog should appear with active session info
    const conflictDialog = testPage.getByRole("alertdialog");
    await expect(conflictDialog).toBeVisible({ timeout: 10_000 });
    await expect(conflictDialog.getByText("Active Task For Profile")).toBeVisible();
    await expect(conflictDialog.getByText("This profile is currently in use")).toBeVisible();

    // Cancel the deletion
    await conflictDialog.getByRole("button", { name: "Cancel" }).click();

    // Dialog should close and we should still be on the profile page
    await expect(conflictDialog).not.toBeVisible();
    await expect(testPage).toHaveURL(
      new RegExp(`/settings/agents/${agent.name}/profiles/${profile.id}`),
    );
  });

  test("deleting profile referenced by a watcher shows watcher in conflict dialog", async ({
    testPage,
    apiClient,
    seedData,
  }) => {
    test.setTimeout(60_000);

    // Linear config has to be present before /api/v1/linear/watches/issue
    // accepts the create POST; the auth-health probe is also what surfaces
    // hasSecret on the watch row's downstream consumers.
    await apiClient.setLinearConfig({ secret: "lin_api_xxx" });
    await apiClient.waitForIntegrationAuthHealthy("linear");

    const { agents } = await apiClient.listAgents();
    const agent = agents[0];
    const profile = await apiClient.createAgentProfile(agent.id, "Watched Profile", {
      model: agent.profiles[0].model,
    });

    await apiClient.createLinearIssueWatch({
      workspaceId: seedData.workspaceId,
      workflowId: seedData.workflowId,
      workflowStepId: seedData.startStepId,
      agentProfileId: profile.id,
      filter: { teamKey: "ENG" },
    });

    await testPage.goto(`/settings/agents/${agent.name}/profiles/${profile.id}`);
    await expect(testPage.getByText("Delete profile", { exact: true })).toBeVisible({
      timeout: 15_000,
    });

    await testPage.getByRole("button", { name: "Delete", exact: true }).click();
    const confirmDialog = testPage.getByRole("alertdialog");
    await expect(confirmDialog).toBeVisible({ timeout: 10_000 });
    await confirmDialog.getByRole("button", { name: "Delete", exact: true }).click();

    // Conflict dialog pops with NO active sessions — only the watcher path.
    // Without the cycle-5 frontend wiring the dialog would either not pop
    // (sessions-only check) or pop empty (watchers ignored).
    const conflictDialog = testPage.getByRole("alertdialog");
    await expect(conflictDialog).toBeVisible({ timeout: 10_000 });
    await expect(conflictDialog.getByText("Watchers (will be disabled):")).toBeVisible();
    await expect(conflictDialog.getByText(/Linear:/)).toBeVisible();
    await expect(conflictDialog.getByText(/team ENG/)).toBeVisible();

    await conflictDialog.getByRole("button", { name: "Cancel" }).click();
    await expect(conflictDialog).not.toBeVisible();
  });

  test("force-deleting profile with watcher disables the watcher row", async ({
    testPage,
    apiClient,
    seedData,
  }) => {
    test.setTimeout(60_000);

    await apiClient.setLinearConfig({ secret: "lin_api_xxx" });
    await apiClient.waitForIntegrationAuthHealthy("linear");

    const { agents } = await apiClient.listAgents();
    const agent = agents[0];
    const profile = await apiClient.createAgentProfile(agent.id, "Watched ForceRemove", {
      model: agent.profiles[0].model,
    });

    const watch = await apiClient.createLinearIssueWatch({
      workspaceId: seedData.workspaceId,
      workflowId: seedData.workflowId,
      workflowStepId: seedData.startStepId,
      agentProfileId: profile.id,
      filter: { teamKey: "ENG" },
    });
    expect(watch.enabled).toBe(true);

    await testPage.goto(`/settings/agents/${agent.name}/profiles/${profile.id}`);
    await expect(testPage.getByText("Delete profile", { exact: true })).toBeVisible({
      timeout: 15_000,
    });

    await testPage.getByRole("button", { name: "Delete", exact: true }).click();
    const confirmDialog = testPage.getByRole("alertdialog");
    await expect(confirmDialog).toBeVisible({ timeout: 10_000 });
    await confirmDialog.getByRole("button", { name: "Delete", exact: true }).click();

    const conflictDialog = testPage.getByRole("alertdialog");
    await expect(conflictDialog).toBeVisible({ timeout: 10_000 });
    await conflictDialog.getByRole("button", { name: "Delete Anyway" }).click();

    await expect(testPage).toHaveURL(/\/settings\/agents$/, { timeout: 15_000 });

    // The eager-disable path (DeleteProfile disables referencing watchers
    // after the row delete succeeds) must have flipped the watcher row to
    // enabled=0 and stamped a cause — without it the watcher would stay live,
    // orphaned at the now-deleted profile, and only self-heal whenever the
    // next external issue happens to match its filter (could be never for a
    // narrow filter).
    const after = await apiClient.getLinearIssueWatch(seedData.workspaceId, watch.id);
    expect(after).not.toBeNull();
    expect(after!.enabled).toBe(false);
    expect(after!.lastError ?? "").toContain(profile.id);
  });

  test("force-deleting profile with active task succeeds after both confirmations", async ({
    testPage,
    apiClient,
    seedData,
  }) => {
    test.setTimeout(90_000);

    // Create a test profile
    const { agents } = await apiClient.listAgents();
    const agent = agents[0];
    const profile = await apiClient.createAgentProfile(agent.id, "ForceRemove Profile", {
      model: agent.profiles[0].model,
    });

    // Create a task using this profile
    await apiClient.createTaskWithAgent(seedData.workspaceId, "Task For Force Delete", profile.id, {
      description: 'e2e:message("force delete test")',
      workflow_id: seedData.workflowId,
      workflow_step_id: seedData.startStepId,
      repository_ids: [seedData.repositoryId],
    });

    // Navigate to profile settings page
    await testPage.goto(`/settings/agents/${agent.name}/profiles/${profile.id}`);

    // Wait for the delete card to load (the card title is "Delete profile")
    await expect(testPage.getByText("Delete profile", { exact: true })).toBeVisible({
      timeout: 15_000,
    });

    // Click the delete button
    await testPage.getByRole("button", { name: "Delete", exact: true }).click();

    // Initial confirmation dialog should appear
    const confirmDialog = testPage.getByRole("alertdialog");
    await expect(confirmDialog).toBeVisible({ timeout: 10_000 });

    // Confirm the initial deletion
    await confirmDialog.getByRole("button", { name: "Delete", exact: true }).click();

    // Conflict dialog should appear with active session info
    const conflictDialog = testPage.getByRole("alertdialog");
    await expect(conflictDialog).toBeVisible({ timeout: 10_000 });
    await expect(conflictDialog.getByText("Task For Force Delete")).toBeVisible();

    // Confirm force deletion
    await conflictDialog.getByRole("button", { name: "Delete Anyway" }).click();

    // Should redirect to agents settings page
    await expect(testPage).toHaveURL(/\/settings\/agents$/, { timeout: 15_000 });
  });
});