6ba50ba51e
* perf(web): render stats page shell immediately with per-panel skeletons The stats route previously blocked the full SSR response on the workspace stats query, leaving the user staring at a blank loading screen for the entire round-trip. Drop the server-side stats fetch (server still resolves the workspace id, which is cheap) and move the stats request to the client. The header, range toggle, and every panel render their shell on mount, with each panel showing its own skeleton until data arrives. Range changes also re-show the skeletons during the refetch instead of staling the previous data. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): address PR review feedback on stats page lazy-loading - Drop unused `loading` flag from stats reducer (Claude) - Show "Failed to load stats" subtitle on fetch error instead of stale "Loading stats…" text (Claude, cubic) - Read live `range` from useSearchParams() and validate against the RangeKey union so skeletons reset immediately on toggle and invalid ?range values fall back to "month" (Claude, CodeRabbit) - Render an error panel per section instead of perpetual skeletons when the stats fetch fails (Greptile) - Use router.replace with scroll:false on range toggle to avoid re-running the server component for a URL-only change Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(web): extract stats pure helpers into stats-utils + unit tests - Move statsReducer, isRangeKey, getRangeLabel, formatDuration, getSubtitle, toPanelState, and buildStatsSummary into apps/web/app/stats/stats-utils.ts so the testable units are reachable outside the client component - Add apps/web/app/stats/stats-utils.test.ts covering reducer transitions, range-key validation, subtitle branching, panel-state derivation, and the summary builder - Switch useStatsData from a cancellation flag to AbortController so fast range toggles actually abort the in-flight fetchStats request instead of letting stale requests run to completion Addresses Claude review blocker + suggestion on PR #1022. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(web): tighten stats lazy-loading per Claude suggestions - loading.tsx now includes TopRepositoriesSkeleton, RepoLeadersSkeleton, and WorkloadSkeleton so a cold navigation to /stats shows the full page layout, not a layout that ends at Repository Activity - Reuse the existing StatsRange union for RangeKey in stats-utils.ts (one type alias, no risk of drift) - Drop the unreachable default arm in getRangeLabel so a future RangeKey addition triggers a TypeScript exhaustiveness error Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
402 lines
12 KiB
TypeScript
402 lines
12 KiB
TypeScript
"use client";
|
|
|
|
import { Card, CardContent, CardHeader, CardTitle } from "@kandev/ui/card";
|
|
import { Button } from "@kandev/ui/button";
|
|
import { PageTopbar } from "@/components/page-topbar";
|
|
import { ToggleGroup, ToggleGroupItem } from "@kandev/ui/toggle-group";
|
|
import type { StatsResponse } from "@/lib/types/http";
|
|
import { useCallback, useEffect, useMemo, useReducer } from "react";
|
|
import { useRouter, useSearchParams } from "next/navigation";
|
|
import { IconChartBar } from "@tabler/icons-react";
|
|
import { useCopyToClipboard } from "@/hooks/use-copy-to-clipboard";
|
|
import { fetchStats } from "@/lib/api/domains/stats-api";
|
|
import {
|
|
OverviewCards,
|
|
WorkloadSection,
|
|
RepositoryStatsGrid,
|
|
TopRepositories,
|
|
RepoLeaders,
|
|
} from "./stats-sections";
|
|
import {
|
|
ActivityHeatmap,
|
|
AgentUsageList,
|
|
CompletedTasksChart,
|
|
MostProductiveSummary,
|
|
} from "./stats-charts";
|
|
import {
|
|
ActivitySkeleton,
|
|
ChartsSkeleton,
|
|
OverviewCardsSkeleton,
|
|
RepoLeadersSkeleton,
|
|
RepositoriesSkeleton,
|
|
TopRepositoriesSkeleton,
|
|
WorkloadSkeleton,
|
|
} from "./stats-skeletons";
|
|
import { PRStatsPanel } from "@/components/github/pr-stats";
|
|
import {
|
|
buildStatsSummary,
|
|
DEFAULT_RANGE,
|
|
getRangeLabel,
|
|
getSubtitle,
|
|
isRangeKey,
|
|
type PanelState,
|
|
RANGE_KEYS,
|
|
type RangeKey,
|
|
type StatsState,
|
|
statsReducer,
|
|
toPanelState,
|
|
} from "./stats-utils";
|
|
|
|
interface StatsPageClientProps {
|
|
workspaceId?: string;
|
|
activeRange?: RangeKey;
|
|
initialError?: string | null;
|
|
}
|
|
|
|
function StatsEmptyState({ message }: { message: string }) {
|
|
return (
|
|
<div className="h-screen w-full flex flex-col bg-background">
|
|
<PageTopbar title="Statistics" icon={<IconChartBar className="h-4 w-4" />} />
|
|
<div className="flex-1 flex items-center justify-center">
|
|
<p className="text-muted-foreground">{message}</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
type StatsHeaderProps = {
|
|
global: StatsResponse["global"] | null;
|
|
range: RangeKey;
|
|
copied: boolean;
|
|
copyDisabled: boolean;
|
|
hasError: boolean;
|
|
onRangeChange: (r: RangeKey) => void;
|
|
onCopy: () => void;
|
|
};
|
|
|
|
function StatsHeader({
|
|
global,
|
|
range,
|
|
copied,
|
|
copyDisabled,
|
|
hasError,
|
|
onRangeChange,
|
|
onCopy,
|
|
}: StatsHeaderProps) {
|
|
return (
|
|
<PageTopbar
|
|
title="Statistics"
|
|
icon={<IconChartBar className="h-4 w-4" />}
|
|
subtitle={getSubtitle(global, hasError)}
|
|
actions={
|
|
<>
|
|
<ToggleGroup
|
|
type="single"
|
|
value={range}
|
|
onValueChange={(v) => {
|
|
if (v) onRangeChange(v as RangeKey);
|
|
}}
|
|
variant="outline"
|
|
className="h-7"
|
|
>
|
|
{RANGE_KEYS.map((key) => (
|
|
<ToggleGroupItem
|
|
key={key}
|
|
value={key}
|
|
className="cursor-pointer h-7 px-2 text-xs data-[state=on]:bg-muted data-[state=on]:text-foreground"
|
|
>
|
|
{getRangeLabel(key)}
|
|
</ToggleGroupItem>
|
|
))}
|
|
</ToggleGroup>
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
size="sm"
|
|
className="h-7 px-2 text-xs cursor-pointer"
|
|
onClick={onCopy}
|
|
disabled={copyDisabled}
|
|
>
|
|
{copied ? "Copied" : "Copy Stats"}
|
|
</Button>
|
|
</>
|
|
}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function SectionDivider({ id, label }: { id: string; label: string }) {
|
|
return (
|
|
<div id={id} className="flex items-center gap-3 pt-2 scroll-mt-24">
|
|
<div className="text-[11px] uppercase tracking-wider text-muted-foreground">{label}</div>
|
|
<div className="h-px flex-1 bg-border/60" />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function ErrorPanel({ title, message }: { title: string; message: string }) {
|
|
return (
|
|
<Card className="rounded-sm">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">{title}</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<p className="text-sm text-muted-foreground">{message}</p>
|
|
</CardContent>
|
|
</Card>
|
|
);
|
|
}
|
|
|
|
function TelemetryPanels({ state, rangeLabel }: { state: PanelState; rangeLabel: string }) {
|
|
if (state.kind === "loading") {
|
|
return (
|
|
<>
|
|
<div id="completed" className="scroll-mt-24">
|
|
<ChartsSkeleton />
|
|
</div>
|
|
<div id="activity" className="scroll-mt-24">
|
|
<ActivitySkeleton />
|
|
</div>
|
|
</>
|
|
);
|
|
}
|
|
if (state.kind === "error") {
|
|
return (
|
|
<>
|
|
<div id="completed" className="scroll-mt-24">
|
|
<ErrorPanel title="Completed Tasks Over Time" message={state.message} />
|
|
</div>
|
|
<div id="activity" className="scroll-mt-24">
|
|
<ErrorPanel title="Activity" message={state.message} />
|
|
</div>
|
|
</>
|
|
);
|
|
}
|
|
const { stats } = state;
|
|
return (
|
|
<>
|
|
<div id="completed" className="scroll-mt-24">
|
|
<div className="grid gap-4 lg:grid-cols-3">
|
|
<Card className="rounded-sm lg:col-span-2">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">
|
|
Completed Tasks Over Time
|
|
</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<CompletedTasksChart completedActivity={stats.completed_activity} />
|
|
</CardContent>
|
|
</Card>
|
|
<Card className="rounded-sm">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">
|
|
Most Productive
|
|
</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<MostProductiveSummary completedActivity={stats.completed_activity} />
|
|
</CardContent>
|
|
</Card>
|
|
</div>
|
|
</div>
|
|
<div id="activity" className="grid gap-4 lg:grid-cols-2 scroll-mt-24">
|
|
<Card className="rounded-sm">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">
|
|
Activity ({rangeLabel.toLowerCase()})
|
|
</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<ActivityHeatmap dailyActivity={stats.daily_activity} />
|
|
</CardContent>
|
|
</Card>
|
|
<Card className="rounded-sm">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">Top Agents</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<AgentUsageList agentUsage={stats.agent_usage} />
|
|
</CardContent>
|
|
</Card>
|
|
</div>
|
|
</>
|
|
);
|
|
}
|
|
|
|
function renderOverviewPanel(state: PanelState) {
|
|
if (state.kind === "loading") return <OverviewCardsSkeleton />;
|
|
if (state.kind === "error") return <ErrorPanel title="Overview" message={state.message} />;
|
|
return <OverviewCards global={state.stats.global} git_stats={state.stats.git_stats} />;
|
|
}
|
|
|
|
function renderRepositoryActivityPanel(state: PanelState) {
|
|
if (state.kind === "loading") return <RepositoriesSkeleton />;
|
|
if (state.kind === "error")
|
|
return <ErrorPanel title="Repository Activity" message={state.message} />;
|
|
return (
|
|
<Card id="repositories" className="rounded-sm scroll-mt-24">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">
|
|
Repository Activity
|
|
</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<RepositoryStatsGrid repositoryStats={state.stats.repository_stats} />
|
|
</CardContent>
|
|
</Card>
|
|
);
|
|
}
|
|
|
|
function renderTopRepositoriesPanel(state: PanelState) {
|
|
if (state.kind === "loading") return <TopRepositoriesSkeleton />;
|
|
if (state.kind === "error")
|
|
return <ErrorPanel title="Top Repositories" message={state.message} />;
|
|
return (
|
|
<Card className="rounded-sm">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">
|
|
Top Repositories
|
|
</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<TopRepositories repositoryStats={state.stats.repository_stats} />
|
|
</CardContent>
|
|
</Card>
|
|
);
|
|
}
|
|
|
|
function renderRepoLeadersPanel(state: PanelState) {
|
|
if (state.kind === "loading") return <RepoLeadersSkeleton />;
|
|
if (state.kind === "error") return <ErrorPanel title="Repo Leaders" message={state.message} />;
|
|
return (
|
|
<Card className="rounded-sm">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-sm font-medium text-muted-foreground">Repo Leaders</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<RepoLeaders repositoryStats={state.stats.repository_stats} />
|
|
</CardContent>
|
|
</Card>
|
|
);
|
|
}
|
|
|
|
function renderWorkloadPanel(state: PanelState) {
|
|
if (state.kind === "loading") return <WorkloadSkeleton />;
|
|
if (state.kind === "error") return <ErrorPanel title="Workload" message={state.message} />;
|
|
return <WorkloadSection task_stats={state.stats.task_stats} />;
|
|
}
|
|
|
|
function StatsContent({
|
|
state,
|
|
rangeLabel,
|
|
workspaceId,
|
|
}: {
|
|
state: PanelState;
|
|
rangeLabel: string;
|
|
workspaceId?: string;
|
|
}) {
|
|
return (
|
|
<div className="flex-1 overflow-auto">
|
|
<div className="max-w-7xl mx-auto p-6">
|
|
<div className="space-y-5">
|
|
{renderOverviewPanel(state)}
|
|
<SectionDivider id="telemetry" label="Telemetry" />
|
|
<TelemetryPanels state={state} rangeLabel={rangeLabel} />
|
|
{renderRepositoryActivityPanel(state)}
|
|
{renderTopRepositoriesPanel(state)}
|
|
{renderRepoLeadersPanel(state)}
|
|
<SectionDivider id="github" label="GitHub" />
|
|
<PRStatsPanel workspaceId={workspaceId ?? null} />
|
|
<SectionDivider id="workload" label="Workload" />
|
|
{renderWorkloadPanel(state)}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function useStatsData(workspaceId: string | undefined, range: RangeKey): StatsState {
|
|
const [state, dispatch] = useReducer(statsReducer, { stats: null, error: null });
|
|
|
|
useEffect(() => {
|
|
if (!workspaceId) return;
|
|
const controller = new AbortController();
|
|
dispatch({ type: "fetch" });
|
|
fetchStats(workspaceId, { cache: "no-store", init: { signal: controller.signal } }, range)
|
|
.then((data) => {
|
|
if (!controller.signal.aborted) dispatch({ type: "success", stats: data });
|
|
})
|
|
.catch((e: unknown) => {
|
|
if (controller.signal.aborted) return;
|
|
const message = e instanceof Error ? e.message : "Failed to fetch stats";
|
|
dispatch({ type: "failure", error: message });
|
|
});
|
|
return () => {
|
|
controller.abort();
|
|
};
|
|
}, [workspaceId, range]);
|
|
|
|
return state;
|
|
}
|
|
|
|
export function StatsPageClient({ workspaceId, activeRange, initialError }: StatsPageClientProps) {
|
|
const router = useRouter();
|
|
const searchParams = useSearchParams();
|
|
const { copied, copy } = useCopyToClipboard();
|
|
|
|
const rawRange = searchParams?.get("range") ?? activeRange;
|
|
const range: RangeKey = isRangeKey(rawRange) ? rawRange : DEFAULT_RANGE;
|
|
const rangeLabel = getRangeLabel(range);
|
|
|
|
const { stats, error: fetchError } = useStatsData(workspaceId, range);
|
|
const panelState = toPanelState(stats, fetchError);
|
|
|
|
const completedInRange = useMemo(
|
|
() => (stats?.completed_activity ?? []).reduce((sum, item) => sum + item.completed_tasks, 0),
|
|
[stats?.completed_activity],
|
|
);
|
|
const statsSummary = useMemo(
|
|
() => (stats ? buildStatsSummary(stats, rangeLabel, completedInRange) : ""),
|
|
[stats, rangeLabel, completedInRange],
|
|
);
|
|
|
|
const handleCopyStats = useCallback(() => {
|
|
if (statsSummary) void copy(statsSummary);
|
|
}, [copy, statsSummary]);
|
|
|
|
const handleRangeChange = useCallback(
|
|
(nextRange: RangeKey) => {
|
|
const params = new URLSearchParams(searchParams?.toString() ?? "");
|
|
params.set("range", nextRange);
|
|
router.replace(`/stats?${params.toString()}`, { scroll: false });
|
|
},
|
|
[router, searchParams],
|
|
);
|
|
|
|
if (initialError)
|
|
return (
|
|
<div className="h-screen w-full flex flex-col bg-background">
|
|
<PageTopbar title="Statistics" icon={<IconChartBar className="h-4 w-4" />} />
|
|
<div className="flex-1 flex items-center justify-center">
|
|
<p className="text-destructive">Error loading stats: {initialError}</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
if (!workspaceId) return <StatsEmptyState message="Select a workspace to view statistics." />;
|
|
|
|
return (
|
|
<div className="h-screen w-full flex flex-col bg-background">
|
|
<StatsHeader
|
|
global={stats?.global ?? null}
|
|
range={range}
|
|
copied={copied}
|
|
copyDisabled={!stats}
|
|
hasError={Boolean(fetchError)}
|
|
onRangeChange={handleRangeChange}
|
|
onCopy={handleCopyStats}
|
|
/>
|
|
<StatsContent state={panelState} rangeLabel={rangeLabel} workspaceId={workspaceId} />
|
|
</div>
|
|
);
|
|
}
|