José Almeida
aeba68680a
fix(layout): address PR review — narrow viewport, hidden sidebar, e2e flake
...
Bot-review fixups for #1005 :
- caps: bound runtime caps by `viewport - VIEWPORT_RESERVE_PX` so the
800px right-cap floor can't collapse the center column on narrow
screens (Cubic P1).
- applier: respect `column.maxWidth` on the sidebar too, so the
`compact` preset's 260px cap is honored at runtime (Cubic P2).
- dockview-store: skip the pinned-defaults mirror when the column is
hidden — auto-sync infers sidebar from grid index 0, which is the
center when sidebar is hidden, so an unguarded mirror would
persist the center's width as the sidebar's (Greptile/Cubic P1).
- trackPinnedWidths: gate the auto-sync on `sidebarVisible` /
`rightPanelsVisible` for the same reason.
- sizing: use `LAYOUT_RIGHT_RATIO` for non-sidebar columns instead of
silently reusing the sidebar ratio (Greptile P2).
- e2e: tablet viewport bumped from 1024 → 700 (≥1024 is desktop, not
tablet — the old viewport never rendered the tablet layout and
every assertion timed out). Tests now also verify rendered panel
proportions, not just the localStorage echo (CodeRabbit #2/#3).
- e2e helpers: throw on missing `.dv-sash` instead of returning `-1`
(CodeRabbit #1 ); shared `openWideTask` extracted from three spec
files (CodeRabbit #5 ); silent `return` in evaluate blocks
replaced with `throw` for fail-fast (CodeRabbit #4 ).
2026-05-22 01:28:06 +01:00
..
2026-05-05 13:55:46 +01:00
2026-05-21 23:35:41 +01:00
2026-05-10 17:30:24 +01:00
2026-05-21 01:31:42 +01:00
2026-03-07 14:53:21 +00:00
2026-05-21 23:35:41 +01:00
2026-05-05 22:06:24 +01:00
2026-05-18 22:04:31 +01:00
2026-03-10 17:30:04 +00:00
2026-05-01 13:27:25 +01:00
2026-02-24 20:33:45 +00:00
2026-05-14 10:27:38 +01:00
2026-04-18 10:32:24 +01:00
2026-05-19 15:53:48 +01:00
2026-05-19 15:53:48 +01:00
2026-05-02 20:26:42 +01:00
2026-05-02 20:26:42 +01:00
2026-05-05 22:09:02 +01:00
2026-05-02 20:26:42 +01:00
2026-05-14 10:27:38 +01:00
2026-05-19 15:53:48 +01:00
2026-05-04 17:28:04 +01:00
2026-05-04 17:28:04 +01:00
2026-05-19 15:53:48 +01:00
2026-05-05 22:09:02 +01:00
2026-05-14 10:27:38 +01:00
2026-05-05 13:55:46 +01:00
2026-02-21 22:14:56 +00:00
2026-02-23 00:16:37 +00:00
2026-02-19 22:18:01 +00:00
2026-05-14 10:27:38 +01:00
2026-05-02 20:26:42 +01:00
2026-05-02 20:26:42 +01:00
2026-05-13 23:46:36 +01:00
2026-05-18 23:08:14 +01:00
2026-05-04 18:53:33 +01:00
2026-05-22 00:49:24 +01:00
2026-04-28 22:23:14 +01:00
2026-05-01 22:32:28 +01:00
2026-05-14 23:57:05 +01:00
2026-05-19 09:19:05 +01:00
2026-05-19 23:41:02 +01:00
2026-05-22 01:28:06 +01:00
2026-05-13 18:39:01 +01:00
2026-05-19 23:41:02 +01:00
2026-05-16 20:07:57 +01:00
2026-05-02 15:19:02 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-03-13 10:44:32 +00:00
2026-02-24 23:01:41 +00:00
2026-05-14 21:26:09 +01:00
2026-05-14 21:26:09 +01:00
2026-05-14 21:26:09 +01:00
2026-05-14 21:26:09 +01:00
2026-05-14 21:26:09 +01:00
2026-05-14 21:26:09 +01:00
2026-02-19 22:18:01 +00:00
2026-05-21 14:01:31 +01:00
2026-05-21 14:01:31 +01:00
2026-04-09 12:49:47 +01:00
2026-05-17 21:26:13 +01:00
2026-02-19 22:18:01 +00:00
2026-05-21 14:01:31 +01:00
2026-04-25 21:42:59 +01:00
2026-05-21 14:01:31 +01:00
2026-04-11 17:43:21 +01:00
2026-03-24 23:38:02 +00:00
2026-03-24 23:38:02 +00:00
2026-02-19 22:18:01 +00:00
2026-02-19 22:18:01 +00:00
2026-04-02 00:08:35 +01:00
2026-05-17 21:26:13 +01:00
2026-05-17 21:26:13 +01:00
2026-05-19 09:18:22 +01:00
2026-03-29 15:33:40 +01:00
2026-02-19 22:18:01 +00:00
2026-03-12 23:22:26 +00:00
2026-03-24 23:38:02 +00:00
2026-04-24 21:31:46 +01:00
2026-04-24 21:31:46 +01:00
2026-05-14 21:26:09 +01:00
2026-05-17 20:16:15 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-04-20 13:44:24 +01:00
2026-05-01 22:32:28 +01:00
2026-05-01 21:02:41 +01:00
2026-05-14 21:26:09 +01:00
2026-03-13 10:44:32 +00:00
2026-05-05 13:55:46 +01:00
2026-05-05 13:55:46 +01:00
2026-03-08 11:03:30 +00:00
2026-05-06 20:25:34 +01:00
2026-05-05 13:55:46 +01:00
2026-05-05 13:55:46 +01:00
2026-05-18 23:08:14 +01:00
2026-05-02 22:25:40 +01:00
2026-05-02 22:25:40 +01:00
2026-05-02 22:25:40 +01:00
2026-05-17 20:16:15 +01:00
2026-05-02 22:25:40 +01:00
2026-05-02 22:25:40 +01:00
2026-05-14 21:26:09 +01:00
2026-05-14 21:26:09 +01:00
2026-04-25 18:40:31 +01:00
2026-05-18 22:04:31 +01:00
2026-05-01 11:00:33 +01:00
2026-05-17 20:16:15 +01:00
2026-05-16 20:07:57 +01:00
2026-05-06 20:25:34 +01:00
2026-02-19 22:18:01 +00:00
2026-05-01 11:00:33 +01:00
2026-05-14 21:26:09 +01:00
2026-02-19 22:18:01 +00:00
2026-04-20 13:44:24 +01:00
2026-05-05 13:55:46 +01:00
2026-04-17 23:20:10 +01:00
2026-02-19 22:18:01 +00:00
2026-03-07 14:53:21 +00:00
2026-04-02 00:08:35 +01:00
2026-05-16 14:04:09 +01:00
2026-05-16 14:04:09 +01:00
2026-05-21 23:35:41 +01:00
2026-04-08 07:55:24 +01:00
2026-04-17 23:20:10 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-05-14 10:27:38 +01:00
2026-05-14 10:27:38 +01:00
2026-05-13 18:04:37 +01:00
2026-05-14 21:26:09 +01:00
2026-05-18 23:08:14 +01:00
2026-05-05 14:13:43 +01:00
2026-05-02 20:26:42 +01:00
2026-05-17 20:16:15 +01:00
2026-04-27 10:22:58 +01:00
2026-04-27 10:22:58 +01:00
2026-04-27 10:22:58 +01:00
2026-04-27 10:22:58 +01:00
2026-04-27 10:22:58 +01:00
2026-04-27 10:22:58 +01:00
2026-02-25 02:10:16 +00:00
2026-05-14 21:26:09 +01:00
2026-05-22 00:49:24 +01:00
2026-05-19 21:44:15 +01:00
2026-05-19 21:44:15 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-05-19 17:55:25 +01:00
2026-05-21 01:31:42 +01:00
2026-02-19 22:18:01 +00:00
2026-05-06 19:05:19 +01:00
2026-05-21 01:31:42 +01:00
2026-04-20 13:44:24 +01:00
2026-05-21 01:31:42 +01:00
2026-05-14 21:26:09 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-05-16 20:07:57 +01:00
2026-03-29 22:27:37 +01:00
2026-05-01 13:27:25 +01:00
2026-04-24 17:14:03 +01:00
2026-05-04 00:53:21 +01:00
2026-05-04 00:53:21 +01:00
2026-05-16 20:07:57 +01:00
2026-05-14 21:26:09 +01:00
2026-05-14 21:26:09 +01:00
2026-04-27 10:22:58 +01:00
2026-05-02 20:26:42 +01:00
2026-05-16 20:07:57 +01:00
2026-05-05 13:55:46 +01:00
2026-04-24 17:14:03 +01:00
2026-03-08 11:03:30 +00:00
2026-02-24 23:01:41 +00:00
2026-04-16 10:14:45 +01:00
2026-02-19 22:18:01 +00:00
2026-02-19 22:18:01 +00:00
2026-05-14 21:26:09 +01:00