e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
163 lines
5.0 KiB
Go
163 lines
5.0 KiB
Go
// Command plugin-pack packages a plugin source directory into the kandev
|
|
// plugin tar.gz format described in docs/plans/plugins/GRPC-CONTRACT.md §6:
|
|
// manifest.yaml plus any server/ui/assets files, with a generated
|
|
// checksums.txt covering everything else. It is a thin CLI wrapper around
|
|
// pkgtar/pkgtartest.WritePackage, reused by both apps/backend's
|
|
// `make e2e-plugin-package` target and (via `go run`, replace directive)
|
|
// external plugin repos such as kandev-plugin-hello.
|
|
//
|
|
// Usage:
|
|
//
|
|
// plugin-pack -dir <plugin-package-dir> -out <file.tar.gz> [-platform-only]
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
|
|
"github.com/kandev/kandev/internal/plugins/manifest"
|
|
"github.com/kandev/kandev/internal/plugins/pkgtar/pkgtartest"
|
|
)
|
|
|
|
const (
|
|
manifestFileName = "manifest.yaml"
|
|
checksumsFileName = "checksums.txt"
|
|
checksumsSigFileName = "checksums.txt.sig"
|
|
serverDirPrefix = "server/"
|
|
)
|
|
|
|
// PackOptions configures Pack.
|
|
type PackOptions struct {
|
|
// PlatformOnly restricts included server/ executables to a single
|
|
// platform (GOOS/GOARCH below), producing a smaller package — useful
|
|
// for test fixtures that only ever run on the host that built them.
|
|
PlatformOnly bool
|
|
// GOOS/GOARCH override the platform used for PlatformOnly filtering.
|
|
// Empty means runtime.GOOS/runtime.GOARCH (the normal case; overridable
|
|
// for tests).
|
|
GOOS string
|
|
GOARCH string
|
|
}
|
|
|
|
// Pack reads every file under dir (which must contain manifest.yaml) and
|
|
// writes a kandev plugin tar.gz package to w, preserving relative paths and
|
|
// generating checksums.txt. When opts.PlatformOnly is set, server/
|
|
// executables for platforms other than the resolved GOOS/GOARCH are
|
|
// excluded.
|
|
func Pack(dir string, w io.Writer, opts PackOptions) error {
|
|
files, err := collectPackageFiles(dir, opts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if _, ok := files[manifestFileName]; !ok {
|
|
return fmt.Errorf("plugin-pack: %s not found under %s", manifestFileName, dir)
|
|
}
|
|
if err := pkgtartest.WritePackage(w, files); err != nil {
|
|
return fmt.Errorf("plugin-pack: writing package: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// collectPackageFiles walks dir and reads every regular file into a
|
|
// package-relative-path -> contents map, optionally filtering out
|
|
// non-host-platform server/ executables (see hostExecutablePath).
|
|
func collectPackageFiles(dir string, opts PackOptions) (map[string][]byte, error) {
|
|
var hostExecPath string
|
|
if opts.PlatformOnly {
|
|
execPath, err := hostExecutablePath(dir, opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
hostExecPath = execPath
|
|
}
|
|
|
|
files := make(map[string][]byte)
|
|
walkErr := filepath.WalkDir(dir, func(path string, d fs.DirEntry, err error) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if d.IsDir() {
|
|
return nil
|
|
}
|
|
rel, err := filepath.Rel(dir, path)
|
|
if err != nil {
|
|
return fmt.Errorf("plugin-pack: relative path for %s: %w", path, err)
|
|
}
|
|
rel = filepath.ToSlash(rel)
|
|
if rel == checksumsFileName || rel == checksumsSigFileName {
|
|
return fmt.Errorf("plugin-pack: %s must not be pre-supplied in %s; it is generated", rel, dir)
|
|
}
|
|
if opts.PlatformOnly && isServerExecutable(rel) && rel != hostExecPath {
|
|
return nil
|
|
}
|
|
data, err := os.ReadFile(path)
|
|
if err != nil {
|
|
return fmt.Errorf("plugin-pack: reading %s: %w", rel, err)
|
|
}
|
|
files[rel] = data
|
|
return nil
|
|
})
|
|
if walkErr != nil {
|
|
return nil, walkErr
|
|
}
|
|
return files, nil
|
|
}
|
|
|
|
// hostExecutablePath parses dir/manifest.yaml and resolves the
|
|
// runtime.executables entry for opts.GOOS/opts.GOARCH (defaulting to
|
|
// runtime.GOOS/runtime.GOARCH).
|
|
func hostExecutablePath(dir string, opts PackOptions) (string, error) {
|
|
goos := opts.GOOS
|
|
if goos == "" {
|
|
goos = runtime.GOOS
|
|
}
|
|
goarch := opts.GOARCH
|
|
if goarch == "" {
|
|
goarch = runtime.GOARCH
|
|
}
|
|
|
|
data, err := os.ReadFile(filepath.Join(dir, manifestFileName))
|
|
if err != nil {
|
|
return "", fmt.Errorf("plugin-pack: reading %s for -platform-only: %w", manifestFileName, err)
|
|
}
|
|
m, err := manifest.Parse(data)
|
|
if err != nil {
|
|
return "", fmt.Errorf("plugin-pack: parsing %s: %w", manifestFileName, err)
|
|
}
|
|
execPath, ok := m.ExecutableFor(goos, goarch)
|
|
if !ok {
|
|
return "", fmt.Errorf("plugin-pack: manifest declares no runtime.executables entry for %s-%s", goos, goarch)
|
|
}
|
|
return execPath, nil
|
|
}
|
|
|
|
// isServerExecutable reports whether rel is a package-relative path under
|
|
// server/ (the directory pkgtartest/pkgtar treat as holding runtime
|
|
// executables).
|
|
func isServerExecutable(rel string) bool {
|
|
return strings.HasPrefix(rel, serverDirPrefix)
|
|
}
|
|
|
|
// packToFile packs dir into a fresh file at out (creating parent
|
|
// directories as needed), overwriting any existing file.
|
|
func packToFile(dir, out string, platformOnly bool) error {
|
|
if err := os.MkdirAll(filepath.Dir(out), 0o755); err != nil {
|
|
return fmt.Errorf("plugin-pack: creating output dir: %w", err)
|
|
}
|
|
f, err := os.Create(out)
|
|
if err != nil {
|
|
return fmt.Errorf("plugin-pack: creating %s: %w", out, err)
|
|
}
|
|
defer func() { _ = f.Close() }()
|
|
|
|
if err := Pack(dir, f, PackOptions{PlatformOnly: platformOnly}); err != nil {
|
|
return err
|
|
}
|
|
return f.Close()
|
|
}
|