a69a026741
Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
5504 lines
215 KiB
Go
5504 lines
215 KiB
Go
// Package orchestrator provides the main orchestrator service that ties all components together.
|
|
package orchestrator
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"maps"
|
|
"os"
|
|
"runtime"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
agentruntime "github.com/kandev/kandev/internal/agent/runtime"
|
|
"github.com/kandev/kandev/internal/agent/runtime/agentctl"
|
|
"github.com/kandev/kandev/internal/agent/runtime/lifecycle"
|
|
"github.com/kandev/kandev/internal/agent/runtime/routingerr"
|
|
"github.com/kandev/kandev/internal/common/constants"
|
|
"github.com/kandev/kandev/internal/editors/capabilities"
|
|
"github.com/kandev/kandev/internal/events"
|
|
"github.com/kandev/kandev/internal/events/bus"
|
|
"github.com/kandev/kandev/internal/orchestrator/dto"
|
|
"github.com/kandev/kandev/internal/orchestrator/executor"
|
|
"github.com/kandev/kandev/internal/orchestrator/messagequeue"
|
|
"github.com/kandev/kandev/internal/orchestrator/queue"
|
|
"github.com/kandev/kandev/internal/sysprompt"
|
|
"github.com/kandev/kandev/internal/task/models"
|
|
wfmodels "github.com/kandev/kandev/internal/workflow/models"
|
|
v1 "github.com/kandev/kandev/pkg/api/v1"
|
|
)
|
|
|
|
// PromptResult contains the result of a prompt operation
|
|
type PromptResult struct {
|
|
StopReason string // The reason the agent stopped (e.g., "end_turn")
|
|
AgentMessage string // The agent's accumulated response message
|
|
}
|
|
|
|
// CoordinatorTaskStopStatus is the idempotent product result returned to a
|
|
// parent task that asks to halt a direct child.
|
|
type CoordinatorTaskStopStatus string
|
|
|
|
const (
|
|
CoordinatorTaskStopStatusStopped CoordinatorTaskStopStatus = "stopped"
|
|
CoordinatorTaskStopStatusNotRunning CoordinatorTaskStopStatus = "not_running"
|
|
coordinatorMCPStopReason = "stopped by parent task via MCP"
|
|
)
|
|
|
|
// CoordinatorTaskStopResult reports whether at least one live child session
|
|
// accepted logical cancellation. Runtime teardown continues asynchronously.
|
|
type CoordinatorTaskStopResult struct {
|
|
Status CoordinatorTaskStopStatus `json:"status"`
|
|
}
|
|
|
|
// resumeReasonErrorRecovery is the resume reason returned when a session is in
|
|
// error-recovery state (WAITING_FOR_INPUT with a non-empty ErrorMessage).
|
|
const resumeReasonErrorRecovery = "error_recovery"
|
|
|
|
// resumeReasonFailedSessionResumable is the resume reason returned when a
|
|
// FAILED session is auto-resumed because its runtime is Resumable. Distinct
|
|
// from "agent_not_running" so log filtering can isolate FAILED auto-resumes.
|
|
const resumeReasonFailedSessionResumable = "failed_session_resumable"
|
|
|
|
// resumeReasonArchiveCancelledResumable is the resume reason returned when a
|
|
// session cancelled by archiving (see models.IsArchiveCancelReason) is
|
|
// resumable once its task is unarchived — the cancellation was a system side
|
|
// effect of Service.ArchiveTask / HandoffService's cascade archive, not an
|
|
// explicit user/coordinator stop, so it must recover like a FAILED session
|
|
// instead of staying stuck on read-only workspace restore.
|
|
const resumeReasonArchiveCancelledResumable = "archive_cancelled_resumable"
|
|
|
|
var ErrAgentPromptInProgress = errors.New("agent is currently processing a prompt")
|
|
var ErrAgentNotReadyForPrompt = errors.New("agent not ready for prompt")
|
|
var ErrSessionResetInProgress = errors.New("session reset in progress")
|
|
|
|
type primarySessionTaskStateUpdater interface {
|
|
UpdateTaskStateIfPrimarySessionState(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
expectedSessionState models.TaskSessionState,
|
|
state v1.TaskState,
|
|
) (bool, error)
|
|
}
|
|
|
|
// ErrSessionNotPromptable is returned when a session cannot accept a prompt
|
|
// because of its lifecycle state (STARTING, CREATED, FAILED, CANCELLED).
|
|
// Distinct from ErrAgentPromptInProgress, which is RUNNING-only — confusing
|
|
// the two misleads the UI and any caller doing errors.Is checks.
|
|
var ErrSessionNotPromptable = errors.New("session not promptable")
|
|
|
|
// errQueuedDispatchSuperseded is returned by promptTask when a queued
|
|
// message's dispatch loses its claim (see isCurrentQueuedDispatch) to a
|
|
// newer dispatch for the same session — e.g. a second parent interrupt
|
|
// cancelling and re-taking while the first dispatch's own goroutine was
|
|
// still settling. Not surfaced to callers of the public PromptTask; only
|
|
// executeQueuedMessage's internal call passes a claim token that can
|
|
// trigger this.
|
|
var errQueuedDispatchSuperseded = errors.New("queued dispatch superseded by a newer one for this session")
|
|
|
|
var (
|
|
// Backend restart recovery can restore the session state before the ACP
|
|
// stream is promptable again. Keep this above CI's slow-start tail so a
|
|
// valid resume waits instead of surfacing "Failed to send message to agent".
|
|
agentPromptReadyTimeout = 30 * time.Second
|
|
agentPromptReadyInterval = 100 * time.Millisecond
|
|
)
|
|
|
|
const promptReadinessRecoveryStopReason = "prompt readiness recovery"
|
|
|
|
type agentPromptStreamRecoverer interface {
|
|
RecoverAgentPromptStream(ctx context.Context, sessionID string) error
|
|
}
|
|
|
|
func isAgentPromptInProgressError(err error) bool {
|
|
return err != nil && errors.Is(err, ErrAgentPromptInProgress)
|
|
}
|
|
|
|
// isSessionBusyError reports whether the session is in a state where a queued
|
|
// or auto-started prompt should be retried later rather than dropped. Covers
|
|
// both "the agent is mid-turn" (ErrAgentPromptInProgress, RUNNING) and "the
|
|
// session isn't yet ready to accept input" (ErrSessionNotPromptable —
|
|
// STARTING, CREATED, FAILED, CANCELLED). The pre-PR code path collapsed both
|
|
// into ErrAgentPromptInProgress; this helper preserves the requeue behaviour
|
|
// after the error split so queued messages targeting a session that is
|
|
// briefly STARTING/CREATED don't get silently dropped (see TODO about the
|
|
// missing dead-letter queue in executeQueuedMessage).
|
|
func isSessionBusyError(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
return errors.Is(err, ErrAgentPromptInProgress) || errors.Is(err, ErrSessionNotPromptable)
|
|
}
|
|
|
|
func isSessionResetInProgressError(err error) bool {
|
|
return err != nil && errors.Is(err, ErrSessionResetInProgress)
|
|
}
|
|
|
|
// isTransientPromptError reports whether a prompt error is worth retrying via
|
|
// the queue. ErrExecutionNotFound is intentionally NOT included here:
|
|
// callers that can recover (autoStartStepPrompt → fallbackFreshLaunchOnMissingExecution)
|
|
// detect it explicitly via errors.Is and route differently; callers that
|
|
// can't (executeQueuedMessage) should not infinite-requeue on it. Treating
|
|
// "execution not found" as transient blanket-applies a retry that loops
|
|
// forever when the execution is genuinely gone.
|
|
func isTransientPromptError(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
msg := strings.ToLower(err.Error())
|
|
return strings.Contains(msg, "agent stream disconnected") ||
|
|
strings.Contains(msg, "use of closed network connection")
|
|
}
|
|
|
|
// isManualRecoveryPromptError identifies a provider error that should retain
|
|
// the queued prompt until the user explicitly resumes the session. It is
|
|
// intentionally separate from isTransientPromptError: exhausted usage does
|
|
// not become available on a short automatic retry, and repeatedly attempting
|
|
// it would consume the queue's retry budget without making progress.
|
|
func isManualRecoveryPromptError(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
message := strings.ToLower(err.Error())
|
|
return strings.Contains(message, "usagelimitexceeded") ||
|
|
strings.Contains(message, "you've hit your usage limit")
|
|
}
|
|
|
|
func isAgentAlreadyRunningError(err error) bool {
|
|
return err != nil && errors.Is(err, lifecycle.ErrAgentAlreadyRunning)
|
|
}
|
|
|
|
// missingSessionWorktreePaths returns the session's recorded worktree
|
|
// directories that are no longer on disk.
|
|
func missingSessionWorktreePaths(session *models.TaskSession) []string {
|
|
var missing []string
|
|
for _, wt := range session.Worktrees {
|
|
if wt == nil || wt.WorktreePath == "" {
|
|
continue
|
|
}
|
|
if _, err := os.Stat(wt.WorktreePath); err != nil {
|
|
missing = append(missing, wt.WorktreePath)
|
|
}
|
|
}
|
|
return missing
|
|
}
|
|
|
|
// noteMissingWorktreesBeforeResume records that a resume is about to go
|
|
// through the worktree manager's recreate path.
|
|
//
|
|
// A missing directory is NOT a resume blocker. Archive cleanup deletes the
|
|
// worktree directory while keeping the environment repository row and the git
|
|
// branch (DestroyWorktree passes removeBranch=false), so *every* resume after
|
|
// an unarchive observes exactly this shape. worktree.Manager.Create reuses the
|
|
// stored record, restores the branch — locally, or by fetching it back from
|
|
// origin — and rebuilds the directory at the same path, which is what the
|
|
// recreate path was written for. Rejecting the resume here instead made
|
|
// unarchive a dead end: the session could never be resumed and the workspace
|
|
// was never restored, even though the work itself was still intact.
|
|
func (s *Service) noteMissingWorktreesBeforeResume(sessionID string, session *models.TaskSession) {
|
|
missing := missingSessionWorktreePaths(session)
|
|
if len(missing) == 0 {
|
|
return
|
|
}
|
|
s.logger.Info("worktree directory missing on resume; it will be recreated from the stored branch",
|
|
zap.String("session_id", sessionID),
|
|
zap.Strings("paths", missing))
|
|
}
|
|
|
|
// EnqueueTask manually adds a task to the queue
|
|
func (s *Service) EnqueueTask(ctx context.Context, task *v1.Task) error {
|
|
s.logger.Debug("manually enqueueing task",
|
|
zap.String("task_id", task.ID),
|
|
zap.String("title", task.Title))
|
|
return s.scheduler.EnqueueTask(task)
|
|
}
|
|
|
|
// PrepareTaskSession creates a session entry without launching the agent.
|
|
// This allows the WS handler to return the session ID immediately while workspace setup
|
|
// continues in the background. Use StartCreatedSession to continue with agent launch.
|
|
// When launchWorkspace is true, workspace infrastructure (agentctl) is launched asynchronously;
|
|
// the frontend receives preparation progress via executor.prepare.progress WS events.
|
|
func (s *Service) PrepareTaskSession(ctx context.Context, taskID string, agentProfileID string, executorID string, executorProfileID string, workflowStepID string, launchWorkspace bool) (string, error) {
|
|
s.logger.Debug("preparing task session",
|
|
zap.String("task_id", taskID),
|
|
zap.String("agent_profile_id", agentProfileID),
|
|
zap.String("executor_id", executorID),
|
|
zap.String("executor_profile_id", executorProfileID),
|
|
zap.String("workflow_step_id", workflowStepID),
|
|
zap.Bool("launch_workspace", launchWorkspace))
|
|
|
|
// Fetch the task to get workspace info
|
|
task, err := s.scheduler.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
s.logger.Error("failed to fetch task for session preparation",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
return "", err
|
|
}
|
|
// Resolve agent/executor profile from task metadata if not explicitly provided
|
|
if agentProfileID == "" {
|
|
if v, ok := task.Metadata[models.MetaKeyAgentProfileID].(string); ok && v != "" {
|
|
agentProfileID = v
|
|
}
|
|
}
|
|
if executorID == "" {
|
|
if v, ok := task.Metadata[models.MetaKeyExecutorID].(string); ok && v != "" {
|
|
executorID = v
|
|
}
|
|
}
|
|
if executorProfileID == "" {
|
|
if v, ok := task.Metadata[models.MetaKeyExecutorProfileID].(string); ok && v != "" {
|
|
executorProfileID = v
|
|
}
|
|
}
|
|
|
|
// Inherit agent/executor profile from parent task's primary session when not
|
|
// explicitly provided. This covers subtasks created with start_agent=false that
|
|
// are later opened manually from the UI. We check each field independently so
|
|
// that a caller providing only some fields still gets the rest filled in.
|
|
if (agentProfileID == "" || executorProfileID == "" || executorID == "") && task.ParentID != "" {
|
|
agentProfileID, executorProfileID, executorID = s.inheritFromParentSession(
|
|
ctx, task.ParentID, agentProfileID, executorProfileID, executorID,
|
|
)
|
|
|
|
// Fall back to workspace defaults for agent profile (subtasks only —
|
|
// regular tasks resolve defaults downstream in the executor layer).
|
|
if agentProfileID == "" {
|
|
workspace, err := s.repo.GetWorkspace(ctx, task.WorkspaceID)
|
|
if err == nil && workspace != nil && workspace.DefaultAgentProfileID != nil && *workspace.DefaultAgentProfileID != "" {
|
|
agentProfileID = *workspace.DefaultAgentProfileID
|
|
}
|
|
}
|
|
if executorID == "" && executorProfileID == "" {
|
|
executorID = models.ExecutorIDWorktree
|
|
}
|
|
}
|
|
|
|
// Fall back to the task's current workflow step when the caller didn't provide one.
|
|
// This ensures sessions created via the kanban card (which doesn't send workflow_step_id)
|
|
// inherit the task's step and participate in workflow events.
|
|
if workflowStepID == "" {
|
|
dbTask, err := s.repo.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to fetch task for workflow step fallback",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
} else if dbTask.WorkflowStepID != "" {
|
|
workflowStepID = dbTask.WorkflowStepID
|
|
}
|
|
}
|
|
|
|
// Create session entry in database. Office tasks route through
|
|
// EnsureSessionForAgent so runs + advanced-mode reuse one row.
|
|
// prepareSessionForStart also propagates any inherited workspace
|
|
// environment (inherit_parent / shared_group) onto the new session.
|
|
sessionID, sessionCreated, err := s.prepareSessionForStart(ctx, task, agentProfileID, executorID, executorProfileID, workflowStepID)
|
|
if err != nil {
|
|
s.logger.Error("failed to prepare session",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
return "", err
|
|
}
|
|
|
|
// Notify the frontend that a new CREATED session exists. The start path
|
|
// transitions through updateTaskSessionState which broadcasts; the prepare
|
|
// path writes the row directly, so without this the per-task session list
|
|
// stays empty until a manual reload.
|
|
if sessionCreated {
|
|
s.publishSessionCreatedEvent(ctx, taskID, sessionID, workflowStepID)
|
|
}
|
|
|
|
if launchWorkspace {
|
|
// Launch workspace infrastructure (agentctl) in the background so the WS response
|
|
// returns the session ID immediately. The frontend navigates to the session page
|
|
// and shows preparation progress via executor.prepare.progress WS events.
|
|
go func() {
|
|
bgCtx := context.Background()
|
|
prepExec, launchErr := s.executor.LaunchPreparedSession(bgCtx, task, sessionID, executor.LaunchOptions{AgentProfileID: agentProfileID, ExecutorID: executorID, WorkflowStepID: workflowStepID})
|
|
if launchErr != nil {
|
|
// LaunchAgent failures persist FAILED in the executor. Earlier
|
|
// workspace failures return here and are recorded through the same
|
|
// session-level recovery claim.
|
|
launchErr = s.handleSessionLaunchFailure(bgCtx, taskID, sessionID, launchErr)
|
|
s.logger.Warn("failed to launch workspace for prepared session (file browsing may be unavailable)",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(launchErr))
|
|
return
|
|
}
|
|
if prepExec != nil {
|
|
s.ensureSessionPRWatch(bgCtx, taskID, prepExec.SessionID, prepExec.WorktreeBranch)
|
|
}
|
|
}()
|
|
}
|
|
|
|
s.logger.Info("task session prepared",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
|
|
return sessionID, nil
|
|
}
|
|
|
|
// StartCreatedSession starts agent execution for a task using a session that is in CREATED state.
|
|
// This is used when a session was prepared (via PrepareSession) but the agent was not launched,
|
|
// and the user now wants to start the agent with a prompt (e.g., from the plan panel or chat).
|
|
// When skipMessageRecord is true, only the session state is updated (the caller already stored the user message).
|
|
// When planMode is true, plan mode instructions are injected into the prompt and session metadata is set.
|
|
// autoStart marks the launch as having been triggered by an automated path
|
|
// (only consumed when skipMessageRecord is false — callers that store their
|
|
// own message control its metadata directly).
|
|
// references contains validated entity references whose exact server-generated
|
|
// context block may survive first-turn canonicalization.
|
|
//
|
|
//nolint:cyclop,funlen,gocognit // Existing complexity inherited from session-lifecycle handling.
|
|
func (s *Service) StartCreatedSession(
|
|
ctx context.Context,
|
|
taskID, sessionID, agentProfileID, prompt string,
|
|
skipMessageRecord, planMode, autoStart bool,
|
|
attachments []v1.MessageAttachment,
|
|
references []v1.EntityReference,
|
|
) (*executor.TaskExecution, error) {
|
|
// One GetWorkflowMeta read shared by profile resolution and prompt build.
|
|
ctx = withWorkflowMetaCache(ctx)
|
|
|
|
s.logger.Debug("starting created session",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("agent_profile_id", agentProfileID))
|
|
|
|
// Load and verify session
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to get session: %w", err)
|
|
}
|
|
if session.TaskID != taskID {
|
|
return nil, fmt.Errorf("session does not belong to task")
|
|
}
|
|
// Accept CREATED (normal) or WAITING_FOR_INPUT (after on_turn_start step transition).
|
|
// When the user sends the first message to a prepared session, on_turn_start may fire
|
|
// and move the step, which sets the session to WAITING_FOR_INPUT before we get here.
|
|
if session.State != models.TaskSessionStateCreated && session.State != models.TaskSessionStateWaitingForInput {
|
|
return nil, fmt.Errorf("session is not in CREATED or WAITING_FOR_INPUT state (current: %s)", session.State)
|
|
}
|
|
|
|
// Office-owned sessions must be started by the scheduler. Reject before
|
|
// resolving profiles or persisting any caller-derived session metadata.
|
|
isOfficeTask, err := s.lookupOfficeTask(ctx, taskID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to determine office task status: %w", err)
|
|
}
|
|
if isOfficeTask {
|
|
return nil, errOfficeTaskStartRequiresScheduler
|
|
}
|
|
|
|
// Use agent profile from request, fall back to session's stored value.
|
|
effectiveProfileID := agentProfileID
|
|
if effectiveProfileID == "" {
|
|
effectiveProfileID = session.AgentProfileID
|
|
}
|
|
|
|
// Resolve the workflow step override / workflow default before the
|
|
// required-profile guard, so a session without its own agent_profile_id
|
|
// inherits the workflow's default agent. resolveEffectiveAgentProfile keeps
|
|
// the caller profile only when neither a step override nor a workflow
|
|
// default applies; either of those overrides a non-empty caller.
|
|
effectiveProfileID = s.resolveEffectiveAgentProfile(ctx, taskID, "", effectiveProfileID)
|
|
|
|
if effectiveProfileID == "" {
|
|
return nil, fmt.Errorf("agent_profile_id is required")
|
|
}
|
|
|
|
// If the workflow step overrode the profile, update the session record in DB
|
|
// so the frontend tab displays the correct agent (it reads session.agent_profile_id).
|
|
if effectiveProfileID != session.AgentProfileID {
|
|
observedState := session.State
|
|
s.logger.Info("updating session agent profile for workflow step override",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("old_profile", session.AgentProfileID),
|
|
zap.String("new_profile", effectiveProfileID))
|
|
session.AgentProfileID = effectiveProfileID
|
|
// Re-resolve the agent profile snapshot so the tab shows the correct agent logo/name.
|
|
// Set a minimal snapshot first so stale data is never persisted if resolution fails.
|
|
session.AgentProfileSnapshot = map[string]interface{}{"id": effectiveProfileID}
|
|
if profileInfo, err := s.agentManager.ResolveAgentProfile(ctx, effectiveProfileID); err != nil {
|
|
s.logger.Warn("failed to resolve agent profile snapshot for workflow step override",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("profile_id", effectiveProfileID),
|
|
zap.Error(err))
|
|
} else if profileInfo != nil {
|
|
session.AgentProfileSnapshot = map[string]interface{}{
|
|
"id": profileInfo.ProfileID,
|
|
"name": profileInfo.ProfileName,
|
|
"agent_id": profileInfo.AgentID,
|
|
"agent_name": profileInfo.AgentName,
|
|
"model": profileInfo.Model,
|
|
"mode": profileInfo.Mode,
|
|
"config_options": maps.Clone(profileInfo.ConfigOptions),
|
|
}
|
|
}
|
|
if err := s.persistFullTaskSessionIfCurrent(ctx, session, observedState); err != nil {
|
|
return nil, fmt.Errorf("persist workflow session profile: %w", err)
|
|
}
|
|
// Tag as workflow-spawned provenance only after the guarded profile
|
|
// write succeeds; a concurrent stop owns a rejected session.
|
|
s.tagSessionAsWorkflowSwitched(ctx, sessionID)
|
|
s.promoteSessionIfTaskHasNoPrimary(ctx, taskID, session)
|
|
}
|
|
|
|
// Transition task state: CREATED → SCHEDULING → (IN_PROGRESS via executor).
|
|
if err := s.scheduleTaskForSession(ctx, taskID, sessionID); err != nil {
|
|
s.logger.Warn("failed to update task state to SCHEDULING",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
return nil, err
|
|
}
|
|
|
|
task, err := s.scheduler.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
effectivePrompt := prompt
|
|
if effectivePrompt == "" {
|
|
effectivePrompt = task.Description
|
|
}
|
|
|
|
// NOTE: on_turn_start is intentionally NOT processed here.
|
|
// - User-initiated path: dispatchPromptAsync (message_handlers.go) already
|
|
// calls ProcessOnTurnStart before invoking StartCreatedSession via
|
|
// forwardMessageAsPrompt, so on_turn_start has already fired.
|
|
// - Workflow auto-start path: autoStartStepPrompt calls us because the
|
|
// workflow just transitioned us into this step (via on_turn_complete or
|
|
// on_enter). Firing on_turn_start again here cascades the workflow back
|
|
// out before the step's auto-start prompt can be delivered to its agent.
|
|
//
|
|
// However, for the user-initiated path, on_turn_start may have switched the
|
|
// session profile already, in which case the session ID we were called with
|
|
// is now COMPLETED and we need to redirect to the new active session.
|
|
session, err = s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to reload session: %w", err)
|
|
}
|
|
if session.State == models.TaskSessionStateCompleted {
|
|
activeSession, activeErr := s.repo.GetActiveTaskSessionByTaskID(ctx, taskID)
|
|
if activeErr != nil || activeSession == nil {
|
|
return nil, fmt.Errorf("session was switched but no active session found: %w", activeErr)
|
|
}
|
|
session = activeSession
|
|
sessionID = activeSession.ID
|
|
effectiveProfileID = activeSession.AgentProfileID
|
|
}
|
|
|
|
// Apply workflow step prompt wrapping and plan mode injection.
|
|
// Called unconditionally so workflow-step prompt composition (prefix/suffix)
|
|
// applies even when plan mode is not requested.
|
|
// Re-read the task after on_turn_start may have changed the workflow step.
|
|
// Ephemeral tasks skip workflow step processing since they have no workflow.
|
|
dbTask, err := s.repo.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to reload task after on_turn_start: %w", err)
|
|
}
|
|
configMode := false
|
|
if cm, ok := session.Metadata["config_mode"].(bool); ok && cm {
|
|
configMode = true
|
|
}
|
|
titleOwner := false
|
|
if !configMode {
|
|
titleOwner, err = s.ClaimTaskTitleSession(ctx, taskID, sessionID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to claim first-turn task title: %w", err)
|
|
}
|
|
}
|
|
effectivePrompt, planModeActive, promptReferenceContext := s.applyWorkflowAndPlanMode(
|
|
ctx, effectivePrompt, taskID, sessionID, dbTask.WorkflowStepID,
|
|
planMode, task.IsEphemeral, session.IsPassthrough,
|
|
)
|
|
|
|
// Inject config context for config-mode sessions (dedicated settings chat)
|
|
if configMode {
|
|
effectivePrompt = sysprompt.InjectConfigContext(sessionID, effectivePrompt)
|
|
}
|
|
|
|
// Wrap the first prompt with the Kandev MCP system block. See the
|
|
// matching block in startTask for the rationale (DB stores wrapped form;
|
|
// Message.ToAPI strips for display). The injectors canonicalize any upstream
|
|
// wrap from current server state before launch.
|
|
// Passthrough profiles skip the wrap: the prompt is typed straight into the
|
|
// agent CLI's TTY and the user sees it verbatim — they don't want a wall of
|
|
// MCP-tool boilerplate prepended to "hello".
|
|
if effectivePrompt != "" || len(attachments) > 0 {
|
|
effectivePrompt = s.wrapCreatedSessionPrompt(
|
|
ctx, effectivePrompt, taskID, sessionID, session, dbTask,
|
|
isOfficeTask, configMode, titleOwner, references, promptReferenceContext,
|
|
)
|
|
}
|
|
|
|
executorID := session.ExecutorID
|
|
|
|
// Cache the raw prompt so a transient-provider-error (529) retry can
|
|
// re-drive this first turn — initial launches bypass PromptTask.
|
|
s.rememberTurnPrompt(sessionID, prompt, "", planMode, attachments)
|
|
|
|
mcpMode := ""
|
|
if isOfficeTask {
|
|
mcpMode = executor.McpModeOffice
|
|
}
|
|
execution, err := s.executor.LaunchPreparedSession(ctx, task, sessionID, executor.LaunchOptions{AgentProfileID: effectiveProfileID, ExecutorID: executorID, Prompt: effectivePrompt, StartAgent: true, McpMode: mcpMode, Attachments: attachments})
|
|
if err != nil {
|
|
// The executor persists LaunchAgent failures. Cover earlier prepared-session
|
|
// failures here; the session-level claim makes either completion order safe.
|
|
return nil, s.handleSessionLaunchFailure(ctx, taskID, sessionID, err)
|
|
}
|
|
|
|
// Record the initial user message and set plan mode metadata after launch.
|
|
// Note: we do NOT set session state here — the executor sets it to STARTING,
|
|
// and event handlers (handleAgentReady) transition it to WAITING_FOR_INPUT.
|
|
s.postLaunchCreated(ctx, taskID, sessionID, effectivePrompt, skipMessageRecord, planModeActive, autoStart, attachments)
|
|
|
|
// Ensure a PR watch exists so the poller can detect PRs created by the agent.
|
|
// PrepareTaskSession may have already created one, but if that goroutine failed
|
|
// or hadn't completed, this guarantees coverage.
|
|
go s.ensureSessionPRWatch(context.Background(), taskID, execution.SessionID, execution.WorktreeBranch)
|
|
|
|
return execution, nil
|
|
}
|
|
|
|
// wrapCreatedSessionPrompt adds the first-turn context for a prepared session.
|
|
// Passthrough sessions intentionally receive only the short pending-title
|
|
// instruction; structured sessions receive the normal task or Office block.
|
|
func (s *Service) wrapCreatedSessionPrompt(
|
|
ctx context.Context,
|
|
prompt, taskID, sessionID string,
|
|
session *models.TaskSession,
|
|
dbTask *models.Task,
|
|
isOfficeTask, configMode, titleOwner bool,
|
|
references []v1.EntityReference,
|
|
promptReferenceContext string,
|
|
) string {
|
|
referenceContext := EntityReferenceContext(references)
|
|
switch {
|
|
case session.IsPassthrough:
|
|
if !configMode && titleOwner {
|
|
return sysprompt.PendingTaskTitlePassthroughInstruction() + "\n\n" + prompt
|
|
}
|
|
return prompt
|
|
case isOfficeTask:
|
|
return sysprompt.InjectOfficeContext(
|
|
taskID, sessionID, prompt, referenceContext, promptReferenceContext,
|
|
)
|
|
default:
|
|
return sysprompt.InjectKandevContextWithOptions(taskID, sessionID, prompt, sysprompt.KandevContextOptions{
|
|
RequiresCompletionSignal: s.WorkflowStepRequiresCompletionSignal(ctx, dbTask.WorkflowStepID),
|
|
IncludeCoordinatorTaskControls: !configMode,
|
|
IncludeTaskTitleTool: !configMode && titleOwner,
|
|
Autopilot: dbTask.Autopilot,
|
|
IncludeUserQuestionTool: !dbTask.Autopilot && !session.IsPassthrough,
|
|
IncludeParentQuestionTool: dbTask.Autopilot && dbTask.ParentID != "",
|
|
}, referenceContext, promptReferenceContext)
|
|
}
|
|
}
|
|
|
|
// handleSessionLaunchFailure covers launch and resume failures that have not
|
|
// already won terminal bookkeeping. The state CAS makes it safe as an
|
|
// idempotent fallback when executor bookkeeping did run.
|
|
func (s *Service) handleSessionLaunchFailure(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
launchErr error,
|
|
preloadedSession ...*models.TaskSession,
|
|
) error {
|
|
failureCtx := context.WithoutCancel(ctx)
|
|
safeErr := routingerr.SanitizeError(launchErr)
|
|
s.recordSessionLaunchFailure(
|
|
failureCtx, taskID, sessionID, safeErr, preloadedSession...,
|
|
)
|
|
return safeErr
|
|
}
|
|
|
|
// recordSessionLaunchFailure transitions a still-active session to FAILED,
|
|
// attaches missing-branch guidance only after that CAS succeeds, and updates
|
|
// the task only while the same failed session still owns it.
|
|
func (s *Service) recordSessionLaunchFailure(ctx context.Context, taskID, sessionID string, launchErr error, preloadedSession ...*models.TaskSession) {
|
|
_, changed := s.updateTaskSessionStateWithHook(
|
|
ctx, taskID, sessionID, models.TaskSessionStateFailed, launchErr.Error(), false,
|
|
func() { s.handleSessionLaunchFailed(ctx, taskID, sessionID, "", launchErr) }, preloadedSession...,
|
|
)
|
|
if !changed {
|
|
// A resume may begin from an already FAILED session. Its state CAS is
|
|
// intentionally a no-op, but the persisted claim still lets this newly
|
|
// classified failure publish guidance exactly once. The claim itself is
|
|
// state-guarded, so a concurrently cancelled/completed session cannot
|
|
// receive stale recovery UI.
|
|
if len(preloadedSession) > 0 && preloadedSession[0] != nil && preloadedSession[0].State == models.TaskSessionStateFailed {
|
|
s.handleSessionLaunchFailed(ctx, taskID, sessionID, "", launchErr)
|
|
}
|
|
return
|
|
}
|
|
updated, err := s.updateTaskStateForEarlyLaunchFailure(ctx, taskID, sessionID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to update task state to FAILED after early launch error",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
if !updated {
|
|
return
|
|
}
|
|
s.processParentChildrenCompletedForTaskState(ctx, taskID, v1.TaskStateFailed)
|
|
}
|
|
|
|
func (s *Service) updateTaskStateForEarlyLaunchFailure(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
) (bool, error) {
|
|
if updater, ok := s.taskRepo.(primarySessionTaskStateUpdater); ok {
|
|
return updater.UpdateTaskStateIfPrimarySessionState(
|
|
ctx, taskID, sessionID, models.TaskSessionStateFailed, v1.TaskStateFailed,
|
|
)
|
|
}
|
|
// Lightweight test repositories predate the primary-aware extension.
|
|
return s.taskRepo.UpdateTaskStateIfSessionState(
|
|
ctx, taskID, sessionID, models.TaskSessionStateFailed, v1.TaskStateFailed,
|
|
)
|
|
}
|
|
|
|
func (s *Service) reconcileTaskStateForEarlyLaunchFailure(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
state v1.TaskState,
|
|
) error {
|
|
if state != v1.TaskStateFailed {
|
|
return fmt.Errorf("unsupported early launch task state %q", state)
|
|
}
|
|
updated, err := s.updateTaskStateForEarlyLaunchFailure(ctx, taskID, sessionID)
|
|
if err != nil || !updated {
|
|
return err
|
|
}
|
|
s.processParentChildrenCompletedForTaskState(ctx, taskID, state)
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) scheduleTaskForSession(ctx context.Context, taskID, sessionID string) error {
|
|
s.taskRuntimeStateMu.Lock()
|
|
defer s.taskRuntimeStateMu.Unlock()
|
|
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if session == nil {
|
|
return fmt.Errorf("%w: agent session not found: %s", models.ErrTaskSessionNotFound, sessionID)
|
|
}
|
|
if session.State != models.TaskSessionStateCreated &&
|
|
session.State != models.TaskSessionStateWaitingForInput {
|
|
if isTerminalSessionState(session.State) {
|
|
return &executor.SessionStateSupersededError{SessionID: session.ID, State: session.State}
|
|
}
|
|
return fmt.Errorf("session %s is %s; cannot schedule task", session.ID, session.State)
|
|
}
|
|
return s.taskRepo.UpdateTaskState(ctx, taskID, v1.TaskStateScheduling)
|
|
}
|
|
|
|
func (s *Service) promoteSessionIfTaskHasNoPrimary(ctx context.Context, taskID string, session *models.TaskSession) {
|
|
if session == nil || session.IsPrimary {
|
|
return
|
|
}
|
|
sessions, err := s.repo.ListTaskSessions(ctx, taskID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to inspect task sessions for missing primary",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", session.ID),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
for _, existing := range sessions {
|
|
if existing.IsPrimary {
|
|
return
|
|
}
|
|
}
|
|
if err := s.SetPrimarySession(ctx, session.ID); err != nil {
|
|
s.logger.Warn("failed to promote workflow session as primary",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", session.ID),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
session.IsPrimary = true
|
|
}
|
|
|
|
// postLaunchCreated handles post-launch bookkeeping for a created session:
|
|
// records the initial user message (unless skipped) and sets plan mode metadata.
|
|
// It does NOT modify session state — the executor sets STARTING, and event handlers
|
|
// (handleAgentReady) handle the transition to WAITING_FOR_INPUT.
|
|
// autoStart marks the message as having been created by an automated trigger
|
|
// (preserved through to recordInitialMessage's auto_start metadata tag); the
|
|
// flag is only consumed when skipMessage is false (callers that store their
|
|
// own message control its metadata directly).
|
|
func (s *Service) postLaunchCreated(ctx context.Context, taskID, sessionID, prompt string, skipMessage, planModeActive, autoStart bool, attachments []v1.MessageAttachment) {
|
|
if !skipMessage {
|
|
s.recordInitialMessage(ctx, taskID, sessionID, prompt, planModeActive, autoStart, attachments)
|
|
}
|
|
|
|
if planModeActive {
|
|
sess, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err == nil {
|
|
s.setSessionPlanMode(ctx, sess, true)
|
|
}
|
|
}
|
|
}
|
|
|
|
// StartTask manually starts agent execution for a task.
|
|
// If workflowStepID is provided and workflowStepGetter is set, the prompt will be built
|
|
// using the step's prompt_prefix + base prompt + prompt_suffix, and plan mode will be
|
|
// applied if the step has plan_mode enabled.
|
|
// If planMode is true and the workflow step doesn't already apply plan mode,
|
|
// default plan mode instructions are injected into the prompt.
|
|
// autoStart marks the launch as having been triggered by an automated path
|
|
// (PR/issue/Jira/Linear watch, workflow auto-start) rather than direct user
|
|
// input — the seed prompt is tagged so the github cleanup loop can tell
|
|
// "agent ran on its own" from "user actually engaged".
|
|
func (s *Service) StartTask(ctx context.Context, taskID string, agentProfileID string, executorID string, executorProfileID string, priority string, prompt string, workflowStepID string, planMode, autoStart bool, attachments []v1.MessageAttachment) (*executor.TaskExecution, error) {
|
|
return s.startTask(ctx, taskID, agentProfileID, executorID, executorProfileID, priority, prompt, workflowStepID, planMode, autoStart, attachments, startTaskOptions{})
|
|
}
|
|
|
|
// StartTaskWithEnv starts a task and carries launch-scoped environment variables
|
|
// through to the agent runtime. Existing StartTask callers keep the old behavior.
|
|
func (s *Service) StartTaskWithEnv(ctx context.Context, taskID string, agentProfileID string, executorID string, executorProfileID string, priority string, prompt string, workflowStepID string, planMode, autoStart bool, attachments []v1.MessageAttachment, env map[string]string) (*executor.TaskExecution, error) {
|
|
return s.startTask(ctx, taskID, agentProfileID, executorID, executorProfileID, priority, prompt, workflowStepID, planMode, autoStart, attachments, startTaskOptions{Env: env})
|
|
}
|
|
|
|
// startTaskOptions carries the optional, server-only launch inputs that only
|
|
// some callers supply. Keeping them in one struct avoids growing startTask's
|
|
// already long positional parameter list for every new orthogonal concern.
|
|
type startTaskOptions struct {
|
|
// Env holds launch-scoped environment variables for the agent runtime.
|
|
Env map[string]string
|
|
// Route pins a concrete execution profile chosen by Office provider routing.
|
|
Route *executor.RouteOverride
|
|
// SpawnOrigin is set when another agent session spawned this launch; it
|
|
// produces the spawner-attribution system block on the first turn.
|
|
SpawnOrigin *SpawnOrigin
|
|
}
|
|
|
|
// StartTaskWithRoute launches a stable Office identity through a complete
|
|
// concrete execution profile selected by the routing dispatcher.
|
|
//
|
|
// launch carries the Office-built launch context (prompt, env, workflow
|
|
// step, attachments, plan-mode flag) so routed launches behave
|
|
// identically to the legacy launch path for everything except provider
|
|
// selection. Without launch, routed runs would fall back to
|
|
// task.Description and drop role framing / AGENTS.md / wake context.
|
|
//
|
|
// Office-routed launches use autoStart=false: the user kicked off the
|
|
// task; the office layer only chose the provider.
|
|
func (s *Service) StartTaskWithRoute(
|
|
ctx context.Context, taskID, agentProfileID string,
|
|
launch executor.LaunchContext, route executor.RouteOverride,
|
|
) error {
|
|
_, err := s.startTask(ctx, taskID, agentProfileID,
|
|
launch.ExecutorID, launch.ExecutorProfileID, launch.Priority,
|
|
launch.Prompt, launch.WorkflowStepID, launch.PlanMode, false,
|
|
launch.Attachments, startTaskOptions{Env: launch.Env, Route: &route})
|
|
return err
|
|
}
|
|
|
|
//nolint:cyclop,funlen,gocognit // launch path threads many orthogonal concerns (workflow-step / agent-profile / office-task / config-mode / route / system-prompt wrapping); splitting it would require shared mutable state across helpers
|
|
func (s *Service) startTask(ctx context.Context, taskID string, agentProfileID string, executorID string, executorProfileID string, priority string, prompt string, workflowStepID string, planMode, autoStart bool, attachments []v1.MessageAttachment, opts startTaskOptions) (*executor.TaskExecution, error) {
|
|
// One GetWorkflowMeta read shared by profile resolution and prompt build.
|
|
ctx = withWorkflowMetaCache(ctx)
|
|
|
|
env, route := opts.Env, opts.Route
|
|
s.logger.Debug("manually starting task",
|
|
zap.String("task_id", taskID),
|
|
zap.String("agent_profile_id", agentProfileID),
|
|
zap.String("executor_id", executorID),
|
|
zap.String("priority", priority),
|
|
zap.Int("prompt_length", len(prompt)),
|
|
zap.String("workflow_step_id", workflowStepID),
|
|
zap.Bool("plan_mode", planMode),
|
|
zap.Bool("auto_start", autoStart),
|
|
zap.Int("attachments", len(attachments)))
|
|
|
|
isOfficeTask, err := s.lookupOfficeTask(ctx, taskID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to determine office task status: %w", err)
|
|
}
|
|
if isOfficeTask {
|
|
if err := validateOfficeLaunchEnv(taskID, env); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
workflowSessionConfigStepID := workflowStepID
|
|
// Manual starts often omit workflow_step_id because the task is already
|
|
// bound to its current step. Resolve that canonical step before profile
|
|
// selection and launch-layer session configuration so a start-step rule is
|
|
// applied before the first prompt as well.
|
|
if workflowSessionConfigStepID == "" {
|
|
if dbTask, taskErr := s.repo.GetTask(ctx, taskID); taskErr != nil {
|
|
s.logger.Warn("failed to fetch task for workflow step fallback",
|
|
zap.String("task_id", taskID), zap.Error(taskErr))
|
|
} else if dbTask != nil {
|
|
workflowSessionConfigStepID = dbTask.WorkflowStepID
|
|
}
|
|
}
|
|
|
|
// Office tasks do NOT transition through SCHEDULING / IN_PROGRESS on
|
|
// every run. Their lifecycle status (todo / in_review / done /
|
|
// blocked / cancelled) reflects the *user-meaningful workflow*, not
|
|
// the orchestrator's runtime cycle. Runs schedule the *agent*,
|
|
// not the task — the agent's runtime state is shown via the topbar
|
|
// Working spinner + inline session timeline entry. Suppressing the
|
|
// transition here avoids gratuitous flicker (REVIEW → SCHEDULING →
|
|
// IN_PROGRESS → REVIEW for a single comment-reply cycle) and matches
|
|
// the user's mental model.
|
|
if isOfficeTask {
|
|
s.logger.Debug("skipping SCHEDULING transition for office task",
|
|
zap.String("task_id", taskID))
|
|
} else if err := s.taskRepo.UpdateTaskState(ctx, taskID, v1.TaskStateScheduling); err != nil {
|
|
s.logger.Warn("failed to update task state to SCHEDULING",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
}
|
|
|
|
s.moveTaskToWorkflowStep(ctx, taskID, workflowStepID)
|
|
|
|
officeAgentProfileID := ""
|
|
if isOfficeTask {
|
|
officeAgentProfileID = agentProfileID
|
|
}
|
|
|
|
// Resolve the workflow step's agent profile override.
|
|
// The frontend may pass the workspace default profile, but the step may
|
|
// require a different agent (e.g., Codex on "In Progress", Auggie on "Review").
|
|
callerProfileID := agentProfileID
|
|
agentProfileID = s.resolveEffectiveAgentProfile(ctx, taskID, workflowStepID, agentProfileID)
|
|
overrideApplied := agentProfileID != callerProfileID
|
|
if route != nil && route.ExecutionProfileID != "" {
|
|
agentProfileID = route.ExecutionProfileID
|
|
}
|
|
|
|
// Fetch the task from the repository to get complete task info
|
|
task, err := s.scheduler.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
s.logger.Error("failed to fetch task for manual start",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
return nil, err
|
|
}
|
|
if executorID == "" {
|
|
if v, ok := task.Metadata[models.MetaKeyExecutorID].(string); ok && v != "" {
|
|
executorID = v
|
|
}
|
|
}
|
|
if executorProfileID == "" {
|
|
if v, ok := task.Metadata[models.MetaKeyExecutorProfileID].(string); ok && v != "" {
|
|
executorProfileID = v
|
|
}
|
|
}
|
|
|
|
// Override priority if provided in the request
|
|
if priority != "" {
|
|
task.Priority = priority
|
|
}
|
|
|
|
// Use provided prompt, fall back to task description
|
|
effectivePrompt := prompt
|
|
if effectivePrompt == "" {
|
|
effectivePrompt = task.Description
|
|
}
|
|
|
|
// Prepare session first so we have the sessionID for config context injection.
|
|
// For office tasks, replace the per-launch PrepareSession with the per-(task,
|
|
// agent) EnsureSessionForAgent so runs reuse one row across turns.
|
|
sessionID, sessionCreated, err := s.prepareSessionForStart(ctx, task, agentProfileID, executorID, executorProfileID, workflowStepID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
// Seed a matching conditional session configuration before lifecycle
|
|
// startup. The ACP manager applies this durable runtime layer after the
|
|
// selected profile and before the first prompt, preserving the original
|
|
// session tab.
|
|
s.applyWorkflowSessionConfigBeforeLaunchForStep(ctx, taskID, sessionID, workflowSessionConfigStepID)
|
|
// Surface the newly created session before LaunchPreparedSession performs
|
|
// potentially slow environment setup (for example, a Docker health check).
|
|
// The frontend adopts this CREATED session and can render
|
|
// executor.prepare.progress events while the launch request is still pending.
|
|
if sessionCreated {
|
|
s.publishSessionCreatedEvent(ctx, taskID, sessionID, workflowStepID)
|
|
}
|
|
|
|
// When the workflow step overrode the caller's profile, tag the session
|
|
// for provenance: the profile came from workflow routing rather than
|
|
// direct user selection.
|
|
if overrideApplied {
|
|
s.tagSessionAsWorkflowSwitched(ctx, sessionID)
|
|
}
|
|
|
|
// Passthrough sessions skip both the workflow-prompt "@name" expansion below
|
|
// and the Kandev MCP wrap further down: the prompt is typed straight into
|
|
// the agent CLI's TTY and the user sees it verbatim — they don't want a
|
|
// wall of MCP-tool boilerplate or a hidden expansion block prepended to
|
|
// "hello". Use the session snapshot, not a live profile lookup, so a
|
|
// mid-run profile edit cannot change wrap behavior. Looked up once here and
|
|
// reused below so we don't hit GetTaskSession twice for the same fact.
|
|
// If the lookup fails, resolveIsPassthroughForLaunch fails safe by
|
|
// treating the session as passthrough: skipping the wrap/expansion is
|
|
// strictly less harmful than leaking hidden <kandev-system> content into
|
|
// a real passthrough session's PTY.
|
|
isPassthrough := s.resolveIsPassthroughForLaunch(ctx, sessionID)
|
|
launchSession, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to reload launch session: %w", err)
|
|
}
|
|
|
|
effectivePrompt, planModeActive, promptReferenceContext := s.applyWorkflowAndPlanMode(
|
|
ctx, effectivePrompt, task.ID, sessionID, workflowStepID,
|
|
planMode, task.IsEphemeral, isPassthrough,
|
|
)
|
|
|
|
// Inject config context for config-mode sessions (dedicated settings chat)
|
|
configMode := false
|
|
if cm, ok := launchSession.Metadata["config_mode"].(bool); ok && cm {
|
|
configMode = true
|
|
effectivePrompt = sysprompt.InjectConfigContext(sessionID, effectivePrompt)
|
|
}
|
|
titleOwner := false
|
|
if !configMode && !isOfficeTask {
|
|
titleOwner, err = s.ClaimTaskTitleSession(ctx, task.ID, sessionID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to claim first-turn task title: %w", err)
|
|
}
|
|
}
|
|
|
|
// Wrap the first prompt with the Kandev MCP system block (task/session IDs +
|
|
// tool list). Done at the orchestrator layer so recordInitialMessage persists
|
|
// the wrapped form to task_session_messages; Message.ToAPI strips the
|
|
// <kandev-system> block for the UI bubble and exposes it via raw_content.
|
|
// Only the first launch carries this wrap — follow-up prompts and resumes
|
|
// rely on the agent CLI's conversation history retaining it.
|
|
// Idempotent: upstream call sites (wsAddMessage on CREATED sessions,
|
|
// recordAutoStartMessage) wrap before recording the user message so the DB
|
|
// row carries the block; the mode-aware injector canonicalizes it instead of
|
|
// double-wrapping.
|
|
skipKandevMCPWrap := isPassthrough
|
|
// `task` here is *v1.Task from the scheduler, which does NOT carry the
|
|
// orchestrator's WorkflowStepID — go through the task-ID variant so the
|
|
// repo lookup pulls the canonical step. Using the workflowStepID parameter
|
|
// directly is wrong because it can be empty on manual user-initiated starts
|
|
// while the task is already bound to a signal-gated step in the DB.
|
|
if effectivePrompt != "" || len(attachments) > 0 {
|
|
effectivePrompt = s.applyLaunchPromptContext(ctx, launchPromptContext{
|
|
prompt: effectivePrompt,
|
|
taskID: task.ID,
|
|
sessionID: sessionID,
|
|
isOfficeTask: isOfficeTask,
|
|
isPassthrough: skipKandevMCPWrap,
|
|
configMode: configMode,
|
|
referenceContext: promptReferenceContext,
|
|
includeTaskTitleTool: !configMode && titleOwner,
|
|
autopilot: task.Autopilot,
|
|
includeParentQuestionTool: task.Autopilot && task.ParentID != "",
|
|
spawnOrigin: opts.SpawnOrigin,
|
|
})
|
|
}
|
|
|
|
// Office tasks restrict the MCP toolset: kanban tools (move/update/list
|
|
// task, etc.) are excluded because office agents call those via the
|
|
// kandev CLI ($KANDEV_CLI). See docs/specs/office-agent-cli/spec.md.
|
|
mcpMode := ""
|
|
if isOfficeTask {
|
|
mcpMode = executor.McpModeOffice
|
|
}
|
|
|
|
// Cache the raw prompt so a transient-provider-error (529) retry can
|
|
// re-drive this first turn — initial launches bypass PromptTask.
|
|
s.rememberTurnPrompt(sessionID, prompt, "", planMode, attachments)
|
|
|
|
execution, err := s.executor.LaunchPreparedSession(ctx, task, sessionID, executor.LaunchOptions{
|
|
AgentProfileID: agentProfileID,
|
|
OfficeAgentProfileID: officeAgentProfileID,
|
|
ExecutorID: executorID,
|
|
Prompt: effectivePrompt,
|
|
WorkflowStepID: workflowStepID,
|
|
StartAgent: true,
|
|
McpMode: mcpMode,
|
|
Attachments: attachments,
|
|
Env: env,
|
|
RouteOverride: route,
|
|
})
|
|
if err != nil {
|
|
return nil, s.handleSessionLaunchFailure(ctx, taskID, sessionID, err)
|
|
}
|
|
|
|
s.postLaunchStart(ctx, taskID, execution, effectivePrompt, planModeActive || configMode, planModeActive, autoStart, attachments)
|
|
|
|
// Note: Task stays in SCHEDULING state until the agent is fully initialized.
|
|
// The executor will transition to IN_PROGRESS after StartAgentProcess() succeeds.
|
|
|
|
return execution, nil
|
|
}
|
|
|
|
func (s *Service) applyWorkflowSessionConfigBeforeLaunchForStep(
|
|
ctx context.Context,
|
|
taskID string,
|
|
sessionID string,
|
|
workflowStepID string,
|
|
) {
|
|
if s.workflowStepGetter == nil || workflowStepID == "" {
|
|
return
|
|
}
|
|
workflowStep, err := s.workflowStepGetter.GetStep(ctx, workflowStepID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to load workflow step for session configuration",
|
|
zap.String("task_id", taskID), zap.String("step_id", workflowStepID), zap.Error(err))
|
|
return
|
|
}
|
|
if workflowStep == nil {
|
|
return
|
|
}
|
|
preparedSession, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to reload session for session configuration",
|
|
zap.String("task_id", taskID), zap.String("session_id", sessionID), zap.Error(err))
|
|
return
|
|
}
|
|
s.applyWorkflowSessionConfigBeforeLaunch(ctx, taskID, preparedSession, workflowStep)
|
|
}
|
|
|
|
// launchPromptContext carries what the first turn of a launch needs in order to
|
|
// compose its system context.
|
|
type launchPromptContext struct {
|
|
prompt string
|
|
taskID string
|
|
sessionID string
|
|
isOfficeTask bool
|
|
isPassthrough bool
|
|
configMode bool
|
|
includeTaskTitleTool bool
|
|
autopilot bool
|
|
includeParentQuestionTool bool
|
|
referenceContext string
|
|
spawnOrigin *SpawnOrigin
|
|
}
|
|
|
|
// applyLaunchPromptContext prepends the first-turn system context to a launch
|
|
// prompt: the Kandev (or Office) MCP block, plus spawner attribution when the
|
|
// launch came from spawn_session_kandev.
|
|
//
|
|
// Passthrough profiles get attribution only, as plain text — see
|
|
// applySpawnOriginText for why they skip the MCP block entirely.
|
|
func (s *Service) applyLaunchPromptContext(ctx context.Context, p launchPromptContext) string {
|
|
if p.isPassthrough {
|
|
prompt := applySpawnOriginText(p.prompt, p.spawnOrigin)
|
|
if p.includeTaskTitleTool {
|
|
return sysprompt.PendingTaskTitlePassthroughInstruction() + "\n\n" + prompt
|
|
}
|
|
return prompt
|
|
}
|
|
// Spawner attribution is built here, not by the MCP handler that filled
|
|
// SpawnOrigin: the injectors below strip every <kandev-system> block they do
|
|
// not recognize, so the block has to be generated from the same server state
|
|
// that whitelists it as trusted content.
|
|
prompt, spawnContext := applySpawnOriginContext(p.prompt, p.spawnOrigin)
|
|
if p.isOfficeTask {
|
|
return sysprompt.InjectOfficeContext(
|
|
p.taskID, p.sessionID, prompt, p.referenceContext, spawnContext,
|
|
)
|
|
}
|
|
return sysprompt.InjectKandevContextWithOptions(p.taskID, p.sessionID, prompt, sysprompt.KandevContextOptions{
|
|
RequiresCompletionSignal: s.StepRequiresCompletionSignal(ctx, p.taskID),
|
|
IncludeCoordinatorTaskControls: !p.configMode,
|
|
IncludeTaskTitleTool: p.includeTaskTitleTool,
|
|
Autopilot: p.autopilot,
|
|
IncludeUserQuestionTool: !p.autopilot && !p.isPassthrough,
|
|
IncludeParentQuestionTool: p.autopilot && p.includeParentQuestionTool,
|
|
}, p.referenceContext, spawnContext)
|
|
}
|
|
|
|
// spawnOriginContent renders the spawner-attribution text for a launch requested
|
|
// through spawn_session_kandev, or "" for ordinary launches.
|
|
func spawnOriginContent(origin *SpawnOrigin) string {
|
|
if origin == nil {
|
|
return ""
|
|
}
|
|
return sysprompt.SpawnedSessionContext(origin.TaskID, origin.SessionID, origin.SessionName)
|
|
}
|
|
|
|
// applySpawnOriginContext prepends the spawner-attribution system block for a
|
|
// launch requested through spawn_session_kandev and returns the content that
|
|
// the first-turn injector must whitelist so the block is not stripped again as
|
|
// untrusted. Ordinary launches pass through unchanged with empty content.
|
|
func applySpawnOriginContext(prompt string, origin *SpawnOrigin) (string, string) {
|
|
content := spawnOriginContent(origin)
|
|
if content == "" {
|
|
return prompt, ""
|
|
}
|
|
return sysprompt.Wrap(content) + "\n\n" + prompt, content
|
|
}
|
|
|
|
// applySpawnOriginText prepends the same attribution as plain prompt text, for
|
|
// passthrough profiles whose prompt reaches the agent through a TTY the user is
|
|
// watching. There is no injector on that path to whitelist a system block, and
|
|
// wrapping it would only put raw <kandev-system> markup on the terminal.
|
|
func applySpawnOriginText(prompt string, origin *SpawnOrigin) string {
|
|
content := spawnOriginContent(origin)
|
|
if content == "" {
|
|
return prompt
|
|
}
|
|
return content + "\n\n" + prompt
|
|
}
|
|
|
|
// isOfficeTask returns the repository's canonical Office ownership projection.
|
|
func (s *Service) isOfficeTask(ctx context.Context, taskID string) bool {
|
|
isOfficeTask, err := s.lookupOfficeTask(ctx, taskID)
|
|
return err == nil && isOfficeTask
|
|
}
|
|
|
|
func (s *Service) lookupOfficeTask(ctx context.Context, taskID string) (bool, error) {
|
|
dbTask, err := s.repo.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
return dbTask != nil && dbTask.IsFromOffice, nil
|
|
}
|
|
|
|
func validateOfficeRuntimeEnv(env map[string]string) error {
|
|
required := []string{
|
|
"KANDEV_CLI",
|
|
"KANDEV_API_URL",
|
|
"KANDEV_API_KEY",
|
|
"KANDEV_AGENT_ID",
|
|
"KANDEV_WORKSPACE_ID",
|
|
"KANDEV_RUN_ID",
|
|
"KANDEV_TASK_ID",
|
|
}
|
|
missing := make([]string, 0, len(required))
|
|
for _, key := range required {
|
|
if strings.TrimSpace(env[key]) == "" {
|
|
missing = append(missing, key)
|
|
}
|
|
}
|
|
if len(missing) == 0 {
|
|
return nil
|
|
}
|
|
return fmt.Errorf(
|
|
"office runtime context is incomplete (missing %s); start or wake the task through Office",
|
|
strings.Join(missing, ", "),
|
|
)
|
|
}
|
|
|
|
var (
|
|
errOfficeTaskStartRequiresScheduler = errors.New(
|
|
"office tasks must be started through Office; use StartTaskWithEnv with scheduler-injected credentials",
|
|
)
|
|
errOfficeTaskResumeRequiresScheduler = errors.New(
|
|
"office tasks must be resumed through Office; use the Office scheduler to start a fresh run",
|
|
)
|
|
errOfficePreparedResumeRequiresScheduler = errors.New(
|
|
"office tasks must be restarted through Office; prepared-workspace resume is not supported for Office-owned tasks",
|
|
)
|
|
)
|
|
|
|
// validateOfficeLaunchEnv requires the scheduler context to be bound to the
|
|
// task being launched. StartTaskWithEnv is only wired to the internal Office
|
|
// scheduler adapter; the task binding still prevents a complete context map
|
|
// from being reused for a different task.
|
|
func validateOfficeLaunchEnv(taskID string, env map[string]string) error {
|
|
if err := validateOfficeRuntimeEnv(env); err != nil {
|
|
return err
|
|
}
|
|
if env["KANDEV_TASK_ID"] != taskID {
|
|
return fmt.Errorf(
|
|
"office runtime context is bound to task %q, not %q; start or wake the task through Office",
|
|
env["KANDEV_TASK_ID"], taskID,
|
|
)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// prepareSessionForStart creates the session for a launch and propagates any
|
|
// inherited workspace environment onto it.
|
|
//
|
|
// The propagation (inherit_parent / shared_group) lives here rather than only
|
|
// in PrepareTaskSession so every launch entry point inherits consistently —
|
|
// including the direct start path (startTask), which MCP-created subtasks reach
|
|
// via auto-start. Without this, an inherit_parent subtask launched through
|
|
// startTask would provision a fresh worktree instead of reusing the parent's.
|
|
// propagateInheritedEnvironment is a no-op for tasks without a workspace policy.
|
|
func (s *Service) prepareSessionForStart(
|
|
ctx context.Context, task *v1.Task,
|
|
agentProfileID, executorID, executorProfileID, workflowStepID string,
|
|
) (string, bool, error) {
|
|
sessionID, created, err := s.createStartSession(ctx, task, agentProfileID, executorID, executorProfileID, workflowStepID)
|
|
if err != nil {
|
|
return "", false, err
|
|
}
|
|
s.propagateInheritedEnvironment(ctx, task, sessionID)
|
|
return sessionID, created, nil
|
|
}
|
|
|
|
// resolveIsPassthroughForLaunch reloads the session snapshot to decide
|
|
// whether this launch is a passthrough session (skip the Kandev MCP wrap and
|
|
// the "@name" prompt-reference expansion). If the reload fails, this fails
|
|
// safe by treating the session as passthrough: skipping the wrap/expansion is
|
|
// strictly less harmful than leaking hidden <kandev-system> content into a
|
|
// real passthrough session's PTY.
|
|
func (s *Service) resolveIsPassthroughForLaunch(ctx context.Context, sessionID string) bool {
|
|
launchSession, sessErr := s.repo.GetTaskSession(ctx, sessionID)
|
|
if sessErr != nil {
|
|
s.logger.Warn("failed to reload session for passthrough check; defaulting to passthrough (skip hidden-content injection) as the safer failure mode",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(sessErr))
|
|
return true
|
|
}
|
|
return launchSession.IsPassthrough
|
|
}
|
|
|
|
// createStartSession picks the right session-creation path for the task:
|
|
// Office tasks with an assignee use the per-(task, agent) EnsureSessionForAgent
|
|
// (so runs reuse one row across turns); kanban / quick-chat fall through to
|
|
// the per-launch PrepareSession used since day one.
|
|
func (s *Service) createStartSession(
|
|
ctx context.Context, task *v1.Task,
|
|
agentProfileID, executorID, executorProfileID, workflowStepID string,
|
|
) (string, bool, error) {
|
|
dbTask, err := s.repo.GetTask(ctx, task.ID)
|
|
if err == nil && dbTask != nil && dbTask.IsFromOffice && dbTask.AssigneeAgentProfileID != "" {
|
|
session, created, ensureErr := s.executor.EnsureSessionForAgentWithCreation(
|
|
ctx, task, dbTask.AssigneeAgentProfileID, agentProfileID, executorID, executorProfileID,
|
|
)
|
|
if ensureErr != nil {
|
|
return "", false, ensureErr
|
|
}
|
|
return session.ID, created, nil
|
|
}
|
|
sessionID, err := s.executor.PrepareSession(ctx, task, agentProfileID, executorID, executorProfileID, workflowStepID)
|
|
return sessionID, err == nil, err
|
|
}
|
|
|
|
// moveTaskToWorkflowStep moves a task to the target workflow step if provided and different from current.
|
|
func (s *Service) moveTaskToWorkflowStep(ctx context.Context, taskID, workflowStepID string) {
|
|
if workflowStepID == "" {
|
|
return
|
|
}
|
|
dbTask, err := s.repo.GetTask(ctx, taskID)
|
|
if err != nil || dbTask.WorkflowStepID == workflowStepID {
|
|
return
|
|
}
|
|
dbTask.WorkflowStepID = workflowStepID
|
|
dbTask.UpdatedAt = time.Now().UTC()
|
|
if err := s.repo.UpdateTask(ctx, dbTask); err != nil {
|
|
s.logger.Warn("failed to move task to workflow step",
|
|
zap.String("task_id", taskID),
|
|
zap.String("workflow_step_id", workflowStepID),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
s.publishTaskUpdated(ctx, dbTask)
|
|
}
|
|
|
|
// resolveEffectiveAgentProfile checks whether the task's workflow step overrides
|
|
// the agent profile. If the step (or workflow default) specifies a different
|
|
// profile, that profile is returned instead of the caller-provided one.
|
|
// This ensures the initial task start uses the step's agent — not just the
|
|
// workspace default the frontend sends.
|
|
func (s *Service) resolveEffectiveAgentProfile(ctx context.Context, taskID, workflowStepID, callerProfileID string) string {
|
|
if s.workflowStepGetter == nil {
|
|
s.logger.Debug("resolveEffectiveAgentProfile: no workflowStepGetter, using caller profile",
|
|
zap.String("task_id", taskID),
|
|
zap.String("caller_profile", callerProfileID))
|
|
return callerProfileID
|
|
}
|
|
|
|
// Determine the effective step ID: explicit param > task's current step.
|
|
effectiveStepID := workflowStepID
|
|
if effectiveStepID == "" {
|
|
dbTask, err := s.repo.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
s.logger.Debug("resolveEffectiveAgentProfile: failed to load task from DB",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
return callerProfileID
|
|
}
|
|
s.logger.Debug("resolveEffectiveAgentProfile: loaded task from DB",
|
|
zap.String("task_id", taskID),
|
|
zap.String("db_workflow_step_id", dbTask.WorkflowStepID))
|
|
if dbTask.WorkflowStepID == "" {
|
|
s.logger.Debug("resolveEffectiveAgentProfile: task has no workflow step, using caller profile",
|
|
zap.String("task_id", taskID))
|
|
return callerProfileID
|
|
}
|
|
effectiveStepID = dbTask.WorkflowStepID
|
|
}
|
|
|
|
step, err := s.workflowStepGetter.GetStep(ctx, effectiveStepID)
|
|
if err != nil || step == nil {
|
|
s.logger.Debug("resolveEffectiveAgentProfile: failed to load step",
|
|
zap.String("task_id", taskID),
|
|
zap.String("step_id", effectiveStepID),
|
|
zap.Error(err))
|
|
return callerProfileID
|
|
}
|
|
|
|
s.logger.Debug("resolveEffectiveAgentProfile: loaded step",
|
|
zap.String("task_id", taskID),
|
|
zap.String("step_id", effectiveStepID),
|
|
zap.String("step_name", step.Name),
|
|
zap.String("step_agent_profile_id", step.AgentProfileID),
|
|
zap.String("step_workflow_id", step.WorkflowID))
|
|
|
|
stepProfile := s.resolveStepAgentProfile(ctx, step)
|
|
s.logger.Debug("resolveEffectiveAgentProfile: resolved step profile",
|
|
zap.String("task_id", taskID),
|
|
zap.String("step_profile", stepProfile),
|
|
zap.String("caller_profile", callerProfileID))
|
|
|
|
if stepProfile == "" || stepProfile == callerProfileID {
|
|
return callerProfileID
|
|
}
|
|
|
|
s.logger.Info("overriding agent profile with workflow step profile",
|
|
zap.String("task_id", taskID),
|
|
zap.String("step_id", effectiveStepID),
|
|
zap.String("step_name", step.Name),
|
|
zap.String("caller_profile", callerProfileID),
|
|
zap.String("step_profile", stepProfile))
|
|
return stepProfile
|
|
}
|
|
|
|
// postLaunchStart records the initial message and sets plan mode after a successful launch.
|
|
func (s *Service) postLaunchStart(ctx context.Context, taskID string, execution *executor.TaskExecution, prompt string, recordPlanMode, setPlanMode, autoStart bool, attachments []v1.MessageAttachment) {
|
|
if execution.SessionID != "" {
|
|
s.recordInitialMessage(ctx, taskID, execution.SessionID, prompt, recordPlanMode, autoStart, attachments)
|
|
|
|
if setPlanMode {
|
|
session, err := s.repo.GetTaskSession(ctx, execution.SessionID)
|
|
if err == nil {
|
|
s.setSessionPlanMode(ctx, session, true)
|
|
}
|
|
}
|
|
|
|
// Persist prepare_result using SetSessionMetadataKey (json_set) which
|
|
// atomically sets ONE key without touching others. This avoids the
|
|
// read-modify-write race where UpdateSessionMetadata clobbers plan_mode.
|
|
if execution.PrepareResult != nil && execution.PrepareResult.Success {
|
|
pr := lifecycle.SerializePrepareResult(execution.PrepareResult)
|
|
if err := s.repo.SetSessionMetadataKey(ctx, execution.SessionID, "prepare_result", pr); err != nil {
|
|
s.logger.Warn("failed to persist prepare_result",
|
|
zap.String("session_id", execution.SessionID), zap.Error(err))
|
|
}
|
|
}
|
|
}
|
|
go s.ensureSessionPRWatch(context.Background(), taskID, execution.SessionID, execution.WorktreeBranch)
|
|
}
|
|
|
|
// applyWorkflowAndPlanMode applies workflow step configuration and plan mode injection to a prompt.
|
|
// Returns the effective prompt and whether plan mode is active (from either the step or the caller).
|
|
// For ephemeral tasks (quick chat), workflow step processing is skipped since they have no workflow.
|
|
func (s *Service) applyWorkflowAndPlanMode(ctx context.Context, prompt string, taskID string, sessionID string, workflowStepID string, planMode bool, isEphemeral bool, isPassthrough bool) (string, bool, string) {
|
|
effectivePrompt := prompt
|
|
promptReferenceContext := ""
|
|
|
|
stepHasPlanMode := false
|
|
// Skip workflow step prompt injection for ephemeral tasks - they don't have workflows
|
|
if !isEphemeral && workflowStepID != "" && s.workflowStepGetter != nil {
|
|
step, err := s.workflowStepGetter.GetStep(ctx, workflowStepID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to get workflow step for prompt building",
|
|
zap.String("workflow_step_id", workflowStepID),
|
|
zap.Error(err))
|
|
} else {
|
|
stepHasPlanMode = step.HasOnEnterAction(wfmodels.OnEnterEnablePlanMode)
|
|
effectivePrompt, promptReferenceContext = s.buildWorkflowPromptWithContext(
|
|
ctx, effectivePrompt, step, taskID, sessionID, isPassthrough,
|
|
)
|
|
}
|
|
}
|
|
|
|
if planMode && !stepHasPlanMode {
|
|
var parts []string
|
|
parts = append(parts, sysprompt.Wrap(sysprompt.DefaultPlanPrefix()))
|
|
parts = append(parts, effectivePrompt)
|
|
effectivePrompt = strings.Join(parts, "\n\n")
|
|
}
|
|
|
|
return effectivePrompt, planMode || stepHasPlanMode, promptReferenceContext
|
|
}
|
|
|
|
// backfillInitialUserMessageIfMissing records the task's description as the
|
|
// first user message when the session has no messages at all. This covers the
|
|
// edge case where the initial launch failed before recordInitialMessage was
|
|
// called (postLaunchStart only runs after a successful LaunchAgent), leaving
|
|
// the chat empty even though the task carries the prompt the user originally
|
|
// typed.
|
|
//
|
|
// The check requires *zero* messages, not just zero user messages: if any
|
|
// agent output already exists from a partial prior run, the backfilled
|
|
// message would land at the bottom of the chat (CreateMessage stamps
|
|
// CreatedAt=now), which is worse than leaving the chat alone.
|
|
func (s *Service) backfillInitialUserMessageIfMissing(ctx context.Context, taskID, sessionID, prompt string) {
|
|
if prompt == "" || s.messageCreator == nil {
|
|
return
|
|
}
|
|
msgs, err := s.repo.ListMessages(ctx, sessionID)
|
|
if err != nil {
|
|
s.logger.Warn("backfill initial message: list messages failed",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
if len(msgs) > 0 {
|
|
return
|
|
}
|
|
s.recordInitialMessage(ctx, taskID, sessionID, prompt, false, false, nil)
|
|
}
|
|
|
|
// recordInitialMessage creates the initial user message and updates session state after launch.
|
|
// autoStart marks the message as having been created by an automated trigger
|
|
// (workflow auto-start, PR/issue watch, Jira/Linear integration) so cleanup
|
|
// logic can distinguish "agent ran on its own" from "user actually engaged".
|
|
func (s *Service) recordInitialMessage(ctx context.Context, taskID, sessionID, prompt string, planModeActive, autoStart bool, attachments []v1.MessageAttachment) {
|
|
if s.messageCreator != nil && (prompt != "" || len(attachments) > 0) {
|
|
meta := NewUserMessageMeta().WithPlanMode(planModeActive).WithAutoStart(autoStart).WithAttachments(attachments)
|
|
if err := s.messageCreator.CreateUserMessage(ctx, taskID, prompt, sessionID, s.getActiveTurnID(sessionID), meta.ToMap()); err != nil {
|
|
s.logger.Error("failed to create initial user message",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
}
|
|
|
|
// buildWorkflowPrompt constructs the effective prompt using workflow step configuration.
|
|
// If step.Prompt contains {{task_prompt}}, it is replaced with the base prompt.
|
|
// Otherwise, step.Prompt fully replaces the base prompt.
|
|
// If the step has enable_plan_mode in on_enter events, plan mode prefix is also prepended.
|
|
// Only true internal instructions are wrapped in <kandev-system> tags so they can be stripped from the visible chat.
|
|
func (s *Service) buildWorkflowPrompt(ctx context.Context, basePrompt string, step *wfmodels.WorkflowStep, taskID string, sessionID string, isPassthrough bool) string {
|
|
prompt, _ := s.buildWorkflowPromptWithContext(ctx, basePrompt, step, taskID, sessionID, isPassthrough)
|
|
return prompt
|
|
}
|
|
|
|
// workflowInstructionsHeading/End are stable, agent-facing markers for the
|
|
// optional workflow-level prompt block. Chat collapses everything between
|
|
// them by default. Do not i18n (sent to the model, same as step prompt English).
|
|
// The end marker is required so multi-paragraph workflow prompts do not break
|
|
// the frontend split (a first-blank-line heuristic would cut mid-body).
|
|
const (
|
|
workflowInstructionsHeading = "## Workflow instructions"
|
|
workflowInstructionsEnd = "<!-- /workflow-instructions -->"
|
|
)
|
|
|
|
func (s *Service) buildWorkflowPromptWithContext(
|
|
ctx context.Context,
|
|
basePrompt string,
|
|
step *wfmodels.WorkflowStep,
|
|
taskID string,
|
|
sessionID string,
|
|
isPassthrough bool,
|
|
) (string, string) {
|
|
_ = sessionID
|
|
var parts []string
|
|
|
|
if block := s.workflowInstructionsBlock(ctx, step, taskID); block != "" {
|
|
parts = append(parts, block)
|
|
}
|
|
|
|
// Build the prompt from step.Prompt template and base prompt
|
|
if step.Prompt != "" {
|
|
interpolatedPrompt := sysprompt.InterpolatePlaceholders(step.Prompt, taskID)
|
|
if strings.Contains(interpolatedPrompt, "{{task_prompt}}") {
|
|
// Replace placeholder with base prompt
|
|
combined := strings.Replace(interpolatedPrompt, "{{task_prompt}}", basePrompt, 1)
|
|
parts = append(parts, combined)
|
|
} else {
|
|
// A step prompt without {{task_prompt}} is treated as the full visible prompt.
|
|
parts = append(parts, interpolatedPrompt)
|
|
}
|
|
} else {
|
|
// No step prompt, just use base prompt
|
|
parts = append(parts, basePrompt)
|
|
}
|
|
|
|
joined := strings.Join(parts, "\n\n")
|
|
return s.expandPromptReferencesWithContext(ctx, joined, isPassthrough)
|
|
}
|
|
|
|
// workflowInstructionsBlock returns the visible "## Workflow instructions"
|
|
// section when the step's workflow has a non-empty prompt. Empty/whitespace
|
|
// prompts and missing getters/workflows omit the section entirely.
|
|
func (s *Service) workflowInstructionsBlock(ctx context.Context, step *wfmodels.WorkflowStep, taskID string) string {
|
|
if s.workflowStepGetter == nil || step == nil || step.WorkflowID == "" {
|
|
return ""
|
|
}
|
|
meta, err := s.getWorkflowMeta(ctx, step.WorkflowID)
|
|
if err != nil {
|
|
if s.logger != nil {
|
|
s.logger.Warn("failed to get workflow prompt for prompt building",
|
|
zap.String("workflow_id", step.WorkflowID),
|
|
zap.Error(err))
|
|
}
|
|
return ""
|
|
}
|
|
prompt := strings.TrimSpace(meta.Prompt)
|
|
if prompt == "" {
|
|
return ""
|
|
}
|
|
interpolated := strings.TrimSpace(sysprompt.InterpolatePlaceholders(prompt, taskID))
|
|
if interpolated == "" {
|
|
return ""
|
|
}
|
|
// Drop any accidental end-marker text from user content so chat split
|
|
// cannot cut the block early (frontend also prefers the final marker).
|
|
interpolated = strings.ReplaceAll(interpolated, workflowInstructionsEnd, "")
|
|
interpolated = strings.TrimSpace(interpolated)
|
|
if interpolated == "" {
|
|
return ""
|
|
}
|
|
return workflowInstructionsHeading + "\n\n" + interpolated + "\n\n" + workflowInstructionsEnd
|
|
}
|
|
|
|
// expandPromptReferences resolves "@name" saved-prompt references in prompt
|
|
// via the configured PromptReferenceExpander. When no expander is set, prompt
|
|
// is returned unchanged. Passthrough sessions skip expansion entirely: the
|
|
// prompt is written raw to a PTY with no <kandev-system> stripping step, so
|
|
// the expansion's hidden wrapper block would be typed into the terminal
|
|
// verbatim instead of staying hidden.
|
|
func (s *Service) expandPromptReferences(ctx context.Context, prompt string, isPassthrough bool) string {
|
|
expanded, _ := s.expandPromptReferencesWithContext(ctx, prompt, isPassthrough)
|
|
return expanded
|
|
}
|
|
|
|
func (s *Service) expandPromptReferencesWithContext(
|
|
ctx context.Context,
|
|
prompt string,
|
|
isPassthrough bool,
|
|
) (string, string) {
|
|
if s.promptExpander == nil || isPassthrough {
|
|
return prompt, ""
|
|
}
|
|
var zapLogger *zap.Logger
|
|
if s.logger != nil {
|
|
zapLogger = s.logger.Zap()
|
|
}
|
|
return s.promptExpander.AppendReferenceExpansionsWithContext(ctx, prompt, zapLogger)
|
|
}
|
|
|
|
// ResumeTaskSession restarts a specific task session using its stored worktree.
|
|
func (s *Service) ResumeTaskSession(ctx context.Context, taskID, sessionID string) (*executor.TaskExecution, error) {
|
|
s.logger.Debug("resuming task session",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if session.TaskID != taskID {
|
|
return nil, fmt.Errorf("task session does not belong to task")
|
|
}
|
|
running, err := s.repo.GetExecutorRunningBySessionID(ctx, sessionID)
|
|
if (err != nil || running == nil) &&
|
|
session.State != models.TaskSessionStateCancelled &&
|
|
session.State != models.TaskSessionStateFailed {
|
|
// Executor record is required for non-terminal sessions. For cancelled/failed sessions
|
|
// the record may already have been cleaned up before the user clicked Resume — allow it.
|
|
return nil, fmt.Errorf("session is not resumable: no executor record")
|
|
}
|
|
s.noteMissingWorktreesBeforeResume(sessionID, session)
|
|
|
|
// Completed sessions cannot be restarted — they require a new session.
|
|
// Failed and cancelled sessions keep the resume token so the relaunched
|
|
// agent continues the previous conversation (via ACP session/load for
|
|
// native-resume agents, or --resume on CLI). Users who want a fresh start
|
|
// after a failure can invoke RecoverSession with action="fresh_start".
|
|
if session.State == models.TaskSessionStateCompleted {
|
|
return nil, fmt.Errorf("session is completed and cannot be resumed; create a new session instead")
|
|
}
|
|
|
|
isOfficeTask, err := s.lookupOfficeTask(ctx, taskID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to determine office task status: %w", err)
|
|
}
|
|
if isOfficeTask {
|
|
return nil, errOfficeTaskResumeRequiresScheduler
|
|
}
|
|
|
|
// Bury any open turns from the previous run before relaunching. Without
|
|
// this, startTurnForSession adopts the orphan on the next prompt and the
|
|
// UI's running timer counts from the orphan's started_at — which can be
|
|
// hours or days ago. Zero-duration completion keeps analytics honest about
|
|
// the dead window. A failure here shouldn't block the resume; the next
|
|
// completeTurnForSession sweep will mop up.
|
|
//
|
|
// Drop the activeTurns cache entry first, mirroring completeTurnForSession.
|
|
// Otherwise a stale entry would let getActiveTurnID return the now-abandoned
|
|
// turn ID without re-reading the DB, tagging new messages to a closed turn.
|
|
if s.turnService != nil {
|
|
s.activeTurns.Delete(sessionID)
|
|
if err := s.turnService.AbandonOpenTurns(ctx, sessionID); err != nil {
|
|
s.logger.Warn("failed to abandon orphan turns on resume; continuing",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
|
|
// Use context.WithoutCancel to prevent WebSocket request timeout from canceling the resume.
|
|
// Session resume can take time and shouldn't be tied to the WS request lifecycle.
|
|
resumeCtx := context.WithoutCancel(ctx)
|
|
execution, err := s.executor.ResumeSession(resumeCtx, session, true)
|
|
var readySession *models.TaskSession
|
|
if err != nil {
|
|
// If the execution is already running (duplicate resume request), return it as success.
|
|
if errors.Is(err, executor.ErrExecutionAlreadyRunning) {
|
|
execution, readySession, err = s.recoverAlreadyRunningResume(resumeCtx, taskID, sessionID)
|
|
if err != nil && errors.Is(err, ErrAgentNotReadyForPrompt) {
|
|
return nil, err
|
|
}
|
|
}
|
|
if err != nil {
|
|
// Task was archived while the resume was in flight — return the error
|
|
// without mutating task/session state (archive already handled cleanup).
|
|
// Check both the sentinel (early rejection) and re-read the task to catch
|
|
// the race where archive completed after the executor's archived check.
|
|
if errors.Is(err, executor.ErrTaskArchived) {
|
|
return nil, err
|
|
}
|
|
if task, taskErr := s.repo.GetTask(resumeCtx, taskID); taskErr == nil && task != nil && task.ArchivedAt != nil {
|
|
return nil, executor.ErrTaskArchived
|
|
}
|
|
// Use resumeCtx (WithoutCancel) for the failure-recording writes too —
|
|
// if the caller's ctx was already cancelled (e.g. WS client navigated
|
|
// away), the SessionStateFailed and TaskStateFailed updates would
|
|
// themselves fail with "context canceled" and leave the task stuck
|
|
// looking "running" forever.
|
|
// ResumeSession launches the workspace directly rather than through
|
|
// LaunchPreparedSession. Record this failure with the same state CAS,
|
|
// persisted recovery claim, and archive-safe task CAS as early launch.
|
|
return nil, s.handleSessionLaunchFailure(
|
|
resumeCtx, taskID, sessionID, err, session,
|
|
)
|
|
}
|
|
}
|
|
if readySession == nil {
|
|
readySession, err = s.waitForResumedSessionReady(resumeCtx, sessionID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
execution.SessionState = v1.TaskSessionState(readySession.State)
|
|
|
|
// Backfill the initial user message when a prior failed launch never got
|
|
// to recordInitialMessage. Without this, the resume can succeed and the
|
|
// agent starts replying, but the chat shows agent output with no user
|
|
// prompt above it.
|
|
//
|
|
// We use task.Description (the raw user input) rather than the
|
|
// workflow-effective prompt produced by applyWorkflowAndPlanMode. The
|
|
// effective prompt may carry a plan-mode prefix or be templated through a
|
|
// workflow step, but reconstructing the exact prompt the original launch
|
|
// sent to the agent is brittle (workflow state may have advanced since).
|
|
// Surfacing the raw description is intentionally conservative: it shows
|
|
// what the user actually typed, which is what they expect to see in chat.
|
|
if task, taskErr := s.repo.GetTask(resumeCtx, taskID); taskErr != nil {
|
|
s.logger.Warn("resume: failed to load task for initial message backfill",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(taskErr))
|
|
} else if task != nil {
|
|
s.backfillInitialUserMessageIfMissing(resumeCtx, taskID, sessionID, task.Description)
|
|
}
|
|
|
|
s.logger.Debug("task session resumed and ready for input",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
|
|
go s.ensureSessionPRWatch(context.Background(), taskID, execution.SessionID, execution.WorktreeBranch)
|
|
|
|
return execution, nil
|
|
}
|
|
|
|
func (s *Service) waitForResumedSessionReady(ctx context.Context, sessionID string) (*models.TaskSession, error) {
|
|
return s.waitForSessionAndAgentReady(ctx, sessionID, "after resume")
|
|
}
|
|
|
|
func (s *Service) recoverAlreadyRunningResume(
|
|
resumeCtx context.Context,
|
|
taskID string,
|
|
sessionID string,
|
|
) (*executor.TaskExecution, *models.TaskSession, error) {
|
|
existing, ok := s.executor.GetExecutionBySession(sessionID)
|
|
if !ok || existing == nil {
|
|
return nil, nil, executor.ErrExecutionAlreadyRunning
|
|
}
|
|
|
|
readySession, waitErr := s.waitForResumedSessionReady(resumeCtx, sessionID)
|
|
if waitErr == nil {
|
|
existing.SessionState = v1.TaskSessionState(readySession.State)
|
|
return existing, readySession, nil
|
|
}
|
|
if !errors.Is(waitErr, ErrAgentNotReadyForPrompt) {
|
|
return nil, nil, waitErr
|
|
}
|
|
|
|
if err := s.reapPromptUnreadyExecution(resumeCtx, sessionID, waitErr); err != nil {
|
|
return nil, nil, fmt.Errorf("%w: failed to stop prompt-unready execution: %w", ErrAgentNotReadyForPrompt, err)
|
|
}
|
|
|
|
session, err := s.repo.GetTaskSession(resumeCtx, sessionID)
|
|
if err != nil {
|
|
return nil, nil, fmt.Errorf("failed to reload session after prompt-readiness recovery: %w", err)
|
|
}
|
|
if session.TaskID != taskID {
|
|
return nil, nil, fmt.Errorf("task session does not belong to task")
|
|
}
|
|
|
|
execution, err := s.executor.ResumeSession(resumeCtx, session, true)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
readySession, err = s.waitForResumedSessionReady(resumeCtx, sessionID)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
execution.SessionState = v1.TaskSessionState(readySession.State)
|
|
return execution, readySession, nil
|
|
}
|
|
|
|
func (s *Service) waitForSessionAndAgentReady(ctx context.Context, sessionID, waitContext string) (*models.TaskSession, error) {
|
|
if err := s.waitForSessionReady(ctx, sessionID); err != nil {
|
|
return nil, fmt.Errorf("session not ready %s: %w", waitContext, err)
|
|
}
|
|
if err := s.waitForAgentPromptReady(ctx, sessionID); err != nil {
|
|
return nil, fmt.Errorf("agent not ready %s: %w", waitContext, err)
|
|
}
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to reload session %s: %w", waitContext, err)
|
|
}
|
|
return session, nil
|
|
}
|
|
|
|
func (s *Service) waitForStartingSessionPromptable(ctx context.Context, taskID, sessionID string) (*models.TaskSession, error) {
|
|
s.logger.Debug("waiting for starting session to become promptable",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
session, err := s.waitForSessionAndAgentReady(ctx, sessionID, "for prompt")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if err := s.checkSessionPromptable(taskID, sessionID, session.State); err != nil {
|
|
return nil, err
|
|
}
|
|
return session, nil
|
|
}
|
|
|
|
// StartSessionForWorkflowStep starts an existing session with a workflow step's prompt configuration.
|
|
// If the session is not running, it will be resumed first. Then a prompt is sent using the
|
|
// step's prompt_prefix, prompt_suffix, and plan_mode settings combined with the task description.
|
|
func (s *Service) StartSessionForWorkflowStep(ctx context.Context, taskID, sessionID, workflowStepID string) error {
|
|
s.logger.Debug("starting session for workflow step",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("workflow_step_id", workflowStepID))
|
|
|
|
if workflowStepID == "" {
|
|
return fmt.Errorf("workflow_step_id is required")
|
|
}
|
|
if s.workflowStepGetter == nil {
|
|
return fmt.Errorf("workflow step getter not configured")
|
|
}
|
|
|
|
step, err := s.workflowStepGetter.GetStep(ctx, workflowStepID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get workflow step: %w", err)
|
|
}
|
|
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get session: %w", err)
|
|
}
|
|
if session.TaskID != taskID {
|
|
return fmt.Errorf("session does not belong to task")
|
|
}
|
|
|
|
dbTask, err := s.repo.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get task: %w", err)
|
|
}
|
|
|
|
if session.ReviewStatus == models.ReviewStatusPending {
|
|
return fmt.Errorf("session is pending approval - use Approve button to proceed or send a message to request changes")
|
|
}
|
|
|
|
s.advanceTaskWorkflowStep(ctx, dbTask, workflowStepID, session)
|
|
|
|
effectivePrompt := s.buildWorkflowPrompt(ctx, dbTask.Description, step, taskID, sessionID, session.IsPassthrough)
|
|
|
|
if err := s.ensureSessionRunning(ctx, sessionID, session); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Apply conditional session settings after a manual resume and before the
|
|
// step prompt. The helper reloads the session so a resume-created runtime
|
|
// state cannot be overwritten by the stale request snapshot.
|
|
s.applyWorkflowSessionConfigOnEnter(ctx, taskID, session, step)
|
|
|
|
stepPlanMode := step.HasOnEnterAction(wfmodels.OnEnterEnablePlanMode)
|
|
_, err = s.PromptTask(ctx, taskID, sessionID, effectivePrompt, "", stepPlanMode, nil, false)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to prompt session: %w", err)
|
|
}
|
|
|
|
s.logger.Info("session started for workflow step",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("workflow_step_id", workflowStepID),
|
|
zap.String("step_name", step.Name),
|
|
zap.Bool("plan_mode", stepPlanMode))
|
|
|
|
return nil
|
|
}
|
|
|
|
// advanceTaskWorkflowStep updates the task's workflow step and clears session review status if the step changed.
|
|
func (s *Service) advanceTaskWorkflowStep(ctx context.Context, task *models.Task, workflowStepID string, session *models.TaskSession) {
|
|
if task.WorkflowStepID == workflowStepID {
|
|
return
|
|
}
|
|
task.WorkflowStepID = workflowStepID
|
|
task.UpdatedAt = time.Now().UTC()
|
|
if err := s.repo.UpdateTask(ctx, task); err != nil {
|
|
s.logger.Warn("failed to update task workflow step",
|
|
zap.String("task_id", task.ID),
|
|
zap.String("workflow_step_id", workflowStepID),
|
|
zap.Error(err))
|
|
}
|
|
if session.ReviewStatus != models.ReviewStatusNone {
|
|
if err := s.repo.UpdateSessionReviewStatus(ctx, session.ID, ""); err != nil {
|
|
s.logger.Warn("failed to clear session review status",
|
|
zap.String("session_id", session.ID),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
}
|
|
|
|
// ensureSessionRunning resumes the session if the agent is not actually running.
|
|
// After lazy recovery, a session may be in WAITING_FOR_INPUT with no agent process;
|
|
// this function detects that case and triggers a resume.
|
|
func (s *Service) ensureSessionRunning(ctx context.Context, sessionID string, session *models.TaskSession) error {
|
|
isOfficeTask, err := s.lookupOfficeTask(ctx, session.TaskID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to determine office task status: %w", err)
|
|
}
|
|
|
|
// Check if agent is genuinely running (in-memory execution store, not just DB state)
|
|
if exec, ok := s.executor.GetExecutionBySession(sessionID); ok && exec != nil {
|
|
s.recoverAgentPromptStreamIfNeeded(ctx, sessionID)
|
|
if err := s.waitForAgentPromptReady(ctx, sessionID); err != nil {
|
|
if !errors.Is(err, ErrAgentNotReadyForPrompt) {
|
|
return err
|
|
}
|
|
if isOfficeTask {
|
|
return errOfficeTaskResumeRequiresScheduler
|
|
}
|
|
refreshed, reapErr := s.reapAndReloadSession(ctx, sessionID, err)
|
|
if reapErr != nil {
|
|
return reapErr
|
|
}
|
|
session = refreshed
|
|
} else {
|
|
return nil
|
|
}
|
|
}
|
|
|
|
s.logger.Debug("agent not running for session, attempting resume",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("session_state", string(session.State)))
|
|
|
|
// Bounded to two attempts: a fresh cold resume, and — if the launched
|
|
// agent never reports prompt-ready — one reap-and-retry, mirroring the
|
|
// already-tracked-execution branch above. Without this, a wedged launch
|
|
// right after a backend restart (the common "kandev restart" cold-resume
|
|
// shape: in-memory execution store empty, executors_running row intact)
|
|
// surfaced a bare "agent not ready after resume: ... context deadline
|
|
// exceeded" with no self-heal, unlike every other resume path in this
|
|
// file.
|
|
for attempt := 1; ; attempt++ {
|
|
retryable, err := s.attemptColdResume(ctx, sessionID, session, isOfficeTask)
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
if attempt >= 2 || !retryable {
|
|
return err
|
|
}
|
|
refreshed, reapErr := s.reapAndReloadSession(ctx, sessionID, err)
|
|
if reapErr != nil {
|
|
return reapErr
|
|
}
|
|
session = refreshed
|
|
}
|
|
}
|
|
|
|
// reapAndReloadSession stops a prompt-unready execution and reloads the
|
|
// session row afterward. Shared by ensureSessionRunning's already-tracked-
|
|
// execution branch and its cold-resume retry loop so both recovery paths
|
|
// stay in lockstep.
|
|
func (s *Service) reapAndReloadSession(ctx context.Context, sessionID string, cause error) (*models.TaskSession, error) {
|
|
recoveryCtx := context.WithoutCancel(ctx)
|
|
if stopErr := s.reapPromptUnreadyExecution(recoveryCtx, sessionID, cause); stopErr != nil {
|
|
return nil, fmt.Errorf("failed to stop prompt-unready execution: %w", stopErr)
|
|
}
|
|
refreshed, refreshErr := s.repo.GetTaskSession(recoveryCtx, sessionID)
|
|
if refreshErr != nil {
|
|
return nil, fmt.Errorf("failed to reload session after prompt-readiness recovery: %w", refreshErr)
|
|
}
|
|
return refreshed, nil
|
|
}
|
|
|
|
// attemptColdResume performs one resume attempt for ensureSessionRunning's
|
|
// cold-resume loop (no execution currently tracked in memory). retryable is
|
|
// true only when the caller should reap the stuck execution and retry —
|
|
// specifically the main-path prompt-readiness timeout below, which is the
|
|
// exact "kandev restart" wedged-launch shape this loop exists to self-heal.
|
|
// The concurrent-resume-race branch (ErrExecutionAlreadyRunning) reports its
|
|
// own timeout as non-retryable: that failure is against an execution this
|
|
// attempt never launched, not a wedged cold launch, so retrying it here would
|
|
// blur two distinct failure modes the caller's tests pin down separately.
|
|
func (s *Service) attemptColdResume(
|
|
ctx context.Context,
|
|
sessionID string,
|
|
session *models.TaskSession,
|
|
isOfficeTask bool,
|
|
) (retryable bool, err error) {
|
|
// If the session is in CREATED state with an existing workspace (executors_running
|
|
// row exists), the workspace was prepared but the agent was never started. Use
|
|
// LaunchPreparedSession which routes to startAgentOnExistingWorkspace to reuse
|
|
// the workspace rather than ResumeSession which tries a full LaunchAgent and
|
|
// conflicts with the existing execution.
|
|
if session.State == models.TaskSessionStateCreated {
|
|
hasRunning, _ := s.repo.HasExecutorRunningRow(ctx, sessionID)
|
|
if hasRunning {
|
|
return false, s.startAgentOnPreparedWorkspace(ctx, sessionID, session)
|
|
}
|
|
}
|
|
if isOfficeTask {
|
|
return false, errOfficeTaskResumeRequiresScheduler
|
|
}
|
|
|
|
running, lookupErr := s.repo.GetExecutorRunningBySessionID(ctx, sessionID)
|
|
if lookupErr != nil || running == nil {
|
|
return false, fmt.Errorf("session is not resumable: no executor record (state: %s)", session.State)
|
|
}
|
|
|
|
s.noteMissingWorktreesBeforeResume(sessionID, session)
|
|
|
|
// Use context.WithoutCancel to prevent WebSocket request timeout from canceling the resume.
|
|
// The lifecycle layer publishes events.AgentBootReady (handled by handleAgentBootReady)
|
|
// when the agent's ACP session initializes — that's what unblocks waitForSessionReady,
|
|
// no flag-tracking needed.
|
|
resumeCtx := context.WithoutCancel(ctx)
|
|
if _, launchErr := s.executor.ResumeSession(resumeCtx, session, true); launchErr != nil {
|
|
if errors.Is(launchErr, executor.ErrExecutionAlreadyRunning) {
|
|
s.recoverAgentPromptStreamIfNeeded(resumeCtx, sessionID)
|
|
if readyErr := s.waitForAgentPromptReady(resumeCtx, sessionID); readyErr != nil {
|
|
return false, fmt.Errorf("agent not ready after resume race: %w", readyErr)
|
|
}
|
|
return false, nil
|
|
}
|
|
return false, s.handleSessionLaunchFailure(
|
|
resumeCtx,
|
|
session.TaskID,
|
|
sessionID,
|
|
fmt.Errorf("failed to resume session: %w", launchErr),
|
|
session,
|
|
)
|
|
}
|
|
|
|
// ResumeSession launches the agent asynchronously. Wait for it to finish
|
|
// initializing before returning, so the caller can send a prompt immediately.
|
|
//
|
|
// Use resumeCtx (context.WithoutCancel) here too, not the original ctx: the
|
|
// resume itself is already shielded from the caller's request deadline (see
|
|
// comment above), but a short-lived caller context (WebSocket request,
|
|
// MCP tool-call timeout, etc.) would otherwise still abort these polling
|
|
// waits early with a misleading "context deadline exceeded" even though the
|
|
// resume is progressing fine in the background and would succeed within its
|
|
// own bounded timeouts (waitForSessionReady's AgentLaunchTimeout launch
|
|
// budget, and waitForAgentPromptReady's 30s below).
|
|
if err := s.waitForSessionReady(resumeCtx, sessionID); err != nil {
|
|
return false, fmt.Errorf("session not ready after resume: %w", err)
|
|
}
|
|
readyErr := s.waitForAgentPromptReady(resumeCtx, sessionID)
|
|
if readyErr == nil {
|
|
s.logger.Debug("session resumed and ready for prompt")
|
|
return false, nil
|
|
}
|
|
return errors.Is(readyErr, ErrAgentNotReadyForPrompt), fmt.Errorf("agent not ready after resume: %w", readyErr)
|
|
}
|
|
|
|
func (s *Service) recoverAgentPromptStreamIfNeeded(ctx context.Context, sessionID string) {
|
|
if s.agentManager == nil || s.agentManager.IsAgentReadyForPrompt(ctx, sessionID) {
|
|
return
|
|
}
|
|
recoverer, ok := s.agentManager.(agentPromptStreamRecoverer)
|
|
if !ok {
|
|
return
|
|
}
|
|
if err := recoverer.RecoverAgentPromptStream(ctx, sessionID); err != nil {
|
|
s.logger.Debug("agent prompt stream recovery did not make session ready",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
|
|
func (s *Service) reapPromptUnreadyExecution(ctx context.Context, sessionID string, cause error) error {
|
|
if s.agentManager == nil {
|
|
return fmt.Errorf("agent manager is not configured")
|
|
}
|
|
executionID, err := s.agentManager.GetExecutionIDForSession(ctx, sessionID)
|
|
if err != nil || executionID == "" {
|
|
if running, runErr := s.repo.GetExecutorRunningBySessionID(ctx, sessionID); runErr == nil && running != nil {
|
|
executionID = running.AgentExecutionID
|
|
}
|
|
}
|
|
if executionID == "" {
|
|
if err != nil {
|
|
return fmt.Errorf("execution id for session %s: %w", sessionID, err)
|
|
}
|
|
return fmt.Errorf("execution id for session %s not found", sessionID)
|
|
}
|
|
if !s.claimForcedExecutionCleanup(sessionID, executionID) {
|
|
return fmt.Errorf(
|
|
"execution %s teardown is already owned for session %s",
|
|
executionID,
|
|
sessionID,
|
|
)
|
|
}
|
|
|
|
s.logger.Warn("stopping prompt-unready agent execution before resume",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("agent_execution_id", executionID),
|
|
zap.Error(cause))
|
|
if err := s.executor.StopExecution(ctx, executionID, promptReadinessRecoveryStopReason, true); err != nil {
|
|
return err
|
|
}
|
|
s.markExecutionFailed(sessionID, executionID)
|
|
refreshed, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
taskID := ""
|
|
if refreshed != nil {
|
|
taskID = refreshed.TaskID
|
|
}
|
|
s.retireExecutionActivityAndPublish(
|
|
context.WithoutCancel(ctx),
|
|
taskID,
|
|
sessionID,
|
|
executionID,
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("reload session after prompt-readiness teardown: %w", err)
|
|
}
|
|
if refreshed == nil {
|
|
return fmt.Errorf("reload session after prompt-readiness teardown: session %s not found", sessionID)
|
|
}
|
|
if isTerminalSessionState(refreshed.State) {
|
|
return &executor.SessionStateSupersededError{
|
|
SessionID: refreshed.ID,
|
|
State: refreshed.State,
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) waitForAgentPromptReady(ctx context.Context, sessionID string) error {
|
|
if s.agentManager == nil {
|
|
return nil
|
|
}
|
|
|
|
readyCtx, cancel := context.WithTimeout(ctx, agentPromptReadyTimeout)
|
|
defer cancel()
|
|
|
|
ticker := time.NewTicker(agentPromptReadyInterval)
|
|
defer ticker.Stop()
|
|
|
|
for {
|
|
if s.agentManager.IsAgentReadyForPrompt(readyCtx, sessionID) {
|
|
return nil
|
|
}
|
|
|
|
select {
|
|
case <-readyCtx.Done():
|
|
if err := ctx.Err(); err != nil {
|
|
return err
|
|
}
|
|
return fmt.Errorf("%w: %w", ErrAgentNotReadyForPrompt, readyCtx.Err())
|
|
case <-ticker.C:
|
|
}
|
|
}
|
|
}
|
|
|
|
// startAgentOnPreparedWorkspace starts the agent subprocess on a session whose workspace
|
|
// was prepared (agentctl running) but whose agent process was never started. This avoids
|
|
// the "session already has an agent running" error from ResumeSession which tries a full
|
|
// LaunchAgent and conflicts with the existing execution in the lifecycle manager's store.
|
|
func (s *Service) startAgentOnPreparedWorkspace(ctx context.Context, sessionID string, session *models.TaskSession) error {
|
|
s.logger.Debug("session has prepared workspace but no agent, starting agent on existing workspace",
|
|
zap.String("session_id", sessionID))
|
|
|
|
// Boot ready is published as events.AgentBootReady by the lifecycle layer
|
|
// and routed to handleAgentBootReady, which flips the session to
|
|
// WAITING_FOR_INPUT — that's what waitForSessionReady polls for. No flag
|
|
// tracking required here.
|
|
launchCtx := context.WithoutCancel(ctx)
|
|
isOfficeTask, err := s.lookupOfficeTask(launchCtx, session.TaskID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to determine office task status: %w", err)
|
|
}
|
|
if isOfficeTask {
|
|
return errOfficePreparedResumeRequiresScheduler
|
|
}
|
|
task, err := s.scheduler.GetTask(launchCtx, session.TaskID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get task for prepared session: %w", err)
|
|
}
|
|
if _, err := s.ClaimTaskTitleSession(launchCtx, session.TaskID, sessionID); err != nil {
|
|
return fmt.Errorf("failed to claim first-turn task title: %w", err)
|
|
}
|
|
if _, err = s.executor.LaunchPreparedSession(launchCtx, task, sessionID, executor.LaunchOptions{
|
|
AgentProfileID: session.AgentProfileID,
|
|
ExecutorID: session.ExecutorID,
|
|
StartAgent: true,
|
|
}); err != nil {
|
|
launchErr := fmt.Errorf("failed to start agent on prepared workspace: %w", err)
|
|
return s.handleSessionLaunchFailure(launchCtx, session.TaskID, sessionID, launchErr)
|
|
}
|
|
|
|
// Same reasoning as ensureSessionRunning's resume path: use launchCtx
|
|
// (already WithoutCancel'd for the launch call above) so a short-lived
|
|
// caller context doesn't abort these polling waits early.
|
|
if err := s.waitForSessionReady(launchCtx, sessionID); err != nil {
|
|
return fmt.Errorf("session not ready after starting agent: %w", err)
|
|
}
|
|
if err := s.waitForAgentPromptReady(launchCtx, sessionID); err != nil {
|
|
return fmt.Errorf("agent not ready after starting agent: %w", err)
|
|
}
|
|
s.logger.Debug("agent started on prepared workspace and ready for prompt")
|
|
return nil
|
|
}
|
|
|
|
// waitForSessionReady polls the session state until the agent is ready for prompts.
|
|
func (s *Service) waitForSessionReady(ctx context.Context, sessionID string) error {
|
|
const (
|
|
pollInterval = 500 * time.Millisecond
|
|
maxWait = constants.AgentLaunchTimeout
|
|
)
|
|
// Derive a bounded context so the overall wait AND each GetTaskSession query
|
|
// inside the loop honor maxWait. Callers pass context.WithoutCancel(ctx) so
|
|
// the wait survives the caller's request timeout during resume/launch — but
|
|
// that context carries no deadline of its own, so without this a single
|
|
// blocking query could hang well past maxWait (the loop only checks the
|
|
// wall clock between iterations). Mirrors waitForAgentPromptReady.
|
|
readyCtx, cancel := context.WithTimeout(ctx, maxWait)
|
|
defer cancel()
|
|
// Ticker rather than time.After(pollInterval) in the loop: time.After
|
|
// allocates a fresh timer each iteration that lives until it fires, so a
|
|
// long wait would pile up ~maxWait/pollInterval live timers. Mirrors
|
|
// waitForAgentPromptReady.
|
|
ticker := time.NewTicker(pollInterval)
|
|
defer ticker.Stop()
|
|
for {
|
|
select {
|
|
case <-readyCtx.Done():
|
|
return fmt.Errorf("timeout waiting for agent to become ready: %w", readyCtx.Err())
|
|
case <-ticker.C:
|
|
}
|
|
sess, err := s.repo.GetTaskSession(readyCtx, sessionID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to check session state: %w", err)
|
|
}
|
|
switch sess.State {
|
|
case models.TaskSessionStateWaitingForInput:
|
|
return nil
|
|
case models.TaskSessionStateFailed:
|
|
errMsg := sess.ErrorMessage
|
|
if errMsg == "" {
|
|
errMsg = "session failed during startup"
|
|
}
|
|
return fmt.Errorf("session failed: %s", errMsg)
|
|
case models.TaskSessionStateCancelled, models.TaskSessionStateCompleted:
|
|
return fmt.Errorf("session in unexpected state: %s", sess.State)
|
|
}
|
|
}
|
|
}
|
|
|
|
// sessionNotFoundStatus is the status-response error used for both a missing
|
|
// session and one the caller does not own, so the response cannot be used to
|
|
// tell the two apart.
|
|
const sessionNotFoundStatus = "session not found"
|
|
|
|
// GetTaskSessionStatus returns the status of a task session including whether it's resumable
|
|
func (s *Service) GetTaskSessionStatus(ctx context.Context, taskID, sessionID string) (dto.TaskSessionStatusResponse, error) {
|
|
s.logger.Debug("checking task session status",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
|
|
resp := dto.TaskSessionStatusResponse{
|
|
SessionID: sessionID,
|
|
TaskID: taskID,
|
|
}
|
|
|
|
// Per-user scoping: a foreign session is indistinguishable from a missing
|
|
// one, so reuse the same response shape rather than a distinct error.
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
resp.Error = sessionNotFoundStatus
|
|
return resp, nil
|
|
}
|
|
|
|
// 1. Load session from database
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
resp.Error = sessionNotFoundStatus
|
|
return resp, nil
|
|
}
|
|
|
|
if session.TaskID != taskID {
|
|
resp.Error = "session does not belong to task"
|
|
return resp, nil
|
|
}
|
|
|
|
resp.State = string(session.State)
|
|
resp.UpdatedAt = session.UpdatedAt.UTC().Format(time.RFC3339Nano)
|
|
resp.AgentProfileID = session.AgentProfileID
|
|
s.populateExecutorStatusInfo(ctx, session, &resp)
|
|
|
|
running, runErr := s.repo.GetExecutorRunningBySessionID(ctx, sessionID)
|
|
resumeToken := ""
|
|
if runErr == nil && running != nil {
|
|
resumeToken = running.ResumeToken
|
|
resp.ACPSessionID = running.ResumeToken
|
|
resp.Runtime = running.Runtime
|
|
if running.Resumable {
|
|
resp.IsResumable = true
|
|
}
|
|
s.applyRemoteRuntimeStatus(ctx, sessionID, &resp)
|
|
}
|
|
|
|
if shouldHealStuckStartingSession(session, running) {
|
|
s.logger.Info("healing stale STARTING session state from ready runtime status",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("agent_execution_id", running.AgentExecutionID))
|
|
s.setSessionWaitingForInput(ctx, taskID, sessionID)
|
|
refreshedSession, refreshErr := s.repo.GetTaskSession(ctx, sessionID)
|
|
if refreshErr == nil && refreshedSession != nil {
|
|
session = refreshedSession
|
|
resp.State = string(session.State)
|
|
if !session.UpdatedAt.IsZero() {
|
|
resp.UpdatedAt = session.UpdatedAt.UTC().Format(time.RFC3339Nano)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Extract worktree info
|
|
populateWorktreeInfo(session, &resp)
|
|
s.populateEnvironmentWorkspaceInfo(ctx, session, &resp)
|
|
|
|
// 2. Check if this session's agent is running
|
|
if exec, ok := s.executor.GetExecutionBySession(sessionID); ok && exec != nil {
|
|
resp.IsAgentRunning = true
|
|
resp.NeedsResume = false
|
|
return resp, nil
|
|
}
|
|
|
|
// 3. Session can be resumed if it has a resume token
|
|
if resumeToken != "" {
|
|
// Auto-resume FAILED sessions when the runtime is resumable: PR #670 made
|
|
// terminal-state resume safe (cleanup + retry), so recover transparently
|
|
// before surfacing the error. Frontend falls back to restore_workspace if
|
|
// the resume itself fails.
|
|
if session.State == models.TaskSessionStateFailed && running != nil && running.Resumable {
|
|
out := s.validateResumeEligibility(session, resp)
|
|
if out.NeedsResume {
|
|
out.ResumeReason = resumeReasonFailedSessionResumable
|
|
}
|
|
return out, nil
|
|
}
|
|
// A session cancelled by archiving is a system side effect (Service.
|
|
// ArchiveTask / HandoffService cascade), not an explicit user stop —
|
|
// it must recover like a FAILED session once the task is unarchived
|
|
// instead of falling into the terminal-session block below. See
|
|
// models.IsArchiveCancelReason.
|
|
if isArchiveCancelledSession(session) {
|
|
if running != nil && running.Resumable {
|
|
out := s.validateResumeEligibility(session, resp)
|
|
if out.NeedsResume {
|
|
out.ResumeReason = resumeReasonArchiveCancelledResumable
|
|
}
|
|
return out, nil
|
|
}
|
|
// The persisted token's runtime reports Resumable=false — it isn't
|
|
// safe to resume with. Route through the same fresh-start result
|
|
// used when there's no token/running row at all instead of
|
|
// validateResumeEligibility, which never sets IsResumable and
|
|
// would return NeedsResume=true with IsResumable=false, a
|
|
// combination the frontend's auto-resume gate
|
|
// (needs_resume && is_resumable) can never satisfy.
|
|
return evaluateFreshStartResume(session, running, runErr, resp), nil
|
|
}
|
|
// Don't auto-resume other terminal sessions (CANCELLED stays stopped, COMPLETED is done).
|
|
if !isActiveSessionState(session.State) {
|
|
resp.IsAgentRunning = false
|
|
resp.IsResumable = false
|
|
resp.NeedsResume = false
|
|
resp.NeedsWorkspaceRestore = canRestoreWorkspace(&resp)
|
|
return resp, nil
|
|
}
|
|
return s.validateResumeEligibility(session, resp), nil
|
|
}
|
|
|
|
// 4. No resume token — check if session can be started fresh.
|
|
return evaluateFreshStartResume(session, running, runErr, resp), nil
|
|
}
|
|
|
|
// evaluateFreshStartResume checks whether a session without a resume token can be
|
|
// started fresh. Sessions in error-recovery state (non-empty ErrorMessage) are marked
|
|
// resumable but not auto-resumed, so the user sees the error and can choose via action buttons.
|
|
func evaluateFreshStartResume(session *models.TaskSession, running *models.ExecutorRunning, runErr error, resp dto.TaskSessionStatusResponse) dto.TaskSessionStatusResponse {
|
|
if runErr == nil && running != nil && isActiveSessionState(session.State) {
|
|
if isErrorRecoveryState(session) {
|
|
resp.IsAgentRunning = false
|
|
resp.IsResumable = true
|
|
resp.NeedsResume = false
|
|
resp.ResumeReason = resumeReasonErrorRecovery
|
|
return resp
|
|
}
|
|
resp.IsAgentRunning = false
|
|
resp.IsResumable = true
|
|
resp.NeedsResume = true
|
|
resp.ResumeReason = "agent_not_running_fresh_start"
|
|
return resp
|
|
}
|
|
// The archive cleanup (Service.ArchiveTask / HandoffService cascade) tears
|
|
// down the ExecutorRunning row entirely, so an archive-cancelled session
|
|
// reaches this function with running == nil — exactly the shape an
|
|
// unarchive-then-open observes. Treat it as fresh-start resumable rather
|
|
// than falling through to read-only workspace restore.
|
|
if isArchiveCancelledSession(session) {
|
|
resp.IsAgentRunning = false
|
|
resp.IsResumable = true
|
|
resp.NeedsResume = true
|
|
resp.ResumeReason = resumeReasonArchiveCancelledResumable
|
|
return resp
|
|
}
|
|
resp.IsAgentRunning = false
|
|
resp.IsResumable = false
|
|
resp.NeedsResume = false
|
|
resp.NeedsWorkspaceRestore = canRestoreWorkspace(&resp)
|
|
return resp
|
|
}
|
|
|
|
func (s *Service) populateExecutorStatusInfo(ctx context.Context, session *models.TaskSession, resp *dto.TaskSessionStatusResponse) {
|
|
if session == nil || resp == nil {
|
|
return
|
|
}
|
|
resp.ExecutorID = session.ExecutorID
|
|
if session.ExecutorID == "" {
|
|
return
|
|
}
|
|
execModel, err := s.repo.GetExecutor(ctx, session.ExecutorID)
|
|
if err != nil || execModel == nil {
|
|
return
|
|
}
|
|
resp.ExecutorType = string(execModel.Type)
|
|
resp.ExecutorName = execModel.Name
|
|
resp.IsRemoteExecutor = models.IsRemoteExecutorType(execModel.Type)
|
|
resp.Capabilities.EmbeddedVscode = capabilities.SupportsEmbeddedVscode(execModel.Type, runtime.GOOS)
|
|
}
|
|
|
|
func (s *Service) applyRemoteRuntimeStatus(ctx context.Context, sessionID string, resp *dto.TaskSessionStatusResponse) {
|
|
if s.agentManager == nil || resp == nil || !resp.IsRemoteExecutor {
|
|
return
|
|
}
|
|
status, err := s.agentManager.GetRemoteRuntimeStatusBySession(ctx, sessionID)
|
|
if err != nil || status == nil {
|
|
return
|
|
}
|
|
if status.RuntimeName != "" {
|
|
resp.Runtime = status.RuntimeName
|
|
}
|
|
resp.RemoteState = status.State
|
|
resp.RemoteName = status.RemoteName
|
|
if status.ErrorMessage != "" {
|
|
resp.RemoteStatusErr = status.ErrorMessage
|
|
}
|
|
if status.CreatedAt != nil && !status.CreatedAt.IsZero() {
|
|
resp.RemoteCreatedAt = status.CreatedAt.UTC().Format(time.RFC3339)
|
|
}
|
|
if !status.LastCheckedAt.IsZero() {
|
|
resp.RemoteCheckedAt = status.LastCheckedAt.UTC().Format(time.RFC3339)
|
|
}
|
|
}
|
|
|
|
// populateWorktreeInfo copies worktree path and branch into the response if present.
|
|
func canRestoreWorkspace(resp *dto.TaskSessionStatusResponse) bool {
|
|
return resp != nil && resp.WorktreePath != nil && *resp.WorktreePath != ""
|
|
}
|
|
|
|
func populateWorktreeInfo(session *models.TaskSession, resp *dto.TaskSessionStatusResponse) {
|
|
if len(session.Worktrees) == 0 {
|
|
return
|
|
}
|
|
wt := session.Worktrees[0]
|
|
if wt.WorktreePath != "" {
|
|
resp.WorktreePath = &wt.WorktreePath
|
|
}
|
|
if wt.WorktreeBranch != "" {
|
|
resp.WorktreeBranch = &wt.WorktreeBranch
|
|
}
|
|
}
|
|
|
|
func (s *Service) populateEnvironmentWorkspaceInfo(ctx context.Context, session *models.TaskSession, resp *dto.TaskSessionStatusResponse) {
|
|
if hasWorktreeStatus(resp) {
|
|
return
|
|
}
|
|
env, err := s.repo.GetTaskEnvironmentByTaskID(ctx, session.TaskID)
|
|
if err != nil || env == nil {
|
|
return
|
|
}
|
|
if session.TaskEnvironmentID != "" && env.ID != session.TaskEnvironmentID {
|
|
return
|
|
}
|
|
if len(env.Repos) == 0 {
|
|
return
|
|
}
|
|
if resp.WorktreePath == nil && env.Repos[0].WorktreePath != "" {
|
|
resp.WorktreePath = &env.Repos[0].WorktreePath
|
|
}
|
|
if resp.WorktreeBranch == nil && env.Repos[0].WorktreeBranch != "" {
|
|
resp.WorktreeBranch = &env.Repos[0].WorktreeBranch
|
|
}
|
|
}
|
|
|
|
func hasWorktreeStatus(resp *dto.TaskSessionStatusResponse) bool {
|
|
return resp != nil &&
|
|
resp.WorktreePath != nil && *resp.WorktreePath != "" &&
|
|
resp.WorktreeBranch != nil && *resp.WorktreeBranch != ""
|
|
}
|
|
|
|
// isActiveSessionState returns true for session states where lazy resume makes sense.
|
|
func isActiveSessionState(state models.TaskSessionState) bool {
|
|
switch state {
|
|
case models.TaskSessionStateWaitingForInput,
|
|
models.TaskSessionStateStarting,
|
|
models.TaskSessionStateRunning:
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
// isErrorRecoveryState returns true when a session is in WAITING_FOR_INPUT with
|
|
// a non-empty ErrorMessage, indicating it was set by handleRecoverableFailure.
|
|
func isErrorRecoveryState(session *models.TaskSession) bool {
|
|
return session != nil &&
|
|
session.State == models.TaskSessionStateWaitingForInput &&
|
|
session.ErrorMessage != ""
|
|
}
|
|
|
|
// isArchiveCancelledSession reports whether session was cancelled by an
|
|
// archive (Service.ArchiveTask's single-task path or HandoffService's
|
|
// cascade archive) rather than an explicit user/coordinator stop. Such
|
|
// sessions must resume like a FAILED session once the owning task is
|
|
// unarchived — see models.IsArchiveCancelReason and its two constants.
|
|
func isArchiveCancelledSession(session *models.TaskSession) bool {
|
|
return session != nil &&
|
|
session.State == models.TaskSessionStateCancelled &&
|
|
models.IsArchiveCancelReason(session.ErrorMessage)
|
|
}
|
|
|
|
func shouldHealStuckStartingSession(session *models.TaskSession, running *models.ExecutorRunning) bool {
|
|
if session == nil || running == nil {
|
|
return false
|
|
}
|
|
if session.State != models.TaskSessionStateStarting {
|
|
return false
|
|
}
|
|
if running.Status != "ready" {
|
|
return false
|
|
}
|
|
// Pre-refactor this also checked session.AgentExecutionID vs running.AgentExecutionID
|
|
// to skip healing on a divergent row. With the executors_running table now the
|
|
// single source of truth, that comparison is structurally always equal — drop it.
|
|
return true
|
|
}
|
|
|
|
// validateResumeEligibility performs final checks before marking a session as resumable.
|
|
func (s *Service) validateResumeEligibility(session *models.TaskSession, resp dto.TaskSessionStatusResponse) dto.TaskSessionStatusResponse {
|
|
if session.AgentProfileID == "" {
|
|
resp.Error = "session missing agent profile"
|
|
resp.IsResumable = false
|
|
return resp
|
|
}
|
|
|
|
// A missing worktree directory does not make the session unresumable.
|
|
// Archive cleanup deletes the directory and keeps the branch, so reporting
|
|
// IsResumable=false here would hide the resume affordance for every
|
|
// unarchived task — see noteMissingWorktreesBeforeResume. The resume
|
|
// itself recreates the directory through the worktree manager.
|
|
|
|
// Don't auto-resume sessions in error-recovery state.
|
|
if isErrorRecoveryState(session) {
|
|
resp.IsAgentRunning = false
|
|
resp.IsResumable = true
|
|
resp.NeedsResume = false
|
|
resp.ResumeReason = resumeReasonErrorRecovery
|
|
return resp
|
|
}
|
|
|
|
resp.IsAgentRunning = false
|
|
resp.NeedsResume = true
|
|
resp.ResumeReason = "agent_not_running"
|
|
return resp
|
|
}
|
|
|
|
// StopTask stops agent execution for a task (stops all active sessions for the task)
|
|
func (s *Service) StopTask(ctx context.Context, taskID string, reason string, force bool) error {
|
|
s.logger.Info("stopping task execution",
|
|
zap.String("task_id", taskID),
|
|
zap.String("reason", reason),
|
|
zap.Bool("force", force))
|
|
|
|
// Stop all agents for this task
|
|
if err := s.executor.StopByTaskID(ctx, taskID, reason, force); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Move task to REVIEW state for user review
|
|
if err := s.taskRepo.UpdateTaskState(ctx, taskID, v1.TaskStateReview); err != nil {
|
|
s.logger.Error("failed to update task state to REVIEW after stop",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
// Don't return error - the stop was successful
|
|
} else {
|
|
s.logger.Info("task moved to REVIEW state after stop",
|
|
zap.String("task_id", taskID))
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// StopTaskForCoordinator gracefully halts every currently-observed live
|
|
// execution for taskID without accepting caller-controlled lifecycle options.
|
|
// The operation is idempotent: no accepted cancellation is not_running.
|
|
func (s *Service) StopTaskForCoordinator(ctx context.Context, taskID string) (CoordinatorTaskStopResult, error) {
|
|
if s.executor == nil {
|
|
return CoordinatorTaskStopResult{}, errors.New("coordinator stop: executor is not configured")
|
|
}
|
|
sessions, err := s.repo.ListActiveTaskSessionsByTaskID(ctx, taskID)
|
|
if err != nil {
|
|
return CoordinatorTaskStopResult{}, fmt.Errorf("coordinator stop: list active sessions for task %q: %w", taskID, err)
|
|
}
|
|
|
|
// Repository ordering is launch-oriented. Coordinator control uses stable
|
|
// identity ordering so partial failures and retries are deterministic.
|
|
sort.SliceStable(sessions, func(i, j int) bool {
|
|
return coordinatorStopSessionID(sessions[i]) < coordinatorStopSessionID(sessions[j])
|
|
})
|
|
|
|
accepted := 0
|
|
failures := make([]error, 0)
|
|
for _, candidate := range sessions {
|
|
if candidate == nil || candidate.ID == "" {
|
|
failures = append(failures, errors.New("coordinator stop: active session candidate is nil or has an empty ID"))
|
|
continue
|
|
}
|
|
changed, stopErr := s.stopTaskSessionForCoordinator(ctx, taskID, candidate.ID)
|
|
if stopErr != nil {
|
|
failures = append(failures, stopErr)
|
|
continue
|
|
}
|
|
if changed {
|
|
accepted++
|
|
}
|
|
}
|
|
if accepted > 0 {
|
|
// This helper owns Office/archive/active-state guards and publishes
|
|
// through the task-service adapter. Remaining working sessions still
|
|
// block REVIEW on a partial stop.
|
|
s.writeTaskReviewState(ctx, taskID, "")
|
|
}
|
|
if len(failures) > 0 {
|
|
s.logger.Warn("coordinator stop partially failed",
|
|
zap.String("task_id", taskID),
|
|
zap.Int("accepted", accepted),
|
|
zap.Int("failed", len(failures)))
|
|
return CoordinatorTaskStopResult{}, errors.Join(failures...)
|
|
}
|
|
if accepted == 0 {
|
|
return CoordinatorTaskStopResult{Status: CoordinatorTaskStopStatusNotRunning}, nil
|
|
}
|
|
return CoordinatorTaskStopResult{Status: CoordinatorTaskStopStatusStopped}, nil
|
|
}
|
|
|
|
func coordinatorStopSessionID(session *models.TaskSession) string {
|
|
if session == nil {
|
|
return ""
|
|
}
|
|
return session.ID
|
|
}
|
|
|
|
func (s *Service) stopTaskSessionForCoordinator(ctx context.Context, taskID, sessionID string) (bool, error) {
|
|
endCancel := s.beginCancelInFlight(sessionID)
|
|
defer endCancel()
|
|
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
lock.Lock()
|
|
|
|
result, teardownClaimed, err := s.stopTaskSessionForCoordinatorLocked(ctx, taskID, sessionID)
|
|
lock.Unlock()
|
|
release()
|
|
// The detached teardown callback is allowed to observe coordinator state;
|
|
// clear the cancellation ownership marker before handing it off. The defer
|
|
// above remains as an idempotent safety net for error returns.
|
|
endCancel()
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
// Detached teardown must not observe this operation as an in-flight
|
|
// cancellation. ScheduleTeardown starts a goroutine, so relying on the
|
|
// deferred release above makes the ordering scheduler-dependent.
|
|
endCancel()
|
|
if result.Changed && teardownClaimed {
|
|
result.ScheduleTeardown()
|
|
}
|
|
return result.Changed, nil
|
|
}
|
|
|
|
// stopTaskSessionForCoordinatorLocked commits cancellation and claims teardown
|
|
// ownership while sessionID's cancelInFlight guard is held. The caller must
|
|
// release that guard before scheduling the returned teardown.
|
|
func (s *Service) stopTaskSessionForCoordinatorLocked(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
) (executor.SessionStopResult, bool, error) {
|
|
|
|
// Re-read after acquiring the shared cancel/ready/queue guard. A candidate
|
|
// may have become terminal while this call waited for another decision.
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return executor.SessionStopResult{}, false, fmt.Errorf("coordinator stop: reload session %q: %w", sessionID, err)
|
|
}
|
|
if session == nil {
|
|
return executor.SessionStopResult{}, false, fmt.Errorf("coordinator stop: reload session %q returned nil", sessionID)
|
|
}
|
|
if session.TaskID != taskID {
|
|
return executor.SessionStopResult{}, false, fmt.Errorf("coordinator stop: session %q belongs to task %q, not %q", sessionID, session.TaskID, taskID)
|
|
}
|
|
if !isCoordinatorStoppableSessionState(session.State) {
|
|
return executor.SessionStopResult{FinalState: session.State}, false, nil
|
|
}
|
|
|
|
s.taskRuntimeStateMu.Lock()
|
|
defer s.taskRuntimeStateMu.Unlock()
|
|
// Halt-only intent also disarms any provider-backoff retry. This must run
|
|
// even when the failed execution has already disappeared and the result is
|
|
// therefore not_running; otherwise its timer can launch replacement work.
|
|
s.resetTransientRetry(sessionID)
|
|
result, err := s.executor.StopSessionDetailed(ctx, session, coordinatorMCPStopReason, false)
|
|
if err != nil {
|
|
return result, false, fmt.Errorf("coordinator stop: session %q: %w", sessionID, err)
|
|
}
|
|
if result.Changed {
|
|
// Cancellation takes effect before detached runtime teardown. Tombstone
|
|
// the execution immediately so buffered agent frames cannot recreate
|
|
// session output after the coordinator has acknowledged the stop.
|
|
s.markExecutionFailed(sessionID, result.ExecutionID)
|
|
}
|
|
teardownClaimed := result.Changed && s.claimExecutionTeardown(
|
|
sessionID,
|
|
result.ExecutionID,
|
|
executionTeardownIntentGraceful,
|
|
)
|
|
return result, teardownClaimed, nil
|
|
}
|
|
|
|
func isCoordinatorStoppableSessionState(state models.TaskSessionState) bool {
|
|
switch state {
|
|
case models.TaskSessionStateCreated,
|
|
models.TaskSessionStateStarting,
|
|
models.TaskSessionStateRunning,
|
|
models.TaskSessionStateWaitingForInput:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// CancelTaskExecution stops active sessions for a task without mutating task state.
|
|
// It is used by office tree controls where pause/cancel state transitions are
|
|
// handled by the office service itself.
|
|
func (s *Service) CancelTaskExecution(ctx context.Context, taskID string, reason string, force bool) error {
|
|
s.logger.Info("cancelling task execution",
|
|
zap.String("task_id", taskID),
|
|
zap.String("reason", reason),
|
|
zap.Bool("force", force))
|
|
return s.executor.StopByTaskID(ctx, taskID, reason, force)
|
|
}
|
|
|
|
// StopSession stops agent execution for a specific session
|
|
func (s *Service) StopSession(ctx context.Context, sessionID string, reason string, force bool) error {
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
return err
|
|
}
|
|
|
|
s.logger.Info("stopping session execution",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("reason", reason),
|
|
zap.Bool("force", force))
|
|
return s.executor.Stop(ctx, sessionID, reason, force)
|
|
}
|
|
|
|
// DeleteSession deletes a session that is not currently running.
|
|
func (s *Service) DeleteSession(ctx context.Context, sessionID string) error {
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
return err
|
|
}
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
defer release()
|
|
lock.Lock()
|
|
defer lock.Unlock()
|
|
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return fmt.Errorf("session not found: %w", err)
|
|
}
|
|
|
|
// Prevent deleting active sessions
|
|
switch session.State {
|
|
case models.TaskSessionStateRunning, models.TaskSessionStateStarting:
|
|
return fmt.Errorf("cannot delete session in %s state — stop it first", session.State)
|
|
}
|
|
|
|
taskID := session.TaskID
|
|
wasPrimary := session.IsPrimary
|
|
|
|
// A settled DB state can still own a workspace execution or detached
|
|
// background work. Quiesce that runtime boundary before removing the row.
|
|
if err := s.quiesceSessionExecutionBeforeDeletion(ctx, taskID, sessionID); err != nil {
|
|
return err
|
|
}
|
|
|
|
s.logger.Info("deleting session",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("task_id", taskID),
|
|
zap.String("state", string(session.State)),
|
|
zap.Bool("was_primary", wasPrimary))
|
|
|
|
if err := s.repo.DeleteTaskSession(ctx, sessionID); err != nil {
|
|
return fmt.Errorf("failed to delete session: %w", err)
|
|
}
|
|
|
|
// Drop the in-memory git snapshot throttle entry — the session will
|
|
// never receive another git event, so its cache slot is dead weight.
|
|
if s.gitSnapshotCache != nil {
|
|
s.gitSnapshotCache.forget(sessionID)
|
|
}
|
|
// Same reasoning for the push-detection tracker. Multi-repo sessions
|
|
// accumulate one entry per repo; pushTrackerForget walks them all.
|
|
s.pushTrackerForget(sessionID)
|
|
// And the foreground/background turn-activity signal. Execution teardown
|
|
// normally retires it after the final owner exits; deletion forcibly
|
|
// invalidates any trailing token so the removed session cannot be recreated
|
|
// through a stale activity pointer.
|
|
s.clearTurnActivity(sessionID)
|
|
|
|
// Auto-promote another session if we deleted the primary
|
|
if wasPrimary {
|
|
s.promoteNextPrimaryAfterRemoval(ctx, taskID, sessionID)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// quiesceSessionExecutionBeforeDeletion stops the in-memory lifecycle
|
|
// execution, if one exists, before a session row is removed. A runtime that
|
|
// explicitly reports the exact execution as absent is already quiesced; other
|
|
// stop failures preserve the row because detaching a possibly-live execution
|
|
// would let trailing frames recreate activity after deletion.
|
|
func (s *Service) quiesceSessionExecutionBeforeDeletion(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
) error {
|
|
if s.agentManager == nil {
|
|
return nil
|
|
}
|
|
executionID, executionErr := s.agentManager.GetExecutionIDForSession(ctx, sessionID)
|
|
if executionErr != nil || executionID == "" {
|
|
return nil
|
|
}
|
|
stopErr := s.executor.StopExecution(ctx, executionID, "session deleted", true)
|
|
if stopErr != nil && !errors.Is(stopErr, agentruntime.ErrNotFound) {
|
|
return fmt.Errorf("failed to stop session execution before deletion: %w", stopErr)
|
|
}
|
|
if stopErr != nil {
|
|
s.logger.Debug("session execution already absent during deletion",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("agent_execution_id", executionID),
|
|
zap.Error(stopErr))
|
|
}
|
|
s.markExecutionFailed(sessionID, executionID)
|
|
s.retireExecutionActivityAndPublish(
|
|
context.WithoutCancel(ctx), taskID, sessionID, executionID,
|
|
)
|
|
return nil
|
|
}
|
|
|
|
// promoteNextPrimaryAfterRemoval picks the best remaining session as primary
|
|
// after a session is deleted. Prefers RUNNING > active > any remaining.
|
|
func (s *Service) promoteNextPrimaryAfterRemoval(ctx context.Context, taskID, deletedSessionID string) {
|
|
sessions, err := s.repo.ListTaskSessions(ctx, taskID)
|
|
if err != nil || len(sessions) == 0 {
|
|
return
|
|
}
|
|
var candidate string
|
|
for _, sess := range sessions {
|
|
if sess.ID == deletedSessionID {
|
|
continue
|
|
}
|
|
if sess.State == models.TaskSessionStateRunning {
|
|
candidate = sess.ID
|
|
break
|
|
}
|
|
if candidate == "" {
|
|
candidate = sess.ID
|
|
} else if isActiveSessionState(sess.State) {
|
|
// Prefer active over terminal
|
|
candidate = sess.ID
|
|
}
|
|
}
|
|
if candidate != "" {
|
|
if err := s.SetPrimarySession(ctx, candidate); err != nil {
|
|
s.logger.Warn("failed to auto-promote primary after delete",
|
|
zap.String("task_id", taskID),
|
|
zap.String("candidate", candidate),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
}
|
|
|
|
// SetPrimarySession marks a session as the primary session for its task
|
|
// and broadcasts a task.updated event so the frontend reflects the change.
|
|
func (s *Service) SetPrimarySession(ctx context.Context, sessionID string) error {
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := s.repo.SetSessionPrimary(ctx, sessionID); err != nil {
|
|
return fmt.Errorf("failed to set session as primary: %w", err)
|
|
}
|
|
|
|
// Broadcast task.updated so frontend updates the primary star indicator.
|
|
// The task service's publisher loads primary-session info from the DB,
|
|
// which already reflects the SetSessionPrimary write above.
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to fetch session after setting primary", zap.Error(err))
|
|
return nil
|
|
}
|
|
task, err := s.repo.GetTask(ctx, session.TaskID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to fetch task after setting primary", zap.Error(err))
|
|
return nil
|
|
}
|
|
s.publishTaskUpdated(ctx, task)
|
|
return nil
|
|
}
|
|
|
|
// maxSessionNameLength caps user-supplied session names to keep tab labels sane.
|
|
const maxSessionNameLength = 120
|
|
|
|
// RenameSession sets the user-supplied name for a session and broadcasts a
|
|
// session.state_changed event (same state) so all clients update the tab label.
|
|
// An empty name clears the custom label, falling back to the derived title.
|
|
func (s *Service) RenameSession(ctx context.Context, sessionID, name string) error {
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
return err
|
|
}
|
|
|
|
name = strings.TrimSpace(name)
|
|
// Truncate by runes, not bytes — a byte slice could split a multi-byte
|
|
// UTF-8 sequence and persist an invalid string.
|
|
if runes := []rune(name); len(runes) > maxSessionNameLength {
|
|
name = string(runes[:maxSessionNameLength])
|
|
}
|
|
// Fetch BEFORE the write so a post-write lookup failure can never leave a
|
|
// durably renamed row without its broadcast (clients would render stale
|
|
// labels until the next full hydration).
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to load session for rename: %w", err)
|
|
}
|
|
if err := s.repo.RenameTaskSession(ctx, sessionID, name); err != nil {
|
|
return fmt.Errorf("failed to rename session: %w", err)
|
|
}
|
|
session.Name = name
|
|
updatedAt := time.Now().UTC()
|
|
s.publishTaskSessionStateChanged(ctx, session.TaskID, sessionID,
|
|
session.State, session.State, session.ErrorMessage, &updatedAt, session)
|
|
return nil
|
|
}
|
|
|
|
// StopExecution stops agent execution for a specific execution ID.
|
|
func (s *Service) StopExecution(ctx context.Context, executionID string, reason string, force bool) error {
|
|
s.logger.Info("stopping execution",
|
|
zap.String("execution_id", executionID),
|
|
zap.String("reason", reason),
|
|
zap.Bool("force", force))
|
|
return s.executor.StopExecution(ctx, executionID, reason, force)
|
|
}
|
|
|
|
// CaptureArchiveSnapshot captures git state (commits, cumulative diff) for a session before archiving.
|
|
// This preserves the final git state for historical purposes.
|
|
func (s *Service) CaptureArchiveSnapshot(ctx context.Context, sessionID string) error {
|
|
s.logger.Info("capturing archive snapshot", zap.String("session_id", sessionID))
|
|
|
|
baseCommit, baseBranch, err := s.resolveArchiveBaseCommitAndBranch(ctx, sessionID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Skip only if we have neither baseCommit nor baseBranch for merge-base calculation
|
|
if baseCommit == "" && baseBranch == "" {
|
|
s.logger.Debug("no base_commit or base_branch available, skipping archive snapshot capture",
|
|
zap.String("session_id", sessionID))
|
|
return nil
|
|
}
|
|
|
|
// Capture commits - baseBranch can be used for merge-base even if baseCommit is empty
|
|
if !s.captureArchiveCommits(ctx, sessionID, baseCommit, baseBranch) {
|
|
// Agent not running, skip diff capture as well
|
|
return nil
|
|
}
|
|
|
|
// Diff capture requires baseCommit
|
|
if baseCommit == "" {
|
|
s.logger.Debug("no base_commit available, skipping archive diff capture",
|
|
zap.String("session_id", sessionID))
|
|
return nil
|
|
}
|
|
|
|
s.captureArchiveDiff(ctx, sessionID, baseCommit)
|
|
return nil
|
|
}
|
|
|
|
// resolveArchiveBaseCommitAndBranch retrieves the base commit and branch for archive snapshot capture.
|
|
// It first checks the session's stored values, falling back to git status if empty.
|
|
func (s *Service) resolveArchiveBaseCommitAndBranch(ctx context.Context, sessionID string) (string, string, error) {
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return "", "", fmt.Errorf("failed to get session: %w", err)
|
|
}
|
|
|
|
baseCommit := session.BaseCommitSHA
|
|
baseBranch := session.BaseBranch
|
|
|
|
if baseCommit != "" {
|
|
return baseCommit, baseBranch, nil
|
|
}
|
|
|
|
// Fallback: try to get base commit from git status for legacy sessions
|
|
status, err := s.agentManager.GetGitStatus(ctx, sessionID)
|
|
if err != nil {
|
|
s.logger.Debug("failed to get git status for base commit fallback",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return "", baseBranch, nil
|
|
}
|
|
if status != nil && status.BaseCommit != "" {
|
|
s.logger.Debug("using git status base commit as fallback for archive",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("base_commit", status.BaseCommit))
|
|
return status.BaseCommit, baseBranch, nil
|
|
}
|
|
return "", baseBranch, nil
|
|
}
|
|
|
|
// captureArchiveCommits fetches and saves commits from baseCommit to HEAD.
|
|
// If targetBranch is provided, uses dynamic merge-base for accurate filtering.
|
|
// Returns false if the agent is not running (caller should skip remaining capture).
|
|
func (s *Service) captureArchiveCommits(ctx context.Context, sessionID, baseCommit, targetBranch string) bool {
|
|
logResult, err := s.agentManager.GetGitLog(ctx, sessionID, baseCommit, 0, targetBranch) // 0 = no limit
|
|
if err != nil {
|
|
s.logger.Warn("failed to capture git log for archive",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return true // Continue with diff capture even if log fails
|
|
}
|
|
if logResult == nil {
|
|
s.logger.Debug("agent not running, skipping archive snapshot capture",
|
|
zap.String("session_id", sessionID))
|
|
return false
|
|
}
|
|
if logResult.Success && len(logResult.Commits) > 0 {
|
|
s.saveArchiveCommits(ctx, sessionID, logResult.Commits)
|
|
}
|
|
return true
|
|
}
|
|
|
|
// captureGitStatusSnapshot fetches the current (cached) git status from agentctl
|
|
// and saves it as a DB snapshot. Called when a session's execution completes so
|
|
// the status is available when clients subscribe later.
|
|
func (s *Service) captureGitStatusSnapshot(ctx context.Context, sessionID string) {
|
|
_, _ = s.saveGitStatusSnapshot(ctx, sessionID, false)
|
|
}
|
|
|
|
// captureGitStatusSnapshotWithRetry attempts a fresh capture with up to 3
|
|
// retries at 1-second intervals if the first attempt returns stale 0/0 data
|
|
// (caused by git lock contention between concurrent worktrees). Returns
|
|
// immediately without retrying when no execution exists for the session
|
|
// (returns nil,nil) or the agent genuinely has no file changes.
|
|
func (s *Service) captureGitStatusSnapshotWithRetry(ctx context.Context, sessionID string) {
|
|
for attempt := 0; attempt < 3; attempt++ {
|
|
if attempt > 0 {
|
|
time.Sleep(time.Second)
|
|
}
|
|
wrote, noExec := s.saveGitStatusSnapshot(ctx, sessionID, true)
|
|
if noExec {
|
|
return // No execution exists — retrying won't help
|
|
}
|
|
if wrote {
|
|
return // Successfully wrote a snapshot (may be 0/0 for no-change turns, that's fine)
|
|
}
|
|
// saveGitStatusSnapshot returned false without noExec — means fresh
|
|
// returned 0/0 and was skipped due to possible lock contention. Retry.
|
|
}
|
|
}
|
|
|
|
// saveGitStatusSnapshot is the shared implementation for snapshot capture.
|
|
// When fresh is true, it bypasses the workspace tracker's poll cache.
|
|
// Returns (wrote, noExecution): wrote=true if a snapshot was persisted,
|
|
// noExecution=true if the session has no active execution (nil status).
|
|
func (s *Service) saveGitStatusSnapshot(ctx context.Context, sessionID string, fresh bool) (wrote, noExecution bool) {
|
|
var status *client.GitStatusResult
|
|
var err error
|
|
if fresh {
|
|
status, err = s.agentManager.GetGitStatusFresh(ctx, sessionID)
|
|
} else {
|
|
status, err = s.agentManager.GetGitStatus(ctx, sessionID)
|
|
}
|
|
if err != nil {
|
|
s.logger.Debug("failed to capture git status snapshot",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return false, false
|
|
}
|
|
if status == nil {
|
|
return false, true // No execution — caller should not retry
|
|
}
|
|
if !status.Success {
|
|
return false, false
|
|
}
|
|
|
|
// When a fresh query returns zero additions AND zero deletions, the result
|
|
// may be stale due to git lock contention between concurrent worktrees
|
|
// (merge-base computation fails transiently). Don't overwrite a potentially
|
|
// better live_monitor snapshot that already has the correct non-zero values.
|
|
if fresh && status.BranchAdditions == 0 && status.BranchDeletions == 0 {
|
|
return false, false
|
|
}
|
|
|
|
metadata := map[string]interface{}{
|
|
"timestamp": status.Timestamp,
|
|
"modified": status.Modified,
|
|
"added": status.Added,
|
|
"deleted": status.Deleted,
|
|
"untracked": status.Untracked,
|
|
"renamed": status.Renamed,
|
|
"branch_additions": status.BranchAdditions,
|
|
"branch_deletions": status.BranchDeletions,
|
|
}
|
|
|
|
if err := s.repo.CreateGitSnapshot(ctx, &models.GitSnapshot{
|
|
SessionID: sessionID,
|
|
SnapshotType: models.SnapshotTypeStatusUpdate,
|
|
Branch: status.Branch,
|
|
RemoteBranch: status.RemoteBranch,
|
|
HeadCommit: status.HeadCommit,
|
|
BaseCommit: status.BaseCommit,
|
|
Ahead: status.Ahead,
|
|
Behind: status.Behind,
|
|
Files: status.Files,
|
|
TriggeredBy: "agent_completed",
|
|
Metadata: metadata,
|
|
}); err != nil {
|
|
s.logger.Warn("failed to save git status snapshot",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return false, false
|
|
}
|
|
|
|
// Remove stale live_monitor snapshots so the authoritative agent_completed
|
|
// snapshot is always returned by GetLatestGitSnapshot. Without this, a
|
|
// live_monitor poll that raced with agent completion could persist a
|
|
// snapshot with a later timestamp but stale data.
|
|
if err := s.repo.DeleteLiveMonitorSnapshots(ctx, sessionID); err != nil {
|
|
s.logger.Debug("failed to clean up live monitor snapshots",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
}
|
|
|
|
s.logger.Debug("saved git status snapshot",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("branch", status.Branch),
|
|
zap.Bool("fresh", fresh))
|
|
return true, false
|
|
}
|
|
|
|
// captureArchiveDiff fetches and saves the cumulative diff from baseCommit to the working tree
|
|
// (including uncommitted/unstaged changes).
|
|
func (s *Service) captureArchiveDiff(ctx context.Context, sessionID, baseCommit string) {
|
|
diffResult, err := s.agentManager.GetCumulativeDiff(ctx, sessionID, baseCommit)
|
|
if err != nil {
|
|
s.logger.Warn("failed to capture cumulative diff for archive",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
if diffResult == nil || !diffResult.Success {
|
|
return
|
|
}
|
|
|
|
if err := s.repo.CreateGitSnapshot(ctx, &models.GitSnapshot{
|
|
SessionID: sessionID,
|
|
SnapshotType: models.SnapshotTypeArchive,
|
|
HeadCommit: diffResult.HeadCommit,
|
|
BaseCommit: diffResult.BaseCommit,
|
|
Files: diffResult.Files,
|
|
}); err != nil {
|
|
s.logger.Warn("failed to save archive snapshot",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
|
|
s.logger.Debug("saved archive snapshot",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("head_commit", diffResult.HeadCommit),
|
|
zap.Int("total_commits", diffResult.TotalCommits))
|
|
}
|
|
|
|
// parseCommitTime parses a commit timestamp from git log output.
|
|
// Returns UTC time to ensure consistent timestamps across environments.
|
|
func parseCommitTime(s string) time.Time {
|
|
t, err := time.Parse(time.RFC3339, s)
|
|
if err != nil {
|
|
return time.Now().UTC()
|
|
}
|
|
return t.UTC()
|
|
}
|
|
|
|
// saveArchiveCommits persists commits to the database for archive purposes.
|
|
func (s *Service) saveArchiveCommits(ctx context.Context, sessionID string, commits []*client.GitCommitInfo) {
|
|
for _, commit := range commits {
|
|
if err := s.repo.CreateSessionCommit(ctx, &models.SessionCommit{
|
|
SessionID: sessionID,
|
|
CommitSHA: commit.CommitSHA,
|
|
ParentSHA: commit.ParentSHA,
|
|
AuthorName: commit.AuthorName,
|
|
AuthorEmail: commit.AuthorEmail,
|
|
CommitMessage: commit.CommitMessage,
|
|
CommittedAt: parseCommitTime(commit.CommittedAt),
|
|
FilesChanged: commit.FilesChanged,
|
|
Insertions: commit.Insertions,
|
|
Deletions: commit.Deletions,
|
|
}); err != nil {
|
|
s.logger.Warn("failed to save commit for archive",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("commit_sha", commit.CommitSHA),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
s.logger.Debug("saved archive commits",
|
|
zap.String("session_id", sessionID),
|
|
zap.Int("count", len(commits)))
|
|
}
|
|
|
|
// PromptTask sends a follow-up prompt to a running agent for a task session.
|
|
// If planMode is true, a plan mode prefix is prepended to the prompt.
|
|
// Attachments (images) are passed through to the agent if provided.
|
|
func (s *Service) PromptTask(ctx context.Context, taskID, sessionID string, prompt string, model string, planMode bool, attachments []v1.MessageAttachment, dispatchOnly bool) (*PromptResult, error) {
|
|
return s.promptTask(ctx, taskID, sessionID, prompt, model, planMode, attachments, dispatchOnly, "", false, nil)
|
|
}
|
|
|
|
// promptTask is PromptTask's implementation, taking an additional
|
|
// claimEntryID parameter used only by queued dispatches. When non-empty, this
|
|
// acquires sessionID's cancelInFlight guard around a second ownership check
|
|
// and the "mark the session RUNNING" step immediately before startTurnForSession
|
|
// and the (potentially long-blocking) executor.Prompt call below it. The worker
|
|
// claims the handoff before visible side effects; this check keeps the final
|
|
// session transition tied to that same ownership record.
|
|
//
|
|
// A bare (unguarded) "check the token, then separately call
|
|
// setSessionRunning" would still let two settling dispatches for the same
|
|
// session both pass their own check before either actually marks the
|
|
// session RUNNING — the exact double-dispatch this mechanism exists to
|
|
// prevent, just narrowed rather than closed. Serializing the check
|
|
// *and* the mark through the same per-session guard used for every other
|
|
// cancel/take-and-dispatch decision (see the Service.cancelInFlight field
|
|
// doc comment) makes "exactly one dispatch wins" a property of mutual
|
|
// exclusion instead of a racy read. The guard is held only for this
|
|
// fast, DB-only step — released well before the long-running
|
|
// executor.Prompt call — matching every other guard holder's
|
|
// bounded-hold-time contract in this file.
|
|
//
|
|
// Every return path *before* this step (invalid session, not promptable,
|
|
// ensureSessionRunning failure, a model switch) is covered by
|
|
// executeQueuedMessage's own deferred cleanup instead
|
|
// (clearQueuedDispatchInFlightIfCurrent), which is safe since none of them
|
|
// block on an agent turn.
|
|
func (s *Service) promptTask(ctx context.Context, taskID, sessionID string, prompt string, model string, planMode bool, attachments []v1.MessageAttachment, dispatchOnly bool, claimEntryID string, lifecyclePrompt bool, afterClaim func() error) (*PromptResult, error) {
|
|
s.logPromptTaskCall(taskID, sessionID, prompt, model, planMode, attachments, dispatchOnly)
|
|
if err := s.validatePromptTaskStart(sessionID); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Only allow prompts when the session is ready for input.
|
|
session, err := s.loadPromptableSession(ctx, taskID, sessionID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
foregroundClaim, err := s.claimForegroundForPrompt(taskID, sessionID, session)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Apply config-mode and plan-mode prompt transforms.
|
|
effectivePrompt := s.effectivePromptForSession(sessionID, prompt, planMode, session)
|
|
|
|
// Ensure the agent process is actually running. After a lazy backend restart,
|
|
// the session may be in WAITING_FOR_INPUT but no agent process exists yet.
|
|
_, hadExecutionBeforeEnsure := s.executor.GetExecutionBySession(sessionID)
|
|
resumedForPrompt := !hadExecutionBeforeEnsure
|
|
if err := s.ensureSessionRunning(ctx, sessionID, session); err != nil {
|
|
s.releaseForegroundClaimOnFailure(ctx, taskID, sessionID, foregroundClaim)
|
|
return nil, fmt.Errorf("failed to ensure session is running: %w", err)
|
|
}
|
|
|
|
// Reload session after ensureSessionRunning. If a resume happened, ResumeSession
|
|
// updated the session's AgentExecutionID via persistResumeState — but only on the
|
|
// pointer it received. If anything along the way swapped the pointer or the
|
|
// caller's struct is otherwise stale (e.g. a concurrent write), executor.Prompt
|
|
// would call PromptAgent with the OLD execution ID and get ErrExecutionNotFound.
|
|
// Re-reading from the DB after ensureSessionRunning guarantees we use the
|
|
// freshly-persisted AgentExecutionID.
|
|
if reloaded, err := s.repo.GetTaskSession(ctx, sessionID); err == nil && reloaded != nil {
|
|
session = reloaded
|
|
// Re-apply transforms in case metadata changed during ensureSessionRunning.
|
|
effectivePrompt = s.effectivePromptForSession(sessionID, prompt, planMode, session)
|
|
}
|
|
activityExecutionID, _ := s.agentManager.GetExecutionIDForSession(ctx, sessionID)
|
|
foregroundDispatch := s.beginForegroundDispatch(
|
|
sessionID,
|
|
foregroundClaim,
|
|
activityExecutionID,
|
|
)
|
|
if foregroundDispatch == nil {
|
|
s.releaseForegroundClaimOnFailure(ctx, taskID, sessionID, foregroundClaim)
|
|
return nil, fmt.Errorf("%w, please wait for completion", ErrAgentPromptInProgress)
|
|
}
|
|
|
|
if result, handled, switchErr := s.trySwitchModelForPrompt(
|
|
ctx, taskID, sessionID, model, effectivePrompt, session, foregroundDispatch,
|
|
); handled {
|
|
return result, switchErr
|
|
}
|
|
|
|
// Cache the raw prompt so a transient-provider-error (529) retry can
|
|
// re-drive this turn after backoff without the caller's context. Stores
|
|
// the pre-injection prompt; PromptTask re-applies config/plan transforms.
|
|
s.rememberTurnPrompt(sessionID, prompt, model, planMode, attachments)
|
|
|
|
session, rollback, err := s.claimPromptDispatch(
|
|
ctx, taskID, sessionID, claimEntryID, lifecyclePrompt,
|
|
afterClaim, session, foregroundClaim,
|
|
)
|
|
if err != nil {
|
|
s.rollbackForegroundDispatchOnFailure(ctx, taskID, sessionID, foregroundDispatch)
|
|
return nil, err
|
|
}
|
|
// beginForegroundDispatch atomically established foreground-generating
|
|
// ownership before any cleanup/provider event could interleave. Publish that
|
|
// flip now that session admission succeeded; claimed RUNNING prompts also need
|
|
// the broadcast because their earlier atomic claim made the same transition.
|
|
if foregroundDispatch.yieldedBeforeBegin || foregroundClaim != nil {
|
|
s.publishForegroundActivityChanged(ctx, taskID, sessionID)
|
|
}
|
|
|
|
// Use context.WithoutCancel to prevent WebSocket request timeout from canceling the prompt.
|
|
// Prompts can take a long time (minutes) while the WS request may timeout in 15 seconds.
|
|
// We still want to log and respond, but the prompt should continue regardless.
|
|
promptCtx := context.WithoutCancel(ctx)
|
|
result, err := s.executor.PromptWithDispatchCallback(
|
|
promptCtx, taskID, sessionID, effectivePrompt, attachments, dispatchOnly,
|
|
func() {
|
|
if s.acceptForegroundDispatch(foregroundDispatch) {
|
|
s.publishForegroundActivityChanged(promptCtx, taskID, sessionID)
|
|
}
|
|
}, session,
|
|
)
|
|
if err != nil {
|
|
s.rollbackForegroundDispatchOnFailure(ctx, taskID, sessionID, foregroundDispatch)
|
|
return s.handlePromptDispatchFailure(
|
|
ctx, taskID, sessionID, prompt, planMode, resumedForPrompt,
|
|
attachments, rollback, lifecyclePrompt, err,
|
|
)
|
|
}
|
|
return &PromptResult{
|
|
StopReason: result.StopReason,
|
|
AgentMessage: result.AgentMessage,
|
|
}, nil
|
|
}
|
|
|
|
func (s *Service) validatePromptTaskStart(sessionID string) error {
|
|
if sessionID == "" {
|
|
return fmt.Errorf("session_id is required")
|
|
}
|
|
if s.isSessionResetInProgress(sessionID) {
|
|
return ErrSessionResetInProgress
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) logPromptTaskCall(
|
|
taskID, sessionID, prompt, model string,
|
|
planMode bool,
|
|
attachments []v1.MessageAttachment,
|
|
dispatchOnly bool,
|
|
) {
|
|
s.logger.Debug("PromptTask called",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.Int("prompt_length", len(prompt)),
|
|
zap.String("requested_model", model),
|
|
zap.Bool("plan_mode", planMode),
|
|
zap.Int("attachments_count", len(attachments)),
|
|
zap.Bool("dispatch_only", dispatchOnly))
|
|
}
|
|
|
|
func (s *Service) loadPromptableSession(ctx context.Context, taskID, sessionID string) (*models.TaskSession, error) {
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to get session: %w", err)
|
|
}
|
|
if promptErr := s.checkSessionPromptable(taskID, sessionID, session.State); promptErr != nil {
|
|
if !errors.Is(promptErr, ErrSessionNotPromptable) || session.State != models.TaskSessionStateStarting {
|
|
return nil, promptErr
|
|
}
|
|
return s.waitForStartingSessionPromptable(ctx, taskID, sessionID)
|
|
}
|
|
return session, nil
|
|
}
|
|
|
|
// claimForegroundForPrompt serializes two callers racing to take the
|
|
// background-idle foreground turn. For non-experiment RUNNING sessions,
|
|
// checkSessionPromptable already rejects the prompt before this helper is reached.
|
|
func (s *Service) claimForegroundForPrompt(taskID, sessionID string, session *models.TaskSession) (*foregroundClaim, error) {
|
|
if session.State != models.TaskSessionStateRunning {
|
|
return nil, nil
|
|
}
|
|
claim := s.claimForegroundTurn(sessionID)
|
|
if claim != nil {
|
|
return claim, nil
|
|
}
|
|
s.logger.Warn("rejected prompt: another prompt claimed the background-idle foreground turn first",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
return nil, fmt.Errorf("%w, please wait for completion", ErrAgentPromptInProgress)
|
|
}
|
|
|
|
func (s *Service) releaseForegroundClaimOnFailure(ctx context.Context, taskID, sessionID string, claim *foregroundClaim) {
|
|
if s.releaseForegroundClaim(claim) {
|
|
s.publishForegroundActivityChanged(ctx, taskID, sessionID)
|
|
}
|
|
}
|
|
|
|
func (s *Service) rollbackForegroundDispatchOnFailure(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
dispatch *foregroundDispatch,
|
|
) {
|
|
if s.rollbackForegroundDispatch(dispatch) {
|
|
s.publishForegroundActivityChanged(ctx, taskID, sessionID)
|
|
}
|
|
}
|
|
|
|
// trySwitchModelForPrompt keeps foreground admission consistent when a model
|
|
// switch either dispatches the prompt itself or fails before reaching the agent.
|
|
func (s *Service) trySwitchModelForPrompt(ctx context.Context, taskID, sessionID, model, prompt string, session *models.TaskSession, dispatch *foregroundDispatch) (*PromptResult, bool, error) {
|
|
result, switched, err := s.trySwitchModel(ctx, taskID, sessionID, model, prompt, session)
|
|
if !switched && err == nil {
|
|
return nil, false, nil
|
|
}
|
|
if err != nil {
|
|
s.rollbackForegroundDispatchOnFailure(ctx, taskID, sessionID, dispatch)
|
|
return result, true, err
|
|
}
|
|
revealedBackground := s.acceptForegroundDispatch(dispatch)
|
|
if revealedBackground || dispatch.yieldedBeforeBegin || s.acceptedForegroundDispatchClaim(dispatch) {
|
|
s.publishForegroundActivityChanged(ctx, taskID, sessionID)
|
|
}
|
|
return result, true, nil
|
|
}
|
|
|
|
type promptClaimRollback struct {
|
|
previousSessionState models.TaskSessionState
|
|
previousTaskState v1.TaskState
|
|
taskStateClaimed bool
|
|
turnID string
|
|
createdTurn bool
|
|
}
|
|
|
|
func (s *Service) claimPromptDispatch(
|
|
ctx context.Context,
|
|
taskID, sessionID, claimEntryID string,
|
|
lifecyclePrompt bool,
|
|
afterClaim func() error,
|
|
session *models.TaskSession,
|
|
foregroundClaim *foregroundClaim,
|
|
) (*models.TaskSession, promptClaimRollback, error) {
|
|
if lifecyclePrompt {
|
|
return s.claimLifecyclePromptDispatch(
|
|
ctx, taskID, sessionID, claimEntryID, afterClaim,
|
|
)
|
|
}
|
|
rollback := promptClaimRollback{previousSessionState: session.State}
|
|
claimed, err := s.claimSessionRunningForPrompt(
|
|
ctx, taskID, sessionID, claimEntryID, session, foregroundClaim,
|
|
)
|
|
if err != nil {
|
|
return nil, promptClaimRollback{}, err
|
|
}
|
|
rollback.turnID, rollback.createdTurn = s.startTurnForSessionWithOwnership(ctx, sessionID)
|
|
return claimed, rollback, nil
|
|
}
|
|
|
|
func (s *Service) claimLifecyclePromptDispatch(
|
|
ctx context.Context,
|
|
taskID, sessionID, claimEntryID string,
|
|
afterClaim func() error,
|
|
) (*models.TaskSession, promptClaimRollback, error) {
|
|
session, previousSessionState, err := s.claimLifecycleSessionRunning(
|
|
ctx, taskID, sessionID, claimEntryID,
|
|
)
|
|
if err != nil {
|
|
return nil, promptClaimRollback{}, err
|
|
}
|
|
rollback := promptClaimRollback{previousSessionState: previousSessionState}
|
|
rollback.previousTaskState, rollback.taskStateClaimed, err = s.reconcileLifecycleClaim(
|
|
ctx, taskID, sessionID, previousSessionState, session,
|
|
)
|
|
if err != nil {
|
|
return nil, promptClaimRollback{}, err
|
|
}
|
|
rollback.turnID, rollback.createdTurn = s.startTurnForSessionWithOwnership(ctx, sessionID)
|
|
if err := s.acknowledgePromptClaim(ctx, taskID, sessionID, afterClaim, rollback); err != nil {
|
|
return nil, promptClaimRollback{}, err
|
|
}
|
|
return session, rollback, nil
|
|
}
|
|
|
|
func (s *Service) acknowledgePromptClaim(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
afterClaim func() error,
|
|
rollback promptClaimRollback,
|
|
) error {
|
|
if afterClaim == nil {
|
|
return nil
|
|
}
|
|
if err := afterClaim(); err != nil {
|
|
s.rollbackPromptClaim(ctx, taskID, sessionID, rollback)
|
|
if errors.Is(err, errLifecyclePromptReservationSuperseded) {
|
|
return err
|
|
}
|
|
return fmt.Errorf("%w: %v", errLifecyclePromptMessagePersistence, err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) rollbackPromptClaim(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
rollback promptClaimRollback,
|
|
) {
|
|
s.restoreLifecycleClaim(ctx, taskID, sessionID, rollback.previousSessionState)
|
|
if rollback.taskStateClaimed {
|
|
s.restoreLifecycleTaskState(ctx, taskID, rollback.previousTaskState)
|
|
}
|
|
if rollback.createdTurn {
|
|
s.completeTurnIfCurrent(ctx, sessionID, rollback.turnID)
|
|
}
|
|
}
|
|
|
|
// reconcileLifecycleClaim makes the atomic SQLite RUNNING claim observable to
|
|
// the task runtime before a lifecycle prompt creates visible work or reaches
|
|
// the executor.
|
|
func (s *Service) reconcileLifecycleClaim(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
previousState models.TaskSessionState,
|
|
session *models.TaskSession,
|
|
) (v1.TaskState, bool, error) {
|
|
previousTaskState, taskStateClaimed, err := s.claimLifecycleTaskState(ctx, taskID, sessionID)
|
|
if err != nil {
|
|
s.restoreLifecycleClaim(ctx, taskID, sessionID, previousState)
|
|
return "", false, fmt.Errorf("%w: reconcile lifecycle task state: %v", errLifecyclePromptClaim, err)
|
|
}
|
|
if session == nil || session.State != models.TaskSessionStateRunning {
|
|
s.restoreLifecycleClaim(ctx, taskID, sessionID, previousState)
|
|
if taskStateClaimed {
|
|
s.restoreLifecycleTaskState(ctx, taskID, previousTaskState)
|
|
}
|
|
return "", false, fmt.Errorf("%w: lifecycle claim no longer owns running session", errLifecyclePromptClaim)
|
|
}
|
|
s.publishTaskSessionStateChanged(
|
|
ctx, taskID, sessionID, previousState, models.TaskSessionStateRunning,
|
|
"", &session.UpdatedAt, session,
|
|
)
|
|
return previousTaskState, taskStateClaimed, nil
|
|
}
|
|
|
|
func (s *Service) claimLifecycleTaskState(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
) (v1.TaskState, bool, error) {
|
|
s.taskRuntimeStateMu.Lock()
|
|
defer s.taskRuntimeStateMu.Unlock()
|
|
|
|
task, err := s.repo.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
return "", false, err
|
|
}
|
|
if task == nil || taskArchived(task) || task.AssigneeAgentProfileID != "" {
|
|
return "", false, nil
|
|
}
|
|
taskState, err := s.taskRepo.GetTask(ctx, taskID)
|
|
if err != nil {
|
|
return "", false, err
|
|
}
|
|
previousTaskState := task.State
|
|
if taskState != nil {
|
|
previousTaskState = taskState.State
|
|
}
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return "", false, err
|
|
}
|
|
if !runtimeSessionOwnsTaskState(session, v1.TaskStateInProgress) {
|
|
return previousTaskState, false, nil
|
|
}
|
|
updated, err := s.taskRepo.UpdateTaskStateIfSessionState(
|
|
ctx, taskID, sessionID, session.State, v1.TaskStateInProgress,
|
|
)
|
|
if err != nil {
|
|
return "", false, err
|
|
}
|
|
return previousTaskState, updated, nil
|
|
}
|
|
|
|
func (s *Service) restoreLifecycleTaskState(
|
|
ctx context.Context,
|
|
taskID string,
|
|
previousState v1.TaskState,
|
|
) {
|
|
if previousState == "" {
|
|
return
|
|
}
|
|
updated, err := s.taskRepo.UpdateTaskStateIfCurrentIn(
|
|
ctx, taskID, previousState, []v1.TaskState{v1.TaskStateInProgress},
|
|
)
|
|
if err != nil {
|
|
s.logger.Error("failed to restore task state after lifecycle prompt rejection",
|
|
zap.String("task_id", taskID),
|
|
zap.String("previous_state", string(previousState)),
|
|
zap.Error(err))
|
|
return
|
|
}
|
|
if !updated {
|
|
s.logger.Debug("skipped lifecycle task-state restore after concurrent transition",
|
|
zap.String("task_id", taskID),
|
|
zap.String("previous_state", string(previousState)))
|
|
}
|
|
}
|
|
|
|
// handlePromptDispatchFailure handles a failed executor.Prompt call from
|
|
// promptTask. If the failure is the specific "missing execution" error a
|
|
// just-resumed session can hit (see promptTask's resumedForPrompt comment),
|
|
// it falls back to a fresh launch instead of surfacing the error to the
|
|
// caller. Otherwise — or if that fallback launch itself fails — it
|
|
// delegates to handlePromptError for the caller-facing result.
|
|
func (s *Service) handlePromptDispatchFailure(
|
|
ctx context.Context,
|
|
taskID, sessionID, prompt string,
|
|
planMode, resumedForPrompt bool,
|
|
attachments []v1.MessageAttachment,
|
|
rollback promptClaimRollback,
|
|
lifecyclePrompt bool,
|
|
promptErr error,
|
|
) (*PromptResult, error) {
|
|
if resumedForPrompt && errors.Is(promptErr, executor.ErrExecutionNotFound) {
|
|
s.logger.Warn("prompt after lazy resume hit missing execution; falling back to fresh launch",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
if freshErr := s.fallbackFreshLaunchOnMissingExecution(
|
|
ctx, taskID, sessionID, prompt, planMode, nil, attachments, nil,
|
|
); freshErr == nil {
|
|
return &PromptResult{}, nil
|
|
} else {
|
|
promptErr = freshErr
|
|
}
|
|
}
|
|
if lifecyclePrompt {
|
|
s.rollbackPromptClaim(ctx, taskID, sessionID, rollback)
|
|
return nil, promptErr
|
|
}
|
|
return nil, s.handlePromptError(ctx, taskID, sessionID, rollback.previousSessionState, promptErr)
|
|
}
|
|
|
|
// effectivePromptForSession applies promptTask's config-mode and plan-mode
|
|
// prompt transforms to the raw prompt, in that order, using session's
|
|
// *current* Metadata. Each call always starts from the raw prompt argument
|
|
// (never a previously-transformed result), so it is safe for promptTask to
|
|
// call this twice — once on session load and again after a reload that
|
|
// follows ensureSessionRunning, in case metadata changed in between —
|
|
// without double-prepending either transform's system-prompt wrapper.
|
|
func (s *Service) effectivePromptForSession(sessionID, prompt string, planMode bool, session *models.TaskSession) string {
|
|
effectivePrompt := prompt
|
|
if cm, ok := session.Metadata["config_mode"].(bool); ok && cm {
|
|
effectivePrompt = sysprompt.InjectConfigContext(sessionID, prompt)
|
|
}
|
|
if planMode {
|
|
effectivePrompt = sysprompt.InjectPlanMode(effectivePrompt)
|
|
}
|
|
return effectivePrompt
|
|
}
|
|
|
|
var (
|
|
errLifecyclePromptInactive = errors.New("lifecycle prompt task or session is inactive")
|
|
errLifecyclePromptClaim = errors.New("lifecycle prompt claim failed")
|
|
errLifecyclePromptMessagePersistence = errors.New("lifecycle prompt message persistence failed")
|
|
errLifecyclePromptReservationSuperseded = errors.New("lifecycle prompt reservation was superseded")
|
|
)
|
|
|
|
type lifecyclePromptReselectedError struct {
|
|
sessionID string
|
|
}
|
|
|
|
func (e *lifecyclePromptReselectedError) Error() string {
|
|
return fmt.Sprintf("lifecycle prompt session reselected: %s", e.sessionID)
|
|
}
|
|
|
|
// claimSessionRunningForPrompt marks sessionID RUNNING immediately before
|
|
// promptTask dispatches to the agent, and returns the session to use for
|
|
// the rest of the call (possibly reloaded).
|
|
//
|
|
// Direct and queued prompts both claim RUNNING under the per-session
|
|
// cancelInFlight guard. This makes the final "still promptable, now owned by
|
|
// this turn" decision atomic with coordinator stop; the potentially blocking
|
|
// executor.Prompt call remains outside the guard.
|
|
//
|
|
// When claimEntryID is set, the final claim happens under the same per-session
|
|
// cancelInFlightGuard every other cancel/take-and-dispatch decision in this
|
|
// file serializes through. Re-verifying
|
|
// ownership *and* promptability inside this same critical section,
|
|
// immediately before writing RUNNING, closes a gap that checking the token
|
|
// alone would leave open: nothing would otherwise stop this call from
|
|
// blindly marking the session RUNNING over top of a state some other
|
|
// guard-synchronized decision-maker (a cancel, another claim) already
|
|
// changed since promptTask's much-earlier, unguarded checkSessionPromptable
|
|
// call near its top. Reloading the session and re-running
|
|
// checkSessionPromptable here makes "is it actually still safe to mark this
|
|
// session RUNNING right now" an atomic fact, not a stale read.
|
|
func (s *Service) claimSessionRunningForPrompt(
|
|
ctx context.Context,
|
|
taskID, sessionID, claimEntryID string,
|
|
session *models.TaskSession,
|
|
foregroundClaim *foregroundClaim,
|
|
) (*models.TaskSession, error) {
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
defer release()
|
|
lock.Lock()
|
|
defer lock.Unlock()
|
|
if err := s.waitForCancellationWithGuard(ctx, sessionID, lock.Unlock, lock.Lock); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if claimEntryID != "" && !s.isCurrentQueuedDispatch(sessionID, claimEntryID) {
|
|
return nil, errQueuedDispatchSuperseded
|
|
}
|
|
freshSession, sessErr := s.repo.GetTaskSession(ctx, sessionID)
|
|
if sessErr != nil {
|
|
return nil, fmt.Errorf("reload session before claiming queued dispatch: %w", sessErr)
|
|
}
|
|
if freshSession == nil {
|
|
return nil, errQueuedDispatchSuperseded
|
|
}
|
|
if promptErr := s.recheckPromptableWithForegroundClaim(
|
|
taskID, sessionID, freshSession.State, foregroundClaim,
|
|
); promptErr != nil {
|
|
return nil, promptErr
|
|
}
|
|
s.setSessionRunning(ctx, taskID, sessionID, freshSession)
|
|
// setSessionRunning refreshes freshSession in place when its guarded write
|
|
// loses, so a cancellation landing after the promptability check is visible
|
|
// here as a terminal state.
|
|
if isTerminalSessionState(freshSession.State) && freshSession.State != models.TaskSessionStateCompleted {
|
|
return nil, &executor.SessionStateSupersededError{
|
|
SessionID: freshSession.ID,
|
|
State: freshSession.State,
|
|
}
|
|
}
|
|
// Remove only the pre-acceptance marker here. The accepted ownership record
|
|
// remains until the turn settles, so Send Now cannot cancel or duplicate
|
|
// this successor while the executor call is still in progress.
|
|
if claimEntryID != "" {
|
|
s.releaseQueuedDispatchPendingIfCurrent(
|
|
sessionID,
|
|
s.queuedDispatchReservationForEntry(sessionID, claimEntryID),
|
|
)
|
|
}
|
|
return freshSession, nil
|
|
}
|
|
|
|
func (s *Service) claimLifecycleSessionRunning(
|
|
ctx context.Context,
|
|
taskID, sessionID, claimEntryID string,
|
|
) (*models.TaskSession, models.TaskSessionState, error) {
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
defer release()
|
|
lock.Lock()
|
|
defer lock.Unlock()
|
|
if err := s.waitForCancellationWithGuard(ctx, sessionID, lock.Unlock, lock.Lock); err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
if claimEntryID != "" && !s.isCurrentQueuedDispatch(sessionID, claimEntryID) {
|
|
return nil, "", errQueuedDispatchSuperseded
|
|
}
|
|
if err := s.validateLifecyclePromptSelection(ctx, taskID, sessionID); err != nil {
|
|
return nil, "", err
|
|
}
|
|
claim, err := s.repo.ClaimPromptableTaskSessionIfActive(ctx, sessionID)
|
|
if err != nil {
|
|
return nil, "", fmt.Errorf("%w: %v", errLifecyclePromptClaim, err)
|
|
}
|
|
switch claim.Status {
|
|
case models.PromptableTaskSessionInactive:
|
|
return nil, "", errLifecyclePromptInactive
|
|
case models.PromptableTaskSessionBusy:
|
|
return nil, "", fmt.Errorf("%w: lifecycle prompt session is busy", ErrAgentPromptInProgress)
|
|
}
|
|
if claimEntryID != "" && !s.isCurrentQueuedDispatch(sessionID, claimEntryID) {
|
|
s.restoreLifecycleClaim(ctx, taskID, sessionID, claim.PreviousState)
|
|
return nil, "", errQueuedDispatchSuperseded
|
|
}
|
|
if s.isSessionResetInProgress(sessionID) {
|
|
s.restoreLifecycleClaim(ctx, taskID, sessionID, claim.PreviousState)
|
|
return nil, "", ErrSessionResetInProgress
|
|
}
|
|
freshSession, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil || freshSession == nil {
|
|
s.restoreLifecycleClaim(ctx, taskID, sessionID, claim.PreviousState)
|
|
return nil, "", errLifecyclePromptInactive
|
|
}
|
|
s.releaseQueuedDispatchPendingIfCurrent(
|
|
sessionID,
|
|
s.queuedDispatchReservationForEntry(sessionID, claimEntryID),
|
|
)
|
|
return freshSession, claim.PreviousState, nil
|
|
}
|
|
|
|
func (s *Service) validateLifecyclePromptSelection(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
) error {
|
|
selectedSession, err := s.resolveTaskPRAgentSession(ctx, taskID)
|
|
if err != nil || selectedSession == nil {
|
|
task, taskErr := s.repo.GetTask(ctx, taskID)
|
|
if taskErr != nil || task == nil || task.ArchivedAt != nil {
|
|
return errLifecyclePromptInactive
|
|
}
|
|
return fmt.Errorf("%w: no promptable lifecycle session", ErrAgentPromptInProgress)
|
|
}
|
|
if selectedSession.ID != sessionID {
|
|
return &lifecyclePromptReselectedError{sessionID: selectedSession.ID}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) restoreLifecycleClaim(
|
|
ctx context.Context,
|
|
taskID, sessionID string,
|
|
previousState models.TaskSessionState,
|
|
) {
|
|
s.updateTaskSessionState(ctx, taskID, sessionID, previousState, "", false)
|
|
}
|
|
|
|
func (s *Service) recheckPromptableWithForegroundClaim(
|
|
taskID, sessionID string,
|
|
state models.TaskSessionState,
|
|
claim *foregroundClaim,
|
|
) error {
|
|
if claim == nil {
|
|
return s.checkSessionPromptable(taskID, sessionID, state)
|
|
}
|
|
if state != models.TaskSessionStateRunning {
|
|
// ensureSessionRunning may resume the agent after this prompt claimed a
|
|
// background-idle RUNNING session. AgentBootReady advances the durable
|
|
// state to WAITING_FOR_INPUT before dispatch; keep the valid claim across
|
|
// that expected transition while still rejecting terminal or otherwise
|
|
// non-promptable states.
|
|
if err := s.checkSessionPromptable(taskID, sessionID, state); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if !s.isForegroundClaimCurrent(sessionID, claim) {
|
|
return fmt.Errorf("%w, please wait for completion", ErrAgentPromptInProgress)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// checkSessionPromptable returns nil when the session's state accepts a new
|
|
// prompt. RUNNING is rejected with ErrAgentPromptInProgress; any other
|
|
// non-acceptable state (STARTING / CREATED / FAILED / CANCELLED) is rejected
|
|
// with ErrSessionNotPromptable so callers can distinguish "wait for the
|
|
// current turn" from "this session is not in a state where it can take a
|
|
// prompt". IDLE is acceptable: office sessions intentionally park in IDLE
|
|
// between turns (agent torn down, ACP session preserved) and the next prompt
|
|
// resumes them — see ensureSessionRunning.
|
|
func (s *Service) checkSessionPromptable(taskID, sessionID string, state models.TaskSessionState) error {
|
|
switch state {
|
|
case models.TaskSessionStateWaitingForInput,
|
|
models.TaskSessionStateCompleted,
|
|
models.TaskSessionStateIdle:
|
|
return nil
|
|
case models.TaskSessionStateRunning:
|
|
// The safe default is coarse: every RUNNING session is busy. A
|
|
// deployment may explicitly opt a persisted Claude Code session into
|
|
// ADR-0049's adapter-attested background handoff experiment. Every
|
|
// missing identity and non-Claude provider still fails closed.
|
|
if s.ForegroundActivity(sessionID) == v1.ForegroundActivityBackground {
|
|
s.logger.Debug("accepting prompt: enabled Claude foreground handoff is background-idle",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID))
|
|
return nil
|
|
}
|
|
s.logger.Warn("rejected prompt while agent is already running",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("session_state", string(state)))
|
|
return fmt.Errorf("%w, please wait for completion", ErrAgentPromptInProgress)
|
|
default:
|
|
s.logger.Warn("rejected prompt: session not ready for input",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("session_state", string(state)))
|
|
return fmt.Errorf("%w: session is in %s state", ErrSessionNotPromptable, state)
|
|
}
|
|
}
|
|
|
|
// handlePromptError reverts session state, logs the failure, transitions the
|
|
// task to REVIEW for non-transient errors, and completes the in-flight turn.
|
|
// Returns the (possibly remapped) error for the caller to surface.
|
|
func (s *Service) handlePromptError(ctx context.Context, taskID, sessionID string, previousSessionState models.TaskSessionState, err error) error {
|
|
if isTransientPromptError(err) && s.isSessionResetInProgress(sessionID) {
|
|
s.logger.Warn("prompt deferred while session reset is in progress; retry expected",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
err = ErrSessionResetInProgress
|
|
} else {
|
|
s.logger.Error("prompt failed",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
}
|
|
// Revert session state so it doesn't stay stuck in RUNNING. Route through the
|
|
// wrapper so WS subscribers are notified — the UI relies on the
|
|
// session.state_changed broadcast to flip the composer/pause button out of
|
|
// "Agent is running". The wrapper's terminal-state guard is also correct here:
|
|
// if a concurrent agent-failure handler moved the session to FAILED we don't
|
|
// want to overwrite that with previousSessionState. Do NOT pass the preloaded
|
|
// `session` — the wrapper must re-read the row to see any such concurrent
|
|
// terminal transition; the stale pre-RUNNING snapshot would defeat the guard.
|
|
// allowWakeFromWaiting=false — this is a revert away from RUNNING, never a
|
|
// wake transition; the flag only matters when going WAITING_FOR_INPUT → RUNNING.
|
|
s.updateTaskSessionState(ctx, taskID, sessionID, previousSessionState, "", false)
|
|
// ErrCancelEscalated means the user cancelled and the lifecycle manager had to
|
|
// force-unblock a hung agent. Service.CancelAgent owns the cancel reconcile
|
|
// (session → WAITING_FOR_INPUT, task → REVIEW, cancel message, complete
|
|
// turn); skip the REVIEW write here so we don't race that path with a
|
|
// duplicate update.
|
|
// A short transient provider error is owned by the async
|
|
// retry-with-backoff path (handleTransientFailure), which keeps the task
|
|
// in progress while it retries — so don't flap it to REVIEW here.
|
|
if !isTransientPromptError(err) && !errors.Is(err, lifecycle.ErrCancelEscalated) &&
|
|
!routingerr.IsTransientProviderError(err.Error()) {
|
|
s.writeTaskReviewState(ctx, taskID, sessionID)
|
|
}
|
|
s.completeTurnForSession(ctx, sessionID)
|
|
return err
|
|
}
|
|
|
|
// trySwitchModel handles model switching for a prompt. Returns (result, true, nil) if a switch was
|
|
// performed, (nil, false, err) on error, or (nil, false, nil) if no switch was needed.
|
|
func (s *Service) trySwitchModel(ctx context.Context, taskID, sessionID, model, effectivePrompt string, session *models.TaskSession) (*PromptResult, bool, error) {
|
|
if model == "" {
|
|
return nil, false, nil
|
|
}
|
|
var currentModel string
|
|
if session.AgentProfileSnapshot != nil {
|
|
if m, ok := session.AgentProfileSnapshot["model"].(string); ok {
|
|
currentModel = m
|
|
}
|
|
}
|
|
if currentModel == model {
|
|
return nil, false, nil
|
|
}
|
|
s.logger.Info("switching model",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("from", currentModel),
|
|
zap.String("to", model))
|
|
switchCtx := context.WithoutCancel(ctx)
|
|
switchResult, err := s.executor.SwitchModel(switchCtx, taskID, sessionID, model, effectivePrompt)
|
|
if err != nil {
|
|
return nil, true, fmt.Errorf("model switch failed: %w", err)
|
|
}
|
|
s.runtimeModelBySession.Store(sessionID, model)
|
|
if switchResult.StopReason == "model_switched_in_place" {
|
|
// Agent is still running with the new model — let PromptTask send the prompt normally.
|
|
// Invalidate the message creator's model cache so the next message picks up the new model.
|
|
if s.messageCreator != nil {
|
|
s.messageCreator.InvalidateModelCache(sessionID)
|
|
}
|
|
return nil, false, nil
|
|
}
|
|
s.startTurnForSession(ctx, sessionID)
|
|
s.setSessionRunning(ctx, taskID, sessionID, session)
|
|
return &PromptResult{
|
|
StopReason: switchResult.StopReason,
|
|
AgentMessage: switchResult.AgentMessage,
|
|
}, true, nil
|
|
}
|
|
|
|
// RespondToPermission sends a response to a permission request for a session
|
|
func (s *Service) RespondToPermission(ctx context.Context, sessionID, pendingID, optionID string, cancelled, rejected bool) error {
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
return err
|
|
}
|
|
|
|
s.logger.Debug("responding to permission request",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("pending_id", pendingID),
|
|
zap.String("option_id", optionID),
|
|
zap.Bool("cancelled", cancelled),
|
|
zap.Bool("rejected", rejected))
|
|
|
|
// Respond to the permission via agentctl
|
|
if err := s.executor.RespondToPermission(ctx, sessionID, pendingID, optionID, cancelled); err != nil {
|
|
// Permission likely expired — update message so frontend reflects this
|
|
if s.messageCreator != nil {
|
|
if updateErr := s.messageCreator.UpdatePermissionMessage(ctx, sessionID, pendingID, models.PermissionStatusExpired); updateErr != nil {
|
|
s.logger.Warn("failed to mark expired permission message",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("pending_id", pendingID),
|
|
zap.Error(updateErr))
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
|
|
// Determine status based on response. cancelled=true means the user dismissed
|
|
// the dialog; rejected=true means the user explicitly clicked Deny with a
|
|
// reject option. Both map to "rejected" message status.
|
|
status := models.PermissionStatusApproved
|
|
if cancelled || rejected {
|
|
status = models.PermissionStatusRejected
|
|
}
|
|
|
|
// Update the permission message with the new status
|
|
if s.messageCreator != nil {
|
|
if err := s.messageCreator.UpdatePermissionMessage(ctx, sessionID, pendingID, status); err != nil {
|
|
s.logger.Warn("failed to update permission message status",
|
|
zap.String("session_id", sessionID),
|
|
zap.String("pending_id", pendingID),
|
|
zap.String("status", string(status)),
|
|
zap.Error(err))
|
|
// Don't fail the whole operation if message update fails
|
|
}
|
|
}
|
|
|
|
if !cancelled {
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to load task session after permission response",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
return nil
|
|
}
|
|
s.setSessionRunning(ctx, session.TaskID, sessionID, session)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// DrainQueuedMessage dispatches one queued message for a session that is ready
|
|
// for input. It is intentionally one-at-a-time: each successful prompt will
|
|
// complete its own turn and then drain the next entry through handleAgentReady.
|
|
func (s *Service) DrainQueuedMessage(ctx context.Context, sessionID string) (bool, error) {
|
|
if sessionID == "" {
|
|
return false, fmt.Errorf("session_id is required")
|
|
}
|
|
// Acquire the guard *before* checking promptability, not after: check-
|
|
// then-lock would leave a gap where a concurrent
|
|
// QueueAndInterruptForPeerMessage (or another drain) changes the
|
|
// session's state between this call's check and its take, letting a
|
|
// manual drain request race a parent interrupt for the same entry —
|
|
// see the Service.cancelInFlight field doc comment. A blocking Lock
|
|
// (not a TryLock skip) is deliberate: unlike handleAgentReady /
|
|
// handleAgentBootReady (where a losing side can rely on the winning
|
|
// side's own take-and-dispatch, or a future turn's own agent.ready, to
|
|
// retry), a manual drain request has no other future trigger —
|
|
// skipping here could strand an already-queued message instead of
|
|
// just reporting an accurate "not promptable right now".
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
defer release()
|
|
lock.Lock()
|
|
guardLocked := true
|
|
defer func() {
|
|
if guardLocked {
|
|
lock.Unlock()
|
|
}
|
|
}()
|
|
for s.isCancelInFlight(sessionID) {
|
|
lock.Unlock()
|
|
guardLocked = false
|
|
if err := s.waitForCancelInFlight(ctx, sessionID); err != nil {
|
|
return false, err
|
|
}
|
|
lock.Lock()
|
|
guardLocked = true
|
|
}
|
|
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return false, fmt.Errorf("failed to get session: %w", err)
|
|
}
|
|
if err := s.checkSessionPromptable(session.TaskID, sessionID, session.State); err != nil {
|
|
return false, err
|
|
}
|
|
return s.drainQueuedMessageForPromptableSessionLocked(ctx, sessionID), nil
|
|
}
|
|
|
|
// cancelInFlightGuard is a per-session mutex serializing cancel/interrupt/
|
|
// queue-take decisions (see the Service.cancelInFlight field doc comment),
|
|
// paired with a reference count so the registry can safely reclaim the
|
|
// entry once every acquirer has released it — refs is guarded by
|
|
// Service.cancelInFlightMu, never by mu itself, since mu can be held for
|
|
// the caller's whole critical section while refs bookkeeping must stay
|
|
// brief and independent of that.
|
|
type cancelInFlightGuard struct {
|
|
mu sync.Mutex
|
|
refs int
|
|
}
|
|
|
|
type cancellationKind string
|
|
|
|
const (
|
|
cancellationKindExplicit cancellationKind = "explicit"
|
|
cancellationKindSilent cancellationKind = "silent"
|
|
cancellationKindPeer cancellationKind = "peer"
|
|
cancellationKindInternal cancellationKind = "internal"
|
|
cancellationKindQueueSendNow cancellationKind = "queue_send_now"
|
|
cancellationOperationTTL = 30 * time.Second
|
|
)
|
|
|
|
type cancellationIdentity struct {
|
|
executionID string
|
|
promptGeneration uint64
|
|
turnID string
|
|
}
|
|
|
|
type cancelOperation struct {
|
|
done chan struct{}
|
|
joined chan struct{}
|
|
joinObserved bool
|
|
err error
|
|
projectionRelease func()
|
|
kind cancellationKind
|
|
identity cancellationIdentity
|
|
identityReady bool
|
|
expectedTurnID string
|
|
expectedTurnReady bool
|
|
completionEligible bool
|
|
completionEligibilityReady bool
|
|
actions []*cancellationAction
|
|
nextAction int
|
|
explicitReconcileOnce sync.Once
|
|
explicitReconcileErr error
|
|
}
|
|
|
|
// cancellationAction is source-specific work that must run after the shared
|
|
// lifecycle cancellation/reconciliation, but before the coordinator releases
|
|
// the operation to other state-mutating paths. The action runs while holding
|
|
// the session guard, so a manual drain or ready event cannot slip between the
|
|
// shared cancel and the source's own queue/visible-message decision.
|
|
type cancellationAction struct {
|
|
done chan struct{}
|
|
run func(context.Context, *cancelOperation) (bool, error)
|
|
dispatched bool
|
|
err error
|
|
}
|
|
|
|
// acquireCancelInFlightGuard returns the shared per-session mutex guarding
|
|
// cancel/interrupt/queue-take decisions for sessionID, creating one if it
|
|
// doesn't exist yet and registering the caller's reference to it. Callers
|
|
// MUST call the returned release func exactly once when done with the
|
|
// mutex — whether or not they actually acquired it (e.g. a TryLock that
|
|
// returned false still needs release to drop its reference). Pairing every
|
|
// acquire with a release is what keeps cancelInFlight bounded by
|
|
// concurrently-active sessions: once refs drops to zero the entry is
|
|
// deleted from the map instead of accumulating one permanent entry per
|
|
// session ever created.
|
|
func (s *Service) acquireCancelInFlightGuard(sessionID string) (*sync.Mutex, func()) {
|
|
s.cancelInFlightMu.Lock()
|
|
if s.cancelInFlight == nil {
|
|
s.cancelInFlight = make(map[string]*cancelInFlightGuard)
|
|
}
|
|
guard, ok := s.cancelInFlight[sessionID]
|
|
if !ok {
|
|
guard = &cancelInFlightGuard{}
|
|
s.cancelInFlight[sessionID] = guard
|
|
}
|
|
guard.refs++
|
|
s.cancelInFlightMu.Unlock()
|
|
|
|
var released bool
|
|
release := func() {
|
|
if released {
|
|
return
|
|
}
|
|
released = true
|
|
s.cancelInFlightMu.Lock()
|
|
guard.refs--
|
|
if guard.refs == 0 {
|
|
delete(s.cancelInFlight, sessionID)
|
|
}
|
|
s.cancelInFlightMu.Unlock()
|
|
}
|
|
return &guard.mu, release
|
|
}
|
|
|
|
// claimCancellation establishes the single owner for every cancellation source
|
|
// targeting one session. The operation stays registered until its owner has
|
|
// finished lifecycle cancellation and source-specific reconciliation.
|
|
func (s *Service) claimCancellation(sessionID string, kind cancellationKind) (*cancelOperation, bool) {
|
|
operation, owner, _ := s.claimCancellationWithAction(sessionID, kind, nil)
|
|
return operation, owner
|
|
}
|
|
|
|
func (s *Service) claimCancellationWithAction(
|
|
sessionID string,
|
|
kind cancellationKind,
|
|
action func(context.Context, *cancelOperation) (bool, error),
|
|
) (*cancelOperation, bool, *cancellationAction) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if s.cancellationOperations == nil {
|
|
s.cancellationOperations = make(map[string]*cancelOperation)
|
|
}
|
|
if operation, ok := s.cancellationOperations[sessionID]; ok {
|
|
operation.markJoinedLocked()
|
|
if action == nil {
|
|
return operation, false, nil
|
|
}
|
|
registered := &cancellationAction{done: make(chan struct{}), run: action}
|
|
operation.actions = append(operation.actions, registered)
|
|
return operation, false, registered
|
|
}
|
|
operation := &cancelOperation{done: make(chan struct{}), joined: make(chan struct{}), kind: kind}
|
|
var registered *cancellationAction
|
|
if action != nil {
|
|
registered = &cancellationAction{done: make(chan struct{}), run: action}
|
|
operation.actions = append(operation.actions, registered)
|
|
}
|
|
s.cancellationOperations[sessionID] = operation
|
|
return operation, true, registered
|
|
}
|
|
|
|
// claimCancellationWithActionExclusive establishes a cancellation owner only
|
|
// when no source is already active for the session. Send Now uses this stricter
|
|
// variant because joining an explicit cancel (or another Send Now click) would
|
|
// otherwise let the shared cancellation finish with the wrong source
|
|
// semantics. The accepted result is false when a caller must fail closed.
|
|
func (s *Service) claimCancellationWithActionExclusive(
|
|
sessionID string,
|
|
kind cancellationKind,
|
|
action func(context.Context, *cancelOperation) (bool, error),
|
|
) (*cancelOperation, bool, *cancellationAction, bool) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if s.cancellationOperations == nil {
|
|
s.cancellationOperations = make(map[string]*cancelOperation)
|
|
}
|
|
if operation, ok := s.cancellationOperations[sessionID]; ok {
|
|
return operation, false, nil, false
|
|
}
|
|
operation := &cancelOperation{done: make(chan struct{}), joined: make(chan struct{}), kind: kind}
|
|
var registered *cancellationAction
|
|
if action != nil {
|
|
registered = &cancellationAction{done: make(chan struct{}), run: action}
|
|
operation.actions = append(operation.actions, registered)
|
|
}
|
|
s.cancellationOperations[sessionID] = operation
|
|
return operation, true, registered, true
|
|
}
|
|
|
|
func (s *Service) claimExplicitCancellation(
|
|
sessionID string,
|
|
action func(context.Context, *cancelOperation) (bool, error),
|
|
) (*cancelOperation, bool, *cancellationAction) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if s.cancellationOperations == nil {
|
|
s.cancellationOperations = make(map[string]*cancelOperation)
|
|
}
|
|
if operation, ok := s.cancellationOperations[sessionID]; ok {
|
|
if operation.kind == cancellationKindQueueSendNow {
|
|
return operation, false, nil
|
|
}
|
|
operation.markJoinedLocked()
|
|
if operation.kind == cancellationKindExplicit || action == nil {
|
|
return operation, false, nil
|
|
}
|
|
registered := &cancellationAction{done: make(chan struct{}), run: action}
|
|
operation.actions = append(operation.actions, registered)
|
|
return operation, false, registered
|
|
}
|
|
operation := &cancelOperation{
|
|
done: make(chan struct{}),
|
|
joined: make(chan struct{}),
|
|
kind: cancellationKindExplicit,
|
|
}
|
|
s.cancellationOperations[sessionID] = operation
|
|
return operation, true, nil
|
|
}
|
|
|
|
// markJoinedLocked records that another accepted cancellation source has
|
|
// attached to this operation. cancellationOperationsMu must be held.
|
|
func (operation *cancelOperation) markJoinedLocked() {
|
|
if operation == nil || operation.joinObserved {
|
|
return
|
|
}
|
|
operation.joinObserved = true
|
|
close(operation.joined)
|
|
}
|
|
|
|
func (s *Service) currentCancellation(sessionID string) *cancelOperation {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
return s.cancellationOperations[sessionID]
|
|
}
|
|
|
|
func (s *Service) setCancellationIdentity(sessionID string, operation *cancelOperation, identity cancellationIdentity) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if current := s.cancellationOperations[sessionID]; current == operation {
|
|
operation.identity = identity
|
|
operation.identityReady = true
|
|
}
|
|
}
|
|
|
|
func (s *Service) setCancellationExpectedTurn(sessionID string, operation *cancelOperation, turnID string) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if current := s.cancellationOperations[sessionID]; current == operation {
|
|
operation.expectedTurnID = turnID
|
|
operation.expectedTurnReady = true
|
|
}
|
|
}
|
|
|
|
func (s *Service) cancellationExpectedTurnSnapshot(operation *cancelOperation) (string, bool) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if operation == nil {
|
|
return "", false
|
|
}
|
|
return operation.expectedTurnID, operation.expectedTurnReady
|
|
}
|
|
|
|
func (s *Service) setCancellationCompletionEligible(sessionID string, operation *cancelOperation, eligible bool) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if current := s.cancellationOperations[sessionID]; current == operation {
|
|
operation.completionEligible = eligible
|
|
operation.completionEligibilityReady = true
|
|
}
|
|
}
|
|
|
|
func (s *Service) cancellationIdentitySnapshot(operation *cancelOperation) (cancellationIdentity, bool) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if operation == nil {
|
|
return cancellationIdentity{}, false
|
|
}
|
|
return operation.identity, operation.identityReady
|
|
}
|
|
|
|
func (s *Service) cancellationPreparationSnapshot(operation *cancelOperation) (cancellationIdentity, bool, bool) {
|
|
s.cancellationOperationsMu.Lock()
|
|
defer s.cancellationOperationsMu.Unlock()
|
|
if operation == nil {
|
|
return cancellationIdentity{}, false, false
|
|
}
|
|
return operation.identity, operation.completionEligible, operation.completionEligibilityReady
|
|
}
|
|
|
|
func (s *Service) finishCancellation(sessionID string, operation *cancelOperation, err error) {
|
|
s.finishCancellationWithActions(context.Background(), sessionID, operation, err)
|
|
}
|
|
|
|
// finishCancellationWithActions runs all source-specific actions that joined
|
|
// the operation before removing it from the coordinator. The global
|
|
// coordinator mutex is reacquired between actions; a joiner that claims the
|
|
// operation before the final removal is therefore included, while a caller
|
|
// arriving after removal starts a fresh operation and re-evaluates state.
|
|
func (s *Service) finishCancellationWithActions(
|
|
ctx context.Context,
|
|
sessionID string,
|
|
operation *cancelOperation,
|
|
err error,
|
|
) {
|
|
for {
|
|
s.cancellationOperationsMu.Lock()
|
|
if current := s.cancellationOperations[sessionID]; current != operation {
|
|
s.cancellationOperationsMu.Unlock()
|
|
return
|
|
}
|
|
if operation.nextAction >= len(operation.actions) {
|
|
releaseProjection := operation.projectionRelease
|
|
operation.projectionRelease = nil
|
|
operation.err = err
|
|
delete(s.cancellationOperations, sessionID)
|
|
s.cancellationOperationsMu.Unlock()
|
|
if releaseProjection != nil {
|
|
releaseProjection()
|
|
}
|
|
close(operation.done)
|
|
return
|
|
}
|
|
action := operation.actions[operation.nextAction]
|
|
operation.nextAction++
|
|
s.cancellationOperationsMu.Unlock()
|
|
|
|
actionErr := err
|
|
var dispatched bool
|
|
if actionErr == nil && action.run != nil {
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
lock.Lock()
|
|
dispatched, actionErr = action.run(ctx, operation)
|
|
lock.Unlock()
|
|
release()
|
|
}
|
|
|
|
s.cancellationOperationsMu.Lock()
|
|
action.dispatched = dispatched
|
|
action.err = actionErr
|
|
close(action.done)
|
|
s.cancellationOperationsMu.Unlock()
|
|
}
|
|
}
|
|
|
|
// beginCancelInFlight keeps the legacy marker seam used by coordinator-stop
|
|
// and focused tests, but its marker is now the same ownership record used by
|
|
// explicit, silent, and peer cancellation paths.
|
|
func (s *Service) beginCancelInFlight(sessionID string) func() {
|
|
if sessionID == "" {
|
|
return func() {}
|
|
}
|
|
endProjection := s.beginCancellationProjection(sessionID)
|
|
operation, owner := s.claimCancellation(sessionID, cancellationKindInternal)
|
|
if !owner {
|
|
return endProjection
|
|
}
|
|
operation.projectionRelease = endProjection
|
|
|
|
var once sync.Once
|
|
return func() {
|
|
once.Do(func() {
|
|
s.finishCancellation(sessionID, operation, nil)
|
|
endProjection()
|
|
})
|
|
}
|
|
}
|
|
|
|
// beginCancellationProjection records accepted cancellation work for the
|
|
// backend-owned progress projection. It is deliberately separate from the
|
|
// lifecycle ownership coordinator above: stream persistence can use the
|
|
// per-session guard without changing the user-visible cancellation state.
|
|
func (s *Service) beginCancellationProjection(sessionID string) func() {
|
|
if sessionID == "" {
|
|
return func() {}
|
|
}
|
|
s.cancelOperationsMu.Lock()
|
|
if s.cancelOperations == nil {
|
|
s.cancelOperations = make(map[string]*cancellationOperationState)
|
|
}
|
|
state := s.cancelOperations[sessionID]
|
|
if state == nil {
|
|
state = &cancellationOperationState{}
|
|
s.cancelOperations[sessionID] = state
|
|
}
|
|
state.count++
|
|
startDrain := false
|
|
if state.count == 1 {
|
|
state.revision++
|
|
startDrain = s.enqueueCancellationPendingLocked(sessionID, state, true)
|
|
}
|
|
s.cancelOperationsMu.Unlock()
|
|
if startDrain {
|
|
s.drainCancellationPublicationQueue(sessionID, state)
|
|
}
|
|
|
|
var once sync.Once
|
|
return func() {
|
|
once.Do(func() {
|
|
startDrain := false
|
|
s.cancelOperationsMu.Lock()
|
|
state := s.cancelOperations[sessionID]
|
|
if state != nil && state.count > 0 {
|
|
state.count--
|
|
if state.count == 0 {
|
|
state.revision++
|
|
startDrain = s.enqueueCancellationPendingLocked(sessionID, state, false)
|
|
}
|
|
}
|
|
s.cancelOperationsMu.Unlock()
|
|
if startDrain {
|
|
s.drainCancellationPublicationQueue(sessionID, state)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// CancellationPending reports whether at least one accepted cancellation
|
|
// operation is active for sessionID. The projection is intentionally runtime
|
|
// scoped: a backend restart clears it because no cancellation work survives
|
|
// the process restart.
|
|
func (s *Service) CancellationPending(sessionID string) bool {
|
|
pending, _ := s.CancellationPendingSnapshot(sessionID)
|
|
return pending
|
|
}
|
|
|
|
// CancellationPendingSnapshot returns the pending projection and its
|
|
// process-local transition revision from one critical section. Keeping these
|
|
// values together prevents REST/boot hydration from observing a boolean from
|
|
// one generation with the revision from another.
|
|
func (s *Service) CancellationPendingSnapshot(sessionID string) (bool, uint64) {
|
|
if sessionID == "" {
|
|
return false, 0
|
|
}
|
|
s.cancelOperationsMu.Lock()
|
|
defer s.cancelOperationsMu.Unlock()
|
|
state := s.cancelOperations[sessionID]
|
|
if state == nil {
|
|
return false, 0
|
|
}
|
|
return state.count > 0, state.revision
|
|
}
|
|
|
|
func (s *Service) publishCancellationPending(sessionID string, pending bool, revision uint64) {
|
|
if s.eventBus == nil || sessionID == "" {
|
|
return
|
|
}
|
|
payload := map[string]interface{}{
|
|
"session_id": sessionID,
|
|
"cancellation_pending": pending,
|
|
"cancellation_revision": revision,
|
|
}
|
|
if err := s.eventBus.Publish(context.Background(), events.TaskSessionCancellationChanged,
|
|
bus.NewEvent(events.TaskSessionCancellationChanged, "orchestrator", payload)); err != nil {
|
|
if s.logger != nil {
|
|
s.logger.Warn("failed to publish cancellation state",
|
|
zap.String("session_id", sessionID),
|
|
zap.Bool("cancellation_pending", pending),
|
|
zap.Uint64("cancellation_revision", revision),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
}
|
|
|
|
type cancellationOperationState struct {
|
|
count int
|
|
revision uint64
|
|
publications cancellationPublicationQueue
|
|
}
|
|
|
|
type cancellationPublication struct {
|
|
pending bool
|
|
revision uint64
|
|
}
|
|
|
|
type cancellationPublicationQueue struct {
|
|
pending []cancellationPublication
|
|
publishing bool
|
|
}
|
|
|
|
// enqueueCancellationPendingLocked appends a transition while the count and
|
|
// revision are still protected by cancelOperationsMu. The caller must drain
|
|
// the queue after releasing that mutex when this returns true.
|
|
func (s *Service) enqueueCancellationPendingLocked(
|
|
sessionID string,
|
|
state *cancellationOperationState,
|
|
pending bool,
|
|
) bool {
|
|
if s.eventBus == nil || sessionID == "" {
|
|
return false
|
|
}
|
|
queue := &state.publications
|
|
queue.pending = append(queue.pending, cancellationPublication{pending: pending, revision: state.revision})
|
|
if queue.publishing {
|
|
return false
|
|
}
|
|
queue.publishing = true
|
|
return true
|
|
}
|
|
|
|
func (s *Service) drainCancellationPublicationQueue(
|
|
sessionID string,
|
|
state *cancellationOperationState,
|
|
) {
|
|
for {
|
|
s.cancelOperationsMu.Lock()
|
|
queue := &state.publications
|
|
if len(queue.pending) == 0 {
|
|
queue.publishing = false
|
|
s.cancelOperationsMu.Unlock()
|
|
return
|
|
}
|
|
publication := queue.pending[0]
|
|
queue.pending = queue.pending[1:]
|
|
s.cancelOperationsMu.Unlock()
|
|
|
|
s.publishCancellationPending(sessionID, publication.pending, publication.revision)
|
|
}
|
|
}
|
|
|
|
// isCancelInFlight reports whether an actual cancellation operation for
|
|
// sessionID is active or waiting on the shared guard. It deliberately does
|
|
// not inspect the guard mutex itself because stream/lifecycle handlers also
|
|
// use that mutex for non-cancelling side effects.
|
|
func (s *Service) isCancelInFlight(sessionID string) bool {
|
|
if sessionID == "" {
|
|
return false
|
|
}
|
|
return s.currentCancellation(sessionID) != nil
|
|
}
|
|
|
|
// waitForCancelInFlight blocks until all cancellation intents for sessionID
|
|
// have finished. Callers that hold the per-session guard must release it
|
|
// before waiting; the cancellation owner may need that mutex for terminal
|
|
// stream persistence and final reconciliation.
|
|
func (s *Service) waitForCancelInFlight(ctx context.Context, sessionID string) error {
|
|
operation := s.currentCancellation(sessionID)
|
|
if operation == nil {
|
|
return nil
|
|
}
|
|
return operation.wait(ctx)
|
|
}
|
|
|
|
// waitForCancellationWithGuard releases a caller-held per-session mutex while
|
|
// a cancellation owner completes, then reacquires it before returning. The
|
|
// loop closes the small handoff window where a fresh cancellation can claim
|
|
// the session immediately after the first operation finishes.
|
|
func (s *Service) waitForCancellationWithGuard(
|
|
ctx context.Context,
|
|
sessionID string,
|
|
unlock func(),
|
|
relock func(),
|
|
) error {
|
|
for {
|
|
operation := s.currentCancellation(sessionID)
|
|
if operation == nil {
|
|
return nil
|
|
}
|
|
unlock()
|
|
err := operation.wait(ctx)
|
|
relock()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *Service) cancellationOwnsStreamEvent(sessionID, executionID string, promptGeneration uint64) bool {
|
|
operation := s.currentCancellation(sessionID)
|
|
if operation == nil {
|
|
return true
|
|
}
|
|
identity, ready := s.cancellationIdentitySnapshot(operation)
|
|
if !ready {
|
|
// The owner has claimed the operation but has not yet reached the
|
|
// guarded identity snapshot. The stream event is ordered before the
|
|
// yielded lifecycle wait and may proceed to let the owner capture it.
|
|
return true
|
|
}
|
|
if identity.executionID != "" && executionID != "" && identity.executionID != executionID {
|
|
return false
|
|
}
|
|
if identity.promptGeneration != 0 && promptGeneration != 0 && identity.promptGeneration != promptGeneration {
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
func (operation *cancelOperation) wait(ctx context.Context) error {
|
|
select {
|
|
case <-operation.done:
|
|
return operation.err
|
|
case <-ctx.Done():
|
|
return ctx.Err()
|
|
}
|
|
}
|
|
|
|
func (action *cancellationAction) wait(ctx context.Context) (bool, error) {
|
|
if action == nil {
|
|
return false, nil
|
|
}
|
|
select {
|
|
case <-action.done:
|
|
return action.dispatched, action.err
|
|
case <-ctx.Done():
|
|
return false, ctx.Err()
|
|
}
|
|
}
|
|
|
|
// reconcileCancelledTurn durably settles the cancelled session and its turn.
|
|
// A user cancellation may trigger workflow completion only after both pieces
|
|
// of bookkeeping have been confirmed from their authoritative stores. The
|
|
// best-effort lifecycle helpers intentionally remain unchanged for other event
|
|
// paths; this path fails closed so a persistence or turn-service failure cannot
|
|
// advance the task while the cancelled turn is still running.
|
|
func (s *Service) reconcileCancelledTurn(
|
|
ctx context.Context,
|
|
taskID string,
|
|
sessionID string,
|
|
session *models.TaskSession,
|
|
requireWaiting bool,
|
|
) (*models.TaskSession, error) {
|
|
return s.reconcileCancelledTurnOwned(ctx, taskID, sessionID, session, requireWaiting, "")
|
|
}
|
|
|
|
// reconcileCancelledTurnOwned settles cancellation bookkeeping for the turn
|
|
// captured by the caller. An expected turn ID makes every authoritative check
|
|
// fail closed when a successor turn has appeared, rather than allowing the
|
|
// generic cleanup sweep to close unrelated work.
|
|
func (s *Service) reconcileCancelledTurnOwned(
|
|
ctx context.Context,
|
|
taskID string,
|
|
sessionID string,
|
|
session *models.TaskSession,
|
|
requireWaiting bool,
|
|
expectedTurnID string,
|
|
) (*models.TaskSession, error) {
|
|
if err := s.verifyCapturedCancelledTurn(ctx, sessionID, expectedTurnID); err != nil {
|
|
return nil, err
|
|
}
|
|
authoritativeSession, err := s.reconcileCancelledSessionState(ctx, taskID, session, requireWaiting)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if err := s.verifyCapturedCancelledTurn(ctx, sessionID, expectedTurnID); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := s.completeTurnForTaskSessionCheckedOwned(ctx, taskID, sessionID, expectedTurnID); err != nil {
|
|
return nil, fmt.Errorf("settle cancelled turn: %w", err)
|
|
}
|
|
|
|
if session == nil {
|
|
return nil, nil
|
|
}
|
|
if err := validateCancelledSessionState(session.ID, authoritativeSession, requireWaiting); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := s.verifyCancelledTurnClosedOwned(ctx, sessionID, expectedTurnID); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return authoritativeSession, nil
|
|
}
|
|
|
|
func (s *Service) verifyCapturedCancelledTurn(ctx context.Context, sessionID, expectedTurnID string) error {
|
|
if s.turnService == nil || expectedTurnID == "" {
|
|
return nil
|
|
}
|
|
activeTurn, err := s.turnService.GetActiveTurn(ctx, sessionID)
|
|
if err != nil {
|
|
if isNoActiveTurnError(err) {
|
|
return nil
|
|
}
|
|
return fmt.Errorf("inspect captured cancelled turn: %w", err)
|
|
}
|
|
if activeTurn != nil && activeTurn.ID != expectedTurnID {
|
|
return fmt.Errorf("captured cancelled turn %s was superseded by active turn %s", expectedTurnID, activeTurn.ID)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) reconcileCancelledSessionState(
|
|
ctx context.Context,
|
|
taskID string,
|
|
session *models.TaskSession,
|
|
requireWaiting bool,
|
|
) (*models.TaskSession, error) {
|
|
if session == nil || !requireWaiting {
|
|
return session, nil
|
|
}
|
|
updated := s.updateTaskSessionState(
|
|
ctx,
|
|
taskID,
|
|
session.ID,
|
|
models.TaskSessionStateWaitingForInput,
|
|
"",
|
|
true,
|
|
session,
|
|
)
|
|
if updated == nil {
|
|
return nil, fmt.Errorf("persist cancelled session %s as WAITING_FOR_INPUT", session.ID)
|
|
}
|
|
if updated.State != models.TaskSessionStateWaitingForInput {
|
|
return nil, fmt.Errorf(
|
|
"cancelled session %s persisted as %s, want WAITING_FOR_INPUT",
|
|
session.ID,
|
|
updated.State,
|
|
)
|
|
}
|
|
authoritative, err := s.repo.GetTaskSession(ctx, session.ID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("verify cancelled session %s state: %w", session.ID, err)
|
|
}
|
|
if authoritative == nil {
|
|
return nil, fmt.Errorf(
|
|
"cancelled session %s is missing before turn settlement, want WAITING_FOR_INPUT",
|
|
session.ID,
|
|
)
|
|
}
|
|
if authoritative.State != models.TaskSessionStateWaitingForInput {
|
|
return nil, fmt.Errorf(
|
|
"cancelled session %s is %s before turn settlement, want WAITING_FOR_INPUT",
|
|
session.ID,
|
|
authoritative.State,
|
|
)
|
|
}
|
|
return authoritative, nil
|
|
}
|
|
|
|
func validateCancelledSessionState(
|
|
sessionID string,
|
|
authoritativeSession *models.TaskSession,
|
|
requireWaiting bool,
|
|
) error {
|
|
if authoritativeSession == nil {
|
|
return fmt.Errorf("cancelled session %s has no authoritative state", sessionID)
|
|
}
|
|
if requireWaiting && authoritativeSession.State != models.TaskSessionStateWaitingForInput {
|
|
return fmt.Errorf(
|
|
"cancelled session %s settled as %s, want WAITING_FOR_INPUT",
|
|
sessionID,
|
|
authoritativeSession.State,
|
|
)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) verifyCancelledTurnClosed(ctx context.Context, sessionID string) error {
|
|
return s.verifyCancelledTurnClosedOwned(ctx, sessionID, "")
|
|
}
|
|
|
|
func (s *Service) verifyCancelledTurnClosedOwned(ctx context.Context, sessionID, expectedTurnID string) error {
|
|
if s.turnService == nil {
|
|
return nil
|
|
}
|
|
activeTurn, err := s.turnService.GetActiveTurn(ctx, sessionID)
|
|
if err != nil {
|
|
if isNoActiveTurnError(err) {
|
|
return nil
|
|
}
|
|
return fmt.Errorf("verify cancelled turn closure: %w", err)
|
|
}
|
|
if activeTurn != nil {
|
|
if expectedTurnID != "" && activeTurn.ID != expectedTurnID {
|
|
return fmt.Errorf("captured cancelled turn %s was superseded by active turn %s", expectedTurnID, activeTurn.ID)
|
|
}
|
|
return fmt.Errorf("cancelled turn %s remains open", activeTurn.ID)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// CancelAgent interrupts the current agent turn without terminating the process,
|
|
// allowing the user to send a new prompt.
|
|
//
|
|
// Idempotent w.r.t. missing executions: if the agent manager reports no live execution
|
|
// for the session (ErrNoExecutionForSession), the method still reconciles the session's
|
|
// DB state (transitions to WAITING_FOR_INPUT, records the cancel message, completes the
|
|
// turn) so the user can unstick a session whose agent subprocess crashed. Other errors
|
|
// still fail the cancel.
|
|
type cancelAgentPreparation struct {
|
|
session *models.TaskSession
|
|
completionEligible bool
|
|
capturedTurnID string
|
|
cancelTurnID string
|
|
identity cancellationIdentity
|
|
}
|
|
|
|
func (s *Service) CancelAgent(ctx context.Context, sessionID string) (err error) {
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
return err
|
|
}
|
|
if s.repo == nil {
|
|
return errors.New("cancel agent: repository is not configured")
|
|
}
|
|
var operation *cancelOperation
|
|
var owner bool
|
|
var action *cancellationAction
|
|
operation, owner, action = s.claimExplicitCancellation(sessionID, func(actionCtx context.Context, operation *cancelOperation) (bool, error) {
|
|
return false, s.reconcileJoinedExplicitCancellationLocked(actionCtx, sessionID, operation)
|
|
})
|
|
if !owner {
|
|
if err := operation.wait(ctx); err != nil {
|
|
return err
|
|
}
|
|
if operation.kind == cancellationKindExplicit {
|
|
return nil
|
|
}
|
|
if operation.kind == cancellationKindQueueSendNow {
|
|
return ErrSendNowConflict
|
|
}
|
|
if action == nil {
|
|
return s.reconcileJoinedExplicitCancellation(ctx, sessionID, operation)
|
|
}
|
|
_, err := action.wait(ctx)
|
|
return err
|
|
}
|
|
go s.runExplicitCancellation(ctx, sessionID, operation)
|
|
return operation.wait(ctx)
|
|
}
|
|
|
|
func (s *Service) runExplicitCancellation(requestCtx context.Context, sessionID string, operation *cancelOperation) {
|
|
endProjection := s.beginCancellationProjection(sessionID)
|
|
operation.projectionRelease = endProjection
|
|
defer endProjection()
|
|
operationCtx, cancel := context.WithTimeout(context.WithoutCancel(requestCtx), cancellationOperationTTL)
|
|
defer cancel()
|
|
err := s.runExplicitCancellationOwned(operationCtx, sessionID, operation)
|
|
s.finishCancellationWithActions(operationCtx, sessionID, operation, err)
|
|
}
|
|
|
|
func (s *Service) runExplicitCancellationOwned(ctx context.Context, sessionID string, operation *cancelOperation) (err error) {
|
|
s.logger.Debug("cancelling agent turn", zap.String("session_id", sessionID))
|
|
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
defer release()
|
|
lock.Lock()
|
|
guardLocked := true
|
|
unlockGuard := func() {
|
|
if guardLocked {
|
|
lock.Unlock()
|
|
guardLocked = false
|
|
}
|
|
}
|
|
relockGuard := func() {
|
|
if !guardLocked {
|
|
lock.Lock()
|
|
guardLocked = true
|
|
}
|
|
}
|
|
defer unlockGuard()
|
|
|
|
prepared, err := s.prepareCancelAgent(ctx, sessionID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
s.setCancellationIdentity(sessionID, operation, prepared.identity)
|
|
s.setCancellationCompletionEligible(sessionID, operation, prepared.completionEligible)
|
|
if err := s.cancelAgentWhileUnlocked(ctx, sessionID, unlockGuard, relockGuard); err != nil {
|
|
return err
|
|
}
|
|
if err := s.finishCancelledAgentTurn(ctx, sessionID, prepared); err != nil {
|
|
return err
|
|
}
|
|
|
|
s.logger.Debug("agent turn cancelled", zap.String("session_id", sessionID))
|
|
return nil
|
|
}
|
|
|
|
// reconcileJoinedExplicitCancellation applies the user-facing part of an
|
|
// explicit cancel after joining a silent/internal operation. The joined caller
|
|
// never invokes lifecycle cancellation; it only re-evaluates the current
|
|
// session and performs the explicit source's reconciliation once.
|
|
func (s *Service) reconcileJoinedExplicitCancellation(
|
|
requestCtx context.Context,
|
|
sessionID string,
|
|
operation *cancelOperation,
|
|
) error {
|
|
operationCtx, cancel := context.WithTimeout(context.WithoutCancel(requestCtx), cancellationOperationTTL)
|
|
defer cancel()
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
defer release()
|
|
lock.Lock()
|
|
defer lock.Unlock()
|
|
return s.reconcileJoinedExplicitCancellationLocked(operationCtx, sessionID, operation)
|
|
}
|
|
|
|
// reconcileJoinedExplicitCancellationLocked is the source-specific action for
|
|
// a user cancel that joined a silent/internal cancellation. The caller must
|
|
// already hold the session guard; the cancellation coordinator uses this form
|
|
// so the explicit reconciliation is completed before the shared operation is
|
|
// released to other state-mutating paths.
|
|
func (s *Service) reconcileJoinedExplicitCancellationLocked(
|
|
operationCtx context.Context,
|
|
sessionID string,
|
|
operation *cancelOperation,
|
|
) error {
|
|
if _, _, ready := s.cancellationPreparationSnapshot(operation); !ready {
|
|
return errors.New("joined cancellation preparation is incomplete")
|
|
}
|
|
operation.explicitReconcileOnce.Do(func() {
|
|
identity, completionEligible, ready := s.cancellationPreparationSnapshot(operation)
|
|
if !ready {
|
|
operation.explicitReconcileErr = errors.New("joined cancellation preparation became incomplete")
|
|
return
|
|
}
|
|
session, err := s.repo.GetTaskSession(operationCtx, sessionID)
|
|
if err != nil {
|
|
operation.explicitReconcileErr = fmt.Errorf("load session after joined cancel: %w", err)
|
|
return
|
|
}
|
|
if session == nil || isTerminalSessionState(session.State) {
|
|
return
|
|
}
|
|
prepared := cancelAgentPreparation{
|
|
session: session,
|
|
completionEligible: completionEligible,
|
|
capturedTurnID: identity.turnID,
|
|
cancelTurnID: identity.turnID,
|
|
identity: identity,
|
|
}
|
|
operation.explicitReconcileErr = s.finishCancelledAgentTurn(operationCtx, sessionID, prepared)
|
|
})
|
|
return operation.explicitReconcileErr
|
|
}
|
|
|
|
func (s *Service) prepareCancelAgent(ctx context.Context, sessionID string) (cancelAgentPreparation, error) {
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
s.logger.Warn("failed to get session for cancel",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
}
|
|
completionEligible, err := s.cancelTurnCompletionEligible(ctx, session, sessionID)
|
|
if err != nil {
|
|
return cancelAgentPreparation{}, err
|
|
}
|
|
|
|
identity, err := s.captureCancellationIdentity(ctx, sessionID)
|
|
if err != nil {
|
|
return cancelAgentPreparation{}, err
|
|
}
|
|
capturedTurnID := identity.turnID
|
|
cancelTurnID := capturedTurnID
|
|
if cancelTurnID == "" {
|
|
cancelTurnID = s.getActiveTurnID(sessionID)
|
|
}
|
|
return cancelAgentPreparation{
|
|
session: session,
|
|
completionEligible: completionEligible,
|
|
capturedTurnID: capturedTurnID,
|
|
cancelTurnID: cancelTurnID,
|
|
identity: identity,
|
|
}, nil
|
|
}
|
|
|
|
func (s *Service) captureCancellationIdentity(ctx context.Context, sessionID string) (cancellationIdentity, error) {
|
|
executionID, promptGeneration := s.captureCancellationAgentIdentity(ctx, sessionID)
|
|
identity := cancellationIdentity{executionID: executionID, promptGeneration: promptGeneration}
|
|
if s.turnService != nil {
|
|
turnID, err := s.peekActiveTurnID(ctx, sessionID)
|
|
if err != nil {
|
|
return cancellationIdentity{}, fmt.Errorf("inspect active turn before cancel: %w", err)
|
|
}
|
|
identity.turnID = turnID
|
|
}
|
|
return identity, nil
|
|
}
|
|
|
|
func (s *Service) captureCancellationAgentIdentity(ctx context.Context, sessionID string) (string, uint64) {
|
|
if s.agentManager == nil {
|
|
return "", 0
|
|
}
|
|
executionID, err := s.agentManager.GetExecutionIDForSession(ctx, sessionID)
|
|
if err != nil && !errors.Is(err, lifecycle.ErrNoExecutionForSession) {
|
|
s.logger.Debug("could not capture execution identity before cancellation",
|
|
zap.String("session_id", sessionID), zap.Error(err))
|
|
}
|
|
|
|
generationReader, ok := s.agentManager.(interface {
|
|
GetPromptGenerationForSession(context.Context, string) (uint64, error)
|
|
})
|
|
if !ok {
|
|
return executionID, 0
|
|
}
|
|
generation, generationErr := generationReader.GetPromptGenerationForSession(ctx, sessionID)
|
|
if generationErr != nil && !errors.Is(generationErr, lifecycle.ErrNoExecutionForSession) {
|
|
s.logger.Debug("could not capture prompt generation before cancellation",
|
|
zap.String("session_id", sessionID), zap.Error(generationErr))
|
|
}
|
|
return executionID, generation
|
|
}
|
|
|
|
func (s *Service) cancelTurnCompletionEligible(ctx context.Context, session *models.TaskSession, sessionID string) (bool, error) {
|
|
if session == nil {
|
|
return false, nil
|
|
}
|
|
switch session.State {
|
|
case models.TaskSessionStateRunning, models.TaskSessionStateStarting:
|
|
return true, nil
|
|
case models.TaskSessionStateWaitingForInput:
|
|
activeTurnID, err := s.peekActiveTurnID(ctx, sessionID)
|
|
if err != nil {
|
|
return false, fmt.Errorf("inspect active turn before cancel retry: %w", err)
|
|
}
|
|
return activeTurnID != "", nil
|
|
default:
|
|
return false, nil
|
|
}
|
|
}
|
|
|
|
func (s *Service) cancelAgentWhileUnlocked(ctx context.Context, sessionID string, unlockGuard, relockGuard func()) error {
|
|
if s.agentManager == nil {
|
|
return nil
|
|
}
|
|
// The lifecycle manager waits for the in-flight prompt to consume terminal
|
|
// stream frames delivered through the same per-session guard. Keep the
|
|
// operation marker and guard registry reference active, but release only the
|
|
// mutex around that blocking wait.
|
|
unlockGuard()
|
|
cancelErr := s.agentManager.CancelAgent(ctx, sessionID)
|
|
relockGuard()
|
|
if cancelErr == nil {
|
|
return nil
|
|
}
|
|
switch {
|
|
case errors.Is(cancelErr, lifecycle.ErrNoExecutionForSession):
|
|
// A crashed or unregistered process still needs DB reconciliation so the
|
|
// session does not remain stuck.
|
|
s.logger.Error("agent process appears to have crashed: no live execution for session on cancel",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(cancelErr))
|
|
case errors.Is(cancelErr, lifecycle.ErrCancelEscalated):
|
|
// The lifecycle manager already unblocked the prompt and marked the
|
|
// execution ready; reconcile the session state below.
|
|
s.logger.Warn("agent did not acknowledge cancel; reconciling session state",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(cancelErr))
|
|
default:
|
|
return fmt.Errorf("cancel agent: %w", cancelErr)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) finishCancelledAgentTurn(ctx context.Context, sessionID string, prepared cancelAgentPreparation) error {
|
|
session := prepared.session
|
|
if session != nil {
|
|
reconciled, err := s.reconcileCancelledTurnOwned(
|
|
ctx,
|
|
session.TaskID,
|
|
sessionID,
|
|
session,
|
|
prepared.completionEligible,
|
|
prepared.capturedTurnID,
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("reconcile cancelled turn: %w", err)
|
|
}
|
|
if reconciled != nil {
|
|
session = reconciled
|
|
}
|
|
} else if _, err := s.reconcileCancelledTurnOwned(ctx, "", sessionID, nil, false, prepared.capturedTurnID); err != nil {
|
|
return fmt.Errorf("reconcile cancelled turn: %w", err)
|
|
}
|
|
|
|
s.recordCancelledAgentMessage(ctx, session, sessionID, prepared.cancelTurnID)
|
|
s.reconcileCancelledAgentWorkflow(ctx, session, prepared.completionEligible)
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) recordCancelledAgentMessage(ctx context.Context, session *models.TaskSession, sessionID, cancelTurnID string) {
|
|
if s.messageCreator == nil || session == nil {
|
|
return
|
|
}
|
|
metadata := map[string]interface{}{
|
|
"cancelled": true,
|
|
"variant": "warning",
|
|
}
|
|
if err := s.messageCreator.CreateSessionMessage(
|
|
ctx,
|
|
session.TaskID,
|
|
"Turn cancelled by user",
|
|
sessionID,
|
|
string(v1.MessageTypeStatus),
|
|
cancelTurnID,
|
|
metadata,
|
|
false,
|
|
); err != nil {
|
|
s.logger.Warn("failed to create cancel message",
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
|
|
func (s *Service) reconcileCancelledAgentWorkflow(ctx context.Context, session *models.TaskSession, completionEligible bool) {
|
|
if session == nil {
|
|
return
|
|
}
|
|
if completionEligible {
|
|
s.processOnTurnCompleteViaEngineWithCause(ctx, session.TaskID, session, turnCompletionCauseUserCancellation)
|
|
}
|
|
s.reconcileCancelledTaskReview(ctx, session.TaskID, session.ID)
|
|
}
|
|
|
|
func (s *Service) reconcileCancelledTaskReview(ctx context.Context, taskID, sessionID string) {
|
|
task, err := s.repo.GetTask(ctx, taskID)
|
|
if err == nil && task != nil && task.WorkflowStepID != "" && s.workflowStepGetter != nil {
|
|
step, stepErr := s.workflowStepGetter.GetStep(ctx, task.WorkflowStepID)
|
|
if stepErr == nil && step != nil && s.workflowStepIsTerminal(ctx, step.ID) {
|
|
return
|
|
}
|
|
}
|
|
s.writeTaskReviewState(ctx, taskID, sessionID)
|
|
}
|
|
|
|
// takeAndDispatchEntryLocked takes entryID from sessionID's queue and
|
|
// dispatches it, falling back to draining the FIFO head only if the
|
|
// targeted take doesn't find it (a benign not-found, e.g. already taken by
|
|
// a concurrent path). A genuine repository error on the targeted take is
|
|
// propagated instead of falling back — see cancelAndTakeForPeerMessage's
|
|
// doc comment for why. The caller must already hold sessionID's
|
|
// cancelInFlight lock; this neither acquires nor releases it.
|
|
//
|
|
// Deliberately does NOT check isQueuedDispatchInFlight itself: callers
|
|
// that reach here have either just performed a cancel
|
|
// (cancelAndTakeForPeerMessage) — which supersedes whatever another
|
|
// dispatch was in the middle of settling, so a stale in-flight marker from
|
|
// that dispatch must not block taking a *different* entry here — or have
|
|
// already confirmed the session is genuinely idle (takeIfPromptableLocked,
|
|
// which checks the marker itself before delegating here). See
|
|
// drainQueuedMessageForPromptableSessionLocked for the *non-cancelling*
|
|
// FIFO-head drain path, which does check the marker directly.
|
|
func (s *Service) takeAndDispatchEntryLocked(ctx context.Context, sessionID, entryID string) (bool, error) {
|
|
if s.messageQueue != nil {
|
|
queuedMsg, ok, err := s.messageQueue.TakeQueuedEntry(ctx, sessionID, entryID)
|
|
if err != nil {
|
|
return false, fmt.Errorf("take targeted queued message: %w", err)
|
|
}
|
|
if s.dispatchTakenQueuedMessage(ctx, sessionID, queuedMsg, ok) {
|
|
return true, nil
|
|
}
|
|
}
|
|
return s.drainQueuedMessageForPromptableSessionLocked(ctx, sessionID), nil
|
|
}
|
|
|
|
// takeIfPromptableLocked takes and dispatches entryID only if sessionID is
|
|
// currently promptable, without ever issuing a cancel — used by
|
|
// QueueAndInterruptForPeerMessage when cancelling would risk hitting a
|
|
// *different*, unrelated turn instead of the one the caller meant to
|
|
// interrupt (see its active-turn revalidation doc comment). Returns
|
|
// (false, nil), never an error, when the session turns out not to be
|
|
// promptable — or when a *different* dispatch is already settling for
|
|
// this session (isQueuedDispatchInFlight; see the Service.dispatchingQueued
|
|
// field doc comment) — mirroring cancelAndTakeForPeerMessage's own "cancel
|
|
// failed but already promptable" recovery except without ever attempting
|
|
// the cancel. Unlike cancelAndTakeForPeerMessage's path, this never
|
|
// cancels anything, so it has no way to supersede a settling dispatch the
|
|
// way a genuine cancel would — it must defer to it instead. The caller
|
|
// must already hold sessionID's cancelInFlight lock.
|
|
//
|
|
// Also defers to an admitted-but-not-yet-dispatched steer (isSteerInFlight;
|
|
// see steerInFlight's field doc comment) for the same reason: this path
|
|
// never cancels, so it has no way to supersede the steer's dispatch either.
|
|
func (s *Service) takeIfPromptableLocked(ctx context.Context, taskID, sessionID, entryID string) (bool, error) {
|
|
if s.isQueuedDispatchInFlight(sessionID) || s.isSteerInFlight(sessionID) {
|
|
return false, nil
|
|
}
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil || session == nil || s.checkSessionPromptable(taskID, sessionID, session.State) != nil {
|
|
return false, nil
|
|
}
|
|
return s.takeAndDispatchEntryLocked(ctx, sessionID, entryID)
|
|
}
|
|
|
|
// cancelAndTakeForPeerMessage cancels sessionID's in-flight turn and takes
|
|
// and dispatches entryID — the specific message that triggered this
|
|
// interrupt — falling back to draining the FIFO head only if the targeted
|
|
// take doesn't find it (a benign not-found, e.g. already taken by a
|
|
// concurrent path). entryID must be non-empty: the only caller,
|
|
// QueueAndInterruptForPeerMessage, always passes the entry it just
|
|
// inserted. A genuine repository error on the targeted take is propagated
|
|
// instead of falling back: an error says nothing about which entry is
|
|
// actually at the FIFO head, and dispatching it anyway would risk
|
|
// delivering the wrong message while the caller still reports "sent" for
|
|
// the parent's.
|
|
//
|
|
// The caller must already hold sessionID's cancelInFlight lock; this
|
|
// neither acquires nor releases it — see QueueAndInterruptForPeerMessage.
|
|
//
|
|
// The returned bool reports whether this call actually dispatched a
|
|
// message; a false result means the caller's message is still only
|
|
// queued, to be delivered later by whichever drain gets to it.
|
|
//
|
|
// Deliberately mirrors cancelAgentSilent + dispatchTakenQueuedMessage rather
|
|
// than delegating to CancelAgent: the interrupt is an internal steering
|
|
// signal from the parent, not a user action, so unlike the cancel button it
|
|
// must not write a visible "Turn cancelled" message and must not move the
|
|
// task to REVIEW (writeTaskReviewStateOnCancel).
|
|
func (s *Service) cancelAndTakeForPeerMessage(
|
|
ctx context.Context,
|
|
taskID string,
|
|
sessionID string,
|
|
entryID string,
|
|
unlockGuard func(),
|
|
relockGuard func(),
|
|
) (bool, error) {
|
|
return s.cancelAgentSilentWithGuardActionKind(
|
|
ctx,
|
|
taskID,
|
|
sessionID,
|
|
unlockGuard,
|
|
relockGuard,
|
|
func(actionCtx context.Context) (bool, error) {
|
|
return s.takeAndDispatchEntryLocked(actionCtx, sessionID, entryID)
|
|
},
|
|
cancellationKindPeer,
|
|
)
|
|
}
|
|
|
|
// QueueAndInterruptForPeerMessage atomically queues prompt for sessionID
|
|
// and then interrupts the child's in-flight turn to deliver it immediately,
|
|
// instead of waiting for the turn to end naturally. It is used only by
|
|
// handleMessageTask (mcp/handlers) when the sender is the target task's
|
|
// parent: a long-running child otherwise leaves its parent's control/steer
|
|
// messages parked on the FIFO queue until the child's current turn finishes
|
|
// on its own, and with several such children running in parallel the
|
|
// per-session queue can fill up to messagequeue.DefaultMaxPerSession before
|
|
// any of them are delivered.
|
|
//
|
|
// This must be one atomic operation rather than "queue, then separately
|
|
// interrupt" (the original two-step split across the handlers/orchestrator
|
|
// boundary): between an insert becoming visible and a later, separate
|
|
// interrupt call acquiring the session's cancelInFlight lock, the child's
|
|
// turn can complete naturally and handleAgentReady's normal FIFO drain can
|
|
// grab the just-queued entry and start dispatching it as an ordinary turn —
|
|
// only for the later interrupt's cancel to land on and kill that very turn,
|
|
// orphaning the parent's message mid-delivery. Taking the lock before the
|
|
// queue insert closes that: handleAgentReady and handleAgentBootReady's
|
|
// take decisions claim the exact same lock before their own take, so neither
|
|
// can ever observe — and steal — an
|
|
// entry this call is still in the process of queueing-and-claiming.
|
|
//
|
|
// The lock is a genuine, blocking claim (Lock, mirroring
|
|
// executor.Executor.getSessionLock's precedent for per-session mutual
|
|
// exclusion in this codebase) — not a try-once peek with a fallback
|
|
// unguarded insert. Working around a busy lock with an unguarded insert
|
|
// would leave that insert visible to nobody in particular: the current
|
|
// holder may have already finished its own take-or-skip decision before
|
|
// the insert lands, and nothing then guarantees a future drain (the
|
|
// session can go idle with no further agent.ready to retry on). Every
|
|
// existing holder already bounds its own hold time through an independent
|
|
// mechanism (cancelAgentSilent's underlying agent-cancel escalation
|
|
// timeout, or a single fast DB round-trip in the natural-drain paths), so
|
|
// blocking here adds no new deadlock risk.
|
|
//
|
|
// Active-turn revalidation: after acquiring the lock and queueing the
|
|
// message, this re-checks whether the turn active for sessionID is still
|
|
// the one that was active when the caller decided to interrupt (snapshotted
|
|
// via peekActiveTurnID *before* contending for the lock). If a *different*
|
|
// turn is now active — e.g. a workflow on_turn_complete transition
|
|
// auto-started a successor for this same session while this call waited
|
|
// for the guard — cancelling now would kill that unrelated successor turn
|
|
// instead of the one the parent meant to interrupt. In that case this
|
|
// falls back to takeIfPromptableLocked (dispatch directly only if the
|
|
// session happens to already be idle *and* no other dispatch is
|
|
// concurrently settling for it, per isQueuedDispatchInFlight — see the
|
|
// Service.dispatchingQueued field doc comment; otherwise leave the
|
|
// message queued for whichever turn is actually running to drain
|
|
// naturally) instead of ever calling cancelAndTakeForPeerMessage. The
|
|
// turn-identity comparison only trusts a positively-confirmed match — both
|
|
// snapshots read without error, both non-empty, and equal — before it
|
|
// will risk a cancel; any error or mismatch (including "no turn observed
|
|
// at all") takes the safe fallback. The one exception is turnService
|
|
// being unset entirely: with no turn identity obtainable at all, this
|
|
// preserves the exact unconditional-interrupt behavior every existing
|
|
// (turn-unaware) caller and test exercises.
|
|
//
|
|
// Note this deliberately does *not* also gate on isQueuedDispatchInFlight
|
|
// when the turn *is* confirmed unchanged: a cancel (via
|
|
// cancelAndTakeForPeerMessage below) supersedes whatever another dispatch
|
|
// for this same session was in the middle of settling — e.g. a second
|
|
// parent message arriving right behind a first one whose own dispatch
|
|
// hasn't yet reached PromptTask — so it must still be allowed to cancel
|
|
// and take its own entry rather than being blocked by a marker the cancel
|
|
// itself is about to invalidate.
|
|
func (s *Service) QueueAndInterruptForPeerMessage(ctx context.Context, taskID, sessionID, prompt string, metadata map[string]interface{}) (*messagequeue.QueuedMessage, bool, error) {
|
|
if s.messageQueue == nil {
|
|
return nil, false, errors.New("message queue not available")
|
|
}
|
|
|
|
turnBeforeWait, turnPeekErr := s.peekActiveTurnID(ctx, sessionID)
|
|
if turnPeekErr != nil {
|
|
s.logger.Warn("failed to snapshot active turn before peer-message interrupt; will fall back to a promptable-only dispatch instead of risking a cancel of unrelated work",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.Error(turnPeekErr))
|
|
}
|
|
|
|
lock, release := s.acquireCancelInFlightGuard(sessionID)
|
|
lock.Lock()
|
|
guardLocked := true
|
|
unlockGuard := func() {
|
|
if guardLocked {
|
|
lock.Unlock()
|
|
guardLocked = false
|
|
}
|
|
}
|
|
relockGuard := func() {
|
|
if !guardLocked {
|
|
lock.Lock()
|
|
guardLocked = true
|
|
}
|
|
}
|
|
defer func() {
|
|
unlockGuard()
|
|
release()
|
|
}()
|
|
|
|
queued, err := s.messageQueue.QueueMessageWithMetadata(ctx, sessionID, taskID, prompt, "", messagequeue.QueuedByAgent, false, nil, metadata)
|
|
if err != nil {
|
|
return nil, false, err
|
|
}
|
|
s.publishQueueStatusEvent(ctx, sessionID)
|
|
if operation := s.currentCancellation(sessionID); operation != nil && operation.kind != cancellationKindPeer {
|
|
s.logger.Debug("leaving peer message queued while a different cancellation source is in progress",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("queue_id", queued.ID))
|
|
unlockGuard()
|
|
if waitErr := s.waitForCancelInFlight(ctx, sessionID); waitErr != nil {
|
|
return queued, false, waitErr
|
|
}
|
|
return queued, false, nil
|
|
}
|
|
|
|
if s.turnService != nil {
|
|
turnNow, turnNowErr := s.peekActiveTurnID(ctx, sessionID)
|
|
confirmedUnchanged := turnPeekErr == nil && turnNowErr == nil && turnBeforeWait != "" && turnNow == turnBeforeWait
|
|
if !confirmedUnchanged {
|
|
s.logger.Warn("active turn could not be confirmed unchanged while waiting to interrupt; dispatching only if already idle instead of risking a cancel of unrelated work",
|
|
zap.String("task_id", taskID),
|
|
zap.String("session_id", sessionID),
|
|
zap.String("turn_before_wait", turnBeforeWait),
|
|
zap.Bool("turn_peek_error", turnPeekErr != nil || turnNowErr != nil))
|
|
dispatched, fallbackErr := s.takeIfPromptableLocked(ctx, taskID, sessionID, queued.ID)
|
|
return queued, dispatched, fallbackErr
|
|
}
|
|
}
|
|
|
|
dispatched, err := s.cancelAndTakeForPeerMessage(ctx, taskID, sessionID, queued.ID, unlockGuard, relockGuard)
|
|
return queued, dispatched, err
|
|
}
|
|
|
|
// CompleteTask explicitly completes a task and stops all its agents
|
|
func (s *Service) CompleteTask(ctx context.Context, taskID string) error {
|
|
s.logger.Info("completing task",
|
|
zap.String("task_id", taskID))
|
|
|
|
// Stop all agents for this task (which will trigger AgentCompleted events and update session states)
|
|
if err := s.executor.StopByTaskID(ctx, taskID, "task completed by user", false); err != nil {
|
|
// If agents are already stopped, just update the task state directly
|
|
s.logger.Warn("failed to stop agents, updating task state directly",
|
|
zap.String("task_id", taskID),
|
|
zap.Error(err))
|
|
}
|
|
|
|
// Update task state to COMPLETED
|
|
if err := s.taskRepo.UpdateTaskState(ctx, taskID, v1.TaskStateCompleted); err != nil {
|
|
return fmt.Errorf("failed to update task state: %w", err)
|
|
}
|
|
s.processParentChildrenCompletedForTaskState(ctx, taskID, v1.TaskStateCompleted)
|
|
|
|
s.logger.Info("task marked as COMPLETED",
|
|
zap.String("task_id", taskID))
|
|
return nil
|
|
}
|
|
|
|
// ResetAgentContext resets the agent's conversation context for a session,
|
|
// clearing conversation history while preserving the workspace environment.
|
|
func (s *Service) ResetAgentContext(ctx context.Context, sessionID string) error {
|
|
if err := s.authorizeSession(ctx, sessionID); err != nil {
|
|
return err
|
|
}
|
|
|
|
session, err := s.repo.GetTaskSession(ctx, sessionID)
|
|
if err != nil {
|
|
return fmt.Errorf("session not found: %w", err)
|
|
}
|
|
if session.State != models.TaskSessionStateWaitingForInput {
|
|
return fmt.Errorf("agent must be idle to reset context, current state: %s", session.State)
|
|
}
|
|
if hasRunning, hasErr := s.repo.HasExecutorRunningRow(ctx, sessionID); hasErr != nil || !hasRunning {
|
|
return fmt.Errorf("no active agent execution for session %s", sessionID)
|
|
}
|
|
|
|
// Set STARTING so frontend disables input and shows restarting state
|
|
s.updateTaskSessionState(ctx, session.TaskID, sessionID, models.TaskSessionStateStarting, "", false, session)
|
|
|
|
if ok := s.resetAgentContext(ctx, session.TaskID, session, "user_request"); !ok {
|
|
// Restore WAITING_FOR_INPUT on failure
|
|
s.setSessionWaitingForInput(ctx, session.TaskID, sessionID)
|
|
return fmt.Errorf("failed to reset agent context for session %s", sessionID)
|
|
}
|
|
|
|
// Restore WAITING_FOR_INPUT — handleAgentReady ignores events during reset
|
|
s.setSessionWaitingForInput(ctx, session.TaskID, sessionID)
|
|
|
|
if s.messageCreator != nil {
|
|
if err := s.messageCreator.CreateSessionMessage(
|
|
ctx, session.TaskID,
|
|
"Context reset — new conversation started",
|
|
sessionID, string(v1.MessageTypeStatus),
|
|
s.getActiveTurnID(sessionID),
|
|
nil, false,
|
|
); err != nil {
|
|
s.logger.Warn("failed to create context reset message",
|
|
zap.String("session_id", sessionID), zap.Error(err))
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetQueuedTasks returns tasks in the queue
|
|
func (s *Service) GetQueuedTasks() []*queue.QueuedTask {
|
|
return s.queue.List()
|
|
}
|