Files

T

João Salavisa 0df2bbac0a feat(plugins): typed capability-gated Host data API (ADR 0043) (#1753 )

* docs(plugins): draft Host data API proto (read + write DTOs)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): ADR + spec + plan for the Host data API

Plugins access kandev data via capability-gated Host gRPC RPCs returning
hand-mapped DTOs, never the DB directly. ADR 0042.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): add Host data API RPCs and DTOs to plugin proto

Extends the existing service Host (per ADR 0042) with read RPCs
(ListTasks/GetTask, ListWorkspaces, ListWorkflows, ListWorkflowSteps,
ListAgentProfiles, ListRepositories, ListSessions, ListSessionCodeStats)
and declares the deferred phase-2 write RPCs (CreateTask, UpdateTask,
CreateComment) so the contract is stable for later tasks. Regenerates
plugin.pb.go/plugin_grpc.pb.go via `make -C apps/backend proto`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* feat(plugins): Host data API SDK accessors + session LOC aggregation

Wave 1-2 of ADR 0042: pkg/pluginsdk gains typed reader accessors (host.Tasks(),
host.Sessions().CodeStats(), host.Workflows(), ...) over the extended Host gRPC
service, with proto<->native DTO conversions and an UnimplementedHostData seam
for the kandev-side impl. internal/analytics gains the per-session LOC
aggregation those readers surface. Backend handlers + capability gating land in
the next wave.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): capability-gated Host data read handlers (ADR 0042)

Implement pluginHost Tasks/Sessions/Workspaces/Workflows/AgentProfiles/
Repositories readers: each gated on api_read:<resource> (PermissionDenied
otherwise), backed by the service layer via narrow injected interfaces, and
hand-mapped to the pluginsdk DTOs. Sessions().CodeStats routes through the
analytics aggregation; acp_session_id preserves the metadata->resume_token
fallback. Wired through plugins.Service.SetDataSources + backendapp.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(plugins): wire test for Host data reads + docs (ADR 0042 accepted)

End-to-end test over the real go-plugin transport: session data round-trips,
per-resource api_read gating returns PermissionDenied over the wire, cursor
pagination. Document the Host data API + SDK accessors in GRPC-CONTRACT.md,
reconcile the spec to shipped code, mark ADR 0042 accepted.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): full session history + snapshot profile name in data API

Sessions().List now fetches tasks with includeArchived=true — an archived
task's sessions are still real sessions, and CodeStats already made the
same call at the SQL layer, so the two session reads were inconsistent
(26 of 359 sessions visible on a real instance). Tasks().List keeps
archived tasks excluded.

Session gains agent_profile_name (proto field 10) sourced from the
profile snapshot, so sessions of since-uninstalled agents keep a human
label — the AgentProfiles registry only lists live agents.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): renumber Host data API ADR 0042 -> 0043

main merged its own ADR 0042 (project shell output); renumber this one to the
next free slot and update all references.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address Host data API review (perf, pagination, filters, proto)

- paginate before DTO conversion so per-session ACP lookups run <=limit times
- fetch all source pages (no silent 1000/workspace truncation); accurate HasMore
- stable id tiebreaker on paginated sorts
- AND SessionFilter.TaskIDs with WorkspaceIDs; exclude config-mode sessions from
  CodeStats (shared dialect.ExcludeConfigModePredicate) so List/CodeStats match
- Get returns codes.NotFound consistently in-process and over the wire
- wrap bare-DTO RPC responses (GetTaskResponse etc.) for Buf response uniqueness

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): mark Host data API plan tasks done

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2026-07-17 13:43:58 +01:00

2.3 KiB

Raw Blame History

id, title, status, wave, depends_on, plan, spec, adr

title

status

wave

depends_on

plan

spec

adr

06-tests

Capability-gating, DTO-mapping, and plugin-reads-sessions integration tests

done

04-host-data-impl

plan.md

../../../specs/plugins/spec.md

../../../decisions/0043-plugin-host-data-api.md

Task 06: Host data API tests

Cover the spec scenarios for the Host data API at the host boundary. (Aggregation SQL and SDK round-trip conversions are unit-tested in tasks 02/03; this task owns the host RPC behavior and the end-to-end plugin path.)

Scope

Capability gating (internal/plugins/host_test.go): for each read RPC, assert PermissionDenied with capability 'api_read:<resource>' not declared when the manifest omits the resource, and success when it declares it. Assert write RPCs return Unimplemented.
DTO mapping: table-driven internal-model → DTO assertions per resource, covering optional/NULL fields and RFC3339 timestamp formatting; assert the Session DTO carries acp_session_id.
Pagination: ListTasks (or another list RPC) returns has_more + a next_cursor that yields the next page and terminates.
Ephemeral exclusion: ListTasks without include_ephemeral omits ephemeral tasks.
Integration: drive a Host client (SDK grpcHostClient over the broker, or the existing plugins test harness) to call ListSessions + ListSessionCodeStats against a seeded DB and assert rows come back without any file-level DB access — the concrete "plugin reads sessions via the API" scenario.

Acceptance

Tests exist for each spec scenario listed above and pass.
No test opens the SQLite file to stand in for the plugin path — the plugin-facing assertion goes through the Host RPC surface.

Verification

cd apps/backend && go test ./internal/plugins/...

Files likely touched

apps/backend/internal/plugins/host_test.go
possibly apps/backend/internal/plugins/host_data_test.go

Inputs

Host impl from task-04; existing test harness in internal/plugins/host_test.go / service_test.go.
Spec: "Host data API" scenarios.
Backend testing conventions in apps/backend/CLAUDE.md (synctest, goleak).

Dependencies

Task 04.

Output contract

Summary, list of scenarios covered, test result, coverage gaps if any, and status update here + in plan.md.

2.3 KiB Raw Blame History