Files

T

João Salavisa 0df2bbac0a feat(plugins): typed capability-gated Host data API (ADR 0043) (#1753 )

* docs(plugins): draft Host data API proto (read + write DTOs)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): ADR + spec + plan for the Host data API

Plugins access kandev data via capability-gated Host gRPC RPCs returning
hand-mapped DTOs, never the DB directly. ADR 0042.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): add Host data API RPCs and DTOs to plugin proto

Extends the existing service Host (per ADR 0042) with read RPCs
(ListTasks/GetTask, ListWorkspaces, ListWorkflows, ListWorkflowSteps,
ListAgentProfiles, ListRepositories, ListSessions, ListSessionCodeStats)
and declares the deferred phase-2 write RPCs (CreateTask, UpdateTask,
CreateComment) so the contract is stable for later tasks. Regenerates
plugin.pb.go/plugin_grpc.pb.go via `make -C apps/backend proto`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* feat(plugins): Host data API SDK accessors + session LOC aggregation

Wave 1-2 of ADR 0042: pkg/pluginsdk gains typed reader accessors (host.Tasks(),
host.Sessions().CodeStats(), host.Workflows(), ...) over the extended Host gRPC
service, with proto<->native DTO conversions and an UnimplementedHostData seam
for the kandev-side impl. internal/analytics gains the per-session LOC
aggregation those readers surface. Backend handlers + capability gating land in
the next wave.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): capability-gated Host data read handlers (ADR 0042)

Implement pluginHost Tasks/Sessions/Workspaces/Workflows/AgentProfiles/
Repositories readers: each gated on api_read:<resource> (PermissionDenied
otherwise), backed by the service layer via narrow injected interfaces, and
hand-mapped to the pluginsdk DTOs. Sessions().CodeStats routes through the
analytics aggregation; acp_session_id preserves the metadata->resume_token
fallback. Wired through plugins.Service.SetDataSources + backendapp.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(plugins): wire test for Host data reads + docs (ADR 0042 accepted)

End-to-end test over the real go-plugin transport: session data round-trips,
per-resource api_read gating returns PermissionDenied over the wire, cursor
pagination. Document the Host data API + SDK accessors in GRPC-CONTRACT.md,
reconcile the spec to shipped code, mark ADR 0042 accepted.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): full session history + snapshot profile name in data API

Sessions().List now fetches tasks with includeArchived=true — an archived
task's sessions are still real sessions, and CodeStats already made the
same call at the SQL layer, so the two session reads were inconsistent
(26 of 359 sessions visible on a real instance). Tasks().List keeps
archived tasks excluded.

Session gains agent_profile_name (proto field 10) sourced from the
profile snapshot, so sessions of since-uninstalled agents keep a human
label — the AgentProfiles registry only lists live agents.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): renumber Host data API ADR 0042 -> 0043

main merged its own ADR 0042 (project shell output); renumber this one to the
next free slot and update all references.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address Host data API review (perf, pagination, filters, proto)

- paginate before DTO conversion so per-session ACP lookups run <=limit times
- fetch all source pages (no silent 1000/workspace truncation); accurate HasMore
- stable id tiebreaker on paginated sorts
- AND SessionFilter.TaskIDs with WorkspaceIDs; exclude config-mode sessions from
  CodeStats (shared dialect.ExcludeConfigModePredicate) so List/CodeStats match
- Get returns codes.NotFound consistently in-process and over the wire
- wrap bare-DTO RPC responses (GetTaskResponse etc.) for Buf response uniqueness

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): mark Host data API plan tasks done

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2026-07-17 13:43:58 +01:00

2.4 KiB

Raw Blame History

id, title, status, wave, depends_on, plan, spec, adr

title

status

wave

depends_on

plan

spec

adr

05-rewrite-agent-stats-plugin

Rewrite kandev-plugin-agent-stats to use the SDK data API

done

03-sdk-data-accessors

04-host-data-impl

plan.md

../../../specs/plugins/spec.md

../../../decisions/0043-plugin-host-data-api.md

Task 05: Rewrite kandev-plugin-agent-stats to use the SDK data API

The proof the carrot is sufficient: replace the agent-stats plugin's direct SQLite access with the Host data API. This is a separate repository at /home/jcfs/.kandev/tasks/tokens-per-task-loc_9tk/kandev-plugin-agent-stats/ — do not vendor it into the kandev repo; reference it.

Scope

Delete readSessions + sessionsQuery and the modernc.org/sqlite dependency from server/stats.go. Stop opening ~/.kandev/data/kandev.db.
Fetch sessions via host.Sessions().List(...) and per-session LOC via host.Sessions().CodeStats(...). Map the returned Session + SessionCodeStats into the existing sessionRow shape (agent display, model, acp_session_id, committed + peak-pending lines).
Keep effectiveLines semantics (max of committed and peak-pending) on the DTO fields; keep the tokscale join on acp_session_id unchanged (external tool, unaffected).
Declare capabilities.api_read: ["sessions"] in the plugin manifest.yaml.
Remove the KANDEV_AGENT_STATS_DB config path (no DB path needed); keep the tokscale override.

Acceptance

The plugin no longer imports a SQLite driver or opens any kandev DB file.
Stats report still renders sessions + LOC + tokscale ratios using data obtained solely through the Host data API.
manifest.yaml declares api_read: ["sessions"].

Verification

In the plugin repo: go build ./... and its existing go test ./....

Files likely touched (separate repo)

.../kandev-plugin-agent-stats/server/stats.go
.../kandev-plugin-agent-stats/server/plugin.go
.../kandev-plugin-agent-stats/manifest.yaml
.../kandev-plugin-agent-stats/go.mod (drop sqlite dep)

Inputs

SDK data accessors from task-03; live host impl from task-04.
Current plugin: server/stats.go (sessionRow, aggregate, effectiveLines), server/plugin.go (loadConfig, collect).

Dependencies

Tasks 03, 04.

Output contract

Summary, confirmation the SQLite import is gone, mapping notes (DTO → sessionRow), build/test result, and status update here + in plan.md.

2.4 KiB Raw Blame History