Files
kandev/apps/web/components/task/chat/use-chat-input-container.ts
T
José Almeida 9389ac9c79 fix(web): keep editor disabled during STARTING so quick-chat sends don't race
My previous fix made submit no longer block on isStarting, with the
goal of keeping local quick-chat sessions from silently dropping
messages. The trace from CI showed it traded one failure for another:
the editor became contenteditable while the session was still
STARTING, the e2e suite pressed Cmd+Enter immediately, and the
backend rejected with "Failed to send message to agent" because the
agent process wasn't ready yet.

Restore the original semantics — STARTING blocks both editor and
submit — but keep `isPreparingEnvironment` as the narrower trigger for
the "agent still being set up" tooltip. Net behaviour:
  - STARTING transition: editor disabled, no tooltip (signal is the
    disabled state itself)
  - container/sandbox prepare: editor disabled + tooltip explaining why
  - quick-chat sessions: editor stays disabled until RUNNING, no race
2026-05-10 15:19:50 +01:00

247 lines
8.0 KiB
TypeScript

"use client";
import { useCallback, useRef, useState, useEffect, useImperativeHandle } from "react";
import type React from "react";
import { useResizableInput } from "@/hooks/use-resizable-input";
import { useChatInputState } from "./use-chat-input-state";
import type { TipTapInputHandle } from "./tiptap-input";
import type { ContextItem } from "@/lib/types/context";
import type { ContextFile } from "@/lib/state/context-files-store";
import type { Message } from "@/lib/types/http";
import type { DiffComment } from "@/lib/diff/types";
import type { MessageAttachment, ChatInputContainerHandle } from "./chat-input-container";
type UseChatInputContainerParams = {
ref: React.ForwardedRef<ChatInputContainerHandle>;
sessionId: string | null;
isSending: boolean;
isStarting: boolean;
/** True only during a real Docker/Sprites prepare phase. Different from
* `isStarting`, which fires for every session that's transitioning
* through STARTING (including local quick-chat). Submit gating uses
* this narrower flag so quick-chat sessions aren't blocked. */
isPreparingEnvironment: boolean;
isMoving: boolean;
isFailed: boolean;
needsRecovery: boolean;
executorUnavailable: boolean;
isAgentBusy: boolean;
hasAgentCommands: boolean;
placeholder: string | undefined;
contextItems: ContextItem[];
pendingClarification: Message | null | undefined;
onClarificationResolved: (() => void) | undefined;
pendingCommentsByFile: Record<string, DiffComment[]> | undefined;
hasContextComments: boolean;
showRequestChangesTooltip: boolean;
onRequestChangesTooltipDismiss: (() => void) | undefined;
onSubmit: (
message: string,
reviewComments?: DiffComment[],
attachments?: MessageAttachment[],
inlineMentions?: ContextFile[],
) => void;
};
function useInputHandle(
ref: React.ForwardedRef<ChatInputContainerHandle>,
inputRef: React.RefObject<TipTapInputHandle | null>,
) {
useImperativeHandle(
ref,
() => ({
focusInput: () => inputRef.current?.focus(),
getTextareaElement: () => inputRef.current?.getTextareaElement() ?? null,
getValue: () => inputRef.current?.getValue() ?? "",
getSelectionStart: () => inputRef.current?.getSelectionStart() ?? 0,
insertText: (text: string, from: number, to: number) => {
inputRef.current?.insertText(text, from, to);
},
clear: () => inputRef.current?.clear(),
}),
[inputRef],
);
}
function useSyncTipTapRef(
tiptapRef: React.RefObject<TipTapInputHandle | null>,
inputRef: React.RefObject<TipTapInputHandle | null>,
) {
useEffect(() => {
tiptapRef.current = inputRef.current;
});
}
function getInputPlaceholder(
placeholder: string | undefined,
isAgentBusy: boolean,
hasAgentCommands: boolean,
isStarting: boolean,
): string {
if (isStarting) return "Preparing workspace...";
if (placeholder) return placeholder;
if (isAgentBusy) return "Queue more instructions...";
if (hasAgentCommands) return "Ask to make changes, @mention files, run /commands";
return "Ask to make changes, @mention files";
}
function computeDerivedState(params: {
isStarting: boolean;
isPreparingEnvironment: boolean;
isMoving: boolean;
isSending: boolean;
isFailed: boolean;
needsRecovery: boolean;
executorUnavailable: boolean;
pendingClarification: Message | null | undefined;
onClarificationResolved: (() => void) | undefined;
pendingCommentsByFile: Record<string, DiffComment[]> | undefined;
allItemsLength: number;
isInputFocused: boolean;
placeholder: string | undefined;
isAgentBusy: boolean;
hasAgentCommands: boolean;
}) {
// STARTING is included so the editor itself stays uneditable until the
// session reaches RUNNING. Without this, the e2e suite's wait-for-
// contenteditable would fire mid-STARTING, the test would press Cmd+Enter,
// and the backend would reject with "Failed to send message to agent"
// before the agent process is ready to receive prompts.
const isDisabled =
params.isStarting ||
params.isMoving ||
params.isSending ||
params.isFailed ||
params.needsRecovery ||
params.executorUnavailable;
const submitDisabled = isDisabled;
// The "agent still being set up" tooltip is only meaningful while a
// container/sandbox is actively bootstrapping. The brief STARTING
// transition for local quick-chat sessions doesn't deserve its own
// tooltip — the editor is disabled, that's the signal.
const submitDisabledReason = params.isPreparingEnvironment
? "The agent is still being set up."
: undefined;
const hasClarification = !!(params.pendingClarification && params.onClarificationResolved);
const hasPendingComments = !!(
params.pendingCommentsByFile && Object.keys(params.pendingCommentsByFile).length > 0
);
const hasContextZone = params.allItemsLength > 0;
const showFocusHint = !params.isInputFocused && !hasClarification && !hasPendingComments;
const inputPlaceholder = getInputPlaceholder(
params.placeholder,
params.isAgentBusy,
params.hasAgentCommands,
params.isStarting,
);
return {
isDisabled,
submitDisabled,
submitDisabledReason,
hasClarification,
hasPendingComments,
hasContextZone,
showFocusHint,
inputPlaceholder,
};
}
export function useChatInputContainer(params: UseChatInputContainerParams) {
const { ref, sessionId, isSending, isStarting, isPreparingEnvironment, isMoving } = params;
const { isFailed, needsRecovery, executorUnavailable, isAgentBusy, hasAgentCommands } = params;
const { placeholder, contextItems, pendingClarification, onClarificationResolved } = params;
const { pendingCommentsByFile, showRequestChangesTooltip } = params;
const { onRequestChangesTooltipDismiss, onSubmit } = params;
const [isInputFocused, setIsInputFocused] = useState(false);
const [showNewSessionDialog, setShowNewSessionDialog] = useState(false);
const [contextPopoverOpen, setContextPopoverOpen] = useState(false);
const tiptapRef = useRef<TipTapInputHandle | null>(null);
const getContentElement = useCallback(() => tiptapRef.current?.getTextareaElement() ?? null, []);
const { height, resetHeight, autoExpand, containerRef, resizeHandleProps } = useResizableInput(
sessionId ?? undefined,
getContentElement,
);
const fileInputRef = useRef<HTMLInputElement>(null);
const { value, inputRef, addFiles, handleChange, handleSubmit, allItems } = useChatInputState({
sessionId,
isSending,
contextItems,
pendingCommentsByFile,
hasContextComments: params.hasContextComments,
showRequestChangesTooltip,
onRequestChangesTooltipDismiss,
onSubmit,
});
useSyncTipTapRef(tiptapRef, inputRef);
useInputHandle(ref, inputRef);
// Auto-expand the input container as the user types more lines
const handleChangeWithAutoExpand = useCallback(
(val: string) => {
handleChange(val);
requestAnimationFrame(autoExpand);
},
[handleChange, autoExpand],
);
useEffect(() => {
if (showRequestChangesTooltip && inputRef.current) inputRef.current.focus();
}, [showRequestChangesTooltip, inputRef]);
const handleAgentCommand = useCallback(
(commandName: string) => {
onSubmit(`/${commandName}`);
},
[onSubmit],
);
const handleSubmitWithReset = useCallback(
() => handleSubmit(resetHeight),
[handleSubmit, resetHeight],
);
const derived = computeDerivedState({
isStarting,
isPreparingEnvironment,
isMoving,
isSending,
isFailed,
needsRecovery,
executorUnavailable,
pendingClarification,
onClarificationResolved,
pendingCommentsByFile,
allItemsLength: allItems.length,
isInputFocused,
placeholder,
isAgentBusy,
hasAgentCommands,
});
return {
isInputFocused,
setIsInputFocused,
showNewSessionDialog,
setShowNewSessionDialog,
contextPopoverOpen,
setContextPopoverOpen,
height,
containerRef,
resizeHandleProps,
value,
inputRef,
addFiles,
fileInputRef,
handleChange: handleChangeWithAutoExpand,
handleSubmitWithReset,
handleAgentCommand,
allItems,
...derived,
};
}
export type { TipTapInputHandle };