7771155c8f
* feat(task): add per-group minimize state to dockview store Adds `minimizedGroupIds: Set<string>` plus `toggleGroupMinimized` and `clearMinimizedGroups` actions. The set is cleared on maximize, exit-maximize, preset apply, custom layout apply, env switch, default-layout rebuild, and release-to-default so minimize state never leaks across task environments and never overlaps with maximize. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(task): add minimize button to dockview group header Adds an IconMinus toggle button alongside Maximize/Split/Close in each non-chat dockview group header. Clicking it adds the group ID to the store's `minimizedGroupIds`; a new `useMinimizedGroupSync` hook walks `api.groups`, stamps a `data-kandev-minimized` attribute on each group element, and calls `group.api.setSize` to shrink the group to the splitview minimum (the freed space redistributes to siblings). A CSS rule hides the content container so only the tab strip remains visible. The hook also auto-restores a minimized group when a new panel is added to it (e.g. via the `+` menu) and evicts removed groups from the set. Clicking Minimize while maximized first exits maximize so the user doesn't end up with a header-only view. In wide mode the button is inline; in narrow mode it folds into the existing overflow dropdown as its first item. Chat group never sees the button (same exclusion as Close). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(task): tighten minimize-icon test, drop unused TID The previous "renders Restore tooltip and icon swap" case had two weak assertions: `getAttribute(...) !== null || btn !== null` is tautologically true, and `btn.innerHTML.toContain("svg")` matches both icon variants. Replaced with two focused tests that assert the Tabler class differs between the minimized and non-minimized state. Also dropped the unused `minimizeMenuItem` entry from the TID map. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(task): minimize-from-maximize used stale group ID `handleMinimize` previously called `toggleGroupMinimized(group.id)` after `exitMaximizedLayout()`. During maximize, `group.id` is the ephemeral overlay group's ID — once the original layout is restored that ID is gone from `api.groups`, and the minimize was silently lost. Read `maximizedGroupId` (the pre-maximize group ID stored at maximize time) from the store and target that instead. Reported on PR #1039 by claude-review, CodeRabbit, and Greptile. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * perf(task): skip redundant data-attribute writes in minimize sync The sync hook re-runs on every `onDidAddGroup` / `onDidAddPanel`, which previously rewrote `data-kandev-minimized` on every group regardless of whether the value actually changed. Guard with a getAttribute-before-set check. Reported on PR #1039 by claude-review. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(task): cover useMinimizedGroupSync hook Adds 11 unit tests for the hook: mount-time attribute stamping, null-api no-op, minimize/restore round-trip with prior-size replay, auto-restore on panel add into a minimized group, no auto-restore for unrelated groups, group-removal eviction from the store and prior-size map, fresh size on re-added group with the same ID, sync of newly added groups, the perf guard on redundant attribute writes, and clean unmount. Reported on PR #1039 by claude-review as a blocker (CLAUDE.md mandates tests for new hooks). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(task): defer minimize toggle to next RAF when exiting maximize `exitMaximizedLayout` schedules `api.layout(w, h)` in a requestAnimation Frame after the synchronous fromJSON rebuild. Calling `toggleGroup Minimized` immediately afterwards races with that layout pass, and the resulting `setSize({ width: 0, height: 0 })` could be overridden — the content was still hidden by CSS but the group kept its full splitview footprint. Defer the toggle one frame so the maximize-exit settles first. Reported on PR #1039 by claude-review, Greptile, and cubic. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(task): guard deferred minimize against env-switch + redundant setSize Two small polish fixes from PR #1039 review: - The RAF callback in `handleMinimize` now verifies the target group still exists in `api.groups` before toggling. Within the frame, an env-switch (or another maximize) could clear `minimizedGroupIds`; blindly re-adding a stale ID would leave it in the set, and if the next env happens to reuse the same well-known constant ID (e.g. "right-top"), the wrong group would render as minimized. (cubic P2 finding.) - `applyGroupMinimized` now early-returns when re-syncing an already- minimized group (`priorSizes.has(groupId)`), instead of re-emitting setSize(0,0) and its size-change events. New test covers this. (claude-review suggestion.) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
143 lines
5.1 KiB
TypeScript
143 lines
5.1 KiB
TypeScript
import { describe, it, expect, beforeEach, vi } from "vitest";
|
|
import type { DockviewApi } from "dockview-react";
|
|
import { useDockviewStore } from "./dockview-store";
|
|
|
|
type ActivePanelEvent = { id: string };
|
|
type CapturedHandlers = {
|
|
active: ((e?: ActivePanelEvent) => void) | null;
|
|
};
|
|
|
|
type ParamsPanel = { id: string; params: Record<string, unknown> };
|
|
|
|
function makeApi(panels: ParamsPanel[] = []): { api: DockviewApi; captured: CapturedHandlers } {
|
|
const captured: CapturedHandlers = { active: null };
|
|
const api = {
|
|
onDidActivePanelChange: (cb: (e?: ActivePanelEvent) => void) => {
|
|
captured.active = cb;
|
|
return { dispose: vi.fn() };
|
|
},
|
|
onDidAddPanel: () => ({ dispose: vi.fn() }),
|
|
onDidRemovePanel: () => ({ dispose: vi.fn() }),
|
|
getPanel: (id: string) => panels.find((p) => p.id === id),
|
|
hasMaximizedGroup: () => false,
|
|
} as unknown as DockviewApi;
|
|
return { api, captured };
|
|
}
|
|
|
|
describe("dockview-store resolveFilePath (via onDidActivePanelChange)", () => {
|
|
beforeEach(() => {
|
|
useDockviewStore.getState().setApi(null);
|
|
});
|
|
|
|
it("resolves pinned file: panel id to its path", () => {
|
|
const { api, captured } = makeApi();
|
|
useDockviewStore.getState().setApi(api);
|
|
|
|
captured.active?.({ id: "file:src/foo.ts" });
|
|
|
|
expect(useDockviewStore.getState().activeFilePath).toBe("src/foo.ts");
|
|
});
|
|
|
|
it("resolves pinned diff:file: panel id to its path", () => {
|
|
const { api, captured } = makeApi();
|
|
useDockviewStore.getState().setApi(api);
|
|
|
|
captured.active?.({ id: "diff:file:src/bar.ts" });
|
|
|
|
expect(useDockviewStore.getState().activeFilePath).toBe("src/bar.ts");
|
|
});
|
|
|
|
it("resolves preview:file-editor panel via params.path", () => {
|
|
const { api, captured } = makeApi([
|
|
{ id: "preview:file-editor", params: { path: "src/baz.ts" } },
|
|
]);
|
|
useDockviewStore.getState().setApi(api);
|
|
|
|
captured.active?.({ id: "preview:file-editor" });
|
|
|
|
expect(useDockviewStore.getState().activeFilePath).toBe("src/baz.ts");
|
|
});
|
|
|
|
it("resolves preview:file-diff panel via params.path", () => {
|
|
const { api, captured } = makeApi([
|
|
{ id: "preview:file-diff", params: { path: "src/diff.ts" } },
|
|
]);
|
|
useDockviewStore.getState().setApi(api);
|
|
|
|
captured.active?.({ id: "preview:file-diff" });
|
|
|
|
expect(useDockviewStore.getState().activeFilePath).toBe("src/diff.ts");
|
|
});
|
|
|
|
it("clears activeFilePath when a non-file panel becomes active", () => {
|
|
const { api, captured } = makeApi();
|
|
useDockviewStore.getState().setApi(api);
|
|
|
|
captured.active?.({ id: "file:src/foo.ts" });
|
|
expect(useDockviewStore.getState().activeFilePath).toBe("src/foo.ts");
|
|
|
|
captured.active?.({ id: "chat" });
|
|
expect(useDockviewStore.getState().activeFilePath).toBeNull();
|
|
});
|
|
|
|
it("clears activeFilePath when active-panel-change fires with no panel", () => {
|
|
const { api, captured } = makeApi();
|
|
useDockviewStore.getState().setApi(api);
|
|
|
|
captured.active?.({ id: "diff:file:src/bar.ts" });
|
|
expect(useDockviewStore.getState().activeFilePath).toBe("src/bar.ts");
|
|
|
|
captured.active?.(undefined);
|
|
expect(useDockviewStore.getState().activeFilePath).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("dockview-store minimize state", () => {
|
|
beforeEach(() => {
|
|
useDockviewStore.setState({ minimizedGroupIds: new Set<string>() });
|
|
});
|
|
|
|
it("toggleGroupMinimized adds then removes a group ID", () => {
|
|
const { toggleGroupMinimized } = useDockviewStore.getState();
|
|
toggleGroupMinimized("g1");
|
|
expect(useDockviewStore.getState().minimizedGroupIds.has("g1")).toBe(true);
|
|
toggleGroupMinimized("g1");
|
|
expect(useDockviewStore.getState().minimizedGroupIds.has("g1")).toBe(false);
|
|
});
|
|
|
|
it("toggleGroupMinimized swaps the Set instance so selectors re-fire", () => {
|
|
const before = useDockviewStore.getState().minimizedGroupIds;
|
|
useDockviewStore.getState().toggleGroupMinimized("g1");
|
|
const after = useDockviewStore.getState().minimizedGroupIds;
|
|
expect(after).not.toBe(before);
|
|
});
|
|
|
|
it("toggleGroupMinimized treats distinct IDs independently", () => {
|
|
const { toggleGroupMinimized } = useDockviewStore.getState();
|
|
toggleGroupMinimized("g1");
|
|
toggleGroupMinimized("g2");
|
|
const ids = useDockviewStore.getState().minimizedGroupIds;
|
|
expect(ids.has("g1")).toBe(true);
|
|
expect(ids.has("g2")).toBe(true);
|
|
toggleGroupMinimized("g1");
|
|
const ids2 = useDockviewStore.getState().minimizedGroupIds;
|
|
expect(ids2.has("g1")).toBe(false);
|
|
expect(ids2.has("g2")).toBe(true);
|
|
});
|
|
|
|
it("clearMinimizedGroups empties the Set", () => {
|
|
useDockviewStore.getState().toggleGroupMinimized("g1");
|
|
useDockviewStore.getState().toggleGroupMinimized("g2");
|
|
expect(useDockviewStore.getState().minimizedGroupIds.size).toBe(2);
|
|
useDockviewStore.getState().clearMinimizedGroups();
|
|
expect(useDockviewStore.getState().minimizedGroupIds.size).toBe(0);
|
|
});
|
|
|
|
it("clearMinimizedGroups is a no-op when already empty (preserves identity)", () => {
|
|
const before = useDockviewStore.getState().minimizedGroupIds;
|
|
useDockviewStore.getState().clearMinimizedGroups();
|
|
const after = useDockviewStore.getState().minimizedGroupIds;
|
|
expect(after).toBe(before);
|
|
});
|
|
});
|