kandev/docs/plans/native-desktop-downloads/task-02-export-feedback.md

id, title, status, wave, depends_on, plan, requirements, acceptance_criteria, system_design

id	title	status	wave	depends_on	plan	requirements	acceptance_criteria	system_design
02-export-feedback	Align export feedback and Blob lifetime	blocked	2	01-desktop-save-handler	plan.md	REQ-DESKTOP-NATIVE-DOWNLOADS-001	AC-DESKTOP-NATIVE-DOWNLOADS-001.2 AC-DESKTOP-NATIVE-DOWNLOADS-001.4 AC-DESKTOP-NATIVE-DOWNLOADS-001.5	../../specs/desktop/system-design/native-downloads.md

Task 02: Align export feedback and Blob lifetime

Summary

Keep generated object URLs alive through native completion, and make the System Logs export report the real desktop save result. Browser and phone downloads remain usable.

In scope

• Correct direct Blob export callers with immediate URL revocation.
• Register Logs feedback before starting the HTTP request, pause the transfer while the native Save panel is open, and report bounded retryable failures.
• Keep diagnostic toast suppression scoped to the Logs operation while its page is active.
• Add focused browser and phone download coverage for the affected paths.

Out of scope

• Changing ZIP, SVG, JSON, or task-file contents.
• Changing desktop updater behavior.

Acceptance

1. System Logs does not claim a download or saved file before desktop completion; cancel is neutral and failure is visible and retryable.
2. Every audited first-party object-URL export survives native download initiation and retains browser download behavior.
3. Existing phone controls and browser download flows remain accessible.

ASCII UI preview

UI-01: Desktop export and UI-02: Phone and browser from the plan:

Desktop: Export -> Save dialog -> Saved / visible failure
Phone:   Export -> existing browser-managed download

The phone's existing customizer drawer remains the entry point. AC-001.2, AC-001.4, and AC-001.5 define the outcomes.

Verification

(cd apps/web && pnpm exec vitest run components/settings/system/log-viewer.test.tsx lib/utils/file-download.test.ts lib/desktop/download-feedback.test.ts)
(cd apps/web && pnpm run i18n:check)
(cd apps/web && pnpm run i18n:ratchet)
(cd apps/web && pnpm e2e:run tests/system/logs-page.spec.ts)
(cd apps/web && pnpm e2e:run --project mobile-chrome tests/system/mobile-logs-bundle.spec.ts)
(cd apps/web && pnpm run typecheck)

The desktop startup smoke does not exercise native downloads. Record a packaged macOS run with Save/Cancel and HTTP/Blob byte hashes before marking AC-001.2 complete.

Files likely touched

• apps/web/components/settings/system/log-viewer.tsx
• apps/web/components/settings/system/log-viewer.test.tsx
• apps/web/lib/utils/file-download.ts
• apps/web/lib/utils/file-download.test.ts
• apps/web/app/office/workspace/settings/export/export-preview.tsx
• apps/web/app/office/workspace/org/org-chart-canvas.tsx
• apps/web/app/office/agents/[id]/components/agent-memory-tab.tsx
• apps/web/e2e/tests/system/mobile-logs-bundle.spec.ts
• apps/web/e2e/tests/system/logs-page.spec.ts
• apps/web/e2e/tests/system/backups-page.spec.ts
• apps/web/src/locales/* if new status copy is needed
• docs/public/desktop-app.md

Dependencies

Task 01: the native result contract must exist before the UI consumes it.

Risks

Tests must check a real browser download and native transfer, not merely that an anchor was clicked. Avoid leaking object URLs after failed attempts.

Parallelism

sequential

Inputs

• Requirements
• System design
• Existing browser and mobile Playwright download tests

Results

• pnpm exec vitest run components/settings/system/log-viewer.test.tsx lib/utils/file-download.test.ts lib/desktop/download-feedback.test.ts lib/desktop/download-ready.test.ts: all 25 tests passed. Coverage includes delayed native Blob initiation, Save-panel lifetime, terminal cleanup, bounded cleanup, no-result recovery, listener failure and retry, ready-URL replay, route-aware feedback, and an unrelated export using the diagnostic filename.
• pnpm exec vitest run lib/desktop/external-links-usage.test.ts: all 5 ownership assertions passed after changing the Logs download helper.
• Targeted ESLint, pnpm run typecheck, and the production Vite build passed.
• pnpm run i18n:check and pnpm run i18n:ratchet passed.
• pnpm e2e:run tests/system/logs-page.spec.ts: all 3 browser tests passed after a fresh production build.
• pnpm e2e:run --project mobile-chrome tests/system/mobile-logs-bundle.spec.ts: all 3 mobile tests passed after a fresh production build.
• node --test scripts/validate-public-docs.test.mjs: all 62 tests passed; the public-doc validator accepted all 47 pages.
• python3 scripts/list-docs.py validate and python3 scripts/lint-spec-files.py --all passed.
• The Linux desktop package built and its startup smoke passed. It does not automate the native Save dialog or verify downloaded bytes.
• The diagnostic listener is established before the HTTP anchor is clicked. Save-panel selection and transfer completion have separate bounded timeouts; a missing listener or terminal event leaves the export retryable.
• Packaged macOS Save/Cancel and byte-preservation evidence remains required before AC-001.2 is verified. This Linux host cannot run that WKWebView check.
• Status remains blocked on the same native transfer gate as Task 01. The frontend and browser/mobile checks are complete; AC-001.2 is unverified.