Files
kandev/apps/backend/internal/agent/agents/managed_npm_runtime.go
T
Jelloeater's Agent 65f27ecbff fix(agents): launch opencode-acp binary-first (native binary on PATH), don't break on stale npm cache (#3836)
Co-authored-by: goose <goose@aaif.dev>
Co-authored-by: Benjamin <benjaminchamwb@gmail.com>
Co-authored-by: Carlos Florencio <carlosmflorencio@gmail.com>
Co-authored-by: João Salavisa <joao.salavisa@gmail.com>
2026-09-21 23:20:43 +01:00

171 lines
5.6 KiB
Go

package agents
import (
"fmt"
"os/exec"
"strings"
"github.com/kandev/kandev/internal/agent/managedruntime"
)
// ManagedNPMRuntimeSpec defines a built-in npm-distributed ACP runtime.
// Package and ACPArgs must come from trusted agent metadata, never request
// input, because update jobs execute them directly.
//
// NativeBinary optionally names a standalone CLI that ships the same ACP
// interface as the npm package. When that binary is resolvable on PATH,
// host-side launch, probe, refresh, and update commands use it consistently.
// The managed npm runtime remains the fallback for containers and remotes.
type ManagedNPMRuntimeSpec struct {
Package string
DefaultVersion string
ACPArgs []string
NativeBinary string
}
// DefaultVersionOrPinned returns the reviewed default version, including the
// catalogue fallback for specs that do not embed one. Custom specs without an
// explicit default remain empty rather than treating the bare package name as
// a version.
func (s ManagedNPMRuntimeSpec) DefaultVersionOrPinned() string {
if s.DefaultVersion != "" {
return s.DefaultVersion
}
packageSpec := s.PackageSpec("")
if strings.HasPrefix(packageSpec, s.Package+"@") {
return strings.TrimPrefix(packageSpec, s.Package+"@")
}
return ""
}
func newManagedNPMRuntimeSpec(packageName string, acpArgs ...string) ManagedNPMRuntimeSpec {
return ManagedNPMRuntimeSpec{
Package: packageName,
DefaultVersion: MustDefaultManagedNPMRuntimeVersion(packageName),
ACPArgs: acpArgs,
}
}
// PackageSpec returns the trusted package name or exact package@version spec.
func (s ManagedNPMRuntimeSpec) PackageSpec(version string) string {
if version == "" {
version = s.DefaultVersion
if version == "" {
if reviewed, err := DefaultManagedNPMRuntimeVersion(s.Package); err == nil {
version = reviewed
} else if isBuiltInManagedNPMRuntimePackage(s.Package) {
panic(fmt.Sprintf("managed runtime default is unavailable for %q: %v", s.Package, err))
}
}
}
if version == "" {
return s.Package
}
return s.Package + "@" + version
}
// ExecutionCacheKey returns npm's deterministic _npx execution-tree key for
// this trusted package spec. The optional version uses the reviewed default.
func (s ManagedNPMRuntimeSpec) ExecutionCacheKey(versions ...string) string {
return managedruntime.NpxExecutionCacheKey(s.PackageSpec(firstVersion(versions)))
}
// ACPCommand returns the normal launch command for the exact version when one
// is supplied. An empty version uses the reviewed default.
func (s ManagedNPMRuntimeSpec) ACPCommand(version string) Command {
return s.ACPCommandWithNpmPreference(version, false)
}
// ACPCommandWithNpmPreference builds a managed runtime launch command. The
// package spec and ACP arguments remain trusted agent metadata; recovery only
// changes npm's metadata freshness preference.
func (s ManagedNPMRuntimeSpec) ACPCommandWithNpmPreference(version string, preferOnline bool) Command {
preference := "--prefer-offline"
if preferOnline {
preference = "--prefer-online"
}
args := []string{"npx", "--yes", preference, s.PackageSpec(version)}
args = append(args, s.ACPArgs...)
return NewCommand(args...)
}
// CachedACPCommand returns the default exact-version launch command.
func (s ManagedNPMRuntimeSpec) CachedACPCommand() Command {
return s.ACPCommand("")
}
// CacheUpdateCommand returns the explicit cache preparation command. The
// optional version makes npm prepare one deterministic package@version tree.
func (s ManagedNPMRuntimeSpec) CacheUpdateCommand(versions ...string) Command {
packageSpec := s.PackageSpec(firstVersion(versions))
return NewCommand(
"npm",
"exec",
"--yes",
"--prefer-online",
"--package="+packageSpec,
"--",
"node",
"-e",
"",
)
}
// NativeCommand returns the direct-binary launch command. Callers must gate it
// on NativeBinaryOnPath so remotes and containers use the managed runtime.
func (s ManagedNPMRuntimeSpec) NativeCommand() Command {
args := []string{s.NativeBinary}
args = append(args, s.ACPArgs...)
return NewCommand(args...)
}
// NativeBinaryOnPath reports whether the optional native binary is resolvable
// from the host PATH.
func (s ManagedNPMRuntimeSpec) NativeBinaryOnPath() bool {
if s.NativeBinary == "" {
return false
}
_, err := exec.LookPath(s.NativeBinary)
return err == nil
}
// NativeUpdateCommand updates the npm package that owns the native binary.
// The optional version keeps exact-version updates on the same runtime.
func (s ManagedNPMRuntimeSpec) NativeUpdateCommand(versions ...string) Command {
return NewCommand("npm", "install", "-g", s.PackageSpec(firstVersion(versions)))
}
// UpdateCommand selects the update recipe for the runtime that launches on
// this host. Native binaries use the global npm install recipe; other hosts
// keep the managed execution-cache update.
func (s ManagedNPMRuntimeSpec) UpdateCommand(versions ...string) Command {
if s.NativeBinaryOnPath() {
return s.NativeUpdateCommand(versions...)
}
return s.CacheUpdateCommand(versions...)
}
// RefreshCommand selects the command used to probe the runtime after an
// update. Native hosts probe the same binary that the update installs.
func (s ManagedNPMRuntimeSpec) RefreshCommand(versions ...string) Command {
if s.NativeBinaryOnPath() {
return s.NativeCommand()
}
if len(versions) > 0 && versions[0] != "" {
return s.ACPCommand(versions[0])
}
return s.CachedACPCommand()
}
func firstVersion(versions []string) string {
if len(versions) == 0 {
return ""
}
return versions[0]
}
func isBuiltInManagedNPMRuntimePackage(packageName string) bool {
_, err := DefaultManagedNPMRuntimeVersion(packageName)
return err == nil
}